)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"538e84b75bbc0626309e6baffdc4a525b2407565","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9b138890_a3f618a8","updated":"2024-04-25 14:21:10.000000000","message":"i think we forgot to delete volume2 in first test therefore the -1","commit_id":"755e755c689226eaa812f8376a8dac8323ad6120"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5cafb8d1b6af58eaa26f4c5af513d2d6a203fe69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4d6284b7_1ba26c7c","updated":"2024-04-26 14:09:44.000000000","message":"I think it would be helpful to structure these a bit differently.  I think you\u0027ve been working on this issue so long that everything is obvious to you, but it\u0027s not so obvious to other contributors.  See suggestions inline.","commit_id":"ce01e35f1624586d2488ea9bb1b20dfd1e135c2c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3bfb1cd2341b0c1cced649ee0943e65a0e1f6ac2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"43e7da93_b82316c2","updated":"2024-04-26 13:07:01.000000000","message":"recheck cinder-tempest-plugin-cbak-ceph - 39 failures, looks like mostly no valid host found when trying to create a server","commit_id":"ce01e35f1624586d2488ea9bb1b20dfd1e135c2c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c9265ca1874a4dd92c732490a233d445240981b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"21122505_e48c9d89","updated":"2024-05-02 22:34:04.000000000","message":"Tests and comments LGTM.  Only a +1 while we figure out what to do about the flag issue Luigi raised.","commit_id":"6f4627b288f092c045a24f1b75ef371ef74fcf5d"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"603bf797fe8b8dcf7876bda6fa154fae37438b90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"74b9d392_d1f1ecc6","updated":"2024-05-06 21:52:33.000000000","message":"recheck\n\ncinder-tempest-plugin-basic-zed failed in neutron config generation:\n\nImportError: cannot import name \u0027security_groups_rules_belongs_to_default_sg\u0027 from \u0027neutron_lib.api.definitions\u0027 (/usr/local/lib/python3.8/dist-packages/neutron_lib/api/definitions/__init__.py)","commit_id":"aa24635e32a2c2f7c66e4aad2a2b994a75cb494f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"55469e8ff5011f69f9b9744da90c24ac8ba3acb0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"dcc09110_92b402bc","updated":"2024-05-07 13:20:07.000000000","message":"recheck cinder-tempest-plugin-lvm-multiattach - tempest.scenario.test_shelve_instance.TestShelveInstance.test_shelve_volume_backed_instance : ssh timeout connecting to the instance","commit_id":"aa24635e32a2c2f7c66e4aad2a2b994a75cb494f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e919c8d77ac7d7a35413ab7c0386189acb828e9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"2c3c40e3_10dc4208","updated":"2024-05-10 13:14:30.000000000","message":"My concerns have been addressed (and I think Luigi\u0027s and Rajat\u0027s have been, too).\n\nI noticed that the c-t-p-basic-* jobs are all passing because they\u0027re children of the devstack-tempest job.  Presumably when this patch is merged, we will start seeing failures in our stable branch jobs that use ceph, so I put up a patch for Bobcat:\nhttps://review.opendev.org/c/openstack/cinder/+/919054","commit_id":"a374844be93037807cf249b5839d4eb370b3b47c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"37f9ab81ede4a30af91df0f19cd755e74a74bc61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"46fc1318_9e8228d5","updated":"2024-05-10 13:25:59.000000000","message":"my comments are also addressed, let\u0027s wait for Luigi","commit_id":"a374844be93037807cf249b5839d4eb370b3b47c"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"25ebf272995db99ba36ce79f64cc67ec5f8960c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"60cff009_a0224d7d","updated":"2024-05-08 09:45:00.000000000","message":"recheck\n\ncinder-tempest-plugin-lvm-multiattach\n++ functions:get_extra_file:65              :   [[ https://github.com/etcd-io/etcd/releases/download/v3.4.27/etcd-v3.4.27-linux-amd64.tar.gz !\u003d file* ]]\n++ functions:get_extra_file:67              :   [[ ! -f /opt/stack/devstack/files/etcd-v3.4.27-linux-amd64.tar.gz ]]\n++ functions:get_extra_file:68              :   wget --progress\u003ddot:giga -t 2 -c https://github.com/etcd-io/etcd/releases/download/v3.4.27/etcd-v3.4.27-linux-amd64.tar.gz -O /opt/stack/devstack/files/etcd-v3.4.27-linux-amd64.tar.gz\n--2024-05-07 18:21:41--  https://github.com/etcd-io/etcd/releases/download/v3.4.27/etcd-v3.4.27-linux-amd64.tar.gz\nResolving github.com (github.com)... failed: Temporary failure in name resolution.\nwget: unable to resolve host address ‘github.com’","commit_id":"a374844be93037807cf249b5839d4eb370b3b47c"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"6b9695507ad42c2cd48eb31a64cd7331208c6c12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"b053e726_b0e2c364","updated":"2024-05-07 17:52:16.000000000","message":"recheck\n\ncinder-tempest-plugin-lvm-multiattach failed with\n{3}\n    tempest.scenario.test_instances_with_cinder_volumes.TestInstancesWithCinderVolumes.test_instances_with_cinder_volumes_on_all_compute_nodes [178.267185s] ... FAILED\n\n\n      File \"/opt/stack/tempest/tempest/scenario/test_instances_with_cinder_volumes.py\", line 200, in test_instances_with_cinder_volumes_on_all_compute_nodes\n    timestamp_before \u003d self.create_timestamp(\n\n      File \"/opt/stack/tempest/tempest/scenario/manager.py\", line 1233, in create_timestamp\n    ssh_client.exec_command(\u0027sudo mount /dev/%s %s\u0027 % (dev_name,\n    \n        tempest.lib.exceptions.SSHExecCommandFailed: Command \u0027set -eu -o pipefail; PATH\u003d$PATH:/sbin:/usr/sbin; sudo mount /dev/vdb /mnt/vdb\u0027, exit status: 255, stderr:\nmount: mounting /dev/vdb on /mnt/vdb failed: Device or resource busy","commit_id":"a374844be93037807cf249b5839d4eb370b3b47c"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0fee3867f7793445993eb64248fe0a4af54c4997","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"4d4a6f71_4865eb93","updated":"2024-05-08 12:48:27.000000000","message":"recheck\n\nnvmet-barbican job failed in\ntempest.scenario.test_instances_with_cinder_volumes.TestInstancesWithCinderVolumes.test_instances_with_cinder_volumes_on_all_compute_nodes","commit_id":"a374844be93037807cf249b5839d4eb370b3b47c"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"d8517b04e6449cf41aabd1ca1151866c447047ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"5044d68d_73602296","updated":"2024-05-14 14:12:06.000000000","message":"I\u0027m fine with this, thanks. We need to merge https://review.opendev.org/c/openstack/cinder/+/919054 and its (still not existing) backport to 2023.1 before this one (please see my comment on 919054)","commit_id":"1f29ca126cb8f155a435f0cb0b0fc80d2f2d7e2b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7314ed0f6291b017e7e4eb3e2df29a43b0868f11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"5593982e_896052c8","updated":"2024-05-14 13:44:23.000000000","message":"LGTM, fwiw.","commit_id":"1f29ca126cb8f155a435f0cb0b0fc80d2f2d7e2b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"eb39b1f903c3fdc70fd56de3bb7e9dc659d2408e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"cd89eafb_7a0d418a","updated":"2024-05-14 23:08:53.000000000","message":"OK, the stable gate patches are ready and have +1 from Zuul:\n\nstable/2023.2: https://review.opendev.org/c/openstack/cinder/+/919054\nstable/2023.1: https://review.opendev.org/c/openstack/cinder/+/919621","commit_id":"1f29ca126cb8f155a435f0cb0b0fc80d2f2d7e2b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"556c16211e02380f0ae01e1ff8db87adec08af07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"cb9b27c1_49b015ed","updated":"2024-05-15 18:06:33.000000000","message":"The stable branch patches for the tests to be disabled are merged so everyone\u0027s comments are addressed. LGTM.","commit_id":"1f29ca126cb8f155a435f0cb0b0fc80d2f2d7e2b"}],"cinder_tempest_plugin/api/volume/test_volume_dependency.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"53e57067deaad7a452d98b753caaf9e2854d7416","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                                                \u0027available\u0027)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        snapshot1 \u003d self.create_snapshot(volume1[\u0027id\u0027])"},{"line_number":177,"context_line":"        # TODO: wait until snap is available"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        vol2_args \u003d {\u0027name\u0027: (\u0027volume2-for-test-\u0027"},{"line_number":180,"context_line":"                              \u00270e20bd6e-440f-41d8-9b5d-fc047ac00423\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"d8ecbe1b_f403ce93","line":177,"updated":"2024-03-28 15:50:56.000000000","message":"create_snapshot() already does this.","commit_id":"b62ce001c73dbafe9bc8d4150c65ba1a486c3fd6"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"53e57067deaad7a452d98b753caaf9e2854d7416","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                                                \u0027available\u0027)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        snapshot1 \u003d self.create_snapshot(volume1[\u0027id\u0027])"},{"line_number":215,"context_line":"        # TODO: wait until snap is available"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        vol2_args \u003d {\u0027name\u0027: (\u0027volume2-for-test-\u0027"},{"line_number":218,"context_line":"                              \u0027e6050452-06bd-4c7f-9912-45178c83e379\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"85ed3b32_b0ea3daa","line":215,"range":{"start_line":215,"start_character":8,"end_line":215,"end_character":44},"updated":"2024-03-28 15:50:56.000000000","message":"create_snapshot() already does this.","commit_id":"b62ce001c73dbafe9bc8d4150c65ba1a486c3fd6"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"538e84b75bbc0626309e6baffdc4a525b2407565","unresolved":true,"context_lines":[{"line_number":122,"context_line":"        self._delete_vol_and_wait(volume_3)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @classmethod"},{"line_number":125,"context_line":"    def del_image(cls, id):"},{"line_number":126,"context_line":"        images_client \u003d cls.os_primary.image_client_v2"},{"line_number":127,"context_line":"        images_client.delete_image(id)"},{"line_number":128,"context_line":"        images_client.wait_for_resource_deletion(id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"24b15875_ac46cfa8","line":125,"range":{"start_line":125,"start_character":23,"end_line":125,"end_character":25},"updated":"2024-04-25 14:21:10.000000000","message":"nit: id is too generic, maybe image_id?","commit_id":"755e755c689226eaa812f8376a8dac8323ad6120"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"37d013054f172427ae069b44a5e9e29503808218","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        self._delete_vol_and_wait(volume_3)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @classmethod"},{"line_number":125,"context_line":"    def del_image(cls, id):"},{"line_number":126,"context_line":"        images_client \u003d cls.os_primary.image_client_v2"},{"line_number":127,"context_line":"        images_client.delete_image(id)"},{"line_number":128,"context_line":"        images_client.wait_for_resource_deletion(id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"52658c00_5629da2e","line":125,"range":{"start_line":125,"start_character":23,"end_line":125,"end_character":25},"in_reply_to":"24b15875_ac46cfa8","updated":"2024-05-10 13:13:10.000000000","message":"Done","commit_id":"755e755c689226eaa812f8376a8dac8323ad6120"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"538e84b75bbc0626309e6baffdc4a525b2407565","unresolved":true,"context_lines":[{"line_number":128,"context_line":"        images_client.wait_for_resource_deletion(id)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    @decorators.idempotent_id(\u00270e20bd6e-440f-41d8-9b5d-fc047ac00423\u0027)"},{"line_number":131,"context_line":"    def test_image_volume_dependencies(self):"},{"line_number":132,"context_line":"        image_args \u003d {"},{"line_number":133,"context_line":"            \u0027disk_format\u0027: \u0027raw\u0027,"},{"line_number":134,"context_line":"            \u0027container_format\u0027: \u0027bare\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"51d33504_361b426c","line":131,"range":{"start_line":131,"start_character":0,"end_line":131,"end_character":45},"updated":"2024-04-25 14:21:10.000000000","message":"nit: would be great to have a docstring explaining what we are testing here and the steps we perform","commit_id":"755e755c689226eaa812f8376a8dac8323ad6120"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f92eaf61acc71c11359d5513c6fd630aaf991cdc","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        images_client.wait_for_resource_deletion(id)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    @decorators.idempotent_id(\u00270e20bd6e-440f-41d8-9b5d-fc047ac00423\u0027)"},{"line_number":131,"context_line":"    def test_image_volume_dependencies(self):"},{"line_number":132,"context_line":"        image_args \u003d {"},{"line_number":133,"context_line":"            \u0027disk_format\u0027: \u0027raw\u0027,"},{"line_number":134,"context_line":"            \u0027container_format\u0027: \u0027bare\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"f452fd18_46e32101","line":131,"range":{"start_line":131,"start_character":0,"end_line":131,"end_character":45},"in_reply_to":"51d33504_361b426c","updated":"2024-05-01 17:41:26.000000000","message":"Done","commit_id":"755e755c689226eaa812f8376a8dac8323ad6120"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"538e84b75bbc0626309e6baffdc4a525b2407565","unresolved":true,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        self.volumes_client.delete_volume(volume1[\u0027id\u0027])"},{"line_number":162,"context_line":"        self.volumes_client.wait_for_resource_deletion(volume1[\u0027id\u0027])"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        self.del_image(image[\u0027id\u0027])"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    @decorators.idempotent_id(\u0027e6050452-06bd-4c7f-9912-45178c83e379\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"52d38d52_4b75bb34","line":163,"updated":"2024-04-25 14:21:10.000000000","message":"i think we missed to delete volume 2?\n\n        self.volumes_client.delete_volume(volume2[\u0027id\u0027])\n        self.volumes_client.wait_for_resource_deletion(volume2[\u0027id\u0027])","commit_id":"755e755c689226eaa812f8376a8dac8323ad6120"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c32b124b7bcdff7c1fc56c00231a8ecca4953768","unresolved":true,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        self.volumes_client.delete_volume(volume1[\u0027id\u0027])"},{"line_number":162,"context_line":"        self.volumes_client.wait_for_resource_deletion(volume1[\u0027id\u0027])"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        self.del_image(image[\u0027id\u0027])"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    @decorators.idempotent_id(\u0027e6050452-06bd-4c7f-9912-45178c83e379\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"b1a2c08c_c235f490","line":163,"in_reply_to":"52d38d52_4b75bb34","updated":"2024-04-25 17:34:48.000000000","message":"create_volume() adds a hook that deletes it at the cleanup stage.  Since volume2 is not the \"interesting\" part of this test and is expected to just delete normally because it has no clones, it makes sense to let the regular cleanup infrastructure handle it.","commit_id":"755e755c689226eaa812f8376a8dac8323ad6120"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"37f9ab81ede4a30af91df0f19cd755e74a74bc61","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        self.volumes_client.delete_volume(volume1[\u0027id\u0027])"},{"line_number":162,"context_line":"        self.volumes_client.wait_for_resource_deletion(volume1[\u0027id\u0027])"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        self.del_image(image[\u0027id\u0027])"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    @decorators.idempotent_id(\u0027e6050452-06bd-4c7f-9912-45178c83e379\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7e5fd227_1927fe31","line":163,"in_reply_to":"b1a2c08c_c235f490","updated":"2024-05-10 13:25:59.000000000","message":"Acknowledged","commit_id":"755e755c689226eaa812f8376a8dac8323ad6120"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5cafb8d1b6af58eaa26f4c5af513d2d6a203fe69","unresolved":true,"context_lines":[{"line_number":120,"context_line":"        self._delete_vol_and_wait(volume_1)"},{"line_number":121,"context_line":"        self._delete_vol_and_wait(volume_2)"},{"line_number":122,"context_line":"        self._delete_vol_and_wait(volume_3)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @classmethod"},{"line_number":125,"context_line":"    def del_image(cls, image_id):"},{"line_number":126,"context_line":"        images_client \u003d cls.os_primary.image_client_v2"}],"source_content_type":"text/x-python","patch_set":10,"id":"52809d72_0f30f5ae","line":123,"updated":"2024-04-26 14:09:44.000000000","message":"You will want to kill me, but I think these tests need to be in their own ImageVolumeDependencyTests class, because I think you need more tests.  You can doc the class with something like, \"These tests should obviously pass when Glance and Cinder are using different backends.  But when Glance and Cinder are configured to share a copy-on-write backend like Ceph, even though resources like images and volumes are independent at the openstack level, they will have relations in the backend that can prevent them from behaving normally with respect to deletion.  This was particularly the case for RBD before change Ixxxxx.\"\n\nThen, I think add the tests in increasing order of insanity, like:\n\n1. create image, create volume, delete image\n2. create image, create volume1, clone volume2 from volume1, delete volume1, delete image\n3. add in snapshot stuff\n4. etc","commit_id":"ce01e35f1624586d2488ea9bb1b20dfd1e135c2c"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f92eaf61acc71c11359d5513c6fd630aaf991cdc","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        self._delete_vol_and_wait(volume_1)"},{"line_number":121,"context_line":"        self._delete_vol_and_wait(volume_2)"},{"line_number":122,"context_line":"        self._delete_vol_and_wait(volume_3)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @classmethod"},{"line_number":125,"context_line":"    def del_image(cls, image_id):"},{"line_number":126,"context_line":"        images_client \u003d cls.os_primary.image_client_v2"}],"source_content_type":"text/x-python","patch_set":10,"id":"dbb3d470_3521dd0e","line":123,"in_reply_to":"52809d72_0f30f5ae","updated":"2024-05-01 17:41:26.000000000","message":"Done","commit_id":"ce01e35f1624586d2488ea9bb1b20dfd1e135c2c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5cafb8d1b6af58eaa26f4c5af513d2d6a203fe69","unresolved":true,"context_lines":[{"line_number":131,"context_line":"    def test_image_volume_dependencies(self):"},{"line_number":132,"context_line":"        \"\"\"Tests deletion of images/volumes with cloned children."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        This tests deletion of an image which has a cloned volume"},{"line_number":135,"context_line":"        from it that may be in the backend\u0027s trash (because it is"},{"line_number":136,"context_line":"        the base of another cloned volume)."},{"line_number":137,"context_line":"        \"\"\""},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"6bb786fa_f39cac2c","line":135,"range":{"start_line":134,"start_character":34,"end_line":135,"end_character":15},"updated":"2024-04-26 14:09:44.000000000","message":"You\u0027ll have to be careful how you phrase this, because conceptually the volume isn\u0027t cloned from the image (you don\u0027t want people to think you\u0027re testing the image-volume cache here, though probably that needs some more tests, too (but not necessarily in this patch)).","commit_id":"ce01e35f1624586d2488ea9bb1b20dfd1e135c2c"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f92eaf61acc71c11359d5513c6fd630aaf991cdc","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    def test_image_volume_dependencies(self):"},{"line_number":132,"context_line":"        \"\"\"Tests deletion of images/volumes with cloned children."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        This tests deletion of an image which has a cloned volume"},{"line_number":135,"context_line":"        from it that may be in the backend\u0027s trash (because it is"},{"line_number":136,"context_line":"        the base of another cloned volume)."},{"line_number":137,"context_line":"        \"\"\""},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"853eb6c2_2bd746fa","line":135,"range":{"start_line":134,"start_character":34,"end_line":135,"end_character":15},"in_reply_to":"6bb786fa_f39cac2c","updated":"2024-05-01 17:41:26.000000000","message":"Done","commit_id":"ce01e35f1624586d2488ea9bb1b20dfd1e135c2c"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"4932363831312b943ad9a6d5bde752b08e0668ec","unresolved":true,"context_lines":[{"line_number":134,"context_line":"    level, but in some configurations (i.e. when using Ceph as storage"},{"line_number":135,"context_line":"    for both Cinder and Glance) it was possible to end up with images"},{"line_number":136,"context_line":"    or volumes that could not be deleted.  This was fixed for RBD in"},{"line_number":137,"context_line":"    Cinder 2024.1 change I009d0748f."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    \"\"\""},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5c9e0269_a23f625a","line":137,"updated":"2024-05-02 14:30:27.000000000","message":"So is this going to work on older versions of openstack? It may require some flag if https://review.opendev.org/c/openstack/cinder/+/835384 is not available on, say, antelope or bobcat.","commit_id":"6f4627b288f092c045a24f1b75ef371ef74fcf5d"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"ffee4d5df49f23555a91206e93d51b234e910372","unresolved":true,"context_lines":[{"line_number":134,"context_line":"    level, but in some configurations (i.e. when using Ceph as storage"},{"line_number":135,"context_line":"    for both Cinder and Glance) it was possible to end up with images"},{"line_number":136,"context_line":"    or volumes that could not be deleted.  This was fixed for RBD in"},{"line_number":137,"context_line":"    Cinder 2024.1 change I009d0748f."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    \"\"\""},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"2d9cc412_6108ba6c","line":137,"in_reply_to":"2418a381_5950612b","updated":"2024-05-10 16:47:01.000000000","message":"I see the flag being added to a test of the parent class, but none of the tests in this class use it. Is it expected? Wouldn\u0027t the test fail? Or is it not a problem now that zed moved to unmaintained?","commit_id":"6f4627b288f092c045a24f1b75ef371ef74fcf5d"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d44be98e31f775850f8e872286075a30e98858b8","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    level, but in some configurations (i.e. when using Ceph as storage"},{"line_number":135,"context_line":"    for both Cinder and Glance) it was possible to end up with images"},{"line_number":136,"context_line":"    or volumes that could not be deleted.  This was fixed for RBD in"},{"line_number":137,"context_line":"    Cinder 2024.1 change I009d0748f."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    \"\"\""},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9c4239b2_f8271faf","line":137,"in_reply_to":"2d9cc412_6108ba6c","updated":"2024-05-13 13:09:15.000000000","message":"It was intended to be applied to these tests instead, will fix.","commit_id":"6f4627b288f092c045a24f1b75ef371ef74fcf5d"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d9635b37be9930fa638cfaa638b4365f4c249cca","unresolved":true,"context_lines":[{"line_number":134,"context_line":"    level, but in some configurations (i.e. when using Ceph as storage"},{"line_number":135,"context_line":"    for both Cinder and Glance) it was possible to end up with images"},{"line_number":136,"context_line":"    or volumes that could not be deleted.  This was fixed for RBD in"},{"line_number":137,"context_line":"    Cinder 2024.1 change I009d0748f."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    \"\"\""},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"2418a381_5950612b","line":137,"in_reply_to":"5c9e0269_a23f625a","updated":"2024-05-02 16:30:25.000000000","message":"It would fail on older versions without this fix (i.e. Bobcat or earlier) in configurations running the RBD driver.\n\nIt\u0027s not clear to me what the best way to handle this is, since such a flag would represent \"has this bug been fixed?\" and not a new feature.  (How do we usually do that?)","commit_id":"6f4627b288f092c045a24f1b75ef371ef74fcf5d"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"49d3997db51d01afe98c42cf40d734e91381b66e","unresolved":true,"context_lines":[{"line_number":139,"context_line":"    or volumes that could not be deleted.  This was fixed for RBD in"},{"line_number":140,"context_line":"    Cinder 2024.1 change I009d0748f."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    \"\"\""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    @classmethod"},{"line_number":145,"context_line":"    def del_image(cls, image_id):"}],"source_content_type":"text/x-python","patch_set":14,"id":"cc371295_3d5e7194","line":142,"updated":"2024-05-13 07:26:29.000000000","message":"Also, this class includes the same tests of VolumeDependencyTests but they are apparently executed again with the same configuration.\nMaybe this should inherit directly from base.BaseVolumeTest?","commit_id":"a374844be93037807cf249b5839d4eb370b3b47c"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d44be98e31f775850f8e872286075a30e98858b8","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    or volumes that could not be deleted.  This was fixed for RBD in"},{"line_number":140,"context_line":"    Cinder 2024.1 change I009d0748f."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    \"\"\""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    @classmethod"},{"line_number":145,"context_line":"    def del_image(cls, image_id):"}],"source_content_type":"text/x-python","patch_set":14,"id":"d054b794_de6cbe53","line":142,"in_reply_to":"cc371295_3d5e7194","updated":"2024-05-13 13:09:15.000000000","message":"D\u0027oh, will fix this.","commit_id":"a374844be93037807cf249b5839d4eb370b3b47c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7314ed0f6291b017e7e4eb3e2df29a43b0868f11","unresolved":true,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from tempest.common import utils"},{"line_number":18,"context_line":"from tempest.common import waiters"},{"line_number":19,"context_line":"from tempest import config"}],"source_content_type":"text/x-python","patch_set":15,"id":"54718a93_8d98a50c","line":16,"updated":"2024-05-14 13:44:23.000000000","message":"nit: extra blank line? but if flake8 doesn\u0027t care, then I shouldn\u0027t either","commit_id":"1f29ca126cb8f155a435f0cb0b0fc80d2f2d7e2b"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"70cfb482f44a58f0dc3d80b68efb5b09e0bb53d7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from tempest.common import utils"},{"line_number":18,"context_line":"from tempest.common import waiters"},{"line_number":19,"context_line":"from tempest import config"}],"source_content_type":"text/x-python","patch_set":15,"id":"ac976e13_6e3273f1","line":16,"in_reply_to":"54718a93_8d98a50c","updated":"2024-05-15 18:25:25.000000000","message":"Acknowledged","commit_id":"1f29ca126cb8f155a435f0cb0b0fc80d2f2d7e2b"}]}