)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"0e554578e6e5e9a84a49a40bea249a235fabbb59","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Yosi Ben Shimon \u003cybenshim@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-04-25 07:55:34 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Test capabilites for srbac fiture"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Changed the test to keep convention without abstract methods"},{"line_number":10,"context_line":"Also remvoed base.BaseVolumeTest inheritance"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"328bd57d_85ee0d50","line":7,"updated":"2023-04-25 10:28:11.000000000","message":"fixture","commit_id":"310d743969d7a7227cceee92eb9eba6930760163"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"6fe788d80f8aa3eef8a9cda08c05c098a7735a46","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Yosi Ben Shimon \u003cybenshim@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-04-25 07:55:34 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Test capabilites for srbac fiture"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Changed the test to keep convention without abstract methods"},{"line_number":10,"context_line":"Also remvoed base.BaseVolumeTest inheritance"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ad961c3b_cc972333","line":7,"in_reply_to":"328bd57d_85ee0d50","updated":"2023-04-25 10:42:27.000000000","message":"Done","commit_id":"310d743969d7a7227cceee92eb9eba6930760163"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"c0457fb08978297370a54b91058b1443dd45b602","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Test capabilites for srbac feature"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Changed the test to keep convention without abstract methods"},{"line_number":10,"context_line":"Also remvoed base.BaseVolumeTest inheritance"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7020487fcdb0a8e34be92a2b0f110b885cbeb339"},{"line_number":13,"context_line":"Signed-off-by: Yosi Ben Shimon \u003cybenshim@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"6cc7ce4b_88c88ab1","line":10,"updated":"2023-04-27 08:06:19.000000000","message":"This is the most important reason for the change, I would add an explanation: \n\n... inheritance, to isolate RBAC tests from the normal tests while they are developed, even though this could be revisited in the future the base classes for API tests in cinder-tempest-plugin could be unified.","commit_id":"e80f380c4e4f1fd05e1e4f5b3e7143f83a1e4dd6"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"3dc7164edb08dafe6f508c0fb1f3ebae04cffb81","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Test capabilites for srbac feature"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Changed the test to keep convention without abstract methods"},{"line_number":10,"context_line":"Also remvoed base.BaseVolumeTest inheritance"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7020487fcdb0a8e34be92a2b0f110b885cbeb339"},{"line_number":13,"context_line":"Signed-off-by: Yosi Ben Shimon \u003cybenshim@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"f5a60d04_655228b7","line":10,"in_reply_to":"6cc7ce4b_88c88ab1","updated":"2023-04-27 12:50:12.000000000","message":"Done","commit_id":"e80f380c4e4f1fd05e1e4f5b3e7143f83a1e4dd6"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"448ae279eba9bd2dab2b053307633ac64c0d511a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"518e1e81_2c385ab3","updated":"2023-04-25 07:49:49.000000000","message":"Thanks Yosi! LGTM!\nThe failures aren\u0027t related to this change.","commit_id":"310d743969d7a7227cceee92eb9eba6930760163"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"c0457fb08978297370a54b91058b1443dd45b602","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"efd26723_cb75463c","updated":"2023-04-27 08:06:19.000000000","message":"Just one note","commit_id":"e80f380c4e4f1fd05e1e4f5b3e7143f83a1e4dd6"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"fa90656c124ff4aab1aa903f7f459cd267e85d3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7d933773_0d43bc9f","updated":"2023-04-25 13:58:54.000000000","message":"recheck","commit_id":"e80f380c4e4f1fd05e1e4f5b3e7143f83a1e4dd6"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"9b123a39f6f5bd17a81b232ac0971d51ab1a1412","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"055f2f73_ca92b9a3","updated":"2023-04-27 07:53:35.000000000","message":"recheck\n\nfailure of cinder-tempest-plugin-cbak-ceph most likely due to an infra/mirroring issue:\nERROR: Could not find a version that satisfies the requirement pysaml2\u003d\u003d\u003d7.4.1 (from -c /opt/stack/requirements/upper-constraints.txt (line 381)) (from versions: 0.4.3, 1.0.1, 1.0.2, 1.0.3, 1.1.0, 2.0.0, 2.1.0, 2.2.0, 2.3.0, 2.4.0, 3.0.0, 3.0.2, 4.0.0, 4.0.1, 4.0.2, 4.0.3, 4.0.4, 4.0.5rc1, 4.0.5, 4.1.0, 4.2.0, 4.3.0, 4.4.0, 4.5.0, 4.6.0, 4.6.1, 4.6.2, 4.6.3, 4.6.4, 4.6.5, 4.7.0, 4.8.0, 4.9.0, 5.0.0, 5.1.0, 5.2.0, 5.3.0, 5.4.0, 6.0.0, 6.1.0, 6.2.0, 6.3.0, 6.3.1, 6.4.0, 6.4.1, 6.5.0, 6.5.1, 6.5.2, 7.0.0, 7.0.1, 7.1.0, 7.1.1, 7.1.2, 7.2.0, 7.2.1, 7.3.0, 7.3.1)\nERROR: No matching distribution found for pysaml2\u003d\u003d\u003d7.4.1 (from -c /opt/stack/requirements/upper-constraints.txt (line 381))","commit_id":"e80f380c4e4f1fd05e1e4f5b3e7143f83a1e4dd6"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"d02c36ba5449ca31628487a76c6f026be94ceb79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"eebd0173_047a35ce","updated":"2023-04-30 11:11:52.000000000","message":"LGTM!\nlet\u0027s get it merged!","commit_id":"490c8257137097ae9d561f326b5ae469f480038f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"267f366539cef43f39819d4e1201904161ce0e99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1d0348e7_6c9a85bb","updated":"2023-05-02 13:08:34.000000000","message":"cinder-tempest-plugin-protection-functional is green and running the tests.  LGTM.","commit_id":"490c8257137097ae9d561f326b5ae469f480038f"}],"cinder_tempest_plugin/rbac/v3/base.py":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"448ae279eba9bd2dab2b053307633ac64c0d511a","unresolved":true,"context_lines":[{"line_number":41,"context_line":"            cls.min_microversion, cls.max_microversion,"},{"line_number":42,"context_line":"            CONF.volume.min_microversion, CONF.volume.max_microversion)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @classmethod"},{"line_number":45,"context_line":"    def setup_clients(cls):"},{"line_number":46,"context_line":"        super(VolumeV3RbacBaseTests, cls).setup_clients()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @classmethod"},{"line_number":49,"context_line":"    def setup_credentials(cls):"}],"source_content_type":"text/x-python","patch_set":4,"id":"f89a5a00_bbb6ca42","line":46,"range":{"start_line":44,"start_character":0,"end_line":46,"end_character":57},"updated":"2023-04-25 07:49:49.000000000","message":"It can be removed.","commit_id":"310d743969d7a7227cceee92eb9eba6930760163"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"6fe788d80f8aa3eef8a9cda08c05c098a7735a46","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            cls.min_microversion, cls.max_microversion,"},{"line_number":42,"context_line":"            CONF.volume.min_microversion, CONF.volume.max_microversion)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @classmethod"},{"line_number":45,"context_line":"    def setup_clients(cls):"},{"line_number":46,"context_line":"        super(VolumeV3RbacBaseTests, cls).setup_clients()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @classmethod"},{"line_number":49,"context_line":"    def setup_credentials(cls):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f7fca0a_0576cb47","line":46,"range":{"start_line":44,"start_character":0,"end_line":46,"end_character":57},"in_reply_to":"f89a5a00_bbb6ca42","updated":"2023-04-25 10:42:27.000000000","message":"Done","commit_id":"310d743969d7a7227cceee92eb9eba6930760163"}],"cinder_tempest_plugin/rbac/v3/test_capabilities.py":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"b9bebf4c159783b4449708be4d308a005a4f4879","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class VolumeV3RbacCapabilityTests(rbac_base.VolumeV3RbacBaseTests):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    @classmethod"},{"line_number":22,"context_line":"    def skip_checks(cls):"},{"line_number":23,"context_line":"        super(VolumeV3RbacCapabilityTests, cls).skip_checks()"},{"line_number":24,"context_line":"        if not CONF.volume_feature_enabled.backup:"},{"line_number":25,"context_line":"            raise cls.skipException(\"Cinder backup feature disabled\")"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fa081c6_fa85b918","line":25,"range":{"start_line":21,"start_character":0,"end_line":25,"end_character":69},"updated":"2023-04-24 14:43:31.000000000","message":"I guess you added it by mistake!","commit_id":"0e77783437b8ecd8acca2e1545133c0b421a3dce"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"c1eb7809daa093325594b0432b0b6aa0d344d34e","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class VolumeV3RbacCapabilityTests(rbac_base.VolumeV3RbacBaseTests):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    @classmethod"},{"line_number":22,"context_line":"    def skip_checks(cls):"},{"line_number":23,"context_line":"        super(VolumeV3RbacCapabilityTests, cls).skip_checks()"},{"line_number":24,"context_line":"        if not CONF.volume_feature_enabled.backup:"},{"line_number":25,"context_line":"            raise cls.skipException(\"Cinder backup feature disabled\")"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"56d46469_f9faac45","line":25,"range":{"start_line":21,"start_character":0,"end_line":25,"end_character":69},"in_reply_to":"9fa081c6_fa85b918","updated":"2023-04-24 14:57:52.000000000","message":"Done","commit_id":"0e77783437b8ecd8acca2e1545133c0b421a3dce"}]}
