)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"729af27fe6837ba41432825eaf4496ff5d211a87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0fcb5cf7_9d971ca6","updated":"2023-05-02 00:09:15.000000000","message":"in addition to this we need to pass validation resource here too as create_server in this plugin does not do","commit_id":"ed0e90ec441e58d8b3aeb44e063a86293e73999c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5625036513185b3fe88a66b199c6c223e5265987","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"adf24504_d0ca78fb","updated":"2023-05-01 13:31:47.000000000","message":"recheck guest kernel crashed","commit_id":"ed0e90ec441e58d8b3aeb44e063a86293e73999c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"38fdbb2c3a5f817ceb53aeb3a6e3e07f2e3465d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"df8c6b48_578f3eb2","updated":"2023-04-28 16:20:02.000000000","message":"recheck tempest dep changed","commit_id":"ed0e90ec441e58d8b3aeb44e063a86293e73999c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b40d7810fd9e5c77cdfe2d3a2ee14b93cac3c154","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9803c79d_f7d824a4","updated":"2023-05-03 18:15:11.000000000","message":"I\u0027d defer to Ghanshyam about the requirements version bump.. bumping the tempest requirement to 30.0.0 wouldn\u0027t be sufficient either because of a number of other changes necessary to cover all use cases... glad to see this stuff working!","commit_id":"93ca44807c18dbafa0993f90addf9079c7823720"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8869b06275635e31a1a5b64b19175a2608162a09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"59121b92_df7a4509","updated":"2023-05-03 13:03:02.000000000","message":"Makes sense to me.  The dependency has several ancestor patches that still need to merge.  SSHABLE as a waitable server state was added to tempest over a year ago by https://review.opendev.org/#/q/Ib14fa7dc5c80","commit_id":"93ca44807c18dbafa0993f90addf9079c7823720"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"7941048ac61a266bd29c20794fc443ed1f341362","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0be5d072_64ceae34","updated":"2023-05-03 16:51:21.000000000","message":"SSHABLE was added in tempest 30.0.0 but cinder-tempest-plugin says it requires tempest\u003e\u003d27.0.0.  Do we need to bump the required tempest version here?","commit_id":"93ca44807c18dbafa0993f90addf9079c7823720"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2051159602f6fc7dbc274e1c5a742763344bc32c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4f9f467a_fe4c8a07","updated":"2023-05-02 22:00:50.000000000","message":"recheck tempest dep changed again. hoping this is the last time :)","commit_id":"93ca44807c18dbafa0993f90addf9079c7823720"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"aaff9cf89fde441cf09d42fdca3c95f486d6b1d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"375cf9ee_417beb30","in_reply_to":"0be5d072_64ceae34","updated":"2023-05-03 17:16:57.000000000","message":"Actually, looking at the older code, I think this will continue to work on the older versions, it just won\u0027t wait for them to be sshable (of course). That\u0027s the behavior we had before these changes, so I\u0027m not sure this actually *requires* newer tempest.\n\nThat said, I\u0027ll just defer to gmann. Tempest 30 was yoga so unless this plugin needs to support much older versions than are currently supported, bumping the version might be fine, I dunno.\n\nTechnically for SSHABLE to work with the scenario tests, it needs tempest master, so...","commit_id":"93ca44807c18dbafa0993f90addf9079c7823720"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"36ae715319b5bd82d736ce0380e6cde9dd67e182","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1b36e2f7_0af2f409","in_reply_to":"375cf9ee_417beb30","updated":"2023-05-03 18:15:45.000000000","message":"I agree with Eric SSHABLE in wait_until arg does not work for tempest\u003c30.0.0 as it will timeout if we pass wait_until\u003dSSHABLE in tempest\u003c30.0.0\n\n-  https://github.com/openstack/tempest/blob/30.0.0/tempest/common/compute.py#L268\n\nWe can bump the version here and below is something we can do for stable branch testing:\n\n- Any stable branch in supported state use the tempest master so no issue here\n- stable/xena branch going in EM and we need to use tempest \u003c30.0.0 and cinder-tempest-plugin \u003e1.5.0 (released in xena) \u003c\u003d1.8.0 (latest release before this change) and it will work.\n- stable/yoga can go in same way I mean if tempest is pinned \u003c30.0.0 in stable/yoga then compatible cinder-tempest-plugin can be used ( \u003e 1.6.0 (released in yoga) \u003c\u003d1.8.0 (latest release before this change))\n\nWhen I pin the tempest in stable EM branch, I do test project stable jobs with plugins and cap pinned tempest compatible plugin version.\n\n-  https://review.opendev.org/q/topic:ussuri-pin-tempest\n- https://review.opendev.org/q/topic:wallaby-pin-tempest","commit_id":"93ca44807c18dbafa0993f90addf9079c7823720"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"882b20e3ec7dc29908cfd367857f59fce0f80898","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"83f9798d_b40567b5","updated":"2023-05-04 13:38:01.000000000","message":"Good catch by Eric and Ghanshyam on the tempest min version.  LGTM.","commit_id":"5f38afea788938b7bd984f03b8913087419b9d30"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0db4c8220a3e5a5a08e63de8d28adcdebdb87b2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f9f19fbb_108507e4","updated":"2023-05-03 18:43:00.000000000","message":"Thanks!","commit_id":"5f38afea788938b7bd984f03b8913087419b9d30"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c6082da047dc5577cc45c4fe42ebe21eddedff06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5cf3ebfc_3d9365a6","updated":"2023-05-03 21:25:14.000000000","message":"recheck lvm job timed out","commit_id":"5f38afea788938b7bd984f03b8913087419b9d30"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"43809c605ee26e809ab085ed496c6a3829c56d76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f2791c72_37c54512","updated":"2023-05-03 18:22:36.000000000","message":"thanks, lgtm","commit_id":"5f38afea788938b7bd984f03b8913087419b9d30"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ff87b371131351fc3f8e6420a306fcc1352fc61f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"22efe6e9_fac0be98","updated":"2023-05-04 19:42:33.000000000","message":"let me release new tempest and  can bump the same in requirement.txt.\n\nNOTE: ^^ that is needed only for EM and older stable branch testing otherwise all supported branch and master has to be tested with master Tempest and master cinder-tempest-plugin where everything will work.","commit_id":"f010356dd54d6e726feb536a37062eea22620e27"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0a5fb51c1428fa44b4d37d451b1dd1d798ca94a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3e6ab126_58d63d93","in_reply_to":"02ab9216_0c5e6344","updated":"2023-05-04 20:08:43.000000000","message":"this is tempest new releases started https://review.opendev.org/q/topic:tempest-34-2-0-release","commit_id":"f010356dd54d6e726feb536a37062eea22620e27"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2c0a10400722fe16aa5102800ca93754d932be28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"02ab9216_0c5e6344","in_reply_to":"22efe6e9_fac0be98","updated":"2023-05-04 19:49:36.000000000","message":"saying that, I will not block this change for tempest new release things as everything will work currently\n- stable/wallaby use old tempest and old cinder-tempest-plugin\n- stable/xena till master CI use master tempest and master cinder-tempest-plugin so all good here.\n\nIt is up to cinder-tempest-plugin maintainers if they want to hold this until tempest new release coming or merge it now and bump tempest in requirements.txt later","commit_id":"f010356dd54d6e726feb536a37062eea22620e27"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0338d58e063a7d6acc30fa5bbfe2a000366e1da2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8646566e_d7ee7384","updated":"2023-05-05 12:37:51.000000000","message":"I\u0027m OK with approving this now (since Ghanshyam is) and updating the min tempest in requirements.txt once https://review.opendev.org/c/openstack/releases/+/882356 has merged (which may not be until next week since today is Friday).","commit_id":"015448aa507a62d3491b82c2a35cc70c743f2c3c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"64d3bf451e244d1c86b7095ee53b5c5886373476","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"98fb4164_18d5a52f","updated":"2023-05-05 00:21:09.000000000","message":"lgtm","commit_id":"015448aa507a62d3491b82c2a35cc70c743f2c3c"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"d9b08e80c6ce65afd1992c2805a1b2889f71e824","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b436d96e_6e86fec7","updated":"2023-05-05 13:45:08.000000000","message":"ups","commit_id":"015448aa507a62d3491b82c2a35cc70c743f2c3c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"381d8eb57d2cf6bde88a00a38dcd943cc7af82d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5b2f85e4_dd7179ec","in_reply_to":"8646566e_d7ee7384","updated":"2023-05-09 18:45:37.000000000","message":"done in https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/882734","commit_id":"015448aa507a62d3491b82c2a35cc70c743f2c3c"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"be5e05bda88bcad6aa5e095a558aba2a90c8d7a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"57b8414f_55ee46f4","updated":"2023-05-05 13:51:22.000000000","message":"Thanks, that line was fixed, so ninja merging relying on the votes on the previous revision","commit_id":"51c56f219e47662ec5fc2346779a1c68d8e23052"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1ad8fec89463648c40ebd6a026206e224d1ec015","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"e4e4ac53_d785f5dc","updated":"2023-05-05 16:42:34.000000000","message":"recheck bug 2018612","commit_id":"51c56f219e47662ec5fc2346779a1c68d8e23052"}],"cinder_tempest_plugin/api/volume/test_volume_backup.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"729af27fe6837ba41432825eaf4496ff5d211a87","unresolved":true,"context_lines":[{"line_number":104,"context_line":"                   \u0027delete_on_termination\u0027: \u00270\u0027}]"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        server_name \u003d data_utils.rand_name(\u0027instance\u0027)"},{"line_number":107,"context_line":"        server \u003d self.create_server("},{"line_number":108,"context_line":"            name\u003dserver_name,"},{"line_number":109,"context_line":"            block_device_mapping\u003dbd_map,"},{"line_number":110,"context_line":"            wait_until\u003d\u0027SSHABLE\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"73c5fd8d_66da6ffd","line":107,"range":{"start_line":107,"start_character":0,"end_line":107,"end_character":36},"updated":"2023-05-02 00:09:15.000000000","message":"cinder tempest plugin has its own create_server which needs to be fixed to pass the validation resources https://github.com/openstack/cinder-tempest-plugin/blob/master/cinder_tempest_plugin/api/volume/base.py#L136","commit_id":"ed0e90ec441e58d8b3aeb44e063a86293e73999c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"11d7019c1bb3d2275bcb746c1d2a1a6f97319a96","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                   \u0027delete_on_termination\u0027: \u00270\u0027}]"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        server_name \u003d data_utils.rand_name(\u0027instance\u0027)"},{"line_number":107,"context_line":"        server \u003d self.create_server("},{"line_number":108,"context_line":"            name\u003dserver_name,"},{"line_number":109,"context_line":"            block_device_mapping\u003dbd_map,"},{"line_number":110,"context_line":"            wait_until\u003d\u0027SSHABLE\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"99798866_0f58cc17","line":107,"range":{"start_line":107,"start_character":0,"end_line":107,"end_character":36},"in_reply_to":"73c5fd8d_66da6ffd","updated":"2023-05-02 13:56:59.000000000","message":"Done","commit_id":"ed0e90ec441e58d8b3aeb44e063a86293e73999c"}],"cinder_tempest_plugin/scenario/test_snapshots.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d89aa9b31a86dbb754f33e34ec05d239749a09a9","unresolved":true,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        # Create an instance"},{"line_number":56,"context_line":"        server \u003d self.create_server("},{"line_number":57,"context_line":"            key_name\u003dself.keypair[\u0027name\u0027],"},{"line_number":58,"context_line":"            validatable\u003dTrue,"},{"line_number":59,"context_line":"            validation_resources\u003dself.validation_resources,"},{"line_number":60,"context_line":"            wait_until\u003d\u0027SSHABLE\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7d889c39_eb12f455","line":57,"range":{"start_line":57,"start_character":11,"end_line":57,"end_character":42},"updated":"2023-05-04 19:14:34.000000000","message":"we need to pass self.keypair here right to make SSHABLE work","commit_id":"dd36aeab1bd7bee19464afc5a308357a210f1f69"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f7350c0f84ef9a21f6ca04bd5c4b482fca21f8a3","unresolved":true,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        # Create an instance"},{"line_number":56,"context_line":"        server \u003d self.create_server("},{"line_number":57,"context_line":"            key_name\u003dself.keypair[\u0027name\u0027],"},{"line_number":58,"context_line":"            validatable\u003dTrue,"},{"line_number":59,"context_line":"            validation_resources\u003dself.validation_resources,"},{"line_number":60,"context_line":"            wait_until\u003d\u0027SSHABLE\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"67aa30db_4a446216","line":57,"range":{"start_line":57,"start_character":11,"end_line":57,"end_character":42},"in_reply_to":"4d7023ac_f871d921","updated":"2023-05-04 19:38:19.000000000","message":"Ohk, Dan explianed it in IRC, L33 case is actually when run_validation\u003dFalse and tempest will not do any validation but this test need this new kaypair for other puspose.\n\nall good here","commit_id":"dd36aeab1bd7bee19464afc5a308357a210f1f69"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ec2012751bd39553a996adbf1eb678d468422a41","unresolved":true,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        # Create an instance"},{"line_number":56,"context_line":"        server \u003d self.create_server("},{"line_number":57,"context_line":"            key_name\u003dself.keypair[\u0027name\u0027],"},{"line_number":58,"context_line":"            validatable\u003dTrue,"},{"line_number":59,"context_line":"            validation_resources\u003dself.validation_resources,"},{"line_number":60,"context_line":"            wait_until\u003d\u0027SSHABLE\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"a64e946a_98bacaf0","line":57,"range":{"start_line":57,"start_character":11,"end_line":57,"end_character":42},"in_reply_to":"7d889c39_eb12f455","updated":"2023-05-04 19:19:45.000000000","message":"I don\u0027t think so (and not according to my testing) because we\u0027re passing `validation_resources`. Above I get self.keypair from validation_resources so that passing this matches what is in validation_resources.","commit_id":"dd36aeab1bd7bee19464afc5a308357a210f1f69"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"41df12e945b6f5b71f09c6f91e8318fdafafc5e6","unresolved":true,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        # Create an instance"},{"line_number":56,"context_line":"        server \u003d self.create_server("},{"line_number":57,"context_line":"            key_name\u003dself.keypair[\u0027name\u0027],"},{"line_number":58,"context_line":"            validatable\u003dTrue,"},{"line_number":59,"context_line":"            validation_resources\u003dself.validation_resources,"},{"line_number":60,"context_line":"            wait_until\u003d\u0027SSHABLE\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"4d7023ac_f871d921","line":57,"range":{"start_line":57,"start_character":11,"end_line":57,"end_character":42},"in_reply_to":"a64e946a_98bacaf0","updated":"2023-05-04 19:27:26.000000000","message":"I think we have issue here, for example if self.kaypair is from L33 which is new keypair and with key_namke passing here it will get injected in nova server but validation_resources will not have keypair and SSH will not work.\n- https://github.com/openstack/tempest/blob/8f9c77b368285a732f59594abbe3cadd5f7f52f6/tempest/common/compute.py#L140\n\nValidation_resource must have keypair and if somehow it is not then we need to add that from new created keypair also in L33","commit_id":"dd36aeab1bd7bee19464afc5a308357a210f1f69"}],"cinder_tempest_plugin/scenario/test_volume_multiattach.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"2554232209084770c5f056b431fb0fc088dd4b95","unresolved":true,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        # Create an instance"},{"line_number":53,"context_line":"        server_1 \u003d self.create_server("},{"line_number":54,"context_line":"            keypair\u003dself.keypair,"},{"line_number":55,"context_line":"            wait_until\u003d\u0027SSHABLE\u0027,"},{"line_number":56,"context_line":"            security_groups\u003d[{\u0027name\u0027: self.security_group[\u0027name\u0027]}])"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7f3c51a3_9bfc5dbd","line":54,"updated":"2023-05-04 13:44:00.000000000","message":"did the signature of create_server changed (and/or our usage of self.keypair) and we missed it?","commit_id":"5f38afea788938b7bd984f03b8913087419b9d30"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"e738144ca5b8d07f96bfcd6a9e1349fc666b5230","unresolved":true,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        # Create an instance"},{"line_number":53,"context_line":"        server_1 \u003d self.create_server("},{"line_number":54,"context_line":"            keypair\u003dself.keypair,"},{"line_number":55,"context_line":"            wait_until\u003d\u0027SSHABLE\u0027,"},{"line_number":56,"context_line":"            security_groups\u003d[{\u0027name\u0027: self.security_group[\u0027name\u0027]}])"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"f073024b_fdd0b7d4","line":54,"in_reply_to":"2de2f387_db4260db","updated":"2023-05-04 14:42:43.000000000","message":"So shouldn\u0027t we tag a new version of tempest and depend on that?","commit_id":"5f38afea788938b7bd984f03b8913087419b9d30"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4afaf83a63e7ad1ef2f0ec3b9903874b33bb75b0","unresolved":true,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        # Create an instance"},{"line_number":53,"context_line":"        server_1 \u003d self.create_server("},{"line_number":54,"context_line":"            keypair\u003dself.keypair,"},{"line_number":55,"context_line":"            wait_until\u003d\u0027SSHABLE\u0027,"},{"line_number":56,"context_line":"            security_groups\u003d[{\u0027name\u0027: self.security_group[\u0027name\u0027]}])"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"2de2f387_db4260db","line":54,"in_reply_to":"7f3c51a3_9bfc5dbd","updated":"2023-05-04 13:57:32.000000000","message":"Yeah, I changed it here:\n\nhttps://review.opendev.org/c/openstack/tempest/+/881675/13/tempest/scenario/manager.py\n\nBut fair point that that\u0027s not in tempest 30 either. It\u0027s kinda frustrating to have these spread out like this :/\n\nIf we have to support only released tempests then I guess these tests need to provide all the validation resource stuff themselves, because being able to do it natively in scenario/manager was stuff I only recently added to tempest.","commit_id":"5f38afea788938b7bd984f03b8913087419b9d30"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d89aa9b31a86dbb754f33e34ec05d239749a09a9","unresolved":true,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        # Create an instance"},{"line_number":53,"context_line":"        server_1 \u003d self.create_server("},{"line_number":54,"context_line":"            keypair\u003dself.keypair,"},{"line_number":55,"context_line":"            wait_until\u003d\u0027SSHABLE\u0027,"},{"line_number":56,"context_line":"            security_groups\u003d[{\u0027name\u0027: self.security_group[\u0027name\u0027]}])"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"4ee0ee49_68dada59","line":54,"in_reply_to":"aba25754_a308f238","updated":"2023-05-04 19:14:34.000000000","message":"So there is no backward compatible change here and we test supported stable and master gate with the master cinder-tempest-plugin and master tempest so all good and work here for our CI. We can see stable job passing here.\n\nNow if we think of stable branch say stable/xena going to EM and we need to try cinder-tempest-plugin master(after this change) with tempest 30.0.0 then it would not work.\n \n- old way of passing the key_name still work. This means cinder-tempest-plugin continue working the same way with Tempest 30.0.0 or tempest master.\n- New way to pass SSHABLE and keypair object work with Tempest master with fix 881675 but does not work with Tempest 30.0.0 So master conder-tempest-plugin (after this change) need to get the new released tempest to make SSHABLE work.\n\nWe just need to find compatible cinder-tempest-plugin and tempest versions to run it successfully on stable/xena once it is EM but if we want to be very safe side then I am ok to release new tag for Tempest and bump tempest in cinder-tempest-plugin requirement","commit_id":"5f38afea788938b7bd984f03b8913087419b9d30"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"428aba10e176aa5804532b9b2c3dd59c030c5342","unresolved":true,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        # Create an instance"},{"line_number":53,"context_line":"        server_1 \u003d self.create_server("},{"line_number":54,"context_line":"            keypair\u003dself.keypair,"},{"line_number":55,"context_line":"            wait_until\u003d\u0027SSHABLE\u0027,"},{"line_number":56,"context_line":"            security_groups\u003d[{\u0027name\u0027: self.security_group[\u0027name\u0027]}])"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"aba25754_a308f238","line":54,"in_reply_to":"f073024b_fdd0b7d4","updated":"2023-05-04 15:13:51.000000000","message":"If we can, that\u0027d be great, but I guess I assumed that a mid-cycle tag of master tempest wasn\u0027t on the table. I\u0027ll have to defer to the QA people for that.\n\nI\u0027m trying to get this reswizzled to not depend on that in the meantime, but it\u0027d obviously be a lot nicer if I didn\u0027t have to, since this is all working in its current form.","commit_id":"5f38afea788938b7bd984f03b8913087419b9d30"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d89aa9b31a86dbb754f33e34ec05d239749a09a9","unresolved":true,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        # Create an instance"},{"line_number":60,"context_line":"        server_1 \u003d self.create_server("},{"line_number":61,"context_line":"            key_name\u003dself.keypair[\u0027name]\u0027],"},{"line_number":62,"context_line":"            wait_until\u003d\u0027SSHABLE\u0027,"},{"line_number":63,"context_line":"            security_groups\u003d[{\u0027name\u0027: self.security_group[\u0027name\u0027]}])"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"868e28a7_632220e2","line":61,"range":{"start_line":61,"start_character":12,"end_line":61,"end_character":42},"updated":"2023-05-04 19:14:34.000000000","message":"ditto","commit_id":"dd36aeab1bd7bee19464afc5a308357a210f1f69"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d89aa9b31a86dbb754f33e34ec05d239749a09a9","unresolved":true,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        # Create another instance"},{"line_number":101,"context_line":"        server_2 \u003d self.create_server("},{"line_number":102,"context_line":"            keypair\u003dself.keypair,"},{"line_number":103,"context_line":"            wait_until\u003d\u0027SSHABLE\u0027,"},{"line_number":104,"context_line":"            security_groups\u003d[{\u0027name\u0027: self.security_group[\u0027name\u0027]}])"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a1ca282_0bc04ba3","line":102,"range":{"start_line":102,"start_character":12,"end_line":102,"end_character":33},"updated":"2023-05-04 19:14:34.000000000","message":"+1","commit_id":"dd36aeab1bd7bee19464afc5a308357a210f1f69"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"388e10f1e6d5c9acb7296a2c33e3f1a4593ca1de","unresolved":true,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        # Create another instance"},{"line_number":101,"context_line":"        server_2 \u003d self.create_server("},{"line_number":102,"context_line":"            keypair\u003dself.keypair,"},{"line_number":103,"context_line":"            wait_until\u003d\u0027SSHABLE\u0027,"},{"line_number":104,"context_line":"            security_groups\u003d[{\u0027name\u0027: self.security_group[\u0027name\u0027]}])"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"4f4f4874_9c492853","line":102,"range":{"start_line":102,"start_character":12,"end_line":102,"end_character":33},"in_reply_to":"2121420c_67f1dcf9","updated":"2023-05-05 13:34:39.000000000","message":"Yeah, I missed this one. I\u0027ll write a followup patch since this is in the gate now.","commit_id":"dd36aeab1bd7bee19464afc5a308357a210f1f69"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"82167919f125f1701584e0946d58d89464a45b22","unresolved":true,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        # Create another instance"},{"line_number":101,"context_line":"        server_2 \u003d self.create_server("},{"line_number":102,"context_line":"            keypair\u003dself.keypair,"},{"line_number":103,"context_line":"            wait_until\u003d\u0027SSHABLE\u0027,"},{"line_number":104,"context_line":"            security_groups\u003d[{\u0027name\u0027: self.security_group[\u0027name\u0027]}])"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"f1038529_ccfe4789","line":102,"range":{"start_line":102,"start_character":12,"end_line":102,"end_character":33},"in_reply_to":"4f4f4874_9c492853","updated":"2023-05-05 13:45:31.000000000","message":"please update this one, I hope I\u0027ve blocked the merge","commit_id":"dd36aeab1bd7bee19464afc5a308357a210f1f69"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"772d121c67f771053417d98bf5bda2908769e037","unresolved":true,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        # Create another instance"},{"line_number":101,"context_line":"        server_2 \u003d self.create_server("},{"line_number":102,"context_line":"            keypair\u003dself.keypair,"},{"line_number":103,"context_line":"            wait_until\u003d\u0027SSHABLE\u0027,"},{"line_number":104,"context_line":"            security_groups\u003d[{\u0027name\u0027: self.security_group[\u0027name\u0027]}])"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"2121420c_67f1dcf9","line":102,"range":{"start_line":102,"start_character":12,"end_line":102,"end_character":33},"in_reply_to":"7a1ca282_0bc04ba3","updated":"2023-05-05 08:22:15.000000000","message":"shouldn\u0027t this be restored to the previous value, just like lines 61 and 130?","commit_id":"dd36aeab1bd7bee19464afc5a308357a210f1f69"}]}