)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"d59ea69bb94b61f345fe679db173ab56395776d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"74c8573e_2d8496a9","updated":"2023-10-08 18:16:24.000000000","message":"recheck\n\nUnrelated issues in cinder-tempest-plugin-lvm-multiattach","commit_id":"db60c1de9ee734d28d15665f6768be468e6610a9"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"6997d4555a524a2877a19dde3e43ad418b396a98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d7d2999f_8620d8ac","updated":"2023-10-09 07:25:54.000000000","message":"recheck\n\nUnrelated issues in cinder-tempest-plugin-lvm-nvmet-barbican","commit_id":"db60c1de9ee734d28d15665f6768be468e6610a9"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"de8d069f1f4162177291eab03749861265c4c468","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0af19cac_1670dea3","updated":"2023-10-08 10:25:16.000000000","message":"recheck\n\nUnrelated issues in:\ncinder-tempest-plugin-lvm-multiattach\ncinder-tempest-plugin-lvm-lio-barbican","commit_id":"db60c1de9ee734d28d15665f6768be468e6610a9"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"c00f57aa70f8c8af4fa5ccc443b6776cc3ff0345","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7d84dfce_4d7f0c9c","updated":"2023-10-04 07:37:36.000000000","message":"recheck\n\nUnrelated issues in:\ncinder-tempest-plugin-lvm-multiattach\ncinder-tempest-plugin-lvm-lio-barbican\ncinder-tempest-plugin-lvm-nvmet-barbican","commit_id":"db60c1de9ee734d28d15665f6768be468e6610a9"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0ad1179d0d7534b4de30efeb389323e2710fc20f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"13f57fb2_bac5b9e9","updated":"2024-01-19 15:45:28.000000000","message":"one comment inline.\nAlso skipping the tests doesn\u0027t seem like a good option, we should find the root cause why readers are allowed to update/delete resources which will be a big loophole is the \"Security\" aspect of SRBAC.","commit_id":"4e8bf9d35f68d8a8aa310956bfd09cf34432d023"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"453a4adbeffcb768b4c752d8c2d57cc396089393","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d46a7435_f780ec4a","updated":"2023-11-05 08:27:38.000000000","message":"recheck\n\nUnrelated failures","commit_id":"4e8bf9d35f68d8a8aa310956bfd09cf34432d023"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"950942b7dea9606b516348208d722cdf8ea15b33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"81a67d49_2608560f","updated":"2023-11-16 11:04:06.000000000","message":"recheck\n\nUnrelated issue in:\ncinder-tempest-plugin-cbak-s3","commit_id":"4e8bf9d35f68d8a8aa310956bfd09cf34432d023"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"dcbf2893b6906f83ffa9cd5ca15875cb10f15754","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"69f038f4_b249e03b","updated":"2023-11-15 08:54:36.000000000","message":"recheck\n\nUnrelated issue in:\ncinder-tempest-plugin-lvm-multiattach\ncinder-tempest-plugin-cbak-s3","commit_id":"4e8bf9d35f68d8a8aa310956bfd09cf34432d023"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"66fe1db33d03c067f88410c87acc02557a503d1b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"33cd083a_60f41d99","updated":"2023-10-30 09:42:19.000000000","message":"recheck\n\nUnrelated issue in:\ncinder-tempest-plugin-lvm-multiattach\ncinder-tempest-plugin-lvm-lio-barbican\ncinder-tempest-plugin-lvm-nvmet-barbican","commit_id":"4e8bf9d35f68d8a8aa310956bfd09cf34432d023"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"e2dd152bc4b4a858a55547a97aa994e1fb3dddcc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c1a1a865_8aa63d5e","updated":"2023-10-31 07:50:57.000000000","message":"recheck\n\nUnrelated issue in:\ncinder-tempest-plugin-lvm-multiattach\ncinder-tempest-plugin-lvm-nvmet-barbican","commit_id":"4e8bf9d35f68d8a8aa310956bfd09cf34432d023"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"6fb018193eae08aa053ae177049bae111170588b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a3943a1e_2ea3aa54","updated":"2023-11-12 07:57:17.000000000","message":"recheck\n\nUnrelated issue in:\ncinder-tempest-plugin-lvm-multiattach\ncinder-tempest-plugin-lvm-nvmet-barbican\ncinder-tempest-plugin-cbak-s3","commit_id":"4e8bf9d35f68d8a8aa310956bfd09cf34432d023"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"05850ad571752d030c1da26831a4ef78567a78fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d308a7ab_762c5240","updated":"2023-11-09 07:53:43.000000000","message":"recheck\n\nUnrelated issue in:\ncinder-tempest-plugin-lvm-multiattach\ncinder-tempest-plugin-lvm-nvmet-barbican\ncinder-tempest-plugin-cbak-s3","commit_id":"4e8bf9d35f68d8a8aa310956bfd09cf34432d023"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"240ee509d051d2cc9a1a90058c36c1a348e6190c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7724e33a_e12f63f3","updated":"2023-10-15 13:47:10.000000000","message":"recheck\n\nUnrelated issues in:\ncinder-tempest-plugin-lvm-lio-barbican\ncinder-tempest-plugin-lvm-nvmet-barbican","commit_id":"4e8bf9d35f68d8a8aa310956bfd09cf34432d023"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"d9a07062c29ccc957cad7bca9d5d7574da7f2919","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f65b457b_8b3e7668","updated":"2024-01-16 12:55:32.000000000","message":"recheck\n\nUnrelated issues in:\ncinder-tempest-plugin-lvm-multiattach\ncinder-tempest-plugin-lvm-lio-barbican\ncinder-tempest-plugin-lvm-nvmet-barbican\ncinder-tempest-plugin-cbak-s3","commit_id":"4e8bf9d35f68d8a8aa310956bfd09cf34432d023"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"32c30d7ec4f0ed1fd40b9bc66fd35b4e7ba19826","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"40d373b4_dcbeb31a","updated":"2023-10-15 07:58:53.000000000","message":"recheck\n\nUnrelated issues in:\ncinder-tempest-plugin-lvm-multiattach\ncinder-tempest-plugin-lvm-nvmet-barbican","commit_id":"4e8bf9d35f68d8a8aa310956bfd09cf34432d023"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"cb5359106d7b7a8bb0f801a675a570d85559829b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0c0ff1cd_c657393d","in_reply_to":"81a67d49_2608560f","updated":"2023-11-16 15:37:05.000000000","message":"cbak-s3 seems to be misconfigured:\n\nNov 16 11:39:46.907230 np0035782234 cinder-backup[81873]: ERROR oslo_messaging.rpc.server [None req-e01345ee-81f9-411c-9d7a-c2c59bfe4b7d tempest-VolumesBackupsV39Test-790611015 None] Exception during message handling: cinder.backup.drivers.s3.S3ClientError: S3 client error: An error occurred (400) when calling the HeadBucket operation: Bad Request\n\nNov 16 11:39:47.181053 np0035782234 cinder-backup[81873]: WARNING cinder.backup.drivers.s3 [None req-a72e0798-a412-4194-827f-d902682a747d tempest-VolumesBackupsV39Test-790611015 None] backup_s3_verify_ssl is True but no cert file was provided","commit_id":"4e8bf9d35f68d8a8aa310956bfd09cf34432d023"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"2b67bdc80947bc0eab412265d34afc5760790fc5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ff220a72_f98f3148","updated":"2024-06-09 13:44:07.000000000","message":"recheck","commit_id":"557ebe146ac458de1f2c3bdfdb454e5753519167"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"75e7c20f22d28d00fc4b8e3be144df7c93f632c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6549d4b8_bb76011c","updated":"2024-01-22 11:43:56.000000000","message":"recheck\n\nUnrelated issues in cinder-tempest-plugin-lvm-lio-barbican","commit_id":"557ebe146ac458de1f2c3bdfdb454e5753519167"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"4cefce5f8e5896c896e372890ebe0004a9b864ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fa0022c1_375f72f1","updated":"2024-06-10 12:19:55.000000000","message":"recheck\n\nunrelated issue in cinder-tempest-plugin-lvm-multiattach","commit_id":"886ca504bfd3682fc8e2ba6930552234b2d1dca5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8d8e5275afd0a32b2d9eb7484337519f699f5acd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9d20caf9_216b5683","updated":"2024-08-23 16:32:00.000000000","message":"recheck - somehow zuul did not notice the new patch set","commit_id":"b4c7f7435c8801d9bdfccdbee680e8436712166d"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"80210f373ab11852b4386935834bdbb3913e98f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"62417d8b_70ba5e37","updated":"2024-09-27 09:25:28.000000000","message":"recheck\n\njust that on a single line maybe?","commit_id":"c07c11563fa74e5878e95d47e070c003926a82dd"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e8273d543b0c781fc2da127b6042f50847e2a594","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"688a00c5_041677cc","updated":"2024-09-26 14:54:40.000000000","message":"recheck logs have expired","commit_id":"c07c11563fa74e5878e95d47e070c003926a82dd"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"36e4d5e37e153c398f815e27aa4fc3c6484a93e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"58e2df76_27662694","updated":"2024-09-27 09:00:19.000000000","message":"recheck not sure why the jobs didn\u0027t run","commit_id":"c07c11563fa74e5878e95d47e070c003926a82dd"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"28952a05320e2a3ef99aa46e39762468e41a78fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f9669874_e2af50e2","updated":"2024-09-30 08:37:12.000000000","message":"We looked at this on friday and looks like the problem is not with the reader tests but with the client being supplied which might be admin.\nIn local devstack env, with demo_reader user and demo project, we cannot create volumes or any other resource or modify/delete anything.\nit only works in the gate because of a few things noted inline.","commit_id":"9433247546e701684350640a70a2cddda32589c5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d4ef30b49c27012ed1485ef6356229f49dffcea8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"931fbc88_6996460f","updated":"2024-10-08 12:45:53.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican - timeout during cinder_tempest_plugin.scenario.test_snapshots.SnapshotDataIntegrityTests.test_snapshot_data_integrity","commit_id":"844a65187a6a30f88032c32db0f57edf0a4b5e1f"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"01bf55f4366417fb8aac2e7381b358f1aa3c13b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"5e1eab80_e8363e60","updated":"2024-12-03 09:10:58.000000000","message":"recheck","commit_id":"ab6cc083fd81cef7a44ed3a5939abdf5ad34b39f"}],"cinder_tempest_plugin/rbac/v3/test_volumes_metadata.py":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"229b1fcfa7125629a13438495dc169963c978574","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def resource_setup(cls):"},{"line_number":35,"context_line":"        super(VolumeV3RbacVolumesMetadataTests, cls).resource_setup()"},{"line_number":36,"context_line":"        cls.volume_id \u003d cls.create_test_volume(cls)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def create_test_volume(self):"},{"line_number":39,"context_line":"        return self.create_volume("}],"source_content_type":"text/x-python","patch_set":3,"id":"5ec1da26_9b703675","line":36,"range":{"start_line":36,"start_character":28,"end_line":36,"end_character":46},"updated":"2023-10-10 08:56:02.000000000","message":"I know it\u0027s not related to this patch but I think this method should return the full object so that it is possible to filter every attribute and not only the volume id.","commit_id":"db60c1de9ee734d28d15665f6768be468e6610a9"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"229b1fcfa7125629a13438495dc169963c978574","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def resource_setup(cls):"},{"line_number":35,"context_line":"        super(VolumeV3RbacVolumesMetadataTests, cls).resource_setup()"},{"line_number":36,"context_line":"        cls.volume_id \u003d cls.create_test_volume(cls)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def create_test_volume(self):"},{"line_number":39,"context_line":"        return self.create_volume("}],"source_content_type":"text/x-python","patch_set":3,"id":"67d15d99_c2fb7619","line":36,"range":{"start_line":36,"start_character":47,"end_line":36,"end_character":50},"updated":"2023-10-10 08:56:02.000000000","message":"You can remove it.","commit_id":"db60c1de9ee734d28d15665f6768be468e6610a9"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"84bc3a41d9085f1ce4376a07ef278d2f2f3d1880","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def resource_setup(cls):"},{"line_number":35,"context_line":"        super(VolumeV3RbacVolumesMetadataTests, cls).resource_setup()"},{"line_number":36,"context_line":"        cls.volume_id \u003d cls.create_test_volume(cls)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def create_test_volume(self):"},{"line_number":39,"context_line":"        return self.create_volume("}],"source_content_type":"text/x-python","patch_set":3,"id":"c4975d7c_fd7a4c0d","line":36,"range":{"start_line":36,"start_character":28,"end_line":36,"end_character":46},"in_reply_to":"5ec1da26_9b703675","updated":"2023-10-11 18:54:22.000000000","message":"Ack. Will do it in other patch.","commit_id":"db60c1de9ee734d28d15665f6768be468e6610a9"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"84bc3a41d9085f1ce4376a07ef278d2f2f3d1880","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def resource_setup(cls):"},{"line_number":35,"context_line":"        super(VolumeV3RbacVolumesMetadataTests, cls).resource_setup()"},{"line_number":36,"context_line":"        cls.volume_id \u003d cls.create_test_volume(cls)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def create_test_volume(self):"},{"line_number":39,"context_line":"        return self.create_volume("}],"source_content_type":"text/x-python","patch_set":3,"id":"08fff18b_def5780b","line":36,"range":{"start_line":36,"start_character":47,"end_line":36,"end_character":50},"in_reply_to":"67d15d99_c2fb7619","updated":"2023-10-11 18:54:22.000000000","message":"Done","commit_id":"db60c1de9ee734d28d15665f6768be468e6610a9"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"23f30364e44b18e1415af8b3502b445955bbff39","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def resource_setup(cls):"},{"line_number":35,"context_line":"        super(VolumeV3RbacVolumesMetadataTests, cls).resource_setup()"},{"line_number":36,"context_line":"        cls.volume_id \u003d cls.create_test_volume(cls)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def create_test_volume(self):"},{"line_number":39,"context_line":"        return self.create_volume("}],"source_content_type":"text/x-python","patch_set":3,"id":"02cffdb9_41d39ed5","line":36,"range":{"start_line":36,"start_character":28,"end_line":36,"end_character":46},"in_reply_to":"c4975d7c_fd7a4c0d","updated":"2024-01-22 09:00:50.000000000","message":"Done","commit_id":"db60c1de9ee734d28d15665f6768be468e6610a9"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"229b1fcfa7125629a13438495dc169963c978574","unresolved":true,"context_lines":[{"line_number":35,"context_line":"        super(VolumeV3RbacVolumesMetadataTests, cls).resource_setup()"},{"line_number":36,"context_line":"        cls.volume_id \u003d cls.create_test_volume(cls)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def create_test_volume(self):"},{"line_number":39,"context_line":"        return self.create_volume("},{"line_number":40,"context_line":"            client\u003dself.volumes_client, metadata\u003dself.metadata"},{"line_number":41,"context_line":"        )"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def _create_volume_metadata(self, expected_status):"},{"line_number":44,"context_line":"        \"\"\"Test create_volume_metadata operation."}],"source_content_type":"text/x-python","patch_set":3,"id":"e21a0c6a_ce876897","line":41,"range":{"start_line":38,"start_character":0,"end_line":41,"end_character":9},"updated":"2023-10-10 08:56:02.000000000","message":"I don\u0027t think it\u0027s needed.\nBetter to call it directly in the test to make it clearer that the volume is created with metadata.","commit_id":"db60c1de9ee734d28d15665f6768be468e6610a9"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"84bc3a41d9085f1ce4376a07ef278d2f2f3d1880","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        super(VolumeV3RbacVolumesMetadataTests, cls).resource_setup()"},{"line_number":36,"context_line":"        cls.volume_id \u003d cls.create_test_volume(cls)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def create_test_volume(self):"},{"line_number":39,"context_line":"        return self.create_volume("},{"line_number":40,"context_line":"            client\u003dself.volumes_client, metadata\u003dself.metadata"},{"line_number":41,"context_line":"        )"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def _create_volume_metadata(self, expected_status):"},{"line_number":44,"context_line":"        \"\"\"Test create_volume_metadata operation."}],"source_content_type":"text/x-python","patch_set":3,"id":"4cad8595_5079c5f2","line":41,"range":{"start_line":38,"start_character":0,"end_line":41,"end_character":9},"in_reply_to":"e21a0c6a_ce876897","updated":"2023-10-11 18:54:22.000000000","message":"Done","commit_id":"db60c1de9ee734d28d15665f6768be468e6610a9"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"4d5bc83c73e04c07444b754a01d662c26964a042","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from cinder_tempest_plugin.rbac.v3 import base as rbac_base"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"CONF \u003d config.CONF"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class VolumeV3RbacVolumesMetadataTests(rbac_base.VolumeV3RbacBaseTests):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ad741f12_6fc5f224","line":19,"updated":"2024-01-19 15:38:15.000000000","message":"I have a silly question: is it okay to have an unused boilerplate?\nThis is unused, right? Am I missing something?","commit_id":"4e8bf9d35f68d8a8aa310956bfd09cf34432d023"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"23f30364e44b18e1415af8b3502b445955bbff39","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from cinder_tempest_plugin.rbac.v3 import base as rbac_base"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"CONF \u003d config.CONF"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class VolumeV3RbacVolumesMetadataTests(rbac_base.VolumeV3RbacBaseTests):"}],"source_content_type":"text/x-python","patch_set":4,"id":"577966fa_46a9e7ca","line":19,"in_reply_to":"ad741f12_6fc5f224","updated":"2024-01-22 09:00:50.000000000","message":"Done","commit_id":"4e8bf9d35f68d8a8aa310956bfd09cf34432d023"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0ad1179d0d7534b4de30efeb389323e2710fc20f","unresolved":true,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"class ProjectReaderTests(VolumeV3RbacVolumesMetadataTests):"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    credentials \u003d [\u0027project_reader\u0027, \u0027project_admin\u0027]"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    @classmethod"},{"line_number":177,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ec44a7f_46dfd8fa","line":174,"range":{"start_line":174,"start_character":38,"end_line":174,"end_character":51},"updated":"2024-01-19 15:45:28.000000000","message":"I\u0027m not sure how this credentials list work but why are we passing project_admin here? I assume we only need to test the project_reader here\n\nAlso does removing the project_admin part has any impact on bug#2038369 since i can see that our policies for admin metadata are correctly configured to use the right rules.\n\nhttps://github.com/openstack/cinder/blob/master/cinder/policies/volume_metadata.py","commit_id":"4e8bf9d35f68d8a8aa310956bfd09cf34432d023"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"23f30364e44b18e1415af8b3502b445955bbff39","unresolved":true,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"class ProjectReaderTests(VolumeV3RbacVolumesMetadataTests):"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    credentials \u003d [\u0027project_reader\u0027, \u0027project_admin\u0027]"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    @classmethod"},{"line_number":177,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bd6657da_260a95a4","line":174,"range":{"start_line":174,"start_character":38,"end_line":174,"end_character":51},"in_reply_to":"9ec44a7f_46dfd8fa","updated":"2024-01-22 09:00:50.000000000","message":"We are passing project_admin because we want to perform some actions that reader can\u0027t.\nFor example, the test \"create_volume_metadata\" tries to create the metadata as a reader but the volume itself gets created by the admin as the reader don\u0027t have permission to do so.","commit_id":"4e8bf9d35f68d8a8aa310956bfd09cf34432d023"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"28952a05320e2a3ef99aa46e39762468e41a78fb","unresolved":true,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"class ProjectReaderTests(VolumeV3RbacVolumesMetadataTests):"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    credentials \u003d [\u0027project_reader\u0027, \u0027project_admin\u0027]"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    @classmethod"},{"line_number":177,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fe816221_aae11e4a","line":174,"range":{"start_line":174,"start_character":38,"end_line":174,"end_character":51},"in_reply_to":"bd6657da_260a95a4","updated":"2024-09-30 08:37:12.000000000","message":"Got it but this doesn\u0027t look like the right way to do it.\n1. Creating the volume should be done separately and not in the metadata create helper method\n2. project_admin shouldn\u0027t be used here since i think we are executing the tests from the admin role and not from reader role hence the failures","commit_id":"4e8bf9d35f68d8a8aa310956bfd09cf34432d023"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"5c40597a6fd0c93da74ec6eb4c03c2d23acd52b8","unresolved":true,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"class ProjectReaderTests(VolumeV3RbacVolumesMetadataTests):"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    credentials \u003d [\u0027project_reader\u0027, \u0027project_admin\u0027]"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    @classmethod"},{"line_number":177,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":4,"id":"97171b7d_8223468c","line":174,"range":{"start_line":174,"start_character":38,"end_line":174,"end_character":51},"in_reply_to":"fe816221_aae11e4a","updated":"2024-10-01 12:04:27.000000000","message":"1. ack, will do it separately\n2. the volume should be created using admin, but the requests (for metadata creation for example) should be used with either reader, member or admin","commit_id":"4e8bf9d35f68d8a8aa310956bfd09cf34432d023"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"28952a05320e2a3ef99aa46e39762468e41a78fb","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    @classmethod"},{"line_number":26,"context_line":"    def setup_clients(cls):"},{"line_number":27,"context_line":"        super().setup_clients()"},{"line_number":28,"context_line":"        cls.admin_volumes_client \u003d cls.os_project_admin.volumes_client_latest"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @classmethod"},{"line_number":31,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":10,"id":"36c78979_e62610c5","line":28,"range":{"start_line":28,"start_character":8,"end_line":28,"end_character":77},"updated":"2024-09-30 08:37:12.000000000","message":"why are we setting admin client in the helper methods? wouldn\u0027t this override the reader or member clients we are setting in the test classes?","commit_id":"9433247546e701684350640a70a2cddda32589c5"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"5c40597a6fd0c93da74ec6eb4c03c2d23acd52b8","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    @classmethod"},{"line_number":26,"context_line":"    def setup_clients(cls):"},{"line_number":27,"context_line":"        super().setup_clients()"},{"line_number":28,"context_line":"        cls.admin_volumes_client \u003d cls.os_project_admin.volumes_client_latest"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @classmethod"},{"line_number":31,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":10,"id":"925cf1af_11256eeb","line":28,"range":{"start_line":28,"start_character":8,"end_line":28,"end_character":77},"in_reply_to":"36c78979_e62610c5","updated":"2024-10-01 12:04:27.000000000","message":"Each class (reader, member \u0026 admin) creates its own cls.client with the relevant creds.\nSo, no. this doesn\u0027t overrides the cls.client and the requests are being used with the correct client.","commit_id":"9433247546e701684350640a70a2cddda32589c5"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"28952a05320e2a3ef99aa46e39762468e41a78fb","unresolved":true,"context_lines":[{"line_number":40,"context_line":"        \"\"\""},{"line_number":41,"context_line":"        volume \u003d self.create_volume()"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        self.do_request("},{"line_number":44,"context_line":"            method\u003d\u0027create_volume_metadata\u0027, expected_status\u003dexpected_status,"},{"line_number":45,"context_line":"            volume_id\u003dvolume[\u0027id\u0027], metadata\u003d{\u0027key3\u0027: \u0027value3\u0027}"},{"line_number":46,"context_line":"        )"},{"line_number":47,"context_line":"        if expected_status !\u003d exceptions.Forbidden:"},{"line_number":48,"context_line":"            vol \u003d self.admin_volumes_client.show_volume("},{"line_number":49,"context_line":"                volume_id\u003dvolume[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"57c7b05b_ad70b0e3","line":46,"range":{"start_line":43,"start_character":8,"end_line":46,"end_character":9},"updated":"2024-09-30 08:37:12.000000000","message":"we are not passing any client here, did we check which client is used to set the admin metadata?","commit_id":"9433247546e701684350640a70a2cddda32589c5"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"5c40597a6fd0c93da74ec6eb4c03c2d23acd52b8","unresolved":true,"context_lines":[{"line_number":40,"context_line":"        \"\"\""},{"line_number":41,"context_line":"        volume \u003d self.create_volume()"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        self.do_request("},{"line_number":44,"context_line":"            method\u003d\u0027create_volume_metadata\u0027, expected_status\u003dexpected_status,"},{"line_number":45,"context_line":"            volume_id\u003dvolume[\u0027id\u0027], metadata\u003d{\u0027key3\u0027: \u0027value3\u0027}"},{"line_number":46,"context_line":"        )"},{"line_number":47,"context_line":"        if expected_status !\u003d exceptions.Forbidden:"},{"line_number":48,"context_line":"            vol \u003d self.admin_volumes_client.show_volume("},{"line_number":49,"context_line":"                volume_id\u003dvolume[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"e4514cd6_9cc2287e","line":46,"range":{"start_line":43,"start_character":8,"end_line":46,"end_character":9},"in_reply_to":"57c7b05b_ad70b0e3","updated":"2024-10-01 12:04:27.000000000","message":"You can see in base.py file here: https://github.com/openstack/cinder-tempest-plugin/blob/master/cinder_tempest_plugin/rbac/v3/base.py#L76\n\nIf we don\u0027t pass the client, it uses the cls.client that is being initialized in every class setup_clients()","commit_id":"9433247546e701684350640a70a2cddda32589c5"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"28952a05320e2a3ef99aa46e39762468e41a78fb","unresolved":true,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"class ProjectMemberTests(VolumeV3RbacVolumesMetadataTests):"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    credentials \u003d [\u0027project_member\u0027, \u0027project_admin\u0027]"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    @classmethod"},{"line_number":202,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":10,"id":"8b986303_7f550403","line":199,"range":{"start_line":199,"start_character":38,"end_line":199,"end_character":51},"updated":"2024-09-30 08:37:12.000000000","message":"same, we should only have project_member here and not admin","commit_id":"9433247546e701684350640a70a2cddda32589c5"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"5c40597a6fd0c93da74ec6eb4c03c2d23acd52b8","unresolved":true,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"class ProjectMemberTests(VolumeV3RbacVolumesMetadataTests):"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    credentials \u003d [\u0027project_member\u0027, \u0027project_admin\u0027]"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    @classmethod"},{"line_number":202,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":10,"id":"0102b2cc_62c8064e","line":199,"range":{"start_line":199,"start_character":38,"end_line":199,"end_character":51},"in_reply_to":"8b986303_7f550403","updated":"2024-10-01 12:04:27.000000000","message":"Correct, but in this case, we will have to set the credential[] in the parent class with only \u0027project_admin\u0027.\nAnd then when we inherit this class and use the credential[] with \u0027project_member\u0027, only it will override the one with the \u0027project_admin\u0027.","commit_id":"9433247546e701684350640a70a2cddda32589c5"}]}