)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"f5c6a2b10532fb4a05dd6090e76c6a813aab685b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1d686266_952583bc","updated":"2023-11-29 13:30:41.000000000","message":"(and thanks for pushing this)","commit_id":"e17229399bb6c569cc794ac50a64ec8ea89da7f4"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"6fcae3437850e90cb9605a676233160db73f076b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3dcb8109_73aba20e","updated":"2024-07-15 14:56:06.000000000","message":"Hi Eric, can you please revisit the comments?","commit_id":"e17229399bb6c569cc794ac50a64ec8ea89da7f4"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"50c3f03917ac610196cf6aea9c336a02f57a79a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"67383291_fcd7c1da","updated":"2024-04-08 11:59:39.000000000","message":"Ok, let\u0027s at least fix the failure","commit_id":"e17229399bb6c569cc794ac50a64ec8ea89da7f4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ca47390b1d042c24ccd7f50aa83b650100d91481","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"60c7d16a_703e8a79","updated":"2024-05-28 14:34:37.000000000","message":"Question/comment inline.","commit_id":"e17229399bb6c569cc794ac50a64ec8ea89da7f4"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"a36d109050bb7d6489efb0185e8b529ad1ab154b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3156f838_95005c9b","updated":"2024-01-10 11:35:58.000000000","message":"recheck\n\na few jobs have been fixed","commit_id":"e17229399bb6c569cc794ac50a64ec8ea89da7f4"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"368103dce18c29f167b42083ff49c4ac2892d679","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d062806d_6b6faf27","updated":"2024-04-08 08:07:08.000000000","message":"recheck\n\nget fresh logs","commit_id":"e17229399bb6c569cc794ac50a64ec8ea89da7f4"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"054ea089c8196fb0703c78e9c416c146bd603c47","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a908118c_750d1440","updated":"2024-03-07 10:52:53.000000000","message":"recheck\n\nlogs","commit_id":"e17229399bb6c569cc794ac50a64ec8ea89da7f4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"80c6b89f23e963f8482ecd6f4aca7f9ac0d2fa24","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7f673241_448ba634","updated":"2024-09-04 11:08:55.000000000","message":"LGTM, thanks for fixing this Eric!","commit_id":"7329a20da5db9b4667b890155d7663661f36199d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c89477c0eece33a3f09e239e130ed4d9de527641","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"651632b6_f891d10d","updated":"2024-09-06 14:05:17.000000000","message":"LGTM.  Thanks, Eric!","commit_id":"7329a20da5db9b4667b890155d7663661f36199d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d459698b050418bf1d77ad45843602e2bb9e6d64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c5742b1e_a6120619","updated":"2024-09-04 11:10:30.000000000","message":"Removing W+1 if Brian wants to revisit his comment","commit_id":"7329a20da5db9b4667b890155d7663661f36199d"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"93be1bc6f0df3f0b6cd17520b7e12196c82c5558","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cbb06ea0_d8974952","updated":"2024-08-20 18:40:50.000000000","message":"recheck\n\nhttps://review.opendev.org/c/openstack/cinder-tempest-plugin/+/926620 , which fixes the failing cbak job , merged just a few minutes before this patch was updated","commit_id":"7329a20da5db9b4667b890155d7663661f36199d"}],"cinder_tempest_plugin/scenario/test_volume_multiattach.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"ab5270afece7632f604de75b5e125d4b7f9134a2","unresolved":true,"context_lines":[{"line_number":76,"context_line":"            other_volume \u003d self.create_encrypted_volume("},{"line_number":77,"context_line":"                \u0027luks\u0027, volume_type\u003d\u0027luks\u0027)"},{"line_number":78,"context_line":"        else:"},{"line_number":79,"context_line":"            other_volume \u003d self.create_volume("},{"line_number":80,"context_line":"                volume_type\u003dmultiattach_vol_type[\u0027id\u0027])"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        # Create a normal volume"}],"source_content_type":"text/x-python","patch_set":1,"id":"da0de3b7_010fca37","line":79,"updated":"2023-11-29 13:30:25.000000000","message":"this doesn\u0027t need a multiattach volume, but just a regular volume. I was thinking about setting some other property, but maybe just a random one?","commit_id":"e17229399bb6c569cc794ac50a64ec8ea89da7f4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ca47390b1d042c24ccd7f50aa83b650100d91481","unresolved":true,"context_lines":[{"line_number":76,"context_line":"            other_volume \u003d self.create_encrypted_volume("},{"line_number":77,"context_line":"                \u0027luks\u0027, volume_type\u003d\u0027luks\u0027)"},{"line_number":78,"context_line":"        else:"},{"line_number":79,"context_line":"            other_volume \u003d self.create_volume("},{"line_number":80,"context_line":"                volume_type\u003dmultiattach_vol_type[\u0027id\u0027])"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        # Create a normal volume"}],"source_content_type":"text/x-python","patch_set":1,"id":"cb8bd084_7066397c","line":79,"in_reply_to":"da0de3b7_010fca37","updated":"2024-05-28 14:34:37.000000000","message":"To follow up on Luigi\u0027s point, the comment at lines 85-87 implies that the reason we were using an encrypted volume here is that it was a convenient way to make sure that we would have 3 volumes of different types ... but now if the attach_encrypted feature is not enabled, we will wind up with two volumes being of the same type.\n\nI don\u0027t know how much this matters for the test, since simple_volume and other_volume aren\u0027t used in the test after they\u0027re attached, but I guess the comment at lines 85-87 needs some revision.","commit_id":"e17229399bb6c569cc794ac50a64ec8ea89da7f4"}]}