)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e0d8e9099e229c3bbdd88fce81d6d560f966d4c9","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     ybenshim \u003cybenshim@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-02-21 13:02:36 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"OSP 18.0 RFE"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"cinder backup needs to restore thin volumes (new volumes only)"},{"line_number":10,"context_line":"This test will loop through the backends, create backup and restore"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bffdcc07_f48cd8d0","line":7,"updated":"2024-05-13 18:28:58.000000000","message":"This needs a more descriptive (and upstream-oriented) summary line.","commit_id":"488a6b8e50bb5efef4c98032aae2b226ee1e1170"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"82ffe4ffdf1e452150e4e04e08bcd5b4ca30d7d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"94d6367c_70bc929a","updated":"2024-02-28 15:32:41.000000000","message":"I can\u0027t comment on the content yet, but the first line of the message doesn\u0027t really explain what\u0027s going on. The fact that this a possible implementation of a test for some release of a product is irrelevant here, and the commit message should just focus on what is needed here. Please fix .it\n\nAlso, it would be useful to have a testing job (we may have  with two cinder backends where the test is executed, because by default is not. I believe cinder-tempest-lvm-multibackend in the cinder repository does that, so you could try a review which depends on this to see if the test is executed.\n\nBut more important, there is already a prior review where the person who proposed it is not working on openstack anymore: https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/835512 \nDoes that cover the same use case? If it does, it would make sense to rebase that review and continue from it.","commit_id":"488a6b8e50bb5efef4c98032aae2b226ee1e1170"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"14da9e60b26a4f778a4681db98bb80884bbc2a81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"018b8c60_6523b1f6","updated":"2024-04-01 12:15:06.000000000","message":"Thanks Yosi! Please see the comments.","commit_id":"488a6b8e50bb5efef4c98032aae2b226ee1e1170"}],"cinder_tempest_plugin/scenario/test_volume_backup_restore.py":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"14da9e60b26a4f778a4681db98bb80884bbc2a81","unresolved":true,"context_lines":[{"line_number":38,"context_line":"        if len(CONF.volume.backend_names) \u003c 2:"},{"line_number":39,"context_line":"            LOG.warning(\"Requires at least two different backend names\")"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def setup_clients(cls):"},{"line_number":43,"context_line":"        super(ThinVolumeBackupRestoreTests, cls).setup_clients()"},{"line_number":44,"context_line":"        cls.volumes_client \u003d cls.os_primary.volumes_client_latest"},{"line_number":45,"context_line":"        cls.volume_types_client \u003d cls.os_primary.volume_types_client_latest"},{"line_number":46,"context_line":"        cls.backups_client \u003d cls.os_primary.backups_client_latest"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def setUp(self):"},{"line_number":49,"context_line":"        super(ThinVolumeBackupRestoreTests, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"7412876a_81f02301","line":46,"range":{"start_line":41,"start_character":0,"end_line":46,"end_character":65},"updated":"2024-04-01 12:15:06.000000000","message":"The clients mentioned have already been initialized within the setup_clients method of the parent classes.\n\nBy the way, volume_types_client_latest client should be initialized with admin credentials:\ncls.os_admin.volume_types_client_latest rather than cls.os_primary.volume_types_client_latest","commit_id":"488a6b8e50bb5efef4c98032aae2b226ee1e1170"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"14da9e60b26a4f778a4681db98bb80884bbc2a81","unresolved":true,"context_lines":[{"line_number":56,"context_line":"            self.keypair \u003d self.validation_resources[\u0027keypair\u0027]"},{"line_number":57,"context_line":"        else:"},{"line_number":58,"context_line":"            self.keypair \u003d self.create_keypair()"},{"line_number":59,"context_line":"        self.security_group \u003d self.create_security_group()"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        self.backend_names \u003d CONF.volume.backend_names"},{"line_number":62,"context_line":"        # Create an instance"}],"source_content_type":"text/x-python","patch_set":3,"id":"89cc2b40_39e21dde","line":59,"range":{"start_line":59,"start_character":8,"end_line":59,"end_character":58},"updated":"2024-04-01 12:15:06.000000000","message":"I\u0027m not entirely sure, but I think that if validation is enabled we should have a security group.","commit_id":"488a6b8e50bb5efef4c98032aae2b226ee1e1170"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"14da9e60b26a4f778a4681db98bb80884bbc2a81","unresolved":true,"context_lines":[{"line_number":88,"context_line":"            prefix\u003dCONF.resource_name_prefix,"},{"line_number":89,"context_line":"            name\u003dself.__class__.__name__ + \u0027-Volume\u0027)"},{"line_number":90,"context_line":"        extra_specs \u003d {}"},{"line_number":91,"context_line":"        if backend_name:"},{"line_number":92,"context_line":"            extra_specs \u003d {\"volume_backend_name\": backend_name}"},{"line_number":93,"context_line":"        vol_type \u003d self.create_volume_type("},{"line_number":94,"context_line":"            name\u003dtype_name, extra_specs\u003dextra_specs"}],"source_content_type":"text/x-python","patch_set":3,"id":"ef9d2ae1_32176d8e","line":91,"range":{"start_line":91,"start_character":8,"end_line":91,"end_character":23},"updated":"2024-04-01 12:15:06.000000000","message":"Why if statement if the \"backend_name\" parameter is a required parameter ?","commit_id":"488a6b8e50bb5efef4c98032aae2b226ee1e1170"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"14da9e60b26a4f778a4681db98bb80884bbc2a81","unresolved":true,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        volume_params \u003d {"},{"line_number":98,"context_line":"            \u0027name\u0027: vol_name,"},{"line_number":99,"context_line":"            \u0027volume_type\u0027: vol_type[\u0027name\u0027], \u0027size\u0027: 10"},{"line_number":100,"context_line":"        }"},{"line_number":101,"context_line":"        self.volume \u003d self.volumes_client.create_volume("},{"line_number":102,"context_line":"            **volume_params"}],"source_content_type":"text/x-python","patch_set":3,"id":"d185019d_0d79b4db","line":99,"range":{"start_line":99,"start_character":53,"end_line":99,"end_character":55},"updated":"2024-04-01 12:15:06.000000000","message":"1 is not enough ?","commit_id":"488a6b8e50bb5efef4c98032aae2b226ee1e1170"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"14da9e60b26a4f778a4681db98bb80884bbc2a81","unresolved":true,"context_lines":[{"line_number":98,"context_line":"            \u0027name\u0027: vol_name,"},{"line_number":99,"context_line":"            \u0027volume_type\u0027: vol_type[\u0027name\u0027], \u0027size\u0027: 10"},{"line_number":100,"context_line":"        }"},{"line_number":101,"context_line":"        self.volume \u003d self.volumes_client.create_volume("},{"line_number":102,"context_line":"            **volume_params"},{"line_number":103,"context_line":"        )[\u0027volume\u0027]"},{"line_number":104,"context_line":"        waiters.wait_for_volume_resource_status("},{"line_number":105,"context_line":"            self.volumes_client, self.volume[\u0027id\u0027], \u0027available\u0027"},{"line_number":106,"context_line":"        )"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        self.instance_ip \u003d self.get_server_ip(self.server)"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"b8740317_0e1cee14","line":106,"range":{"start_line":101,"start_character":0,"end_line":106,"end_character":9},"updated":"2024-04-01 12:15:06.000000000","message":"Is there a particular reason you\u0027re not utilizing the \u0027create_volume\u0027 helper method?","commit_id":"488a6b8e50bb5efef4c98032aae2b226ee1e1170"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"14da9e60b26a4f778a4681db98bb80884bbc2a81","unresolved":true,"context_lines":[{"line_number":157,"context_line":"            self.volumes_client, self.restore[\u0027volume_id\u0027], \u0027available\u0027"},{"line_number":158,"context_line":"        )"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        self.restored_volume \u003d self.volumes_client.show_volume("},{"line_number":161,"context_line":"            self.restore[\u0027volume_id\u0027]"},{"line_number":162,"context_line":"        )[\u0027volume\u0027]"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    @decorators.idempotent_id(\u0027f81a0357-abfc-48d1-98c8-e7ebaa60e4a0\u0027)"},{"line_number":165,"context_line":"    def test_backup_restore_thin_volume(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"a3f2c83c_e9e7c192","line":162,"range":{"start_line":160,"start_character":0,"end_line":162,"end_character":19},"updated":"2024-04-01 12:15:06.000000000","message":"Is it really necessary?\nThis method returns nothing.","commit_id":"488a6b8e50bb5efef4c98032aae2b226ee1e1170"}]}