)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"ff6285308faa3623aa0ce79956404c04e7018400","unresolved":true,"context_lines":[{"line_number":10,"context_line":"There are multiple patches that contains the same file and code."},{"line_number":11,"context_line":"Now, we will remove all the code from the other patches and rebase on"},{"line_number":12,"context_line":"this patch."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I4d5b4f5a212a587cc744874334502adb7179fd2a"},{"line_number":15,"context_line":"Signed-off-by: Yosi Ben Shimon \u003cybenshim@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"0048ef21_b25cf941","line":13,"updated":"2024-10-09 09:25:46.000000000","message":"This patch also changes several shared methods to pass the client, shouldn\u0027t this be explained in the commit message?","commit_id":"f0222d7a1cb8c1876baffebbe89180f767e2e3f7"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"bc761f651f61725d52c4aa6b17103627e445aa53","unresolved":false,"context_lines":[{"line_number":10,"context_line":"There are multiple patches that contains the same file and code."},{"line_number":11,"context_line":"Now, we will remove all the code from the other patches and rebase on"},{"line_number":12,"context_line":"this patch."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I4d5b4f5a212a587cc744874334502adb7179fd2a"},{"line_number":15,"context_line":"Signed-off-by: Yosi Ben Shimon \u003cybenshim@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"5ae96361_9c90fde7","line":13,"in_reply_to":"0048ef21_b25cf941","updated":"2024-10-09 10:09:35.000000000","message":"Acknowledged","commit_id":"f0222d7a1cb8c1876baffebbe89180f767e2e3f7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"528c9d1301341faacc60c4c88a33db0e7e4ad3f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bb8334d1_cf61ff03","updated":"2024-05-28 10:39:59.000000000","message":"Thanks Yosi!\nOverall it LGTM!\nPlease see the comments bellow.","commit_id":"d2164ba654d1ee315b9899406b4fdd763d8070da"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"2650c92700b0a0ce1c242007f716d0960673afec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"092ddd70_205c1103","updated":"2024-06-03 10:30:59.000000000","message":"recheck\n\nUnrelated issues in cinder-tempest-plugin-cbak-ceph","commit_id":"69b2c69d88b516f672aa8c10c9625184a88a3d18"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"4727b94f60e92d638be1347d7c5a8250e323bf9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"792b7aa7_f219b09e","updated":"2024-06-03 07:19:03.000000000","message":"recheck\n\nUnrelated issues in cinder-tempest-plugin-lvm-multiattach","commit_id":"69b2c69d88b516f672aa8c10c9625184a88a3d18"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"3c338d7dc07fc5fd216906a1565fa3bed36d11ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a5cb5d38_c13d491e","updated":"2024-06-09 08:34:59.000000000","message":"run-NetApp CI","commit_id":"bf4f22ada737f23db903d8fbb9181fea52a85530"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"60f3ad47dd1dada7bcb44ab21dcd61b03b213369","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c9a39575_5f199e78","updated":"2024-07-23 08:53:14.000000000","message":"recheck\n\nUnrelated issue in cinder-tempest-plugin-basic-2024-1","commit_id":"05fb678724e38405a70e6188549664aacde8a996"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"056ae0ad9ba0a07140c820ac61758db01831017e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"95520472_fbb7a369","updated":"2024-07-24 14:12:05.000000000","message":"run-NetApp CI","commit_id":"05fb678724e38405a70e6188549664aacde8a996"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"298527cbd064dc6b0202ff36c8726704ef7fb860","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"a861eebe_b4daecfe","updated":"2024-08-13 08:19:32.000000000","message":"run-NetApp CI","commit_id":"bbe0b93d57bba8d56bee256ebea406d329c59061"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"ab886476db79049eb12add22a494ea694ff86637","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"a85b4b0a_bfe05eef","updated":"2024-08-15 13:40:27.000000000","message":"recheck\n\nUnrelated issues in cinder-tempest-plugin-cbak-ceph","commit_id":"55929e46b71cd85571aaf96d057d85fb52a842ac"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"d958828525570226f50f96d796330d763f46545f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ab7bb013_a4efa1d6","updated":"2024-08-18 08:39:51.000000000","message":"recheck\n\nUnrelated issues in cinder-tempest-plugin-cbak-ceph","commit_id":"55929e46b71cd85571aaf96d057d85fb52a842ac"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"c991e9c4892a9f71333c7c61b5eba154b4b210bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f0d7420f_fd1025b5","updated":"2024-08-20 06:59:04.000000000","message":"recheck\n\nUnrelated issues in cinder-tempest-plugin-cbak-ceph","commit_id":"55929e46b71cd85571aaf96d057d85fb52a842ac"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0a48e414db6a95a6d9d354586117da59e4c8b95c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"d5242f99_4152f5c8","updated":"2024-08-16 14:32:11.000000000","message":"recheck cinder-tempest-plugin-lvm-nvmet-barbican failed\n\nmounting failed which is unrelated to this patch\n\nmount: mounting /dev/vdb on /mnt/995647987/vdb failed: Device or resource busy","commit_id":"55929e46b71cd85571aaf96d057d85fb52a842ac"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d873011c0477e4fc20c8c025c1e5f7b8641ed8b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"45fcd4ac_547809e0","updated":"2024-08-20 18:12:06.000000000","message":"recheck the patch skipping the failing tests is merged now https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/926620","commit_id":"55929e46b71cd85571aaf96d057d85fb52a842ac"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f90af57a2d85792facc1805539ab1f4bfb622454","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"40221f8d_f9040d27","updated":"2024-09-26 13:51:52.000000000","message":"recheck cinder-tempest-plugin-lvm-nvmet-barbican","commit_id":"19a1705dc5f67c42f52e5cd39250da7e77138560"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"b98fe0bdc7fb950daee2f01e4a047c51da2306b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"2b7d1011_ca4e3f75","updated":"2024-10-07 11:48:11.000000000","message":"Thanks Yosi!\nA minor comment on your patch.","commit_id":"bf532230e8945e9c35e9ef442cc4c7d98096b70b"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"433523905cd26998f3120dbc488efbfedcc80df7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"68d33448_48436fe4","updated":"2024-10-08 06:48:27.000000000","message":"run-NetApp CI","commit_id":"1e764cbd32414b4c0768dd4aa7b74b2cc57e5706"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ded9bb6eb26afea2e3823b5110e55ee34de36345","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"eeaa7cd8_56958a09","updated":"2024-10-08 12:42:06.000000000","message":"Sort of a nit noted inline, but it affects the readability of the code.","commit_id":"c34ecaaed11f78f8222957483bdb47b767cb7a98"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"e5d6aa6bb78c36f5d9d14161c1b0ef7e53148992","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"9afb7a75_c6729e41","updated":"2024-10-10 06:09:08.000000000","message":"run-NetApp CI","commit_id":"f74dcf67ec3c236f7fa6b23fd2d6a79ccddcfff6"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"16d37ea22847834e84a9373f80ade0220f2a3c4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"b9e20ec2_3b528ca2","updated":"2024-10-29 08:02:05.000000000","message":"run-NetApp CI","commit_id":"f74dcf67ec3c236f7fa6b23fd2d6a79ccddcfff6"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"3af9b72bdcc2cdb3d190f6744ca09fb720b24b15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"f8775fe9_1e3c85f9","updated":"2024-10-29 07:20:57.000000000","message":"run-NetApp CI","commit_id":"f74dcf67ec3c236f7fa6b23fd2d6a79ccddcfff6"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"052dbed7dfb2c5ee9756db8007670c61c43bf62d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"4cb508af_37e4d19a","updated":"2024-11-19 14:49:02.000000000","message":"run-NetApp CI","commit_id":"b190c31cea6c4ae0a45110a3ae512acd7a189079"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"1fec874f23c37aa9f686dd6b0641f9d5e5af9261","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"76eeeaa6_592d6c58","updated":"2024-11-04 07:25:39.000000000","message":"run-NetApp CI","commit_id":"b190c31cea6c4ae0a45110a3ae512acd7a189079"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"9fbef6c95f08ffa9bc7bf074139dd12a00598ab7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"b3516ecc_c60e45b2","updated":"2024-11-10 09:27:33.000000000","message":"run-NetApp CI","commit_id":"b190c31cea6c4ae0a45110a3ae512acd7a189079"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"db2e830f4de7730c01d814ca150f00670b61bd65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"5f1bb3f9_1c16e678","updated":"2025-09-11 06:57:49.000000000","message":"recheck\n\nFresh logs","commit_id":"4d5676333a4139dd653d2849d3f4c101b0d8f997"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"4aae2daba66c7d239af173ad0f7b1288a22f8110","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"d73f1632_1221291f","updated":"2025-05-19 08:03:44.000000000","message":"recheck\n\nFresh logs","commit_id":"4d5676333a4139dd653d2849d3f4c101b0d8f997"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"f1ffb1f80126d41bd5bae2ae89e694819637568c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"f3d11ad9_f0315bdf","updated":"2025-03-05 14:02:28.000000000","message":"recheck\n\nfor fresh logs","commit_id":"4d5676333a4139dd653d2849d3f4c101b0d8f997"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"8607a18da7c7745c6e579bf100e3878d8eb57d9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"d9cf7e98_34b08e48","updated":"2025-11-13 07:24:56.000000000","message":"recheck\n\nFresh logs","commit_id":"245dcd6e01024019b93b4d3ef27a9cf088bb7cb5"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"246917060ac4e55583776fbfcc43bf993efd2f75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"3edaeecc_7d52b7d3","updated":"2025-11-30 17:14:15.000000000","message":"recheck\n\nUnrelated issues","commit_id":"245dcd6e01024019b93b4d3ef27a9cf088bb7cb5"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"694d18bd5910712227c0d57dfc77031ead9cd562","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"54d3f50b_a830f40e","updated":"2025-12-02 15:37:23.000000000","message":"recheck\n\nUnrelated issues","commit_id":"245dcd6e01024019b93b4d3ef27a9cf088bb7cb5"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"80d470a518fc96c791f54e0190e1967fffe9e432","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"6c4b83e7_6dc61efe","updated":"2025-11-16 11:02:43.000000000","message":"recheck\n\nUnrelated issues","commit_id":"245dcd6e01024019b93b4d3ef27a9cf088bb7cb5"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"a91a3d9a16a41231dca7ed027514da6888776cec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"6f07b43a_bd4bcad2","updated":"2025-12-15 09:18:46.000000000","message":"recheck\n\nUnrelated issues","commit_id":"245dcd6e01024019b93b4d3ef27a9cf088bb7cb5"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"68dc29915a22239a5956c2ef3f8aec75606edb8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"6f2da9e9_a919431e","updated":"2025-11-25 21:05:42.000000000","message":"recheck\n\nUnrelated issues","commit_id":"245dcd6e01024019b93b4d3ef27a9cf088bb7cb5"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"cf56eeae627445e89e82a1787e6cb40c8bb100d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"b8a00ccf_a4b04c2f","updated":"2026-02-17 11:15:47.000000000","message":"recheck\n\nUnrelated issues","commit_id":"245dcd6e01024019b93b4d3ef27a9cf088bb7cb5"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"8211413b5c3055275c52fdd22fed2337e572cc9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"bd7928f4_e31a718a","updated":"2026-01-29 10:41:18.000000000","message":"recheck\n\nUnrelated issues","commit_id":"245dcd6e01024019b93b4d3ef27a9cf088bb7cb5"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"0cbccdf8e51152d5c412c37a09b2a8024a5eafbd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"cc67023c_9da76af8","updated":"2026-01-06 21:11:13.000000000","message":"recheck\n\nUnrelated issues","commit_id":"245dcd6e01024019b93b4d3ef27a9cf088bb7cb5"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"a20326222216a56ecdf581c41af00328268af320","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"d561fd94_a6c753f9","updated":"2025-11-18 14:49:02.000000000","message":"recheck\n\nUnrelated issues","commit_id":"245dcd6e01024019b93b4d3ef27a9cf088bb7cb5"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"17514e262963e6d1637840c99d701eb598e916ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"c0b3af3c_44f625d4","updated":"2025-11-13 09:29:12.000000000","message":"recheck\n\nUnrelated issues in:\ncinder-tempest-plugin-lvm-multiattach\ncinder-tempest-plugin-lvm-lio-barbican\ncinder-tempest-plugin-cbak-ceph","commit_id":"245dcd6e01024019b93b4d3ef27a9cf088bb7cb5"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"d2894c6198eaa092f5ffd86e1247464525578d0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"d604085f_0b8540fe","updated":"2026-03-17 07:27:30.000000000","message":"recheck\n\nUnrelated issues","commit_id":"11465177aaf05d77ccbcb6b03eebefcfd0837469"}],"cinder_tempest_plugin/rbac/v3/base.py":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"528c9d1301341faacc60c4c88a33db0e7e4ad3f5","unresolved":true,"context_lines":[{"line_number":89,"context_line":"    def create_volume(self, client, volume_type\u003dNone, metadata\u003dNone, **kwargs):"},{"line_number":90,"context_line":"        \"\"\"Wrapper utility that returns a test volume"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        Args:"},{"line_number":93,"context_line":"            client: Client object"},{"line_number":94,"context_line":"            volume_type: Volume type object"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"02fe924c_906aa8dd","line":92,"range":{"start_line":92,"start_character":8,"end_line":92,"end_character":12},"updated":"2024-05-28 10:39:59.000000000","message":"metadata arg is missing.","commit_id":"d2164ba654d1ee315b9899406b4fdd763d8070da"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"d228631bdc87004aed2ddb952ca1dfa47f3d0a86","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    def create_volume(self, client, volume_type\u003dNone, metadata\u003dNone, **kwargs):"},{"line_number":90,"context_line":"        \"\"\"Wrapper utility that returns a test volume"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        Args:"},{"line_number":93,"context_line":"            client: Client object"},{"line_number":94,"context_line":"            volume_type: Volume type object"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5fcd9c1e_5997cf02","line":92,"range":{"start_line":92,"start_character":8,"end_line":92,"end_character":12},"in_reply_to":"02fe924c_906aa8dd","updated":"2024-05-29 08:41:09.000000000","message":"Done","commit_id":"d2164ba654d1ee315b9899406b4fdd763d8070da"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"528c9d1301341faacc60c4c88a33db0e7e4ad3f5","unresolved":true,"context_lines":[{"line_number":241,"context_line":"        return group"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    @staticmethod"},{"line_number":244,"context_line":"    def add_volume_to_group("},{"line_number":245,"context_line":"        groups_client, group_id, volumes_client, volume_id"},{"line_number":246,"context_line":"    ):"},{"line_number":247,"context_line":"        \"\"\"Wrapper utility that adds a volume to a group"}],"source_content_type":"text/x-python","patch_set":3,"id":"106ebd6b_76794eed","line":244,"range":{"start_line":244,"start_character":4,"end_line":244,"end_character":28},"updated":"2024-05-28 10:39:59.000000000","message":"I don\u0027t think there is any justification for placing it in the base class, since it\u0027s not common used.","commit_id":"d2164ba654d1ee315b9899406b4fdd763d8070da"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"d228631bdc87004aed2ddb952ca1dfa47f3d0a86","unresolved":true,"context_lines":[{"line_number":241,"context_line":"        return group"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    @staticmethod"},{"line_number":244,"context_line":"    def add_volume_to_group("},{"line_number":245,"context_line":"        groups_client, group_id, volumes_client, volume_id"},{"line_number":246,"context_line":"    ):"},{"line_number":247,"context_line":"        \"\"\"Wrapper utility that adds a volume to a group"}],"source_content_type":"text/x-python","patch_set":3,"id":"7eb437c5_2b123b6e","line":244,"range":{"start_line":244,"start_character":4,"end_line":244,"end_character":28},"in_reply_to":"106ebd6b_76794eed","updated":"2024-05-29 08:41:09.000000000","message":"I have this same usage in two places:\ngroups and group-snapshots","commit_id":"d2164ba654d1ee315b9899406b4fdd763d8070da"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"2473675d4e8dcd03653c041a921292eb9a43770a","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        return group"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    @staticmethod"},{"line_number":244,"context_line":"    def add_volume_to_group("},{"line_number":245,"context_line":"        groups_client, group_id, volumes_client, volume_id"},{"line_number":246,"context_line":"    ):"},{"line_number":247,"context_line":"        \"\"\"Wrapper utility that adds a volume to a group"}],"source_content_type":"text/x-python","patch_set":3,"id":"042356ca_0967ed7a","line":244,"range":{"start_line":244,"start_character":4,"end_line":244,"end_character":28},"in_reply_to":"35a1b8b1_741c0982","updated":"2024-06-05 10:49:59.000000000","message":"Done","commit_id":"d2164ba654d1ee315b9899406b4fdd763d8070da"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"8d3bcda1e0be9d8c0a54a10640d84d577c26559f","unresolved":true,"context_lines":[{"line_number":241,"context_line":"        return group"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    @staticmethod"},{"line_number":244,"context_line":"    def add_volume_to_group("},{"line_number":245,"context_line":"        groups_client, group_id, volumes_client, volume_id"},{"line_number":246,"context_line":"    ):"},{"line_number":247,"context_line":"        \"\"\"Wrapper utility that adds a volume to a group"}],"source_content_type":"text/x-python","patch_set":3,"id":"35a1b8b1_741c0982","line":244,"range":{"start_line":244,"start_character":4,"end_line":244,"end_character":28},"in_reply_to":"7eb437c5_2b123b6e","updated":"2024-05-29 09:18:33.000000000","message":"I know and I think it shouldn\u0027t be implemented in the base class for the reason I mentioned in the previous comment.","commit_id":"d2164ba654d1ee315b9899406b4fdd763d8070da"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"75b1654c5fc688454b7eccf0504b15e9bf269cf2","unresolved":true,"context_lines":[{"line_number":242,"context_line":"        return group"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    @classmethod"},{"line_number":245,"context_line":"    def create_volume_type(cls, name\u003dNone, volume_types_client\u003dNone, **kwargs):"},{"line_number":246,"context_line":"        \"\"\"Wrapper utility that returns a test volume-type."},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        Args:"}],"source_content_type":"text/x-python","patch_set":6,"id":"a5b66fb8_d071ff18","line":245,"range":{"start_line":245,"start_character":43,"end_line":245,"end_character":67},"updated":"2024-07-25 06:36:41.000000000","message":"If I\u0027m not mistaken, only an admin can create a volume type, so this argument is redundant. Please use cls.admin_volume_types_client but ensure it is initialized","commit_id":"05fb678724e38405a70e6188549664aacde8a996"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"25ed9c3004fe3889c5f9f3ac1dd7dea6ec832469","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        return group"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    @classmethod"},{"line_number":245,"context_line":"    def create_volume_type(cls, name\u003dNone, volume_types_client\u003dNone, **kwargs):"},{"line_number":246,"context_line":"        \"\"\"Wrapper utility that returns a test volume-type."},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        Args:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5d30e6a3_a0350afe","line":245,"range":{"start_line":245,"start_character":43,"end_line":245,"end_character":67},"in_reply_to":"0db0464f_cd73e979","updated":"2024-07-25 20:37:54.000000000","message":"Done","commit_id":"05fb678724e38405a70e6188549664aacde8a996"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"473380ab425997539a73af5bc86cc2a03dcbf341","unresolved":true,"context_lines":[{"line_number":242,"context_line":"        return group"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    @classmethod"},{"line_number":245,"context_line":"    def create_volume_type(cls, name\u003dNone, volume_types_client\u003dNone, **kwargs):"},{"line_number":246,"context_line":"        \"\"\"Wrapper utility that returns a test volume-type."},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        Args:"}],"source_content_type":"text/x-python","patch_set":6,"id":"6463ecae_53906cbe","line":245,"range":{"start_line":245,"start_character":43,"end_line":245,"end_character":67},"in_reply_to":"42799421_cea8a8ab","updated":"2024-07-25 09:49:33.000000000","message":"Sorry, but I don\u0027t think these reasons are justified.\nBy the way, I suggest to create one method in the base class and remove this one:\nhttps://github.com/openstack/cinder-tempest-plugin/blob/master/cinder_tempest_plugin/rbac/v3/test_volume_types.py#L49","commit_id":"05fb678724e38405a70e6188549664aacde8a996"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"1655fdd65cfee0b4f0f1d929b555ac8a138b496c","unresolved":true,"context_lines":[{"line_number":242,"context_line":"        return group"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    @classmethod"},{"line_number":245,"context_line":"    def create_volume_type(cls, name\u003dNone, volume_types_client\u003dNone, **kwargs):"},{"line_number":246,"context_line":"        \"\"\"Wrapper utility that returns a test volume-type."},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        Args:"}],"source_content_type":"text/x-python","patch_set":6,"id":"0db0464f_cd73e979","line":245,"range":{"start_line":245,"start_character":43,"end_line":245,"end_character":67},"in_reply_to":"6463ecae_53906cbe","updated":"2024-07-25 09:58:58.000000000","message":"Yes, this one will be removed after this patch will be merged","commit_id":"05fb678724e38405a70e6188549664aacde8a996"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"065f90db26e39ce6f0f95fad829efded91ac3418","unresolved":true,"context_lines":[{"line_number":242,"context_line":"        return group"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    @classmethod"},{"line_number":245,"context_line":"    def create_volume_type(cls, name\u003dNone, volume_types_client\u003dNone, **kwargs):"},{"line_number":246,"context_line":"        \"\"\"Wrapper utility that returns a test volume-type."},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        Args:"}],"source_content_type":"text/x-python","patch_set":6,"id":"42799421_cea8a8ab","line":245,"range":{"start_line":245,"start_character":43,"end_line":245,"end_character":67},"in_reply_to":"a5b66fb8_d071ff18","updated":"2024-07-25 09:27:13.000000000","message":"True but it\u0027s the convention here to pass the client in other methods as well.\nAlso, I don\u0027t think we should restrict it to admin only (in case of future changes that member can also create).","commit_id":"05fb678724e38405a70e6188549664aacde8a996"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"75b1654c5fc688454b7eccf0504b15e9bf269cf2","unresolved":true,"context_lines":[{"line_number":253,"context_line":"            Volume-type object"},{"line_number":254,"context_line":"        \"\"\""},{"line_number":255,"context_line":"        name \u003d name or data_utils.rand_name(cls.__name__ + \u0027-volume-type\u0027)"},{"line_number":256,"context_line":"        volume_type \u003d volume_types_client.create_volume_type("},{"line_number":257,"context_line":"            name\u003dname, **kwargs)[\u0027volume_type\u0027]"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        cls.addClassResourceCleanup("}],"source_content_type":"text/x-python","patch_set":6,"id":"57e536e4_cf08ce20","line":256,"range":{"start_line":256,"start_character":22,"end_line":256,"end_character":41},"updated":"2024-07-25 06:36:41.000000000","message":"cls.admin_volume_types_client","commit_id":"05fb678724e38405a70e6188549664aacde8a996"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"25ed9c3004fe3889c5f9f3ac1dd7dea6ec832469","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            Volume-type object"},{"line_number":254,"context_line":"        \"\"\""},{"line_number":255,"context_line":"        name \u003d name or data_utils.rand_name(cls.__name__ + \u0027-volume-type\u0027)"},{"line_number":256,"context_line":"        volume_type \u003d volume_types_client.create_volume_type("},{"line_number":257,"context_line":"            name\u003dname, **kwargs)[\u0027volume_type\u0027]"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        cls.addClassResourceCleanup("}],"source_content_type":"text/x-python","patch_set":6,"id":"19054207_0831e28b","line":256,"range":{"start_line":256,"start_character":22,"end_line":256,"end_character":41},"in_reply_to":"57e536e4_cf08ce20","updated":"2024-07-25 20:37:54.000000000","message":"Done","commit_id":"05fb678724e38405a70e6188549664aacde8a996"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"75b1654c5fc688454b7eccf0504b15e9bf269cf2","unresolved":true,"context_lines":[{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        cls.addClassResourceCleanup("},{"line_number":260,"context_line":"            test_utils.call_and_ignore_notfound_exc,"},{"line_number":261,"context_line":"            volume_types_client.wait_for_resource_deletion,"},{"line_number":262,"context_line":"            volume_type[\u0027id\u0027]"},{"line_number":263,"context_line":"        )"},{"line_number":264,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"8c8f14fd_69084110","line":261,"range":{"start_line":261,"start_character":12,"end_line":261,"end_character":31},"updated":"2024-07-25 06:36:41.000000000","message":"cls.admin_volume_types_client","commit_id":"05fb678724e38405a70e6188549664aacde8a996"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"25ed9c3004fe3889c5f9f3ac1dd7dea6ec832469","unresolved":false,"context_lines":[{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        cls.addClassResourceCleanup("},{"line_number":260,"context_line":"            test_utils.call_and_ignore_notfound_exc,"},{"line_number":261,"context_line":"            volume_types_client.wait_for_resource_deletion,"},{"line_number":262,"context_line":"            volume_type[\u0027id\u0027]"},{"line_number":263,"context_line":"        )"},{"line_number":264,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1b95d163_04505453","line":261,"range":{"start_line":261,"start_character":12,"end_line":261,"end_character":31},"in_reply_to":"8c8f14fd_69084110","updated":"2024-07-25 20:37:54.000000000","message":"Done","commit_id":"05fb678724e38405a70e6188549664aacde8a996"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"75b1654c5fc688454b7eccf0504b15e9bf269cf2","unresolved":true,"context_lines":[{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        cls.addClassResourceCleanup("},{"line_number":266,"context_line":"            test_utils.call_and_ignore_notfound_exc,"},{"line_number":267,"context_line":"            volume_types_client.delete_volume_type,"},{"line_number":268,"context_line":"            volume_type_id\u003dvolume_type[\u0027id\u0027]"},{"line_number":269,"context_line":"        )"},{"line_number":270,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"4b549b58_d590f810","line":267,"range":{"start_line":267,"start_character":12,"end_line":267,"end_character":31},"updated":"2024-07-25 06:36:41.000000000","message":"cls.admin_volume_types_client","commit_id":"05fb678724e38405a70e6188549664aacde8a996"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"25ed9c3004fe3889c5f9f3ac1dd7dea6ec832469","unresolved":false,"context_lines":[{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        cls.addClassResourceCleanup("},{"line_number":266,"context_line":"            test_utils.call_and_ignore_notfound_exc,"},{"line_number":267,"context_line":"            volume_types_client.delete_volume_type,"},{"line_number":268,"context_line":"            volume_type_id\u003dvolume_type[\u0027id\u0027]"},{"line_number":269,"context_line":"        )"},{"line_number":270,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"51b11a10_893114ae","line":267,"range":{"start_line":267,"start_character":12,"end_line":267,"end_character":31},"in_reply_to":"4b549b58_d590f810","updated":"2024-07-25 20:37:54.000000000","message":"Done","commit_id":"05fb678724e38405a70e6188549664aacde8a996"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"62502e8421ec49780be2ceb270f86aedd51ad4f8","unresolved":true,"context_lines":[{"line_number":234,"context_line":"        return group"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    @classmethod"},{"line_number":237,"context_line":"    def create_volume_type("},{"line_number":238,"context_line":"            cls, name\u003dNone, with_encryption\u003dFalse, cleanup\u003dTrue, **kwargs"},{"line_number":239,"context_line":"    ):"},{"line_number":240,"context_line":"        \"\"\"Wrapper utility that returns a test volume-type."},{"line_number":241,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bfdd25ea_a570a53f","line":238,"range":{"start_line":237,"start_character":3,"end_line":238,"end_character":73},"updated":"2024-08-14 11:04:27.000000000","message":"As we discussed, it\u0027s preferable to separate this method into two: one for volume type creation and another for volume type encryption.","commit_id":"bbe0b93d57bba8d56bee256ebea406d329c59061"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"868f09c8a989314d54b4f8986201bfe9d3355f92","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        return group"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    @classmethod"},{"line_number":237,"context_line":"    def create_volume_type("},{"line_number":238,"context_line":"            cls, name\u003dNone, with_encryption\u003dFalse, cleanup\u003dTrue, **kwargs"},{"line_number":239,"context_line":"    ):"},{"line_number":240,"context_line":"        \"\"\"Wrapper utility that returns a test volume-type."},{"line_number":241,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"523b707c_ca096270","line":238,"range":{"start_line":237,"start_character":3,"end_line":238,"end_character":73},"in_reply_to":"bfdd25ea_a570a53f","updated":"2024-08-15 07:46:35.000000000","message":"Done","commit_id":"bbe0b93d57bba8d56bee256ebea406d329c59061"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7d3c8e80a8cc59ddbc8378bdfadeeaa380d8c860","unresolved":true,"context_lines":[{"line_number":104,"context_line":"        if volume_type:"},{"line_number":105,"context_line":"            kwargs[\u0027volume_type\u0027] \u003d volume_type"},{"line_number":106,"context_line":"        kwargs[\u0027metadata\u0027] \u003d metadata"},{"line_number":107,"context_line":"        volume \u003d self.admin_volumes_client.create_volume(**kwargs)[\u0027volume\u0027]"},{"line_number":108,"context_line":"        self.cleanup("},{"line_number":109,"context_line":"            test_utils.call_and_ignore_notfound_exc, func\u003dself.delete_resource,"},{"line_number":110,"context_line":"            client\u003dself.admin_volumes_client, volume_id\u003dvolume[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"f06672f4_4495c6ee","line":107,"range":{"start_line":107,"start_character":17,"end_line":107,"end_character":42},"updated":"2024-08-21 08:11:44.000000000","message":"Is there any specific reason to use the admin user for this operation? \nIt doesn’t require admin permissions, so I think you should include the option to perform the action with other users.","commit_id":"55929e46b71cd85571aaf96d057d85fb52a842ac"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"771f75ec9a29ed72c88ac1b18cb55376611a44b4","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        if volume_type:"},{"line_number":105,"context_line":"            kwargs[\u0027volume_type\u0027] \u003d volume_type"},{"line_number":106,"context_line":"        kwargs[\u0027metadata\u0027] \u003d metadata"},{"line_number":107,"context_line":"        volume \u003d self.admin_volumes_client.create_volume(**kwargs)[\u0027volume\u0027]"},{"line_number":108,"context_line":"        self.cleanup("},{"line_number":109,"context_line":"            test_utils.call_and_ignore_notfound_exc, func\u003dself.delete_resource,"},{"line_number":110,"context_line":"            client\u003dself.admin_volumes_client, volume_id\u003dvolume[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"f3cd0dc3_b8c6a7cc","line":107,"range":{"start_line":107,"start_character":17,"end_line":107,"end_character":42},"in_reply_to":"f06672f4_4495c6ee","updated":"2024-08-27 10:46:13.000000000","message":"Done","commit_id":"55929e46b71cd85571aaf96d057d85fb52a842ac"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7d3c8e80a8cc59ddbc8378bdfadeeaa380d8c860","unresolved":true,"context_lines":[{"line_number":131,"context_line":"            VolumeV3RbacBaseTests.__name__ + \u0027-Snapshot\u0027"},{"line_number":132,"context_line":"        )"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        snapshot \u003d cls.admin_snapshot_client.create_snapshot("},{"line_number":135,"context_line":"            volume_id\u003dvolume_id, **kwargs)[\u0027snapshot\u0027]"},{"line_number":136,"context_line":"        if cleanup:"},{"line_number":137,"context_line":"            cls.cleanup("}],"source_content_type":"text/x-python","patch_set":10,"id":"2dcbd8bc_58c193a5","line":134,"range":{"start_line":134,"start_character":19,"end_line":134,"end_character":44},"updated":"2024-08-21 08:11:44.000000000","message":"Same","commit_id":"55929e46b71cd85571aaf96d057d85fb52a842ac"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"771f75ec9a29ed72c88ac1b18cb55376611a44b4","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            VolumeV3RbacBaseTests.__name__ + \u0027-Snapshot\u0027"},{"line_number":132,"context_line":"        )"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        snapshot \u003d cls.admin_snapshot_client.create_snapshot("},{"line_number":135,"context_line":"            volume_id\u003dvolume_id, **kwargs)[\u0027snapshot\u0027]"},{"line_number":136,"context_line":"        if cleanup:"},{"line_number":137,"context_line":"            cls.cleanup("}],"source_content_type":"text/x-python","patch_set":10,"id":"bf0ffeb4_4ba3c8af","line":134,"range":{"start_line":134,"start_character":19,"end_line":134,"end_character":44},"in_reply_to":"2dcbd8bc_58c193a5","updated":"2024-08-27 10:46:13.000000000","message":"Done","commit_id":"55929e46b71cd85571aaf96d057d85fb52a842ac"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7d3c8e80a8cc59ddbc8378bdfadeeaa380d8c860","unresolved":true,"context_lines":[{"line_number":181,"context_line":"            name \u003d data_utils.rand_name(cls.__class__.__name__ + \u0027-Backup\u0027)"},{"line_number":182,"context_line":"            kwargs[\u0027name\u0027] \u003d name"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        backup \u003d cls.admin_backups_client.create_backup("},{"line_number":185,"context_line":"            volume_id\u003dvolume_id, **kwargs"},{"line_number":186,"context_line":"        )[\u0027backup\u0027]"},{"line_number":187,"context_line":"        if add_cleanup:"}],"source_content_type":"text/x-python","patch_set":10,"id":"c41e9e62_b63a458c","line":184,"range":{"start_line":184,"start_character":17,"end_line":184,"end_character":41},"updated":"2024-08-21 08:11:44.000000000","message":"Same","commit_id":"55929e46b71cd85571aaf96d057d85fb52a842ac"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"771f75ec9a29ed72c88ac1b18cb55376611a44b4","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            name \u003d data_utils.rand_name(cls.__class__.__name__ + \u0027-Backup\u0027)"},{"line_number":182,"context_line":"            kwargs[\u0027name\u0027] \u003d name"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        backup \u003d cls.admin_backups_client.create_backup("},{"line_number":185,"context_line":"            volume_id\u003dvolume_id, **kwargs"},{"line_number":186,"context_line":"        )[\u0027backup\u0027]"},{"line_number":187,"context_line":"        if add_cleanup:"}],"source_content_type":"text/x-python","patch_set":10,"id":"f90128d1_6315b9ea","line":184,"range":{"start_line":184,"start_character":17,"end_line":184,"end_character":41},"in_reply_to":"c41e9e62_b63a458c","updated":"2024-08-27 10:46:13.000000000","message":"Done","commit_id":"55929e46b71cd85571aaf96d057d85fb52a842ac"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7d3c8e80a8cc59ddbc8378bdfadeeaa380d8c860","unresolved":true,"context_lines":[{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        group_name \u003d data_utils.rand_name("},{"line_number":214,"context_line":"            cls.__class__.__name__ + \u0027-Group\u0027)"},{"line_number":215,"context_line":"        group \u003d cls.admin_groups_client.create_group("},{"line_number":216,"context_line":"            name\u003dgroup_name, group_type\u003dgroup_type[\u0027id\u0027],"},{"line_number":217,"context_line":"            volume_types\u003d[volume_type[\u0027id\u0027]]"},{"line_number":218,"context_line":"        )[\u0027group\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"ef637b3e_ebb94f41","line":215,"range":{"start_line":215,"start_character":16,"end_line":215,"end_character":39},"updated":"2024-08-21 08:11:44.000000000","message":"Same","commit_id":"55929e46b71cd85571aaf96d057d85fb52a842ac"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"771f75ec9a29ed72c88ac1b18cb55376611a44b4","unresolved":false,"context_lines":[{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        group_name \u003d data_utils.rand_name("},{"line_number":214,"context_line":"            cls.__class__.__name__ + \u0027-Group\u0027)"},{"line_number":215,"context_line":"        group \u003d cls.admin_groups_client.create_group("},{"line_number":216,"context_line":"            name\u003dgroup_name, group_type\u003dgroup_type[\u0027id\u0027],"},{"line_number":217,"context_line":"            volume_types\u003d[volume_type[\u0027id\u0027]]"},{"line_number":218,"context_line":"        )[\u0027group\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"f6b04493_e820ae85","line":215,"range":{"start_line":215,"start_character":16,"end_line":215,"end_character":39},"in_reply_to":"ef637b3e_ebb94f41","updated":"2024-08-27 10:46:13.000000000","message":"Done","commit_id":"55929e46b71cd85571aaf96d057d85fb52a842ac"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7d3c8e80a8cc59ddbc8378bdfadeeaa380d8c860","unresolved":true,"context_lines":[{"line_number":314,"context_line":"        )"},{"line_number":315,"context_line":"        kwargs[\u0027group_id\u0027] \u003d group_id"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        group_snap \u003d cls.admin_group_snapshots_client.create_group_snapshot("},{"line_number":318,"context_line":"            **kwargs"},{"line_number":319,"context_line":"        )[\u0027group_snapshot\u0027]"},{"line_number":320,"context_line":"        group_snap[\u0027group_id\u0027] \u003d kwargs[\u0027group_id\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff5bbab3_46109ed5","line":317,"range":{"start_line":317,"start_character":21,"end_line":317,"end_character":53},"updated":"2024-08-21 08:11:44.000000000","message":"Same","commit_id":"55929e46b71cd85571aaf96d057d85fb52a842ac"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"771f75ec9a29ed72c88ac1b18cb55376611a44b4","unresolved":false,"context_lines":[{"line_number":314,"context_line":"        )"},{"line_number":315,"context_line":"        kwargs[\u0027group_id\u0027] \u003d group_id"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        group_snap \u003d cls.admin_group_snapshots_client.create_group_snapshot("},{"line_number":318,"context_line":"            **kwargs"},{"line_number":319,"context_line":"        )[\u0027group_snapshot\u0027]"},{"line_number":320,"context_line":"        group_snap[\u0027group_id\u0027] \u003d kwargs[\u0027group_id\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"b9882375_bc3876b6","line":317,"range":{"start_line":317,"start_character":21,"end_line":317,"end_character":53},"in_reply_to":"ff5bbab3_46109ed5","updated":"2024-08-27 10:46:13.000000000","message":"Done","commit_id":"55929e46b71cd85571aaf96d057d85fb52a842ac"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"b98fe0bdc7fb950daee2f01e4a047c51da2306b9","unresolved":true,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    @cleanup_order"},{"line_number":89,"context_line":"    def create_volume("},{"line_number":90,"context_line":"            self, volumes_client\u003dNone,"},{"line_number":91,"context_line":"            volume_type\u003dNone, metadata\u003dNone, **kwargs"},{"line_number":92,"context_line":"    ):"},{"line_number":93,"context_line":"        \"\"\"Wrapper utility that returns a test volume"}],"source_content_type":"text/x-python","patch_set":13,"id":"37fd329b_4308785b","line":90,"range":{"start_line":90,"start_character":18,"end_line":90,"end_character":37},"updated":"2024-10-07 11:48:11.000000000","message":"This should be a mandatory argument, not an optional one.","commit_id":"bf532230e8945e9c35e9ef442cc4c7d98096b70b"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"5ecbc6713aca2c7d4ba7001b47516106f8199414","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    @cleanup_order"},{"line_number":89,"context_line":"    def create_volume("},{"line_number":90,"context_line":"            self, volumes_client\u003dNone,"},{"line_number":91,"context_line":"            volume_type\u003dNone, metadata\u003dNone, **kwargs"},{"line_number":92,"context_line":"    ):"},{"line_number":93,"context_line":"        \"\"\"Wrapper utility that returns a test volume"}],"source_content_type":"text/x-python","patch_set":13,"id":"c30222a2_9ed61610","line":90,"range":{"start_line":90,"start_character":18,"end_line":90,"end_character":37},"in_reply_to":"37fd329b_4308785b","updated":"2024-10-07 11:57:11.000000000","message":"Acknowledged","commit_id":"bf532230e8945e9c35e9ef442cc4c7d98096b70b"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"b98fe0bdc7fb950daee2f01e4a047c51da2306b9","unresolved":true,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    @cleanup_order"},{"line_number":124,"context_line":"    def create_snapshot("},{"line_number":125,"context_line":"            cls, volume_id, snapshot_client\u003dNone, cleanup\u003dTrue, **kwargs"},{"line_number":126,"context_line":"    ):"},{"line_number":127,"context_line":"        \"\"\"Wrapper utility that returns a test snapshot."},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"fc395aff_3e0a9ae2","line":125,"range":{"start_line":125,"start_character":28,"end_line":125,"end_character":48},"updated":"2024-10-07 11:48:11.000000000","message":"Same","commit_id":"bf532230e8945e9c35e9ef442cc4c7d98096b70b"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"5ecbc6713aca2c7d4ba7001b47516106f8199414","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    @cleanup_order"},{"line_number":124,"context_line":"    def create_snapshot("},{"line_number":125,"context_line":"            cls, volume_id, snapshot_client\u003dNone, cleanup\u003dTrue, **kwargs"},{"line_number":126,"context_line":"    ):"},{"line_number":127,"context_line":"        \"\"\"Wrapper utility that returns a test snapshot."},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"68d38826_a8370ad7","line":125,"range":{"start_line":125,"start_character":28,"end_line":125,"end_character":48},"in_reply_to":"fc395aff_3e0a9ae2","updated":"2024-10-07 11:57:11.000000000","message":"Acknowledged","commit_id":"bf532230e8945e9c35e9ef442cc4c7d98096b70b"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"b98fe0bdc7fb950daee2f01e4a047c51da2306b9","unresolved":true,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @classmethod"},{"line_number":176,"context_line":"    def create_backup("},{"line_number":177,"context_line":"            cls, volume_id, backups_client\u003dNone, add_cleanup\u003dTrue, **kwargs"},{"line_number":178,"context_line":"    ):"},{"line_number":179,"context_line":"        \"\"\"Wrapper utility that returns a test backup"},{"line_number":180,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"43386ec9_a08e7d74","line":177,"range":{"start_line":177,"start_character":28,"end_line":177,"end_character":47},"updated":"2024-10-07 11:48:11.000000000","message":"Same","commit_id":"bf532230e8945e9c35e9ef442cc4c7d98096b70b"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"5ecbc6713aca2c7d4ba7001b47516106f8199414","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @classmethod"},{"line_number":176,"context_line":"    def create_backup("},{"line_number":177,"context_line":"            cls, volume_id, backups_client\u003dNone, add_cleanup\u003dTrue, **kwargs"},{"line_number":178,"context_line":"    ):"},{"line_number":179,"context_line":"        \"\"\"Wrapper utility that returns a test backup"},{"line_number":180,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"c3d20dfc_0c9d5d28","line":177,"range":{"start_line":177,"start_character":28,"end_line":177,"end_character":47},"in_reply_to":"43386ec9_a08e7d74","updated":"2024-10-07 11:57:11.000000000","message":"Acknowledged","commit_id":"bf532230e8945e9c35e9ef442cc4c7d98096b70b"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"b98fe0bdc7fb950daee2f01e4a047c51da2306b9","unresolved":true,"context_lines":[{"line_number":209,"context_line":"    @classmethod"},{"line_number":210,"context_line":"    def create_group("},{"line_number":211,"context_line":"            cls, volume_type, group_type,"},{"line_number":212,"context_line":"            groups_client\u003dNone, delete_volumes\u003dFalse"},{"line_number":213,"context_line":"    ):"},{"line_number":214,"context_line":"        \"\"\"Wrapper utility that creates group"},{"line_number":215,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a0a265c_e5a34f7f","line":212,"range":{"start_line":212,"start_character":12,"end_line":212,"end_character":30},"updated":"2024-10-07 11:48:11.000000000","message":"Same","commit_id":"bf532230e8945e9c35e9ef442cc4c7d98096b70b"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"5ecbc6713aca2c7d4ba7001b47516106f8199414","unresolved":false,"context_lines":[{"line_number":209,"context_line":"    @classmethod"},{"line_number":210,"context_line":"    def create_group("},{"line_number":211,"context_line":"            cls, volume_type, group_type,"},{"line_number":212,"context_line":"            groups_client\u003dNone, delete_volumes\u003dFalse"},{"line_number":213,"context_line":"    ):"},{"line_number":214,"context_line":"        \"\"\"Wrapper utility that creates group"},{"line_number":215,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"0d40d94d_caaaa298","line":212,"range":{"start_line":212,"start_character":12,"end_line":212,"end_character":30},"in_reply_to":"5a0a265c_e5a34f7f","updated":"2024-10-07 11:57:11.000000000","message":"Acknowledged","commit_id":"bf532230e8945e9c35e9ef442cc4c7d98096b70b"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"b98fe0bdc7fb950daee2f01e4a047c51da2306b9","unresolved":true,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    @classmethod"},{"line_number":250,"context_line":"    def create_volume_type("},{"line_number":251,"context_line":"            cls, types_client\u003dNone, name\u003dNone, cleanup\u003dTrue, **kwargs"},{"line_number":252,"context_line":"    ):"},{"line_number":253,"context_line":"        \"\"\"Wrapper utility that returns a test volume-type."},{"line_number":254,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"0c8aab83_3129d607","line":251,"range":{"start_line":251,"start_character":17,"end_line":251,"end_character":34},"updated":"2024-10-07 11:48:11.000000000","message":"Same","commit_id":"bf532230e8945e9c35e9ef442cc4c7d98096b70b"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"5ecbc6713aca2c7d4ba7001b47516106f8199414","unresolved":false,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    @classmethod"},{"line_number":250,"context_line":"    def create_volume_type("},{"line_number":251,"context_line":"            cls, types_client\u003dNone, name\u003dNone, cleanup\u003dTrue, **kwargs"},{"line_number":252,"context_line":"    ):"},{"line_number":253,"context_line":"        \"\"\"Wrapper utility that returns a test volume-type."},{"line_number":254,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"608171fd_5a9f353e","line":251,"range":{"start_line":251,"start_character":17,"end_line":251,"end_character":34},"in_reply_to":"0c8aab83_3129d607","updated":"2024-10-07 11:57:11.000000000","message":"Acknowledged","commit_id":"bf532230e8945e9c35e9ef442cc4c7d98096b70b"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"b98fe0bdc7fb950daee2f01e4a047c51da2306b9","unresolved":true,"context_lines":[{"line_number":280,"context_line":"        return volume_type"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    @classmethod"},{"line_number":283,"context_line":"    def create_group_type(cls, group_types_client\u003dNone, cleanup\u003dTrue):"},{"line_number":284,"context_line":"        \"\"\"Wrapper utility that returns a test group-type."},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        Args:"}],"source_content_type":"text/x-python","patch_set":13,"id":"e5915731_283c6a8f","line":283,"range":{"start_line":283,"start_character":31,"end_line":283,"end_character":54},"updated":"2024-10-07 11:48:11.000000000","message":"Same","commit_id":"bf532230e8945e9c35e9ef442cc4c7d98096b70b"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"5ecbc6713aca2c7d4ba7001b47516106f8199414","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        return volume_type"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    @classmethod"},{"line_number":283,"context_line":"    def create_group_type(cls, group_types_client\u003dNone, cleanup\u003dTrue):"},{"line_number":284,"context_line":"        \"\"\"Wrapper utility that returns a test group-type."},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        Args:"}],"source_content_type":"text/x-python","patch_set":13,"id":"6588190d_654b0b37","line":283,"range":{"start_line":283,"start_character":31,"end_line":283,"end_character":54},"in_reply_to":"e5915731_283c6a8f","updated":"2024-10-07 11:57:11.000000000","message":"Acknowledged","commit_id":"bf532230e8945e9c35e9ef442cc4c7d98096b70b"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"b98fe0bdc7fb950daee2f01e4a047c51da2306b9","unresolved":true,"context_lines":[{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    @classmethod"},{"line_number":319,"context_line":"    def create_group_snapshot("},{"line_number":320,"context_line":"            cls, group_id, group_snapshots_client\u003dNone, **kwargs"},{"line_number":321,"context_line":"    ):"},{"line_number":322,"context_line":"        \"\"\"Wrapper utility that creates a group-snapshot."},{"line_number":323,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"1dd70896_9f87e9e3","line":320,"range":{"start_line":320,"start_character":27,"end_line":320,"end_character":54},"updated":"2024-10-07 11:48:11.000000000","message":"Same","commit_id":"bf532230e8945e9c35e9ef442cc4c7d98096b70b"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"5ecbc6713aca2c7d4ba7001b47516106f8199414","unresolved":false,"context_lines":[{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    @classmethod"},{"line_number":319,"context_line":"    def create_group_snapshot("},{"line_number":320,"context_line":"            cls, group_id, group_snapshots_client\u003dNone, **kwargs"},{"line_number":321,"context_line":"    ):"},{"line_number":322,"context_line":"        \"\"\"Wrapper utility that creates a group-snapshot."},{"line_number":323,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"f41bc671_491092b6","line":320,"range":{"start_line":320,"start_character":27,"end_line":320,"end_character":54},"in_reply_to":"1dd70896_9f87e9e3","updated":"2024-10-07 11:57:11.000000000","message":"Acknowledged","commit_id":"bf532230e8945e9c35e9ef442cc4c7d98096b70b"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"b98fe0bdc7fb950daee2f01e4a047c51da2306b9","unresolved":true,"context_lines":[{"line_number":356,"context_line":"        return group_snap"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"    @classmethod"},{"line_number":359,"context_line":"    def create_qos_specs(cls, volume_qos_client\u003dNone, cleanup\u003dTrue, **kwargs):"},{"line_number":360,"context_line":"        \"\"\"Wrapper utility that returns a test QOS-specs."},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        Args:"}],"source_content_type":"text/x-python","patch_set":13,"id":"673b074e_fb0fd482","line":359,"range":{"start_line":359,"start_character":30,"end_line":359,"end_character":52},"updated":"2024-10-07 11:48:11.000000000","message":"Same","commit_id":"bf532230e8945e9c35e9ef442cc4c7d98096b70b"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"5ecbc6713aca2c7d4ba7001b47516106f8199414","unresolved":false,"context_lines":[{"line_number":356,"context_line":"        return group_snap"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"    @classmethod"},{"line_number":359,"context_line":"    def create_qos_specs(cls, volume_qos_client\u003dNone, cleanup\u003dTrue, **kwargs):"},{"line_number":360,"context_line":"        \"\"\"Wrapper utility that returns a test QOS-specs."},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        Args:"}],"source_content_type":"text/x-python","patch_set":13,"id":"81817675_b46e2d85","line":359,"range":{"start_line":359,"start_character":30,"end_line":359,"end_character":52},"in_reply_to":"673b074e_fb0fd482","updated":"2024-10-07 11:57:11.000000000","message":"Acknowledged","commit_id":"bf532230e8945e9c35e9ef442cc4c7d98096b70b"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"b98fe0bdc7fb950daee2f01e4a047c51da2306b9","unresolved":true,"context_lines":[{"line_number":389,"context_line":"    @classmethod"},{"line_number":390,"context_line":"    def create_server("},{"line_number":391,"context_line":"            cls,"},{"line_number":392,"context_line":"            os_project_admin\u003dNone, server_client\u003dNone,"},{"line_number":393,"context_line":"            wait_until\u003d\u0027ACTIVE\u0027, **kwargs"},{"line_number":394,"context_line":"    ):"},{"line_number":395,"context_line":"        \"\"\"Wrapper utility that returns a test server."}],"source_content_type":"text/x-python","patch_set":13,"id":"0cdb72fa_7ba61adb","line":392,"range":{"start_line":392,"start_character":35,"end_line":392,"end_character":53},"updated":"2024-10-07 11:48:11.000000000","message":"Same","commit_id":"bf532230e8945e9c35e9ef442cc4c7d98096b70b"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"5ecbc6713aca2c7d4ba7001b47516106f8199414","unresolved":false,"context_lines":[{"line_number":389,"context_line":"    @classmethod"},{"line_number":390,"context_line":"    def create_server("},{"line_number":391,"context_line":"            cls,"},{"line_number":392,"context_line":"            os_project_admin\u003dNone, server_client\u003dNone,"},{"line_number":393,"context_line":"            wait_until\u003d\u0027ACTIVE\u0027, **kwargs"},{"line_number":394,"context_line":"    ):"},{"line_number":395,"context_line":"        \"\"\"Wrapper utility that returns a test server."}],"source_content_type":"text/x-python","patch_set":13,"id":"cfe87a37_783fe634","line":392,"range":{"start_line":392,"start_character":35,"end_line":392,"end_character":53},"in_reply_to":"0cdb72fa_7ba61adb","updated":"2024-10-07 11:57:11.000000000","message":"Acknowledged","commit_id":"bf532230e8945e9c35e9ef442cc4c7d98096b70b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ded9bb6eb26afea2e3823b5110e55ee34de36345","unresolved":true,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @cleanup_order"},{"line_number":123,"context_line":"    def create_snapshot("},{"line_number":124,"context_line":"            cls, volume_id, snapshot_client, cleanup\u003dTrue, **kwargs"},{"line_number":125,"context_line":"    ):"},{"line_number":126,"context_line":"        \"\"\"Wrapper utility that returns a test snapshot."},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"1161eaa7_e3d7d1a9","line":124,"range":{"start_line":124,"start_character":11,"end_line":124,"end_character":15},"updated":"2024-10-08 12:42:06.000000000","message":"This isn\u0027t a class method ... is it supposed to be? Asking because the old code had \u0027self\u0027 here, so you intentionally changed the parameter name.","commit_id":"c34ecaaed11f78f8222957483bdb47b767cb7a98"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"36799fcbf4bb6a05ddc6f057bede56c989ef402f","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @cleanup_order"},{"line_number":123,"context_line":"    def create_snapshot("},{"line_number":124,"context_line":"            cls, volume_id, snapshot_client, cleanup\u003dTrue, **kwargs"},{"line_number":125,"context_line":"    ):"},{"line_number":126,"context_line":"        \"\"\"Wrapper utility that returns a test snapshot."},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"e8f58c05_8a08c2cd","line":124,"range":{"start_line":124,"start_character":11,"end_line":124,"end_character":15},"in_reply_to":"1161eaa7_e3d7d1a9","updated":"2024-10-08 18:51:42.000000000","message":"Acknowledged","commit_id":"c34ecaaed11f78f8222957483bdb47b767cb7a98"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ded9bb6eb26afea2e3823b5110e55ee34de36345","unresolved":true,"context_lines":[{"line_number":140,"context_line":"        snapshot \u003d snapshot_client.create_snapshot("},{"line_number":141,"context_line":"            volume_id\u003dvolume_id, **kwargs)[\u0027snapshot\u0027]"},{"line_number":142,"context_line":"        if cleanup:"},{"line_number":143,"context_line":"            cls.cleanup("},{"line_number":144,"context_line":"                test_utils.call_and_ignore_notfound_exc,"},{"line_number":145,"context_line":"                func\u003dcls.delete_resource,"},{"line_number":146,"context_line":"                client\u003dsnapshot_client, snapshot_id\u003dsnapshot[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":16,"id":"081d09cc_d099f057","line":143,"range":{"start_line":143,"start_character":12,"end_line":143,"end_character":23},"updated":"2024-10-08 12:42:06.000000000","message":"I\u0027m pretty sure this is the instance cleanup (compare to line 197)","commit_id":"c34ecaaed11f78f8222957483bdb47b767cb7a98"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"36799fcbf4bb6a05ddc6f057bede56c989ef402f","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        snapshot \u003d snapshot_client.create_snapshot("},{"line_number":141,"context_line":"            volume_id\u003dvolume_id, **kwargs)[\u0027snapshot\u0027]"},{"line_number":142,"context_line":"        if cleanup:"},{"line_number":143,"context_line":"            cls.cleanup("},{"line_number":144,"context_line":"                test_utils.call_and_ignore_notfound_exc,"},{"line_number":145,"context_line":"                func\u003dcls.delete_resource,"},{"line_number":146,"context_line":"                client\u003dsnapshot_client, snapshot_id\u003dsnapshot[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":16,"id":"e6473a1f_24333d1c","line":143,"range":{"start_line":143,"start_character":12,"end_line":143,"end_character":23},"in_reply_to":"081d09cc_d099f057","updated":"2024-10-08 18:51:42.000000000","message":"Acknowledged","commit_id":"c34ecaaed11f78f8222957483bdb47b767cb7a98"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7971006207b5f08fb734ffedbce2abacab458cc1","unresolved":true,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    @classmethod"},{"line_number":172,"context_line":"    def create_backup(cls, backups_client, volume_id,"},{"line_number":173,"context_line":"                      add_cleanup\u003dTrue, **kwargs):"},{"line_number":174,"context_line":"        \"\"\"Wrapper utility that returns a test backup"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        Args:"}],"source_content_type":"text/x-python","patch_set":18,"id":"b23959fa_e8e7ee66","line":173,"range":{"start_line":173,"start_character":22,"end_line":173,"end_character":33},"updated":"2024-10-29 10:12:17.000000000","message":"For consistency, please rename it to \"cleanup\".","commit_id":"f74dcf67ec3c236f7fa6b23fd2d6a79ccddcfff6"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"05630402617bb1bd904aa801340f68f64d8200de","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    @classmethod"},{"line_number":172,"context_line":"    def create_backup(cls, backups_client, volume_id,"},{"line_number":173,"context_line":"                      add_cleanup\u003dTrue, **kwargs):"},{"line_number":174,"context_line":"        \"\"\"Wrapper utility that returns a test backup"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        Args:"}],"source_content_type":"text/x-python","patch_set":18,"id":"fbe2a4db_af974ce7","line":173,"range":{"start_line":173,"start_character":22,"end_line":173,"end_character":33},"in_reply_to":"b23959fa_e8e7ee66","updated":"2024-10-29 10:50:04.000000000","message":"Done","commit_id":"f74dcf67ec3c236f7fa6b23fd2d6a79ccddcfff6"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7971006207b5f08fb734ffedbce2abacab458cc1","unresolved":true,"context_lines":[{"line_number":240,"context_line":"        return group"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    @classmethod"},{"line_number":243,"context_line":"    def create_volume_type(cls, types_client, name\u003dNone,"},{"line_number":244,"context_line":"                           cleanup\u003dTrue, **kwargs):"},{"line_number":245,"context_line":"        \"\"\"Wrapper utility that returns a test volume-type."},{"line_number":246,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"8eaeb2b0_decf5079","line":243,"range":{"start_line":243,"start_character":32,"end_line":243,"end_character":44},"updated":"2024-10-29 10:12:17.000000000","message":"It\u0027s redundant to define this as an optional argument, as only admins have permission to create a share type. \nPlease use the admin client with the alias \"admin_volume_types_client\".","commit_id":"f74dcf67ec3c236f7fa6b23fd2d6a79ccddcfff6"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"05630402617bb1bd904aa801340f68f64d8200de","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        return group"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    @classmethod"},{"line_number":243,"context_line":"    def create_volume_type(cls, types_client, name\u003dNone,"},{"line_number":244,"context_line":"                           cleanup\u003dTrue, **kwargs):"},{"line_number":245,"context_line":"        \"\"\"Wrapper utility that returns a test volume-type."},{"line_number":246,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"7b3e300b_1e149ba6","line":243,"range":{"start_line":243,"start_character":32,"end_line":243,"end_character":44},"in_reply_to":"8eaeb2b0_decf5079","updated":"2024-10-29 10:50:04.000000000","message":"Change the name but leave it as a parameter for consistency.\nAlso, somewhere in the future, it might be allowed to members to create a volume type","commit_id":"f74dcf67ec3c236f7fa6b23fd2d6a79ccddcfff6"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7971006207b5f08fb734ffedbce2abacab458cc1","unresolved":true,"context_lines":[{"line_number":272,"context_line":"        return volume_type"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    @classmethod"},{"line_number":275,"context_line":"    def create_group_type(cls, group_types_client, cleanup\u003dTrue):"},{"line_number":276,"context_line":"        \"\"\"Wrapper utility that returns a test group-type."},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"        Args:"}],"source_content_type":"text/x-python","patch_set":18,"id":"8810907a_d3cd5a57","line":275,"range":{"start_line":275,"start_character":31,"end_line":275,"end_character":46},"updated":"2024-10-29 10:12:17.000000000","message":"Same","commit_id":"f74dcf67ec3c236f7fa6b23fd2d6a79ccddcfff6"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"05630402617bb1bd904aa801340f68f64d8200de","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        return volume_type"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    @classmethod"},{"line_number":275,"context_line":"    def create_group_type(cls, group_types_client, cleanup\u003dTrue):"},{"line_number":276,"context_line":"        \"\"\"Wrapper utility that returns a test group-type."},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"        Args:"}],"source_content_type":"text/x-python","patch_set":18,"id":"d68f657b_60fbdbfb","line":275,"range":{"start_line":275,"start_character":31,"end_line":275,"end_character":46},"in_reply_to":"8810907a_d3cd5a57","updated":"2024-10-29 10:50:04.000000000","message":"Done","commit_id":"f74dcf67ec3c236f7fa6b23fd2d6a79ccddcfff6"}],"cinder_tempest_plugin/rbac/v3/test_volume_types.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"5e3d30e0f732a96dd1b159af0f876973bf9460e7","unresolved":true,"context_lines":[{"line_number":209,"context_line":"        volume_type \u003d self.create_volume_type("},{"line_number":210,"context_line":"            admin_volume_types_client\u003dself.admin_types_client, **self.params"},{"line_number":211,"context_line":"        )"},{"line_number":212,"context_line":"        # Create encryption_type"},{"line_number":213,"context_line":"        self.admin_encryption_types_client.create_encryption_type("},{"line_number":214,"context_line":"            volume_type[\u0027id\u0027], **self.create_kwargs"},{"line_number":215,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":21,"id":"10891d7c_bd3cb1ae","line":212,"updated":"2024-12-04 14:30:35.000000000","message":"_delete_encryption_type() now creates a type to delete it?\n\nThis seems like the helper method has become a test in itself -- probably better to do this in the test, since this is confusing to have here.","commit_id":"b190c31cea6c4ae0a45110a3ae512acd7a189079"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"81bff1614948c63731143c122b53907ab75fa13b","unresolved":true,"context_lines":[{"line_number":209,"context_line":"        volume_type \u003d self.create_volume_type("},{"line_number":210,"context_line":"            admin_volume_types_client\u003dself.admin_types_client, **self.params"},{"line_number":211,"context_line":"        )"},{"line_number":212,"context_line":"        # Create encryption_type"},{"line_number":213,"context_line":"        self.admin_encryption_types_client.create_encryption_type("},{"line_number":214,"context_line":"            volume_type[\u0027id\u0027], **self.create_kwargs"},{"line_number":215,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":21,"id":"89ff2eea_fe5d54b8","line":212,"in_reply_to":"10891d7c_bd3cb1ae","updated":"2024-12-08 08:44:13.000000000","message":"This method is a test method called by Reader, Member and admin.\nThis test creates its own volume_type and encryption_type because it can be disruptive for other tests that uses this encryption_type (show_encryption_type, show_encryption_spec_item and update_encryption_type for example).","commit_id":"b190c31cea6c4ae0a45110a3ae512acd7a189079"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"6296805845a7ada1e3b480c90e842e81dc12b122","unresolved":true,"context_lines":[{"line_number":209,"context_line":"        volume_type \u003d self.create_volume_type("},{"line_number":210,"context_line":"            admin_volume_types_client\u003dself.admin_types_client, **self.params"},{"line_number":211,"context_line":"        )"},{"line_number":212,"context_line":"        # Create encryption_type"},{"line_number":213,"context_line":"        self.admin_encryption_types_client.create_encryption_type("},{"line_number":214,"context_line":"            volume_type[\u0027id\u0027], **self.create_kwargs"},{"line_number":215,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":21,"id":"30338a3d_71289d34","line":212,"in_reply_to":"89ff2eea_fe5d54b8","updated":"2025-04-02 13:39:29.000000000","message":"I\u0027m not sure I understand - a reader can create a volume type?","commit_id":"b190c31cea6c4ae0a45110a3ae512acd7a189079"}]}