)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"4d4813526eb5c9c90d530cbdf4ac3420c696aa24","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8506300b_e249a92c","updated":"2024-06-25 08:58:37.000000000","message":"There are tests that uses it and they should be changed accordingly.\nFor example:\ncinder-tempest-plugin/cinder_tempest_plugin/api/volume/test_volume_dependency.py:150\ncinder-tempest-plugin/cinder_tempest_plugin/scenario/test_snapshots.py:133\n\n...","commit_id":"1bd98557594a184a3577675bebceaa7dd892363e"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"89f01200f22b07575b8a71eb9dc37fe98d7e4a14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"63b2d373_3ab45530","updated":"2024-06-25 09:35:02.000000000","message":"No, it should be removed. IIRC we can\u0027t have the same option name, but even if we couldn\u0027t, I think it would be better to wait for a new tempest release, we can bump the dependency to the new tempest in cinder-tempest-plugin and drop the local definition of the key.","commit_id":"4a99a69395ea4c040e3f4aed5a7b88cce2cc04aa"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"156b1b962a63bb6b398a69627e05d213c4e675bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c1aa5a0f_e3612ad2","in_reply_to":"0e1ecabc_402d20b6","updated":"2024-06-25 10:04:11.000000000","message":"ack.Going to wait for new tempest release.","commit_id":"4a99a69395ea4c040e3f4aed5a7b88cce2cc04aa"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"af40fb7254cc6d6e6b56eba20854016db182af0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0e1ecabc_402d20b6","in_reply_to":"63b2d373_3ab45530","updated":"2024-06-25 09:37:05.000000000","message":"yeah, i think the installation of the plugin should fail if there are 2 config options named the same (one in plugin, one in tempest)","commit_id":"4a99a69395ea4c040e3f4aed5a7b88cce2cc04aa"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8f164b8c6932bbfd8a8a64de7b022c348b895839","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5b9141dd_36a74ed7","in_reply_to":"c1aa5a0f_e3612ad2","updated":"2024-06-25 17:29:09.000000000","message":"I mentioned the right steps in inline comment, please check those.","commit_id":"4a99a69395ea4c040e3f4aed5a7b88cce2cc04aa"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"23f42cff63663ec454adcd97267938afa7537907","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"43ff6b80_541fd51c","updated":"2024-11-11 11:22:02.000000000","message":"If we do this, shouldn\u0027t we bump the tempest requirements to the first release which defines enable_volume_image_dep_tests (40.0.0)?","commit_id":"b0cca1cac111753697d250a77cfae26f18832cdf"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"28504576392b7a1af78e59b3a8505e67eb9a41d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d051744d_8c330ac9","updated":"2024-11-11 07:51:43.000000000","message":"recheck","commit_id":"b0cca1cac111753697d250a77cfae26f18832cdf"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"3ec9b215c09223a50399627aae3ed4ae8aef6539","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6ebbb04f_52e55639","updated":"2024-11-25 09:50:09.000000000","message":"It\u0027s interesting because it is deprecated but it is not really used anywhere. That said, it looks like the deprecation was done according the expected steps, so +1 while waiting for tempest core people\u0027s opinion.","commit_id":"4ae1dc847829c74cdd0c2235bde38b8b33215323"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"29d25b7b40b1f01dcdc451a71419002f644cef31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d3dce49f_9ac74e5e","updated":"2025-03-05 13:09:12.000000000","message":"Missed the updates","commit_id":"4ae1dc847829c74cdd0c2235bde38b8b33215323"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b5047addf77739a8c319d36834dc0f421a7d8d4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e02b6305_f96d8bd9","updated":"2024-11-25 18:47:15.000000000","message":"change here lgtm, but to make both old and new config working, one more udpate needed in Tempest.","commit_id":"4ae1dc847829c74cdd0c2235bde38b8b33215323"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"969b6ad97c9878ec43b5a0c4774ad9d1450e9845","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6fe26e61_451c8fca","updated":"2024-11-22 16:38:39.000000000","message":"recheck","commit_id":"4ae1dc847829c74cdd0c2235bde38b8b33215323"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"373da745dc6988931c6f6582666e83598de61772","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b89141e3_d72ddf53","updated":"2024-11-24 11:20:49.000000000","message":"recheck","commit_id":"4ae1dc847829c74cdd0c2235bde38b8b33215323"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"30338e1ede873ab3941fd798b478998f736b87b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e7ad0f7d_fecc8f0a","updated":"2025-03-05 15:43:23.000000000","message":"recheck\n\nyes, no blind rechecks, but the failures are not visibile in the history for the two jobs affected","commit_id":"4ae1dc847829c74cdd0c2235bde38b8b33215323"}],"cinder_tempest_plugin/config.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8f164b8c6932bbfd8a8a64de7b022c348b895839","unresolved":true,"context_lines":[{"line_number":22,"context_line":"    cfg.BoolOpt(\u0027volume_revert\u0027,"},{"line_number":23,"context_line":"                default\u003dFalse,"},{"line_number":24,"context_line":"                help\u003d\u0027Enable to run Cinder volume revert tests\u0027),"},{"line_number":25,"context_line":"    cfg.BoolOpt(\u0027enable_volume_image_dep_tests\u0027,"},{"line_number":26,"context_line":"                default\u003dTrue,"},{"line_number":27,"context_line":"                help\u003d\u0027Run tests for dependencies between images and volumes\u0027)"},{"line_number":28,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"6d3d695d_e137f50e","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":48},"updated":"2024-06-25 17:29:09.000000000","message":"you cannot rename the config like this. As this config is already registered in Tempest, we do not need to  add it here. all plugins configs are registerd in tempest namespace only.\n\nYou need to do:\n\n1. deprecate the \u0027volume_image_dep_tests\u0027 config option for removal. Example https://github.com/openstack/tempest/blob/4bd81f8b17ac6e259d4d7bf1840cdfcaafc29f4c/tempest/config.py#L238\n2. add releasenotes for the deprecation \n3. Use enable_volume_image_dep_tests in cinder-tempest-plugin\n4. in the next cycle, you can remove \u0027volume_image_dep_tests\u0027 config option","commit_id":"4a99a69395ea4c040e3f4aed5a7b88cce2cc04aa"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"5519634c21ce2ebada431f46aa3d3068f99f0258","unresolved":true,"context_lines":[{"line_number":22,"context_line":"    cfg.BoolOpt(\u0027volume_revert\u0027,"},{"line_number":23,"context_line":"                default\u003dFalse,"},{"line_number":24,"context_line":"                help\u003d\u0027Enable to run Cinder volume revert tests\u0027),"},{"line_number":25,"context_line":"    cfg.BoolOpt(\u0027enable_volume_image_dep_tests\u0027,"},{"line_number":26,"context_line":"                default\u003dTrue,"},{"line_number":27,"context_line":"                help\u003d\u0027Run tests for dependencies between images and volumes\u0027)"},{"line_number":28,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"a0d90e8f_87ba4d1c","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":48},"in_reply_to":"6d3d695d_e137f50e","updated":"2024-10-06 08:58:34.000000000","message":"Let\u0027s come back to dependency tests :).\nThere is tests that depend on \u0027volume_dep_tests\u0027 configuration.\nShould we move all dependency tests to cinder-tempest-plugin?","commit_id":"4a99a69395ea4c040e3f4aed5a7b88cce2cc04aa"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b5047addf77739a8c319d36834dc0f421a7d8d4b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    cfg.BoolOpt(\u0027volume_revert\u0027,"},{"line_number":23,"context_line":"                default\u003dFalse,"},{"line_number":24,"context_line":"                help\u003d\u0027Enable to run Cinder volume revert tests\u0027),"},{"line_number":25,"context_line":"    cfg.BoolOpt(\u0027enable_volume_image_dep_tests\u0027,"},{"line_number":26,"context_line":"                default\u003dTrue,"},{"line_number":27,"context_line":"                help\u003d\u0027Run tests for dependencies between images and volumes\u0027)"},{"line_number":28,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7c6a6b0b_231c6c94","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":48},"in_reply_to":"a0d90e8f_87ba4d1c","updated":"2024-11-25 18:47:15.000000000","message":"we do not need to move the tests but use the new config option in test in Tempest or cinder-tempest-plugin. I think you did correctly here.","commit_id":"4a99a69395ea4c040e3f4aed5a7b88cce2cc04aa"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b5047addf77739a8c319d36834dc0f421a7d8d4b","unresolved":true,"context_lines":[{"line_number":22,"context_line":"    cfg.BoolOpt(\u0027volume_revert\u0027,"},{"line_number":23,"context_line":"                default\u003dFalse,"},{"line_number":24,"context_line":"                help\u003d\u0027Enable to run Cinder volume revert tests\u0027),"},{"line_number":25,"context_line":"    cfg.BoolOpt(\u0027volume_image_dep_tests\u0027,"},{"line_number":26,"context_line":"                default\u003dTrue,"},{"line_number":27,"context_line":"                help\u003d\u0027Run tests for dependencies between images and volumes\u0027,"},{"line_number":28,"context_line":"                deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9c0f1bb9_3c4d8166","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":41},"updated":"2024-11-25 18:47:15.000000000","message":"Tanks, lgtm but one more update we need to do in Tempest. To keep this deprecated config continue working along with the new config option, you need to add this config as deprecated_name in Tempest new config:\n https://github.com/openstack/tempest/blob/e7b104c23cd2e1ac069bf55fb5e94a582534be81/tempest/config.py#L1123\n\n\nlike below:\n\n    cfg.BoolOpt(\u0027enable_volume_image_dep_tests\u0027,\n                deprecated_name\u003d\u0027volume_image_dep_tests\u0027,\n                default\u003dTrue,\n                help\u003d\u0027Run tests for dependencies between images, volumes\u0027\n                \u0027and instance snapshots\u0027)","commit_id":"4ae1dc847829c74cdd0c2235bde38b8b33215323"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0f4c67b8196f61b138aa0e5b199fb0de8b0835d6","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    cfg.BoolOpt(\u0027volume_revert\u0027,"},{"line_number":23,"context_line":"                default\u003dFalse,"},{"line_number":24,"context_line":"                help\u003d\u0027Enable to run Cinder volume revert tests\u0027),"},{"line_number":25,"context_line":"    cfg.BoolOpt(\u0027volume_image_dep_tests\u0027,"},{"line_number":26,"context_line":"                default\u003dTrue,"},{"line_number":27,"context_line":"                help\u003d\u0027Run tests for dependencies between images and volumes\u0027,"},{"line_number":28,"context_line":"                deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":8,"id":"620d8cfe_3413f825","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":41},"in_reply_to":"1cea89f6_938a2a68","updated":"2025-01-10 22:34:57.000000000","message":"thanks, tempest change is merged now","commit_id":"4ae1dc847829c74cdd0c2235bde38b8b33215323"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"a88078a0690ec108555b2032bda4b47483306e7d","unresolved":true,"context_lines":[{"line_number":22,"context_line":"    cfg.BoolOpt(\u0027volume_revert\u0027,"},{"line_number":23,"context_line":"                default\u003dFalse,"},{"line_number":24,"context_line":"                help\u003d\u0027Enable to run Cinder volume revert tests\u0027),"},{"line_number":25,"context_line":"    cfg.BoolOpt(\u0027volume_image_dep_tests\u0027,"},{"line_number":26,"context_line":"                default\u003dTrue,"},{"line_number":27,"context_line":"                help\u003d\u0027Run tests for dependencies between images and volumes\u0027,"},{"line_number":28,"context_line":"                deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1cea89f6_938a2a68","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":41},"in_reply_to":"9c0f1bb9_3c4d8166","updated":"2024-12-12 16:02:24.000000000","message":"Tempest patch with deprecated config \nhttps://review.opendev.org/c/openstack/tempest/+/934003","commit_id":"4ae1dc847829c74cdd0c2235bde38b8b33215323"}]}