)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"be5061c45738cbd189f7ea2b541d110f2a8bc3a7","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Yosi Ben Shimon \u003cybenshim@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-10-29 18:31:57 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added functionality for OSP 18.0 RFE"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Expose user-visible extra-specs via REST API"},{"line_number":10,"context_line":"The additional functionality added to:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9673fdfb_855b95c7","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":36},"updated":"2024-10-29 17:08:13.000000000","message":"Please be mindful that you are proposing this change to upstream code, not you own downstream product. The commit message should explain why this change is useful for upstream code, again not for your downstream product.","commit_id":"3a06a0682929be85a1eeba56a202e35576ea2f08"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d283661b4c7b404d1afafab8fb2f51bf183dbe4c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Yosi Ben Shimon \u003cybenshim@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-10-29 18:31:57 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added functionality for OSP 18.0 RFE"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Expose user-visible extra-specs via REST API"},{"line_number":10,"context_line":"The additional functionality added to:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"c9afc367_aa407917","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":36},"in_reply_to":"9673fdfb_855b95c7","updated":"2024-10-31 16:26:24.000000000","message":"I agree. How about \"Test user visible extra specs\"","commit_id":"3a06a0682929be85a1eeba56a202e35576ea2f08"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"8f89096dc498cfa7d7a362e66a6148aa020729e2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Yosi Ben Shimon \u003cybenshim@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-10-29 18:31:57 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added functionality for OSP 18.0 RFE"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Expose user-visible extra-specs via REST API"},{"line_number":10,"context_line":"The additional functionality added to:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"f728bfb2_bbf17d33","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":36},"in_reply_to":"c9afc367_aa407917","updated":"2024-11-19 10:50:33.000000000","message":"Done","commit_id":"3a06a0682929be85a1eeba56a202e35576ea2f08"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"a76344bc955d482ffd13314e4d8482fabc4806ad","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added functionality for OSP 18.0 RFE"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Expose user-visible extra-specs via REST API"},{"line_number":10,"context_line":"The additional functionality added to:"},{"line_number":11,"context_line":"test_list_all_extra_specs_for_volume_type"},{"line_number":12,"context_line":"test_show_extra_spec_for_volume_type"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bdaeccc9_b83a2ae3","line":9,"updated":"2024-11-06 14:21:30.000000000","message":"Also, in addition to the request above, the commit message should explain what you want to do. It is clear you are adding something to some tests, but the commit message should answer the question of \"what it is change about\".\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages","commit_id":"3a06a0682929be85a1eeba56a202e35576ea2f08"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"8f89096dc498cfa7d7a362e66a6148aa020729e2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added functionality for OSP 18.0 RFE"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Expose user-visible extra-specs via REST API"},{"line_number":10,"context_line":"The additional functionality added to:"},{"line_number":11,"context_line":"test_list_all_extra_specs_for_volume_type"},{"line_number":12,"context_line":"test_show_extra_spec_for_volume_type"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"54662439_0b9a426e","line":9,"in_reply_to":"bdaeccc9_b83a2ae3","updated":"2024-11-19 10:50:33.000000000","message":"Done","commit_id":"3a06a0682929be85a1eeba56a202e35576ea2f08"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"70864c276ff2f8d5413916ace0de88a6095c1adb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8566178c_c386aaea","updated":"2024-11-19 18:21:45.000000000","message":"Please hold on until https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/934275 is merged","commit_id":"1dfa7e2f64ab7e95154e80a83603e4931df1ef28"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"4962e58abb306f6fcb5b5170086b8cac8df78bd0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0aa5a857_e511a42a","updated":"2024-11-19 14:27:37.000000000","message":"recheck\n\nUnrelated issue in cinder-tempest-plugin-basic-2023-1","commit_id":"1dfa7e2f64ab7e95154e80a83603e4931df1ef28"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"543052ed431de6391d10851fb53ca4d6c597a510","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"45db0d9c_4f65adb9","in_reply_to":"8566178c_c386aaea","updated":"2024-11-19 19:16:17.000000000","message":"ack","commit_id":"1dfa7e2f64ab7e95154e80a83603e4931df1ef28"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"a2240cd6dc7ecb996d145ce5d4bd3f55aa722faa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9619cdea_f3250ddb","updated":"2024-11-21 09:52:13.000000000","message":"recheck\n\nunrelated issues","commit_id":"1fbcd11eb424f3f81614ea660e8ab732c93c4bf9"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"8d4da8b8e86dd1cc17890dc66b66a95213d29faf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2e8db273_6ef5ef40","updated":"2024-11-26 10:36:57.000000000","message":"Thanks Yosi! LGTM\nI have added a small comment.","commit_id":"8abcd7a5373292f90b1d86f53d9bff4b5eca8414"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"b73106fd83a5948f5b95118b646bd709f895d0d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"81cf5614_b0662deb","updated":"2024-12-01 12:25:37.000000000","message":"Thanks Yosi! LGTM","commit_id":"060369f3a2d610d0117cabc36b2b3fa3606619b0"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"8b30250a05829a44a23f5c099d405031a568bdfd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"66878240_80371cf4","updated":"2024-12-02 08:13:07.000000000","message":"run-NetApp CI","commit_id":"060369f3a2d610d0117cabc36b2b3fa3606619b0"}],"cinder_tempest_plugin/rbac/v3/test_volume_types.py":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"78e33c770aa324206609bc5b094256017d495b4a","unresolved":true,"context_lines":[{"line_number":364,"context_line":"            expected_status\u003dexceptions.Forbidden"},{"line_number":365,"context_line":"        )"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"    @decorators.skip_because(bug\u003d\u00272018467\u0027)"},{"line_number":368,"context_line":"    @decorators.idempotent_id(\u002782fd0d34-17b3-4f45-bd2e-728c9a8bff8c\u0027)"},{"line_number":369,"context_line":"    def test_list_all_extra_specs_for_volume_type(self):"},{"line_number":370,"context_line":"        self._list_all_extra_specs_for_volume_type("}],"source_content_type":"text/x-python","patch_set":3,"id":"99e99b96_ec209808","side":"PARENT","line":367,"range":{"start_line":367,"start_character":4,"end_line":367,"end_character":43},"updated":"2024-11-03 13:14:59.000000000","message":"Please include the reason for enabling the tests in the commit message.","commit_id":"645067abfe62d4d6217f3d505c581f4a3fd89cb3"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"23a2b907aa59032fd730581324933dff20648cd9","unresolved":true,"context_lines":[{"line_number":364,"context_line":"            expected_status\u003dexceptions.Forbidden"},{"line_number":365,"context_line":"        )"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"    @decorators.skip_because(bug\u003d\u00272018467\u0027)"},{"line_number":368,"context_line":"    @decorators.idempotent_id(\u002782fd0d34-17b3-4f45-bd2e-728c9a8bff8c\u0027)"},{"line_number":369,"context_line":"    def test_list_all_extra_specs_for_volume_type(self):"},{"line_number":370,"context_line":"        self._list_all_extra_specs_for_volume_type("}],"source_content_type":"text/x-python","patch_set":3,"id":"1ec455ef_dea529f3","side":"PARENT","line":367,"range":{"start_line":367,"start_character":4,"end_line":367,"end_character":43},"in_reply_to":"99e99b96_ec209808","updated":"2024-11-20 15:42:01.000000000","message":"This skip decorator was removed since this issue was observed on 17.1 and was related to this BZ https://bugzilla.redhat.com/show_bug.cgi?id\u003d2315601 where reader and member were _able_ to see the extra specs while they shouldn\u0027t be.\nOn 18.0 these operations work as expected.","commit_id":"645067abfe62d4d6217f3d505c581f4a3fd89cb3"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d283661b4c7b404d1afafab8fb2f51bf183dbe4c","unresolved":true,"context_lines":[{"line_number":35,"context_line":"        \"member\": ["},{"line_number":36,"context_line":"            \u0027multiattach\u0027, \u0027RESKEY:availability_zones\u0027, \u0027replication_enabled\u0027"},{"line_number":37,"context_line":"        ],"},{"line_number":38,"context_line":"        \"admin\": [x for x in extra_specs.keys()]"},{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    encryption_type_key_cipher \u003d \u0027cipher\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7d518a50_bad7fcfb","line":38,"updated":"2024-10-31 16:26:24.000000000","message":"I don\u0027t think the list comprehension is necessary. This should work:\n\n        \"admin\": extra_specs.keys()","commit_id":"3a06a0682929be85a1eeba56a202e35576ea2f08"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"8f89096dc498cfa7d7a362e66a6148aa020729e2","unresolved":true,"context_lines":[{"line_number":35,"context_line":"        \"member\": ["},{"line_number":36,"context_line":"            \u0027multiattach\u0027, \u0027RESKEY:availability_zones\u0027, \u0027replication_enabled\u0027"},{"line_number":37,"context_line":"        ],"},{"line_number":38,"context_line":"        \"admin\": [x for x in extra_specs.keys()]"},{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    encryption_type_key_cipher \u003d \u0027cipher\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7c15e641_4f784c78","line":38,"in_reply_to":"7d518a50_bad7fcfb","updated":"2024-11-19 10:50:33.000000000","message":"You\u0027re right about Python 2 because in Python 2, extra_specs.keys() returns a list.\nIn Python 3, extra_specs.keys() returns a dictionary view object:\ndict_keys([\u0027key1\u0027, \u0027multiattach\u0027, \u0027volume_backend_name\u0027, \u0027RESKEY:availability_zones\u0027, \u0027replication_enabled\u0027])\nand it needs to be converted to a list.\nSince we\u0027re using python \u003e 3.5, we can use either use list(extra_specs.keys()) or [*extra_specs.keys()].\nI\u0027ll use list(extra_specs.keys()) since it\u0027s more readable and consistant.","commit_id":"3a06a0682929be85a1eeba56a202e35576ea2f08"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"78e33c770aa324206609bc5b094256017d495b4a","unresolved":true,"context_lines":[{"line_number":91,"context_line":"        return volume_type"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    @classmethod"},{"line_number":94,"context_line":"    def extra_specs_content_validator(cls, client, extra_specs):"},{"line_number":95,"context_line":"        \"\"\"Validation of extra specs received"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        Addition for RHOSO 18 feature:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dec84cf5_88887499","line":94,"range":{"start_line":94,"start_character":0,"end_line":94,"end_character":64},"updated":"2024-11-03 13:14:59.000000000","message":"There doesn’t seem to be a need for a new test here, as this validates the get extra spec operation. It can be added to \"test_show_extra_spec_for_volume_type\" as an extension of that test.","commit_id":"3a06a0682929be85a1eeba56a202e35576ea2f08"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"8f89096dc498cfa7d7a362e66a6148aa020729e2","unresolved":true,"context_lines":[{"line_number":91,"context_line":"        return volume_type"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    @classmethod"},{"line_number":94,"context_line":"    def extra_specs_content_validator(cls, client, extra_specs):"},{"line_number":95,"context_line":"        \"\"\"Validation of extra specs received"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        Addition for RHOSO 18 feature:"}],"source_content_type":"text/x-python","patch_set":3,"id":"8556b128_cc60cf22","line":94,"range":{"start_line":94,"start_character":0,"end_line":94,"end_character":64},"in_reply_to":"dec84cf5_88887499","updated":"2024-11-19 10:50:33.000000000","message":"This is not a new test. just validation of the extra_specs content","commit_id":"3a06a0682929be85a1eeba56a202e35576ea2f08"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d283661b4c7b404d1afafab8fb2f51bf183dbe4c","unresolved":true,"context_lines":[{"line_number":94,"context_line":"    def extra_specs_content_validator(cls, client, extra_specs):"},{"line_number":95,"context_line":"        \"\"\"Validation of extra specs received"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        Addition for RHOSO 18 feature:"},{"line_number":98,"context_line":"        https://issues.redhat.com/browse/OSPRH-1786"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        Args:"},{"line_number":101,"context_line":"            client: Client object to be used"}],"source_content_type":"text/x-python","patch_set":3,"id":"7b429090_537f4be6","line":98,"range":{"start_line":97,"start_character":0,"end_line":98,"end_character":51},"updated":"2024-10-31 16:26:24.000000000","message":"As noted in the commit message, the code/comments should avoid referencing downstream products whenever possible. One suggestion is to reference the upstream spec [1] where the feature was introduced.\n\n[1] https://specs.openstack.org/openstack/cinder-specs/specs/xena/expose-cinder-user-visible-extra-specs-spec.html\n-OR-\nhttps://review.opendev.org/c/openstack/cinder-specs/+/796166","commit_id":"3a06a0682929be85a1eeba56a202e35576ea2f08"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"8f89096dc498cfa7d7a362e66a6148aa020729e2","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    def extra_specs_content_validator(cls, client, extra_specs):"},{"line_number":95,"context_line":"        \"\"\"Validation of extra specs received"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        Addition for RHOSO 18 feature:"},{"line_number":98,"context_line":"        https://issues.redhat.com/browse/OSPRH-1786"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        Args:"},{"line_number":101,"context_line":"            client: Client object to be used"}],"source_content_type":"text/x-python","patch_set":3,"id":"5007367c_9c0f2ed4","line":98,"range":{"start_line":97,"start_character":0,"end_line":98,"end_character":51},"in_reply_to":"7b429090_537f4be6","updated":"2024-11-19 10:50:33.000000000","message":"Done","commit_id":"3a06a0682929be85a1eeba56a202e35576ea2f08"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d283661b4c7b404d1afafab8fb2f51bf183dbe4c","unresolved":true,"context_lines":[{"line_number":106,"context_line":"        \"\"\""},{"line_number":107,"context_line":"        role \u003d client.user.split(\u0027-\u0027)[-1]"},{"line_number":108,"context_line":"        extra_specs_keys \u003d [x for x in extra_specs.keys()]"},{"line_number":109,"context_line":"        return (sorted(extra_specs_keys) \u003d\u003d"},{"line_number":110,"context_line":"                sorted(cls.expected_extra_specs[role]))"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def _update_volume_type(self, expected_status):"}],"source_content_type":"text/x-python","patch_set":3,"id":"a31c442a_133132f3","line":109,"range":{"start_line":109,"start_character":23,"end_line":109,"end_character":39},"updated":"2024-10-31 16:26:24.000000000","message":"nit: You should be able to use extra_specs.keys() directly and eliminate L108.","commit_id":"3a06a0682929be85a1eeba56a202e35576ea2f08"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"8f89096dc498cfa7d7a362e66a6148aa020729e2","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        \"\"\""},{"line_number":107,"context_line":"        role \u003d client.user.split(\u0027-\u0027)[-1]"},{"line_number":108,"context_line":"        extra_specs_keys \u003d [x for x in extra_specs.keys()]"},{"line_number":109,"context_line":"        return (sorted(extra_specs_keys) \u003d\u003d"},{"line_number":110,"context_line":"                sorted(cls.expected_extra_specs[role]))"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def _update_volume_type(self, expected_status):"}],"source_content_type":"text/x-python","patch_set":3,"id":"6323c9e5_8b52d473","line":109,"range":{"start_line":109,"start_character":23,"end_line":109,"end_character":39},"in_reply_to":"a31c442a_133132f3","updated":"2024-11-19 10:50:33.000000000","message":"Done","commit_id":"3a06a0682929be85a1eeba56a202e35576ea2f08"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d283661b4c7b404d1afafab8fb2f51bf183dbe4c","unresolved":true,"context_lines":[{"line_number":154,"context_line":"        )"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def _show_extra_spec_for_volume_type(self, expected_status):"},{"line_number":157,"context_line":"        \"\"\"Show extra_spec for a volume type\"\"\""},{"line_number":158,"context_line":"        spec \u003d self.do_request("},{"line_number":159,"context_line":"            method\u003d\u0027show_volume_type_extra_specs\u0027,"},{"line_number":160,"context_line":"            expected_status\u003dexpected_status,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9092106b_8bd0bf78","line":157,"updated":"2024-10-31 16:26:24.000000000","message":"You might expand this comment to explain it uses the \u0027multiattach\u0027 extra spec because all admin, member and readers should be able to \"show\" this spec.","commit_id":"3a06a0682929be85a1eeba56a202e35576ea2f08"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"8f89096dc498cfa7d7a362e66a6148aa020729e2","unresolved":true,"context_lines":[{"line_number":154,"context_line":"        )"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def _show_extra_spec_for_volume_type(self, expected_status):"},{"line_number":157,"context_line":"        \"\"\"Show extra_spec for a volume type\"\"\""},{"line_number":158,"context_line":"        spec \u003d self.do_request("},{"line_number":159,"context_line":"            method\u003d\u0027show_volume_type_extra_specs\u0027,"},{"line_number":160,"context_line":"            expected_status\u003dexpected_status,"}],"source_content_type":"text/x-python","patch_set":3,"id":"54f4809f_1348e358","line":157,"in_reply_to":"9092106b_8bd0bf78","updated":"2024-11-19 10:50:33.000000000","message":"Done.\nAnd added also \u0027volume_backend_name\u0027 for the case where only admin should \"see\" this spec","commit_id":"3a06a0682929be85a1eeba56a202e35576ea2f08"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"8d4da8b8e86dd1cc17890dc66b66a95213d29faf","unresolved":true,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        return volume_type"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    @classmethod"},{"line_number":94,"context_line":"    def extra_specs_content_validator(cls, client, extra_specs):"},{"line_number":95,"context_line":"        \"\"\"Validation of volume type\u0027s extra specs content"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3ce97bfd_a12a4d46","line":93,"range":{"start_line":93,"start_character":4,"end_line":93,"end_character":16},"updated":"2024-11-26 10:36:57.000000000","message":"I don\u0027t see a need to use a class method here; it can simply be an instance method.","commit_id":"8abcd7a5373292f90b1d86f53d9bff4b5eca8414"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"3c0b585eb6d35a896017849b09087e6ecbb480c7","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        return volume_type"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    @classmethod"},{"line_number":94,"context_line":"    def extra_specs_content_validator(cls, client, extra_specs):"},{"line_number":95,"context_line":"        \"\"\"Validation of volume type\u0027s extra specs content"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"2a7c2349_40b1478a","line":93,"range":{"start_line":93,"start_character":4,"end_line":93,"end_character":16},"in_reply_to":"3ce97bfd_a12a4d46","updated":"2024-11-28 10:21:56.000000000","message":"Done","commit_id":"8abcd7a5373292f90b1d86f53d9bff4b5eca8414"}]}