)]}'
{"cinder_tempest_plugin/api/volume/test_multiple_volume_from_resource.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a6c0416dbfb37f321910c544ff54f6d234577386","unresolved":true,"context_lines":[{"line_number":110,"context_line":"        res \u003d self._create_multiple_resource(self.create_volume,"},{"line_number":111,"context_line":"                                             **kwargs_create)"},{"line_number":112,"context_line":"        self._wait_for_multiple_resources("},{"line_number":113,"context_line":"            waiters.wait_for_volume_resource_status, res, **kwargs_create)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3c2f9915_f62613c2","line":113,"range":{"start_line":113,"start_character":60,"end_line":113,"end_character":73},"updated":"2025-10-09 13:36:12.000000000","message":"should be \"kwargs_wait\"","commit_id":"b93bee7dc76087a98a4eac894109b762d0e7eee1"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"61f7ba703495fe4176f0b182aabeb82869b0c704","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        res \u003d self._create_multiple_resource(self.create_volume,"},{"line_number":111,"context_line":"                                             **kwargs_create)"},{"line_number":112,"context_line":"        self._wait_for_multiple_resources("},{"line_number":113,"context_line":"            waiters.wait_for_volume_resource_status, res, **kwargs_create)"}],"source_content_type":"text/x-python","patch_set":1,"id":"845b755e_689048ef","line":113,"range":{"start_line":113,"start_character":60,"end_line":113,"end_character":73},"in_reply_to":"3c2f9915_f62613c2","updated":"2025-10-09 17:26:04.000000000","message":"Done","commit_id":"b93bee7dc76087a98a4eac894109b762d0e7eee1"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"884680b63f257ecbd7834455c385814b4bc481e3","unresolved":true,"context_lines":[{"line_number":104,"context_line":"        self._wait_for_multiple_resources("},{"line_number":105,"context_line":"            waiters.wait_for_volume_resource_status, res, **kwargs_wait)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        # Performing two passes here lets us test the image volume cache"},{"line_number":108,"context_line":"        # if it is configured."},{"line_number":109,"context_line":"        kwargs_create \u003d {\"\u0027imageRef\": img_uuid, \"wait_until\": None,"},{"line_number":110,"context_line":"                         \u0027repeat_count\u0027: 2}"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ca5486d_d25dc107","line":107,"updated":"2025-10-13 13:28:48.000000000","message":"I don\u0027t understand why a second pass with repeat_count: 2 is required in order to test the cache. The first pass uses the default repeat_count value (which is 5) and I thought that should cover the test requirements.\n\nThe issue I see is this test seems to have two use cases: stress testing with and without the cache, but the test itself doesn\u0027t know if the cache is enabled and so it doesn\u0027t know which of the cases it\u0027s covering.","commit_id":"07a15d01f39073a7e0e2adc9f86aa818fe3927d5"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"87bf54f44149bcb68a3e76601c6df31beee846f6","unresolved":true,"context_lines":[{"line_number":104,"context_line":"        self._wait_for_multiple_resources("},{"line_number":105,"context_line":"            waiters.wait_for_volume_resource_status, res, **kwargs_wait)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        # Performing two passes here lets us test the image volume cache"},{"line_number":108,"context_line":"        # if it is configured."},{"line_number":109,"context_line":"        kwargs_create \u003d {\"\u0027imageRef\": img_uuid, \"wait_until\": None,"},{"line_number":110,"context_line":"                         \u0027repeat_count\u0027: 2}"}],"source_content_type":"text/x-python","patch_set":3,"id":"07e7ad28_f6f63566","line":107,"in_reply_to":"1ca5486d_d25dc107","updated":"2025-10-13 14:50:16.000000000","message":"I think my suggested change here actually isn\u0027t necessary - since the initial set of volume creation will wait for the cache to populate and then use the cache entry, a second step isn\u0027t needed.  All that is needed is for the test job to actually have the cache enabled.","commit_id":"07a15d01f39073a7e0e2adc9f86aa818fe3927d5"}]}
