)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"591eac4bd46e005dfe3bf407b59a24542c3fa817","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5b497015_65689c49","updated":"2026-01-28 15:25:12.000000000","message":"This can be worked around by configuring tempest.conf, but since this test doesn\u0027t actually need the storage_protocol/vendor_name as part of the test, it makes sense to remove these.","commit_id":"e76224ed4e3705fb3754002018acd7de400d4549"},{"author":{"_account_id":34373,"name":"Jason Paroly","email":"jparoly@redhat.com","username":"jparoly"},"change_message_id":"4b4c01f88b60fd141b8fdb44382f5083819118f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2e2d239c_077719ba","updated":"2026-01-28 14:31:04.000000000","message":"recheck\n\n DevStack setup failed during Ceph deployment with this error:                                                                                                                                                    \n  RuntimeError: Failed command: ... orch set backend cephadm                                                                                                                                                       \n  Error: Module \u0027orchestrator\u0027 is not enabled/loaded                                                                                                                                                               \n                                                                                                                                                                                                                   \n  The tests never ran because Ceph failed to deploy properly. This is a Ceph orchestrator setup issue in the test infrastructure.","commit_id":"e76224ed4e3705fb3754002018acd7de400d4549"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"65832cea4d40f42a30b563c55e44c264f8909571","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8631f0e6_06f3ef17","updated":"2026-02-06 14:53:24.000000000","message":"It really looks like, as it was pointed out, that the test doesn\u0027t require setting those values in the extra_specs. But maybe there was a reason - Brian, you added this test in https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/737380/, was it there any reason for that extra_specs?","commit_id":"d05aaeed7eeaaf8b796c24969bee846cbb814cae"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7a77c8c817ab9274155fd828e40f28e51ba1c0f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"859e09ef_5a6efbc8","updated":"2026-02-10 13:44:59.000000000","message":"See comments inline.","commit_id":"d05aaeed7eeaaf8b796c24969bee846cbb814cae"},{"author":{"_account_id":34373,"name":"Jason Paroly","email":"jparoly@redhat.com","username":"jparoly"},"change_message_id":"f29f6b519f26934349b583858bd879f14c6c23ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"037f6a9f_db23f994","updated":"2026-02-04 13:39:01.000000000","message":"recheck after fix, may have done prior recheck too soon","commit_id":"d05aaeed7eeaaf8b796c24969bee846cbb814cae"},{"author":{"_account_id":34373,"name":"Jason Paroly","email":"jparoly@redhat.com","username":"jparoly"},"change_message_id":"be3ee65aee71a2f7d368ee8dd4559766afcce049","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bb7eec7d_20c3f754","updated":"2026-02-03 21:03:56.000000000","message":"recheck blocking bug has been fixed and merged","commit_id":"d05aaeed7eeaaf8b796c24969bee846cbb814cae"},{"author":{"_account_id":34373,"name":"Jason Paroly","email":"jparoly@redhat.com","username":"jparoly"},"change_message_id":"39637f2b016bad299f1844952b8aea350f58a17b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"06535a28_df34dbee","updated":"2026-01-30 15:20:29.000000000","message":"waiting on fix for https://bugs.launchpad.net/devstack/+bug/2139405 : https://review.opendev.org/c/openstack/devstack/+/975247","commit_id":"d05aaeed7eeaaf8b796c24969bee846cbb814cae"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7a77c8c817ab9274155fd828e40f28e51ba1c0f4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b98b5956_068431d2","in_reply_to":"8631f0e6_06f3ef17","updated":"2026-02-10 13:44:59.000000000","message":"I don\u0027t remember a reason for the extra-specs other than that they were set in the test I used as a model for this one [0], and they seemed innocuous enough.  Not sure why they are causing an issue here but not in the main tempest suite.\n\nI do object, however, to the removal of an assertion in the test; see comment inline.\n\n[0] https://opendev.org/openstack/tempest/src/commit/b146a8c41262cb298be1ecfef056af550b3cd367/tempest/api/volume/admin/test_volume_types.py#L36","commit_id":"d05aaeed7eeaaf8b796c24969bee846cbb814cae"},{"author":{"_account_id":34373,"name":"Jason Paroly","email":"jparoly@redhat.com","username":"jparoly"},"change_message_id":"0b53e478d851403da56ef6b29a1c84b2e0d6488a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5877f010_1774f1ce","in_reply_to":"b98b5956_068431d2","updated":"2026-02-10 15:43:05.000000000","message":"Done","commit_id":"d05aaeed7eeaaf8b796c24969bee846cbb814cae"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"2fb2a9bf5f246556196e5e0e0dc3761ccc928193","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a709ed41_479c31a7","updated":"2026-02-11 17:15:38.000000000","message":"I think https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/976365 should be merged before this change, and we can rebase this one on top of that other.","commit_id":"f06405659a76ceee7bfbc4554ea1eda5cad63c8b"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"ad20022c248e977c02f1f6a08d1140a5a71016ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d0cc2a3b_e220a9b7","updated":"2026-02-27 00:32:31.000000000","message":"Issues fixed, let\u0027s go","commit_id":"f06405659a76ceee7bfbc4554ea1eda5cad63c8b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"958cf266392fcecf8693fa02233e592d86515bc0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"53be84bc_21ad1d7d","updated":"2026-02-12 03:14:40.000000000","message":"Revison LGTM; eventually, Zuul will agree.","commit_id":"f06405659a76ceee7bfbc4554ea1eda5cad63c8b"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"3f19d79f60227f6971a675e626d6629cbafeac23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c51dba2c_cc8cdef7","updated":"2026-02-11 09:30:15.000000000","message":"recheck\n\na few assorted errors which are unrelated to this patch","commit_id":"f06405659a76ceee7bfbc4554ea1eda5cad63c8b"},{"author":{"_account_id":34373,"name":"Jason Paroly","email":"jparoly@redhat.com","username":"jparoly"},"change_message_id":"6a6e3b88b8545fb166ee2aca4525f0b0eb6ed8c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b50d71ce_1d02d52a","updated":"2026-02-11 12:45:21.000000000","message":"recheck failures unrelated to this change. will be investigating fixes for flaky failures around S3 endpoint not up/ready","commit_id":"f06405659a76ceee7bfbc4554ea1eda5cad63c8b"},{"author":{"_account_id":34373,"name":"Jason Paroly","email":"jparoly@redhat.com","username":"jparoly"},"change_message_id":"b9e2e82c0c53ea35a739ff030fa35ea1a364d710","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d0815f32_e988a676","updated":"2026-02-26 00:11:12.000000000","message":"recheck since https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/976365 merged","commit_id":"f06405659a76ceee7bfbc4554ea1eda5cad63c8b"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"634b8c4ea5b2cf4e47e7ae16e770e4208ff25377","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"79d6cc41_9c6ec168","in_reply_to":"b50d71ce_1d02d52a","updated":"2026-02-11 14:19:13.000000000","message":"I have a patch to remove cinder-tempest-plugin-basic-2024-1 as 2024-1 is unsupported. Let\u0027s see if that get merged before","commit_id":"f06405659a76ceee7bfbc4554ea1eda5cad63c8b"}],"cinder_tempest_plugin/api/volume/test_create_from_image.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"591eac4bd46e005dfe3bf407b59a24542c3fa817","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                           \u00276e9266ff-a917-4dd5-aa4a-c36e59e7a2a6\u0027),"},{"line_number":65,"context_line":"                  \u0027imageRef\u0027: image[\u0027id\u0027]}"},{"line_number":66,"context_line":"        # this is the whole point of the test, so make sure this is true"},{"line_number":67,"context_line":"        self.assertNotIn(\u0027volume_type\u0027, kwargs)"},{"line_number":68,"context_line":"        volume \u003d self.create_volume(**kwargs)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        found_volume_type \u003d volume[\u0027volume_type\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"e4a3cb2d_43707c96","line":67,"range":{"start_line":67,"start_character":8,"end_line":67,"end_character":47},"updated":"2026-01-28 15:25:12.000000000","message":"This is a strange assertion given that we just defined kwargs in the test.","commit_id":"e76224ed4e3705fb3754002018acd7de400d4549"},{"author":{"_account_id":34373,"name":"Jason Paroly","email":"jparoly@redhat.com","username":"jparoly"},"change_message_id":"d275d6d8f87eb34a125c9bd669912c8e0f559c90","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                           \u00276e9266ff-a917-4dd5-aa4a-c36e59e7a2a6\u0027),"},{"line_number":65,"context_line":"                  \u0027imageRef\u0027: image[\u0027id\u0027]}"},{"line_number":66,"context_line":"        # this is the whole point of the test, so make sure this is true"},{"line_number":67,"context_line":"        self.assertNotIn(\u0027volume_type\u0027, kwargs)"},{"line_number":68,"context_line":"        volume \u003d self.create_volume(**kwargs)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        found_volume_type \u003d volume[\u0027volume_type\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"015b84fe_f9755dae","line":67,"range":{"start_line":67,"start_character":8,"end_line":67,"end_character":47},"in_reply_to":"e4a3cb2d_43707c96","updated":"2026-01-28 15:58:19.000000000","message":"removed it, added a comment, and updated commit message to reflect this.  Thank you and good catch.","commit_id":"e76224ed4e3705fb3754002018acd7de400d4549"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7a77c8c817ab9274155fd828e40f28e51ba1c0f4","unresolved":true,"context_lines":[{"line_number":69,"context_line":"                           \u00276e9266ff-a917-4dd5-aa4a-c36e59e7a2a6\u0027),"},{"line_number":70,"context_line":"                  \u0027imageRef\u0027: image[\u0027id\u0027]}"},{"line_number":71,"context_line":"        # this is the whole point of the test, so make sure this is true"},{"line_number":72,"context_line":"        self.assertNotIn(\u0027volume_type\u0027, kwargs)"},{"line_number":73,"context_line":"        volume \u003d self.create_volume(**kwargs)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        found_volume_type \u003d volume[\u0027volume_type\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"ce3c2ff1_4408d86a","side":"PARENT","line":72,"updated":"2026-02-10 13:44:59.000000000","message":"I don\u0027t understand the issue with this.  What\u0027s better, a comment that may or may not be read, or an actionable statement?  Because this test was added to detect a regression, I think it\u0027s important to have this assertion, because as long as you add the correct volume_type in the kwargs, the test will still pass, even if the read-the-volume-type-from-image-properties functionality has regressed.  So I completely disagree with moving this to a comment.","commit_id":"058e172729cde892e61ee65c931d5defc0d3d81c"},{"author":{"_account_id":34373,"name":"Jason Paroly","email":"jparoly@redhat.com","username":"jparoly"},"change_message_id":"0b53e478d851403da56ef6b29a1c84b2e0d6488a","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                           \u00276e9266ff-a917-4dd5-aa4a-c36e59e7a2a6\u0027),"},{"line_number":70,"context_line":"                  \u0027imageRef\u0027: image[\u0027id\u0027]}"},{"line_number":71,"context_line":"        # this is the whole point of the test, so make sure this is true"},{"line_number":72,"context_line":"        self.assertNotIn(\u0027volume_type\u0027, kwargs)"},{"line_number":73,"context_line":"        volume \u003d self.create_volume(**kwargs)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        found_volume_type \u003d volume[\u0027volume_type\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"85fa0856_707dc6f6","side":"PARENT","line":72,"in_reply_to":"ce3c2ff1_4408d86a","updated":"2026-02-10 15:43:05.000000000","message":"Done","commit_id":"058e172729cde892e61ee65c931d5defc0d3d81c"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a905fe1ec1cbf06ee77a670c2d17030f15163304","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        kwargs \u003d {\u0027name\u0027: (\u0027volume-for-test-\u0027"},{"line_number":64,"context_line":"                           \u00276e9266ff-a917-4dd5-aa4a-c36e59e7a2a6\u0027),"},{"line_number":65,"context_line":"                  \u0027imageRef\u0027: image[\u0027id\u0027]}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # this is the whole point of the test, so make sure this is true"},{"line_number":68,"context_line":"        self.assertNotIn(\u0027volume_type\u0027, kwargs)"},{"line_number":69,"context_line":"        volume \u003d self.create_volume(**kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5b393ec7_22853751","line":66,"updated":"2026-02-10 15:46:04.000000000","message":"Will update to exclude this","commit_id":"321387862bb5c3946f1b0053e410e84c55cea8e6"}]}