)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"0cd27f3ce0a05eb02cdadff6417b1a6b45f1c19c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"56fa5abf_7aab6209","updated":"2026-08-04 09:50:30.000000000","message":"Hi Amit,\n\nThere is already a similar test in the tempest project, but the rebuild server scenario is missing:\nhttps://github.com/openstack/tempest/blob/master/tempest/scenario/test_volume_boot_pattern.py#L62\n\nMaybe we should consider adding the rebuild coverage to the existing tempest test instead, to avoid duplicating scenarios and reduce the maintenance burden of scenario testing.","commit_id":"0953b64271cb74b919361093c42d510821f4ad3b"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"71427c080df2ba4e25456e687529d41687038c1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c1cbb138_359b1133","in_reply_to":"56fa5abf_7aab6209","updated":"2026-08-04 13:43:57.000000000","message":"so I was thinking as we run both tempest and cinder-tempest-plugin - https://review.opendev.org/c/openstack/tempest/+/995934 is enough.","commit_id":"0953b64271cb74b919361093c42d510821f4ad3b"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"40e7f792774edde167fef3b49364dabc2c9aa015","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"abb66acd_8ff06448","in_reply_to":"c1cbb138_359b1133","updated":"2026-08-05 12:50:44.000000000","message":"Yes, that makes sense. You can abandon this patch.\n\nI was thinking that we could instead add the rebuild server coverage to the existing test in the tempest change:\nhttps://review.opendev.org/c/openstack/tempest/+/995934\n\nLet\u0027s see what Ghanshyam thinks before deciding on the best approach.","commit_id":"0953b64271cb74b919361093c42d510821f4ad3b"}],"cinder_tempest_plugin/scenario/manager.py":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"0cd27f3ce0a05eb02cdadff6417b1a6b45f1c19c","unresolved":true,"context_lines":[{"line_number":173,"context_line":"            disks_list_before_attach, instance_ip, private_key)"},{"line_number":174,"context_line":"        return volume_device_name, attachment"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def create_bfv_server(self, keypair, security_group, image\u003dNone,"},{"line_number":177,"context_line":"                          boot_volume\u003dNone):"},{"line_number":178,"context_line":"        if boot_volume is None:"},{"line_number":179,"context_line":"            if image is None:"},{"line_number":180,"context_line":"                image \u003d CONF.compute.image_ref"},{"line_number":181,"context_line":"            boot_volume \u003d self.create_volume(imageRef\u003dimage)"},{"line_number":182,"context_line":"            waiters.wait_for_volume_resource_status("},{"line_number":183,"context_line":"                self.volumes_client, boot_volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        server \u003d self.boot_instance_from_resource("},{"line_number":186,"context_line":"            source_id\u003dboot_volume[\u0027id\u0027],"},{"line_number":187,"context_line":"            source_type\u003d\u0027volume\u0027,"},{"line_number":188,"context_line":"            keypair\u003dkeypair,"},{"line_number":189,"context_line":"            security_group\u003dsecurity_group)"},{"line_number":190,"context_line":"        waiters.wait_for_server_status("},{"line_number":191,"context_line":"            self.servers_client, server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        return server, boot_volume"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def create_volume_type(self, client\u003dNone, name\u003dNone, extra_specs\u003dNone):"},{"line_number":196,"context_line":"        if not client:"},{"line_number":197,"context_line":"            client \u003d self.os_admin.volume_types_client_latest"}],"source_content_type":"text/x-python","patch_set":1,"id":"85aade85_1421a42e","line":194,"range":{"start_line":176,"start_character":0,"end_line":194,"end_character":0},"updated":"2026-08-04 09:50:30.000000000","message":"I think `boot_instance_from_resource` from tempest could be used here instead, as it already provides this functionality:\nhttps://github.com/openstack/tempest/blob/master/tempest/scenario/manager.py#L1362","commit_id":"0953b64271cb74b919361093c42d510821f4ad3b"}],"cinder_tempest_plugin/scenario/test_volume_rebuild_scenarios.py":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"0cd27f3ce0a05eb02cdadff6417b1a6b45f1c19c","unresolved":true,"context_lines":[{"line_number":39,"context_line":"            self.keypair \u003d self.create_keypair()"},{"line_number":40,"context_line":"        self.security_group \u003d self.create_security_group()"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def _snapshot_volume(self, volume_id):"},{"line_number":43,"context_line":"        snapshot \u003d self.create_volume_snapshot(volume_id, force\u003dTrue)"},{"line_number":44,"context_line":"        waiters.wait_for_volume_resource_status("},{"line_number":45,"context_line":"            self.snapshots_client, snapshot[\u0027id\u0027], \u0027available\u0027)"},{"line_number":46,"context_line":"        return snapshot"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def _rebuild_server(self, server_id, image):"},{"line_number":49,"context_line":"        self.servers_client.rebuild_server("}],"source_content_type":"text/x-python","patch_set":1,"id":"8e8b3bcd_01b25abc","line":46,"range":{"start_line":42,"start_character":0,"end_line":46,"end_character":23},"updated":"2026-08-04 09:50:30.000000000","message":"you can just call self.create_volume_snapshot(volume_id, force\u003dTrue)\n`create_volume_snapshot` already wait for resouce creation","commit_id":"0953b64271cb74b919361093c42d510821f4ad3b"}]}