)]}'
{"test-requirements.txt":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"584726d50e0b21756e29307b84e3df84c488a74f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"testtools\u003e\u003d2.2.0 # MIT"},{"line_number":12,"context_line":"stestr\u003e\u003d1.0.0 # Apache-2.0"},{"line_number":13,"context_line":"# There\u0027s no current Cinder PyPi package we can use"},{"line_number":14,"context_line":"git+git://github.com/openstack/cinder.git"}],"source_content_type":"text/plain","patch_set":4,"id":"5fc1f717_8d1a5414","side":"PARENT","line":14,"updated":"2019-03-15 09:50:53.000000000","message":"Just add cinder here - that is sufficient.","commit_id":"f9dab3d6fb520c1d97279c5b154da3b08de2f5fc"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3996f4e2ad0a15aa9625b6ba3accaa97d73d1fa8","unresolved":false,"context_lines":[{"line_number":11,"context_line":"testtools\u003e\u003d2.2.0 # MIT"},{"line_number":12,"context_line":"stestr\u003e\u003d1.0.0 # Apache-2.0"},{"line_number":13,"context_line":"# There\u0027s no current Cinder PyPi package we can use"},{"line_number":14,"context_line":"git+git://github.com/openstack/cinder.git"}],"source_content_type":"text/plain","patch_set":4,"id":"5fc1f717_8d4ed4be","side":"PARENT","line":14,"in_reply_to":"5fc1f717_8d1a5414","updated":"2019-03-15 10:09:45.000000000","message":"Cinder is already in requirements.txt, we don\u0027t need to add Cinder here.  The github repo was here to make sure that during tests we were using master and not the PyPi package.","commit_id":"f9dab3d6fb520c1d97279c5b154da3b08de2f5fc"}],"tox.ini":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4da5c773bf5a5b4d5ce613c273abc6ac8256a1cb","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# Use cinder from master instead of from PyPi"},{"line_number":15,"context_line":"deps\u003d -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt}"},{"line_number":16,"context_line":"      -r{toxinidir}/test-requirements.txt"},{"line_number":17,"context_line":"      git+git://github.com/openstack/cinder.git"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"commands \u003d"},{"line_number":20,"context_line":"    find . -ignore_readdir_race -type f -name \"*.pyc\" -delete"}],"source_content_type":"text/x-properties","patch_set":1,"id":"5fc1f717_5b068f1e","line":17,"range":{"start_line":17,"start_character":10,"end_line":17,"end_character":47},"updated":"2019-03-13 17:20:06.000000000","message":"should this be git://git.openstack.org/openstack/cinder ?","commit_id":"43ff1883e5b863a351f88787d74d1bab0b307e7a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2e79c8c0db51b28f8eaddf87d1568cc3c70e7ea3","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# Use cinder from master instead of from PyPi"},{"line_number":15,"context_line":"deps\u003d -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt}"},{"line_number":16,"context_line":"      -r{toxinidir}/test-requirements.txt"},{"line_number":17,"context_line":"      git+git://github.com/openstack/cinder.git"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"commands \u003d"},{"line_number":20,"context_line":"    find . -ignore_readdir_race -type f -name \"*.pyc\" -delete"}],"source_content_type":"text/x-properties","patch_set":1,"id":"5fc1f717_bb345394","line":17,"range":{"start_line":17,"start_character":10,"end_line":17,"end_character":47},"in_reply_to":"5fc1f717_5b068f1e","updated":"2019-03-13 17:31:04.000000000","message":"Yes, yes it should","commit_id":"43ff1883e5b863a351f88787d74d1bab0b307e7a"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"584726d50e0b21756e29307b84e3df84c488a74f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# Use cinder from master instead of from PyPi"},{"line_number":15,"context_line":"deps\u003d -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt}"},{"line_number":16,"context_line":"      -r{toxinidir}/test-requirements.txt"},{"line_number":17,"context_line":"      git+git://git.openstack.org/openstack/cinder"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"commands \u003d"},{"line_number":20,"context_line":"    find . -ignore_readdir_race -type f -name \"*.pyc\" -delete"}],"source_content_type":"text/x-properties","patch_set":4,"id":"5fc1f717_cd24dc60","line":17,"updated":"2019-03-15 09:50:53.000000000","message":"You do not need this, you can use cinder in requirements","commit_id":"c6dba60be3e427f4e7304cc39e2b877b0f8dd823"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3996f4e2ad0a15aa9625b6ba3accaa97d73d1fa8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# Use cinder from master instead of from PyPi"},{"line_number":15,"context_line":"deps\u003d -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt}"},{"line_number":16,"context_line":"      -r{toxinidir}/test-requirements.txt"},{"line_number":17,"context_line":"      git+git://git.openstack.org/openstack/cinder"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"commands \u003d"},{"line_number":20,"context_line":"    find . -ignore_readdir_race -type f -name \"*.pyc\" -delete"}],"source_content_type":"text/x-properties","patch_set":4,"id":"5fc1f717_0de9847e","line":17,"in_reply_to":"5fc1f717_cd24dc60","updated":"2019-03-15 10:09:45.000000000","message":"As I mention in L14 we want to use master and not PyPi version.\n\nCinderlib is tightly coupled with Cinder, so much that we wanted to add it into the Cinder project itself, but since setuptools doesn\u0027t support multiple packages in a single repo we created a separate repo.\n\nSince they are so couple we need to keep them in sync during the whole cycle, to make sure we don\u0027t find at the last second that cinderlib is with Cinder master.","commit_id":"c6dba60be3e427f4e7304cc39e2b877b0f8dd823"}]}