)]}'
{"cinderlib/tests/functional/base_tests.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"628973d5d2e33c4f5cfe3c98c8ff454420913479","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        vol_size \u003d kwargs.setdefault(\u0027size\u0027, 1)"},{"line_number":159,"context_line":"        name \u003d kwargs.setdefault(\u0027name\u0027, backend.id)"},{"line_number":160,"context_line":"        kwargs.setdefault(\u0027extra_specs\u0027, {\u0027k\u0027: \u0027v\u0027})"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        vol \u003d backend.create_volume(**kwargs)"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_dc7ca384","line":160,"updated":"2019-07-16 09:28:33.000000000","message":"-1: I think we shouldn\u0027t create all volumes with extra specs, otherwise we remove the coverage for volumes and snapshots with no volume type.\n\nWe could pass the extra_specs keyword argument to this method in some of the tests. For example:\n\n- test_create_delete_volume\n- test_create_delete_snapshot\n- test_attach_detach_volume\n- test_clone\n- test_create_volume_from_snapshot","commit_id":"a74d33ddb9ad4b2116f2dc4c221a9101eaf2857e"}],"cinderlib/tests/unit/persistence/test_base.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"af757f2b12581e38a97bd288797dcf807f5e246d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import cinderlib"},{"line_number":17,"context_line":"from cinderlib.tests.unit.persistence import test_dbms"},{"line_number":18,"context_line":"from cinderlib.tests.unit import utils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_30c80c73","line":17,"updated":"2019-07-23 16:42:11.000000000","message":"I don\u0027t like inheriting from TestDBPersistence, as it means that we\u0027ll run those tests twice.\n\n\nTo avoid that we need to refactor `cinderlib.tests.unit.persistence.base.BasePersistenceTest` to move the helper methods and setup methods into a helper class (`BasePersistenceTest` would inherit from it) and then here we inherit from it and set the persistence configuration in this test to be the same as the memory persistence plugin (it\u0027s faster).","commit_id":"2cfb2789b8d9b536762b6a2f87cd395e5bfc82a8"}]}