)]}'
{"id":"openstack%2Fcinderlib~670887","triplet_id":"openstack%2Fcinderlib~master~If7816bf3deb37c526b86b0baed500bebe637bd40","project":"openstack/cinderlib","branch":"master","topic":"bug/1836724","hashtags":[],"change_id":"If7816bf3deb37c526b86b0baed500bebe637bd40","subject":"Fix: Snapshot creation with volume types","status":"MERGED","created":"2019-07-15 17:16:45.000000000","updated":"2019-07-26 14:34:54.000000000","submitted":"2019-07-26 14:34:53.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"670887-1564151694235-8da850ff","meta_rev_id":"ef707e83e65fe6d4ff7117d42536adb373775fa8","_number":670887,"virtual_id_number":670887,"owner":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-07-26 14:34:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-07-26 11:22:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-07-26 11:22:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-26 11:22:17.000000000","updated_by":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"reviewer":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"state":"REVIEWER"},{"updated":"2019-07-26 14:34:53.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"df4b5714e58171ba331c151f0dcd16af3f5c7fbf","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-07-15 17:16:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3452313691acab41c6e5766a26c5e4e312a1ca34","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-15 19:05:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-py36 http://logs.openstack.org/87/670887/1/check/openstack-tox-py36/732fe7b/ : SUCCESS in 5m 06s\n- openstack-tox-py37 http://logs.openstack.org/87/670887/1/check/openstack-tox-py37/f6b6e91/ : SUCCESS in 5m 11s\n- openstack-tox-docs http://logs.openstack.org/87/670887/1/check/openstack-tox-docs/d1434bb/html/ : SUCCESS in 3m 39s\n- openstack-tox-pep8 http://logs.openstack.org/87/670887/1/check/openstack-tox-pep8/4bc7cc6/ : SUCCESS in 3m 23s\n- cinderlib-tox-py27 http://logs.openstack.org/87/670887/1/check/cinderlib-tox-py27/c6caf0c/ : SUCCESS in 5m 29s\n- cinderlib-tox-py36 http://logs.openstack.org/87/670887/1/check/cinderlib-tox-py36/8049f05/ : SUCCESS in 6m 56s\n- cinderlib-lvm-functional http://logs.openstack.org/87/670887/1/check/cinderlib-lvm-functional/eec1818/ : SUCCESS in 9m 22s\n- cinderlib-ceph-functional http://logs.openstack.org/87/670887/1/check/cinderlib-ceph-functional/232a0ab/ : SUCCESS in 8m 43s","accounts_in_message":[],"_revision_number":1},{"id":"628973d5d2e33c4f5cfe3c98c8ff454420913479","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2019-07-16 09:28:33.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nThanks for the patch!!\n\nBesides not making all tests with volume types, I think it would be would to test the `get_changed_fields` method in the unit tests.\n\nThis method is not currently being tested (my oversight) and I don\u0027t expect this patch to add full coverage for the method, but it would be good to create a new test file `cinderlib/tests/unit/persistence/test_base.py` and at least test the changes introduced by this patch.\n\nThe downvote is for the comment in the `functional/base_tests.py` file, and I won\u0027t hold this patch on account of not having tests for `get_changed_fields`.  Though it would be great to have it.","accounts_in_message":[],"_revision_number":1},{"id":"638ad905eaa62cb9e220eef9687dcdb7af1f910d","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-07-18 10:43:55.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"a508124f593656910b299f6f1d6734a25cabd498","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-07-18 10:46:16.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"ea12be6163ea0a04eee4cf4de622cd6696a568b7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-18 11:31:34.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-py36 http://logs.openstack.org/87/670887/3/check/openstack-tox-py36/4756e70/ : FAILURE in 3m 59s\n- openstack-tox-py37 http://logs.openstack.org/87/670887/3/check/openstack-tox-py37/3dac413/ : FAILURE in 4m 40s\n- openstack-tox-docs http://logs.openstack.org/87/670887/3/check/openstack-tox-docs/1050e28/html/ : SUCCESS in 3m 45s\n- openstack-tox-pep8 http://logs.openstack.org/87/670887/3/check/openstack-tox-pep8/973bd91/ : FAILURE in 3m 39s\n- cinderlib-tox-py27 http://logs.openstack.org/87/670887/3/check/cinderlib-tox-py27/f1b251b/ : FAILURE in 6m 27s\n- cinderlib-tox-py36 http://logs.openstack.org/87/670887/3/check/cinderlib-tox-py36/df342a1/ : FAILURE in 5m 15s\n- cinderlib-lvm-functional http://logs.openstack.org/87/670887/3/check/cinderlib-lvm-functional/c463f58/ : SUCCESS in 9m 07s\n- cinderlib-ceph-functional http://logs.openstack.org/87/670887/3/check/cinderlib-ceph-functional/9102f09/ : SUCCESS in 8m 11s","accounts_in_message":[],"_revision_number":3},{"id":"4ac46d10754c798629c577bb29014a49d2409ec6","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-07-19 08:38:00.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"5097f4ace7ef4c8c2082727371f662fe77170295","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-19 08:50:26.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/87/670887/4/check/openstack-tox-docs/c504e49/html/ : SUCCESS in 3m 02s\n- openstack-tox-pep8 http://logs.openstack.org/87/670887/4/check/openstack-tox-pep8/287a5ba/ : SUCCESS in 3m 21s\n- cinderlib-tox-py27 http://logs.openstack.org/87/670887/4/check/cinderlib-tox-py27/a437e28/ : SUCCESS in 4m 55s\n- cinderlib-tox-py36 http://logs.openstack.org/87/670887/4/check/cinderlib-tox-py36/2f94fc9/ : SUCCESS in 5m 13s\n- cinderlib-tox-py37 http://logs.openstack.org/87/670887/4/check/cinderlib-tox-py37/3ca595f/ : SUCCESS in 5m 16s\n- cinderlib-lvm-functional http://logs.openstack.org/87/670887/4/check/cinderlib-lvm-functional/0a6e1a3/ : SUCCESS in 7m 40s\n- cinderlib-ceph-functional http://logs.openstack.org/87/670887/4/check/cinderlib-ceph-functional/ae1544c/ : SUCCESS in 7m 49s","accounts_in_message":[],"_revision_number":4},{"id":"af757f2b12581e38a97bd288797dcf807f5e246d","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2019-07-23 16:42:11.000000000","message":"Patch Set 4: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"6935c4ec77c3e08530fbb1632f804296b0e14e50","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-07-24 08:12:33.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"11d5ed27f9e1112ccfde52e84b48285ae8d57aea","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-24 08:23:36.000000000","message":"Patch Set 5: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/87/670887/5/check/openstack-tox-docs/f7cf52e/html/ : SUCCESS in 3m 22s\n- openstack-tox-pep8 http://logs.openstack.org/87/670887/5/check/openstack-tox-pep8/5e43d84/ : SUCCESS in 2m 53s\n- cinderlib-tox-py27 http://logs.openstack.org/87/670887/5/check/cinderlib-tox-py27/ee925c2/ : SUCCESS in 5m 02s\n- cinderlib-tox-py36 http://logs.openstack.org/87/670887/5/check/cinderlib-tox-py36/924f95f/ : FAILURE in 5m 49s\n- cinderlib-tox-py37 http://logs.openstack.org/87/670887/5/check/cinderlib-tox-py37/582b5d9/ : FAILURE in 5m 34s\n- cinderlib-lvm-functional http://logs.openstack.org/87/670887/5/check/cinderlib-lvm-functional/975217c/ : SUCCESS in 8m 59s\n- cinderlib-ceph-functional http://logs.openstack.org/87/670887/5/check/cinderlib-ceph-functional/163edf5/ : SUCCESS in 8m 43s","accounts_in_message":[],"_revision_number":5},{"id":"4eea11bf0fd9575fa456765f318fee62a7e07a98","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-07-24 12:22:33.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"431e1b4adcc1afab95b9bbdc688aa4443b9e5b53","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-24 12:37:25.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/87/670887/6/check/openstack-tox-docs/bcc9143/html/ : SUCCESS in 3m 55s\n- openstack-tox-pep8 http://logs.openstack.org/87/670887/6/check/openstack-tox-pep8/4a694ce/ : SUCCESS in 3m 46s\n- cinderlib-tox-py27 http://logs.openstack.org/87/670887/6/check/cinderlib-tox-py27/3a52d2e/ : SUCCESS in 5m 33s\n- cinderlib-tox-py36 http://logs.openstack.org/87/670887/6/check/cinderlib-tox-py36/a4ca61a/ : SUCCESS in 6m 21s\n- cinderlib-tox-py37 http://logs.openstack.org/87/670887/6/check/cinderlib-tox-py37/f278bf9/ : SUCCESS in 7m 15s\n- cinderlib-lvm-functional http://logs.openstack.org/87/670887/6/check/cinderlib-lvm-functional/c6f2f5e/ : SUCCESS in 9m 05s\n- cinderlib-ceph-functional http://logs.openstack.org/87/670887/6/check/cinderlib-ceph-functional/b4d4579/ : SUCCESS in 9m 17s","accounts_in_message":[],"_revision_number":6},{"id":"4b5c5d7528a825c76509f10a816ee84d7bc339f6","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2019-07-26 11:22:17.000000000","message":"Patch Set 6: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":6},{"id":"f502faaa89d851d86870f20edbc2c77789103450","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-26 11:22:38.000000000","message":"Patch Set 6: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":6},{"id":"7dea7c797fa0b8194aad411ec3abe8c850532541","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-26 14:34:53.000000000","message":"Patch Set 6: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/87/670887/6/gate/openstack-tox-docs/e10414f/html/ : SUCCESS in 5m 24s\n- openstack-tox-pep8 http://logs.openstack.org/87/670887/6/gate/openstack-tox-pep8/a514bd8/ : SUCCESS in 3m 38s\n- cinderlib-tox-py27 http://logs.openstack.org/87/670887/6/gate/cinderlib-tox-py27/22ef7d7/ : SUCCESS in 7m 28s\n- cinderlib-tox-py36 http://logs.openstack.org/87/670887/6/gate/cinderlib-tox-py36/ec5c200/ : SUCCESS in 8m 00s\n- cinderlib-tox-py37 http://logs.openstack.org/87/670887/6/gate/cinderlib-tox-py37/f6cb622/ : SUCCESS in 6m 48s\n- cinderlib-lvm-functional http://logs.openstack.org/87/670887/6/gate/cinderlib-lvm-functional/dd5cf55/ : SUCCESS in 8m 50s\n- cinderlib-ceph-functional http://logs.openstack.org/87/670887/6/gate/cinderlib-ceph-functional/06f4887/ : SUCCESS in 8m 46s","accounts_in_message":[],"_revision_number":6},{"id":"f6a03754789f71b3f16c96380567499e578710a9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-26 14:34:54.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"d6bec909e0a4ab20ec8448f9521485f796d08370","revisions":{"a74d33ddb9ad4b2116f2dc4c221a9101eaf2857e":{"kind":"REWORK","_number":1,"created":"2019-07-15 17:16:45.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/87/670887/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinderlib","ref":"refs/changes/87/670887/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/87/670887/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/87/670887/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/87/670887/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinderlib refs/changes/87/670887/1"}}},"commit":{"parents":[{"commit":"3a6ed6b43a868a1fe76436795ec2a0a1e856667c","subject":"Merge \"add python 3.7 unit test job\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/3a6ed6b43a868a1fe76436795ec2a0a1e856667c"}]}],"author":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2019-07-15 17:11:49.000000000","tz":330},"committer":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2019-07-15 17:16:41.000000000","tz":330},"subject":"Set extra specs for volume","message":"Set extra specs for volume\n\nDuring volume creation, a volume_type and volume_type_id is assigned\nto a volume only when extra_specs is passed.\nThis patch appends a fake extra spec to volume tests so they\u0027re always\nassigned a volume type and similarly for associated snapshots.\n\nThis patch also corrects the functionality where a resource with\n\u0027volume_type_id\u0027 field is assumed to have a \u0027volume_type\u0027 field\nwhich isn\u0027t the case for snapshots.\n\nChange-Id: If7816bf3deb37c526b86b0baed500bebe637bd40\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/a74d33ddb9ad4b2116f2dc4c221a9101eaf2857e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/a74d33ddb9ad4b2116f2dc4c221a9101eaf2857e"}]},"branch":"refs/heads/master"},"911d1dc33a74432ee986eefcae37f31b3abf9523":{"kind":"REWORK","_number":2,"created":"2019-07-18 10:43:55.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/87/670887/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinderlib","ref":"refs/changes/87/670887/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/87/670887/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/87/670887/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/87/670887/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinderlib refs/changes/87/670887/2"}}},"commit":{"parents":[{"commit":"3a6ed6b43a868a1fe76436795ec2a0a1e856667c","subject":"Merge \"add python 3.7 unit test job\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/3a6ed6b43a868a1fe76436795ec2a0a1e856667c"}]}],"author":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2019-07-15 17:11:49.000000000","tz":330},"committer":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2019-07-18 10:41:05.000000000","tz":330},"subject":"Fix: Snapshot creation with volume types","message":"Fix: Snapshot creation with volume types\n\nThis patch corrects the functionality where a resource with\n\u0027volume_type_id\u0027 field is assumed to have a \u0027volume_type\u0027 field\nwhich isn\u0027t the case for snapshots.\nThis patch also adds minimal test coverage for get_changed_fields\nmethod.\n\nCloses-Bug: #1836724\n\nChange-Id: If7816bf3deb37c526b86b0baed500bebe637bd40\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/911d1dc33a74432ee986eefcae37f31b3abf9523"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/911d1dc33a74432ee986eefcae37f31b3abf9523"}]},"branch":"refs/heads/master"},"48b7e6b2a53f22e47de16bd8c4b66e4fac8264f5":{"kind":"REWORK","_number":3,"created":"2019-07-18 10:46:16.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/87/670887/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinderlib","ref":"refs/changes/87/670887/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/87/670887/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/87/670887/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/87/670887/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinderlib refs/changes/87/670887/3"}}},"commit":{"parents":[{"commit":"3a6ed6b43a868a1fe76436795ec2a0a1e856667c","subject":"Merge \"add python 3.7 unit test job\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/3a6ed6b43a868a1fe76436795ec2a0a1e856667c"}]}],"author":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2019-07-15 17:11:49.000000000","tz":330},"committer":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2019-07-18 10:46:02.000000000","tz":330},"subject":"Fix: Snapshot creation with volume types","message":"Fix: Snapshot creation with volume types\n\nThis patch corrects the functionality where a resource with\n\u0027volume_type_id\u0027 field is assumed to have a \u0027volume_type\u0027 field\nwhich isn\u0027t the case for snapshots.\nThis patch also adds minimal test coverage for get_changed_fields\nmethod.\n\nCloses-Bug: #1836724\n\nChange-Id: If7816bf3deb37c526b86b0baed500bebe637bd40\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/48b7e6b2a53f22e47de16bd8c4b66e4fac8264f5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/48b7e6b2a53f22e47de16bd8c4b66e4fac8264f5"}]},"branch":"refs/heads/master"},"2cfb2789b8d9b536762b6a2f87cd395e5bfc82a8":{"kind":"REWORK","_number":4,"created":"2019-07-19 08:38:00.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/87/670887/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinderlib","ref":"refs/changes/87/670887/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/87/670887/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/87/670887/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/87/670887/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinderlib refs/changes/87/670887/4"}}},"commit":{"parents":[{"commit":"3a6ed6b43a868a1fe76436795ec2a0a1e856667c","subject":"Merge \"add python 3.7 unit test job\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/3a6ed6b43a868a1fe76436795ec2a0a1e856667c"}]}],"author":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2019-07-15 17:11:49.000000000","tz":330},"committer":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2019-07-19 08:37:45.000000000","tz":330},"subject":"Fix: Snapshot creation with volume types","message":"Fix: Snapshot creation with volume types\n\nThis patch corrects the functionality where a resource with\n\u0027volume_type_id\u0027 field is assumed to have a \u0027volume_type\u0027 field\nwhich isn\u0027t the case for snapshots.\nThis patch also adds minimal test coverage for get_changed_fields\nmethod.\n\nCloses-Bug: #1836724\n\nChange-Id: If7816bf3deb37c526b86b0baed500bebe637bd40\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/2cfb2789b8d9b536762b6a2f87cd395e5bfc82a8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/2cfb2789b8d9b536762b6a2f87cd395e5bfc82a8"}]},"branch":"refs/heads/master"},"fd9e3cde65b1f0bfd166de2d856e07cf70d54054":{"kind":"REWORK","_number":5,"created":"2019-07-24 08:12:33.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/87/670887/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinderlib","ref":"refs/changes/87/670887/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/87/670887/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/87/670887/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/87/670887/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinderlib refs/changes/87/670887/5"}}},"commit":{"parents":[{"commit":"3a6ed6b43a868a1fe76436795ec2a0a1e856667c","subject":"Merge \"add python 3.7 unit test job\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/3a6ed6b43a868a1fe76436795ec2a0a1e856667c"}]}],"author":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2019-07-15 17:11:49.000000000","tz":330},"committer":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2019-07-24 08:12:17.000000000","tz":330},"subject":"Fix: Snapshot creation with volume types","message":"Fix: Snapshot creation with volume types\n\nThis patch corrects the functionality where a resource with\n\u0027volume_type_id\u0027 field is assumed to have a \u0027volume_type\u0027 field\nwhich isn\u0027t the case for snapshots.\nThis patch also adds minimal test coverage for get_changed_fields\nmethod.\n\nCloses-Bug: #1836724\n\nChange-Id: If7816bf3deb37c526b86b0baed500bebe637bd40\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/fd9e3cde65b1f0bfd166de2d856e07cf70d54054"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/fd9e3cde65b1f0bfd166de2d856e07cf70d54054"}]},"branch":"refs/heads/master"},"d6bec909e0a4ab20ec8448f9521485f796d08370":{"kind":"REWORK","_number":6,"created":"2019-07-24 12:22:33.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/87/670887/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinderlib","ref":"refs/changes/87/670887/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/87/670887/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/87/670887/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/87/670887/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinderlib refs/changes/87/670887/6"}}},"commit":{"parents":[{"commit":"c44afc95afc70a91761c86ca0523b6a125f3edb9","subject":"Fix cleanup of persistence tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/c44afc95afc70a91761c86ca0523b6a125f3edb9"}]}],"author":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2019-07-15 17:11:49.000000000","tz":330},"committer":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2019-07-24 12:20:36.000000000","tz":330},"subject":"Fix: Snapshot creation with volume types","message":"Fix: Snapshot creation with volume types\n\nThis patch corrects the functionality where a resource with\n\u0027volume_type_id\u0027 field is assumed to have a \u0027volume_type\u0027 field\nwhich isn\u0027t the case for snapshots.\nThis patch also adds minimal test coverage for get_changed_fields\nmethod.\n\nCloses-Bug: #1836724\n\nChange-Id: If7816bf3deb37c526b86b0baed500bebe637bd40\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/d6bec909e0a4ab20ec8448f9521485f796d08370"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/d6bec909e0a4ab20ec8448f9521485f796d08370"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}