)]}'
{"id":"openstack%2Fcinderlib~672508","triplet_id":"openstack%2Fcinderlib~master~I29847f7a8de49625882145c3eff7983ff8d01265","project":"openstack/cinderlib","branch":"master","topic":"fix-persistence-tests-cleanup","hashtags":[],"change_id":"I29847f7a8de49625882145c3eff7983ff8d01265","subject":"Fix cleanup of persistence tests","status":"MERGED","created":"2019-07-24 12:06:01.000000000","updated":"2019-07-25 18:16:42.000000000","submitted":"2019-07-25 18:16:42.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"672508-1564078602783-67437c28","meta_rev_id":"6ea3ba052be82d28f443a4745bd0020655e971a7","_number":672508,"virtual_id_number":672508,"owner":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-07-25 18:16:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},{"value":0,"date":"2019-07-24 16:31:08.000000000","_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-07-24 13:39:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"value":2,"date":"2019-07-25 15:56:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"value":1,"date":"2019-07-25 15:56:28.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-24 13:39:29.000000000","updated_by":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"reviewer":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"state":"REVIEWER"},{"updated":"2019-07-25 15:56:28.000000000","updated_by":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"reviewer":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"state":"REVIEWER"},{"updated":"2019-07-25 18:16:42.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"5950ca0796bd2defaf9d11e3474c2fbe3cd94bed","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2019-07-24 12:06:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"25e2fcac6c2a5d30bdff4a60a0873621e7ab3dff","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-24 12:23:52.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/08/672508/1/check/openstack-tox-docs/29abd94/html/ : SUCCESS in 4m 28s\n- openstack-tox-pep8 http://logs.openstack.org/08/672508/1/check/openstack-tox-pep8/491cbf5/ : SUCCESS in 4m 23s\n- cinderlib-tox-py27 http://logs.openstack.org/08/672508/1/check/cinderlib-tox-py27/1a1dc62/ : SUCCESS in 7m 41s\n- cinderlib-tox-py36 http://logs.openstack.org/08/672508/1/check/cinderlib-tox-py36/83fd260/ : SUCCESS in 5m 40s\n- cinderlib-tox-py37 http://logs.openstack.org/08/672508/1/check/cinderlib-tox-py37/4b3e764/ : SUCCESS in 5m 37s\n- cinderlib-lvm-functional http://logs.openstack.org/08/672508/1/check/cinderlib-lvm-functional/be2f327/ : SUCCESS in 8m 58s\n- cinderlib-ceph-functional http://logs.openstack.org/08/672508/1/check/cinderlib-ceph-functional/448f76c/ : SUCCESS in 9m 17s","accounts_in_message":[],"_revision_number":1},{"id":"b807ac62dbc17a875e077870bdd19710ebaada34","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-07-24 13:39:29.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)\n\nLGTM. thanks!","accounts_in_message":[],"_revision_number":1},{"id":"1343104f6ff78c19cc43b080482c224dfc560160","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2019-07-24 16:31:08.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"aff4eca50c6763f0b290827cdc72a882c57ec098","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2019-07-25 15:56:28.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"4c36709d5a8f6a60aeae646cd7eda0e7cdbbbe1d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-25 15:56:52.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"88602cd03682529be20bec4937d2bf3751ef04db","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-25 18:16:42.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/08/672508/1/gate/openstack-tox-docs/df6c6b5/html/ : SUCCESS in 4m 43s\n- openstack-tox-pep8 http://logs.openstack.org/08/672508/1/gate/openstack-tox-pep8/3267cf1/ : SUCCESS in 3m 45s\n- cinderlib-tox-py27 http://logs.openstack.org/08/672508/1/gate/cinderlib-tox-py27/0920f8a/ : SUCCESS in 9m 19s\n- cinderlib-tox-py36 http://logs.openstack.org/08/672508/1/gate/cinderlib-tox-py36/83964fd/ : SUCCESS in 6m 43s\n- cinderlib-tox-py37 http://logs.openstack.org/08/672508/1/gate/cinderlib-tox-py37/e8aafbf/ : SUCCESS in 6m 20s\n- cinderlib-lvm-functional http://logs.openstack.org/08/672508/1/gate/cinderlib-lvm-functional/22e1c48/ : SUCCESS in 10m 04s\n- cinderlib-ceph-functional http://logs.openstack.org/08/672508/1/gate/cinderlib-ceph-functional/fface1e/ : SUCCESS in 12m 18s","accounts_in_message":[],"_revision_number":1},{"id":"9c7664f3d03f32cf392926f0f4f316421c3f4222","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-25 18:16:42.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c44afc95afc70a91761c86ca0523b6a125f3edb9","revisions":{"c44afc95afc70a91761c86ca0523b6a125f3edb9":{"kind":"REWORK","_number":1,"created":"2019-07-24 12:06:01.000000000","uploader":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"ref":"refs/changes/08/672508/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinderlib","ref":"refs/changes/08/672508/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/08/672508/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/08/672508/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/08/672508/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinderlib refs/changes/08/672508/1"}}},"commit":{"parents":[{"commit":"a18218ad0d49d0dda91a0ac610a81ae9f0d2f302","subject":"Add Python 3 Train unit tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/a18218ad0d49d0dda91a0ac610a81ae9f0d2f302"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2019-07-24 11:59:00.000000000","tz":120},"committer":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2019-07-24 11:59:00.000000000","tz":120},"subject":"Fix cleanup of persistence tests","message":"Fix cleanup of persistence tests\n\nCinderlib is designed to only have 1 persitent plugin loaded through\nthe whole life of the application, so our unit tests have to work around\nthis by cleaning things up manually, which they are not doing correctly.\n\nCurrent code runs fine because test_dbms.py goes before test_memory.py,\nbut if we rename the test_memory.py to test_a.py then we\u0027ll start seing\n\"IndexError: list index out of range\" errors.\n\nThere are 2 issues with the current code:\n\n- We are not cleaning up properly after the memory persistence test\n  because we are changing instance attributes instead of the class\n  attributes.  We resolve this calling the clear method instead.\n\n- We are not taking into account that the memory persistency plugin\n  changes some of the OVO methods, so we need to restore them after\n  the tests.\n\nChange-Id: I29847f7a8de49625882145c3eff7983ff8d01265\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/c44afc95afc70a91761c86ca0523b6a125f3edb9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/c44afc95afc70a91761c86ca0523b6a125f3edb9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}