)]}'
{"id":"openstack%2Fcinderlib~696375","triplet_id":"openstack%2Fcinderlib~master~I62e992804a3ae6aa0b4aa4f883807783197d4b33","project":"openstack/cinderlib","branch":"master","topic":"bug/1854188","hashtags":[],"change_id":"I62e992804a3ae6aa0b4aa4f883807783197d4b33","subject":"Fix complex configuration options","status":"MERGED","created":"2019-11-27 17:57:06.000000000","updated":"2020-01-10 02:19:57.000000000","submitted":"2019-12-10 17:42:42.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"696375-1575999762465-51380ceb","meta_rev_id":"11692e4438e4538aa3fea8cd301264ac0aeda5e5","_number":696375,"virtual_id_number":696375,"owner":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-12-04 04:16:50.000000000","_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},{"value":0,"date":"2019-12-04 05:32:46.000000000","_account_id":12016,"name":"DellEMC PowerMAX CI","email":"emc.vmax.ci@emc.com","username":"emc-vmax-ci","tags":["SERVICE_USER"]},{"value":0,"date":"2019-11-27 22:47:42.000000000","_account_id":12033,"name":"DellEMC XtremIO CI","email":"emc.xio.ci@emc.com","username":"emc-xio-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-12-10 17:42:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"all":[{"value":0,"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},{"value":0,"_account_id":12016,"name":"DellEMC PowerMAX CI","email":"emc.vmax.ci@emc.com","username":"emc-vmax-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":12033,"name":"DellEMC XtremIO CI","email":"emc.xio.ci@emc.com","username":"emc-xio-ci","tags":["SERVICE_USER"]},{"value":2,"date":"2019-12-05 03:55:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":2,"date":"2019-12-10 14:29:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"all":[{"value":0,"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},{"value":0,"_account_id":12016,"name":"DellEMC PowerMAX CI","email":"emc.vmax.ci@emc.com","username":"emc-vmax-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":12033,"name":"DellEMC XtremIO CI","email":"emc.xio.ci@emc.com","username":"emc-xio-ci","tags":["SERVICE_USER"]},{"value":1,"date":"2019-12-10 14:37:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},{"value":0,"_account_id":12016,"name":"DellEMC PowerMAX CI","email":"emc.vmax.ci@emc.com","username":"emc-vmax-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":12033,"name":"DellEMC XtremIO CI","email":"emc.xio.ci@emc.com","username":"emc-xio-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"_account_id":12016,"name":"DellEMC PowerMAX CI","email":"emc.vmax.ci@emc.com","username":"emc-vmax-ci","tags":["SERVICE_USER"]},{"_account_id":12033,"name":"DellEMC XtremIO CI","email":"emc.xio.ci@emc.com","username":"emc-xio-ci","tags":["SERVICE_USER"]},{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-11-27 22:47:42.000000000","updated_by":{"_account_id":12033,"name":"DellEMC XtremIO CI","email":"emc.xio.ci@emc.com","username":"emc-xio-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":12033,"name":"DellEMC XtremIO CI","email":"emc.xio.ci@emc.com","username":"emc-xio-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-12-04 04:16:50.000000000","updated_by":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"reviewer":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"state":"REVIEWER"},{"updated":"2019-12-04 05:32:46.000000000","updated_by":{"_account_id":12016,"name":"DellEMC PowerMAX CI","email":"emc.vmax.ci@emc.com","username":"emc-vmax-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":12016,"name":"DellEMC PowerMAX CI","email":"emc.vmax.ci@emc.com","username":"emc-vmax-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-12-10 14:29:05.000000000","updated_by":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"reviewer":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"state":"REVIEWER"},{"updated":"2019-12-10 14:37:38.000000000","updated_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"reviewer":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"state":"REVIEWER"},{"updated":"2019-12-10 17:42:42.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"1e5ca7dd5893138017b8ed72b258723aef78275e","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2019-11-27 17:57:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5274000997e5399bb09b9e167ebf4611aa0dd2cd","author":{"_account_id":12033,"name":"DellEMC XtremIO CI","email":"emc.xio.ci@emc.com","username":"emc-xio-ci","tags":["SERVICE_USER"]},"date":"2019-11-27 19:17:17.000000000","message":"Patch Set 1:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- DellEMC_XtremIO_FC-cl http://publiclogs.emc.com/75/696375/1/check/DellEMC_XtremIO_FC-cl/a2015be/DellEMC_XtremIO_FC-cl/8 : FAILURE in 4m 20s\n- DellEMC_XtremIO_iSCSI-cl http://publiclogs.emc.com/75/696375/1/check/DellEMC_XtremIO_iSCSI-cl/fe22d7a/DellEMC_XtremIO_iSCSI-cl/19 : FAILURE in 1m 59s\n\nLeave a comment with \u0027run-DellEMC XtremIO CI\u0027 to trigger a recheck, for more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_XtremIO_CI","accounts_in_message":[],"_revision_number":1},{"id":"583e698b984a0614e8b62f0aa72f5d681baa6abd","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-27 19:57:22.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2f4df8fd11a64537adff5c8382ac9e09 : SUCCESS in 7m 01s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/04f2634891d04b26b59921d37e86ac3d : SUCCESS in 4m 47s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ce77b99c402f422094ab23c3d7a5f50e : SUCCESS in 4m 04s\n- cinderlib-tox-py27 https://zuul.opendev.org/t/openstack/build/f8f25156efc741a3b9d201d70193b38e : FAILURE in 6m 11s\n- cinderlib-tox-py36 https://zuul.opendev.org/t/openstack/build/c8d87c835e754ed39b3ea9f1ec9f708d : SUCCESS in 5m 30s\n- cinderlib-tox-py37 https://zuul.opendev.org/t/openstack/build/9b19982267f243a6b1c7bf78a450350e : SUCCESS in 5m 29s\n- cinderlib-lvm-functional https://zuul.opendev.org/t/openstack/build/06356b18602045c7ad6031a393f7dbc5 : SUCCESS in 8m 59s\n- cinderlib-ceph-functional https://zuul.opendev.org/t/openstack/build/761d5db2a0ab4dc38bf374e2285356c5 : SUCCESS in 9m 17s","accounts_in_message":[],"_revision_number":1},{"id":"628944d6ccf311daa71f3329b3a5e7fa71596df4","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2019-11-27 21:22:57.000000000","message":"Patch Set 1:\n\nError in patch #1 is because I didn\u0027t take into account hash randomization, fixing it in patch #2","accounts_in_message":[],"_revision_number":1},{"id":"dd34f023a4359f79e05e682aa0175f08164661f1","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2019-11-27 21:23:16.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"171ea41cd22be6eb0d1d89be983dd9d8eb75df55","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-27 21:36:49.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3a229084e1fa4a0eab285a18be47305e : SUCCESS in 6m 51s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/5c2be7ce8f8b4ca0ad08a8f5483c35d1 : SUCCESS in 3m 48s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b0b8b1a5c8de47b98ce708a28736d8f6 : SUCCESS in 3m 41s\n- cinderlib-tox-py27 https://zuul.opendev.org/t/openstack/build/bd1d8713d6dc412999e2403f88078544 : SUCCESS in 5m 25s\n- cinderlib-tox-py36 https://zuul.opendev.org/t/openstack/build/c5f0deea76794d44ba38cf539433f606 : SUCCESS in 5m 12s\n- cinderlib-tox-py37 https://zuul.opendev.org/t/openstack/build/93c03eee0bc64e5d8c43c20ca2c477cd : SUCCESS in 5m 44s\n- cinderlib-lvm-functional https://zuul.opendev.org/t/openstack/build/bda3e524dc184690978e041ae93f5516 : SUCCESS in 8m 14s\n- cinderlib-ceph-functional https://zuul.opendev.org/t/openstack/build/4d349f31e3654e92b5dd03098cfee906 : SUCCESS in 8m 53s","accounts_in_message":[],"_revision_number":2},{"id":"16a5419fb8a2694a88edaa9ba910522a5bfc5cf1","author":{"_account_id":12033,"name":"DellEMC XtremIO CI","email":"emc.xio.ci@emc.com","username":"emc-xio-ci","tags":["SERVICE_USER"]},"date":"2019-11-27 22:47:42.000000000","message":"Patch Set 2:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- DellEMC_XtremIO_FC-cl http://publiclogs.emc.com/75/696375/2/check/DellEMC_XtremIO_FC-cl/acb01d0/DellEMC_XtremIO_FC-cl/9 : FAILURE in 4m 14s\n- DellEMC_XtremIO_iSCSI-cl http://publiclogs.emc.com/75/696375/2/check/DellEMC_XtremIO_iSCSI-cl/f4d0f5a/DellEMC_XtremIO_iSCSI-cl/20 : FAILURE in 2m 01s\n\nLeave a comment with \u0027run-DellEMC XtremIO CI\u0027 to trigger a recheck, for more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_XtremIO_CI","accounts_in_message":[],"_revision_number":2},{"id":"95810427d341fe321db598a6f8b94afbf019e4f0","author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"date":"2019-12-04 03:43:17.000000000","message":"Patch Set 2:\n\nrun-DellEMC PowerMAX CI","accounts_in_message":[],"_revision_number":2},{"id":"caabb186381d52176d1ef32accfdc60cbfa7e164","author":{"_account_id":12016,"name":"DellEMC PowerMAX CI","email":"emc.vmax.ci@emc.com","username":"emc-vmax-ci","tags":["SERVICE_USER"]},"date":"2019-12-04 04:14:07.000000000","message":"Patch Set 2:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- DellEMC_PowerMAX_FC-cl http://publiclogs.emc.com/75/696375/2/check/DellEMC_PowerMAX_FC-cl/964e1c1/DellEMC_PowerMAX_FC-cl/1 : FAILURE in 30m 41s\n- DellEMC_PowerMAX_iSCSI-cl http://publiclogs.emc.com/75/696375/2/check/DellEMC_PowerMAX_iSCSI-cl/adcaef5/DellEMC_PowerMAX_iSCSI-cl/1 : FAILURE in 0s\n\nLeave a comment with \u0027run-DellEMC PowerMAX CI\u0027 to trigger a recheck. For more information about this CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_PowerMAX_CI","accounts_in_message":[],"_revision_number":2},{"id":"52c4e32745792af8076879107fc645e1633755e4","author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"date":"2019-12-04 04:16:50.000000000","message":"Patch Set 2:\n\nrun-DellEMC PowerMAX CI","accounts_in_message":[],"_revision_number":2},{"id":"67121614b179118d0907f47d17d96b330887b2f2","author":{"_account_id":12016,"name":"DellEMC PowerMAX CI","email":"emc.vmax.ci@emc.com","username":"emc-vmax-ci","tags":["SERVICE_USER"]},"date":"2019-12-04 05:32:46.000000000","message":"Patch Set 2:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- DellEMC_PowerMAX_FC-cl http://publiclogs.emc.com/75/696375/2/check/DellEMC_PowerMAX_FC-cl/9c01071/DellEMC_PowerMAX_FC-cl/2 : FAILURE in 29m 41s\n- DellEMC_PowerMAX_iSCSI-cl http://publiclogs.emc.com/75/696375/2/check/DellEMC_PowerMAX_iSCSI-cl/e51553f/DellEMC_PowerMAX_iSCSI-cl/2 : FAILURE in 1h 15m 47s\n\nLeave a comment with \u0027run-DellEMC PowerMAX CI\u0027 to trigger a recheck. For more information about this CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_PowerMAX_CI","accounts_in_message":[],"_revision_number":2},{"id":"f9d326b4a213bbb78bb8b61f7d4868ceade9cf96","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2019-12-05 03:55:09.000000000","message":"Patch Set 2: Code-Review+2\n\n(2 comments)\n\nLGTM.  Thanks for the detailed commit message.","accounts_in_message":[],"_revision_number":2},{"id":"e0fd9ac9ef27f73cd0acea1829ecb69667cdf107","author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"date":"2019-12-10 14:29:05.000000000","message":"Patch Set 2: Code-Review+2\n\nLGTM.  I don\u0027t do a lot reviews to cinderlib, so I\u0027m not feeling OK to approve the patch","accounts_in_message":[],"_revision_number":2},{"id":"54a37227da40114f10e05a1ba79804e15c1c6c18","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2019-12-10 14:37:38.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"5e4c84c42be9b5abe7e7438a35a24f66b9368937","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-10 14:38:01.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"8d517efe78eb0ef23910d72697825a18fc37d7cc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-10 17:42:42.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"f7ce3811894621a1f81f7706173fa31d0acca245","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-10 17:42:42.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3097a2a5a93b48f39b5a441f195d8467 : SUCCESS in 11m 03s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/04632c28252c436e990f19a853f3cad5 : SUCCESS in 6m 41s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c0a80c46eb934d00b16ba3a708a35264 : SUCCESS in 4m 56s\n- cinderlib-tox-py27 https://zuul.opendev.org/t/openstack/build/f708a27038ce4948989cfc026762b081 : SUCCESS in 14m 30s\n- cinderlib-tox-py36 https://zuul.opendev.org/t/openstack/build/0a049cba07644968a203da0a85e3eb4b : SUCCESS in 6m 29s\n- cinderlib-tox-py37 https://zuul.opendev.org/t/openstack/build/0ce98bb07e1540a2a2604b97a15570e9 : SUCCESS in 5m 57s\n- cinderlib-lvm-functional https://zuul.opendev.org/t/openstack/build/e98f5e29a6a042e199832d1406be5b2c : SUCCESS in 9m 03s\n- cinderlib-ceph-functional https://zuul.opendev.org/t/openstack/build/2b4335773716451d9d4d597998028f79 : SUCCESS in 9m 56s","accounts_in_message":[],"_revision_number":2},{"id":"e17201f4c31ef6d102b3e8e0c5771e5953d32619","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-10 17:44:03.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7910f094b4924c27bb38c0d666d93e16 : SUCCESS in 59s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/c3943c5f88104691ad81948676addbab : SUCCESS in 56s","accounts_in_message":[],"_revision_number":2},{"id":"a7b09e1b4b3b8adb1b95c7b4c561e5702231e7e4","author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"date":"2020-01-10 02:19:57.000000000","message":"Patch Set 2:\n\nrun-DellEMC XtremIO CI","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"085cb4e4327624dd76f00f2d34aa2bf28a470d8c","revisions":{"11eac8e9cc5ae6edc482d92f0d9127acdd5bcd18":{"kind":"REWORK","_number":1,"created":"2019-11-27 17:57:06.000000000","uploader":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"ref":"refs/changes/75/696375/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinderlib","ref":"refs/changes/75/696375/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/75/696375/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/75/696375/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/75/696375/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinderlib refs/changes/75/696375/1"}}},"commit":{"parents":[{"commit":"b74a3f04b3b1b182a1c36fb5672e87d722fee695","subject":"Fix Python 3 functional tests run","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/b74a3f04b3b1b182a1c36fb5672e87d722fee695"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2019-11-27 17:32:17.000000000","tz":60},"committer":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2019-11-27 17:32:52.000000000","tz":60},"subject":"Fix complex configuration options","message":"Fix complex configuration options\n\nCinderlib cannot properly load configuration options of the type\nListOpt, or MultiOpt where each item is a dictionary, or DictOpt...\n\nFor example, when we try to load a ListOpt option we will see:\n\n  oslo_config.cfg.ConfigFileValueError: Value for option XYZ from\n  LocationInfo(location\u003d\u003cLocations.user: (4, True)\u003e,\n  detail\u003d\u0027/home/me/in_memory_file\u0027) is not valid: Value should start\n  with \"[\"\n\nThis is because cinderlib is treating this option as a MultiOpt.\n\nCinderlib used to just set the values of the options in the instance and\npass it to the driver, and back then we had no problems with complex\ntypes.\n\nThe problem with that approach is that there are some drivers (like\nNetApp\u0027s) that dynamically add configuration options and then force a\nreload of the file, and they couldn\u0027t work with our old approach.\n\nSo we changed to used oslo.config\u0027s normal parsing of files, but to do\nthat we had to convert the driver parameters passed to cinderlib to a\nconfig file and make the parser use a StringIO instance instead of a\nreal file.  We also had to prevent it from looking at the CLI options\n(since those belong to the program that imports the library).\n\nThis new approach is more complex, because cinderlib receives the\nparameters as Python primitives (list, dicts, integers, etc.), but the\nOslo config parser expects an INI file conforming to the non standard\ntypes it provides.\n\nSome of these non standar types are:\n\n- DictOpt is in the form:\n     option \u003d key1:value1,key2:value2\n\n- MultiOpt is in the form:\n     option \u003d value1\n     option \u003d value2\n\n- ListOpt is in the form:\n     option \u003d [value1,value2]\n\nSo cinderlib would receive a list [value1, value2] or a tuple (value1,\nvalue2) and needs to generate a string with the right configuration\noption which can be in the form of a MultiOpt or a ListOpt, depending on\nhow the configuration option was defined.\n\nThis patch adds more logic to the conversion of cinder driver\nconfiguration parameters to oslo config file and uses the configuration\noptions definitions to decide what conversion needs to be done.\n\nWith this change we now do the right converstion for ListOpt, DictOpt,\nand we can even support MultiOpt options that have dictionaries as\nitems.\n\nCloses-Bug: #1854188\nChange-Id: I62e992804a3ae6aa0b4aa4f883807783197d4b33\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/11eac8e9cc5ae6edc482d92f0d9127acdd5bcd18"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/11eac8e9cc5ae6edc482d92f0d9127acdd5bcd18"}]},"branch":"refs/heads/master"},"085cb4e4327624dd76f00f2d34aa2bf28a470d8c":{"kind":"REWORK","_number":2,"created":"2019-11-27 21:23:16.000000000","uploader":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"ref":"refs/changes/75/696375/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinderlib","ref":"refs/changes/75/696375/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/75/696375/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/75/696375/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/75/696375/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinderlib refs/changes/75/696375/2"}}},"commit":{"parents":[{"commit":"b74a3f04b3b1b182a1c36fb5672e87d722fee695","subject":"Fix Python 3 functional tests run","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/b74a3f04b3b1b182a1c36fb5672e87d722fee695"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2019-11-27 17:32:17.000000000","tz":60},"committer":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2019-11-27 21:23:07.000000000","tz":60},"subject":"Fix complex configuration options","message":"Fix complex configuration options\n\nCinderlib cannot properly load configuration options of the type\nListOpt, or MultiOpt where each item is a dictionary, or DictOpt...\n\nFor example, when we try to load a ListOpt option we will see:\n\n  oslo_config.cfg.ConfigFileValueError: Value for option XYZ from\n  LocationInfo(location\u003d\u003cLocations.user: (4, True)\u003e,\n  detail\u003d\u0027/home/me/in_memory_file\u0027) is not valid: Value should start\n  with \"[\"\n\nThis is because cinderlib is treating this option as a MultiOpt.\n\nCinderlib used to just set the values of the options in the instance and\npass it to the driver, and back then we had no problems with complex\ntypes.\n\nThe problem with that approach is that there are some drivers (like\nNetApp\u0027s) that dynamically add configuration options and then force a\nreload of the file, and they couldn\u0027t work with our old approach.\n\nSo we changed to used oslo.config\u0027s normal parsing of files, but to do\nthat we had to convert the driver parameters passed to cinderlib to a\nconfig file and make the parser use a StringIO instance instead of a\nreal file.  We also had to prevent it from looking at the CLI options\n(since those belong to the program that imports the library).\n\nThis new approach is more complex, because cinderlib receives the\nparameters as Python primitives (list, dicts, integers, etc.), but the\nOslo config parser expects an INI file conforming to the non standard\ntypes it provides.\n\nSome of these non standar types are:\n\n- DictOpt is in the form:\n     option \u003d key1:value1,key2:value2\n\n- MultiOpt is in the form:\n     option \u003d value1\n     option \u003d value2\n\n- ListOpt is in the form:\n     option \u003d [value1,value2]\n\nSo cinderlib would receive a list [value1, value2] or a tuple (value1,\nvalue2) and needs to generate a string with the right configuration\noption which can be in the form of a MultiOpt or a ListOpt, depending on\nhow the configuration option was defined.\n\nThis patch adds more logic to the conversion of cinder driver\nconfiguration parameters to oslo config file and uses the configuration\noptions definitions to decide what conversion needs to be done.\n\nWith this change we now do the right converstion for ListOpt, DictOpt,\nand we can even support MultiOpt options that have dictionaries as\nitems.\n\nCloses-Bug: #1854188\nChange-Id: I62e992804a3ae6aa0b4aa4f883807783197d4b33\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/085cb4e4327624dd76f00f2d34aa2bf28a470d8c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/085cb4e4327624dd76f00f2d34aa2bf28a470d8c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}