)]}'
{"id":"openstack%2Fcinderlib~699203","triplet_id":"openstack%2Fcinderlib~master~I67fbf8e9d7ee79f3d6617b4d0ae755dae0e1987a","project":"openstack/cinderlib","branch":"master","topic":"bug/1854188","hashtags":[],"change_id":"I67fbf8e9d7ee79f3d6617b4d0ae755dae0e1987a","subject":"Fix configuration options","status":"MERGED","created":"2019-12-16 12:53:43.000000000","updated":"2019-12-19 17:03:02.000000000","submitted":"2019-12-19 17:01:23.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"699203-1576774883815-fead5b33","meta_rev_id":"0f5faead0e0b42bc29991fbe60930fe828279299","_number":699203,"virtual_id_number":699203,"owner":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":12016,"name":"DellEMC PowerMAX CI","email":"emc.vmax.ci@emc.com","username":"emc-vmax-ci","tags":["SERVICE_USER"]},{"value":0,"date":"2019-12-19 11:52:22.000000000","_account_id":12033,"name":"DellEMC XtremIO CI","email":"emc.xio.ci@emc.com","username":"emc-xio-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-12-19 17:01:23.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":2,"date":"2019-12-19 13:01:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":12016,"name":"DellEMC PowerMAX CI","email":"emc.vmax.ci@emc.com","username":"emc-vmax-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":12033,"name":"DellEMC XtremIO CI","email":"emc.xio.ci@emc.com","username":"emc-xio-ci","tags":["SERVICE_USER"]},{"value":2,"date":"2019-12-19 12:58:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":1,"date":"2019-12-19 13:01:11.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":12016,"name":"DellEMC PowerMAX CI","email":"emc.vmax.ci@emc.com","username":"emc-vmax-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":12033,"name":"DellEMC XtremIO CI","email":"emc.xio.ci@emc.com","username":"emc-xio-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"approved":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":12016,"name":"DellEMC PowerMAX CI","email":"emc.vmax.ci@emc.com","username":"emc-vmax-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":12033,"name":"DellEMC XtremIO CI","email":"emc.xio.ci@emc.com","username":"emc-xio-ci","tags":["SERVICE_USER"]},{"value":2,"date":"2019-12-19 12:59:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":12016,"name":"DellEMC PowerMAX CI","email":"emc.vmax.ci@emc.com","username":"emc-vmax-ci","tags":["SERVICE_USER"]},{"_account_id":12033,"name":"DellEMC XtremIO CI","email":"emc.xio.ci@emc.com","username":"emc-xio-ci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-12-16 16:33:11.000000000","updated_by":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"reviewer":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"state":"REVIEWER"},{"updated":"2019-12-17 11:54:06.000000000","updated_by":{"_account_id":12016,"name":"DellEMC PowerMAX CI","email":"emc.vmax.ci@emc.com","username":"emc-vmax-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":12016,"name":"DellEMC PowerMAX CI","email":"emc.vmax.ci@emc.com","username":"emc-vmax-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-12-19 11:52:22.000000000","updated_by":{"_account_id":12033,"name":"DellEMC XtremIO CI","email":"emc.xio.ci@emc.com","username":"emc-xio-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":12033,"name":"DellEMC XtremIO CI","email":"emc.xio.ci@emc.com","username":"emc-xio-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-12-19 12:59:58.000000000","updated_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"reviewer":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"state":"REVIEWER"},{"updated":"2019-12-19 13:01:11.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2019-12-19 17:01:23.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"22cbc79912685984f799b8dc6c6af55eb641ba22","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2019-12-16 12:53:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6d1272845f79defc8be846a6ea9a7ece145d9980","author":{"_account_id":12033,"name":"DellEMC XtremIO CI","email":"emc.xio.ci@emc.com","username":"emc-xio-ci","tags":["SERVICE_USER"]},"date":"2019-12-16 12:58:41.000000000","message":"Patch Set 1:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- DellEMC_XtremIO_FC-cl http://publiclogs.emc.com/03/699203/1/check/DellEMC_XtremIO_FC-cl/1f536ff/DellEMC_XtremIO_FC-cl/14 : FAILURE in 4m 44s\n- DellEMC_XtremIO_iSCSI-cl http://publiclogs.emc.com/03/699203/1/check/DellEMC_XtremIO_iSCSI-cl/d0ad273/DellEMC_XtremIO_iSCSI-cl/25 : FAILURE in 2m 25s\n\nLeave a comment with \u0027run-DellEMC XtremIO CI\u0027 to trigger a recheck, for more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_XtremIO_CI","accounts_in_message":[],"_revision_number":1},{"id":"85ea6820cbfa44da5ed236baa221d1255653c830","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-16 13:15:38.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/31e0fcd943074513b564d9c20fc51b29 : SUCCESS in 9m 15s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/42509bd614d647e383f0ea26ddbde019 : SUCCESS in 4m 11s\n- cinderlib-tox-py27 https://zuul.opendev.org/t/openstack/build/524f46e15e2c40ef9ee5cff3138cb730 : SUCCESS in 17m 25s\n- cinderlib-tox-py36 https://zuul.opendev.org/t/openstack/build/f71fed111c45452e9620909680b8fbe9 : SUCCESS in 7m 52s\n- cinderlib-tox-py37 https://zuul.opendev.org/t/openstack/build/1e447e36d5904c6c93ebe45ae039541e : SUCCESS in 7m 03s\n- cinderlib-lvm-functional https://zuul.opendev.org/t/openstack/build/9f54846ae3364b54a048c42b8c326d3e : SUCCESS in 9m 30s\n- cinderlib-ceph-functional https://zuul.opendev.org/t/openstack/build/2338e363e585442b804717b2a6e447ba : SUCCESS in 9m 05s","accounts_in_message":[],"_revision_number":1},{"id":"d8781d045697039d101ffd193f37a0c0942612ef","author":{"_account_id":12033,"name":"DellEMC XtremIO CI","email":"emc.xio.ci@emc.com","username":"emc-xio-ci","tags":["SERVICE_USER"]},"date":"2019-12-16 13:20:36.000000000","message":"Patch Set 1:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- DellEMC_XtremIO_FC-cl http://publiclogs.emc.com/03/699203/1/check/DellEMC_XtremIO_FC-cl/9642a59/DellEMC_XtremIO_FC-cl/15 : FAILURE in 4m 45s\n- DellEMC_XtremIO_iSCSI-cl http://publiclogs.emc.com/03/699203/1/check/DellEMC_XtremIO_iSCSI-cl/1648a83/DellEMC_XtremIO_iSCSI-cl/26 : FAILURE in 2m 30s\n\nLeave a comment with \u0027run-DellEMC XtremIO CI\u0027 to trigger a recheck, for more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_XtremIO_CI","accounts_in_message":[],"_revision_number":1},{"id":"53d784ae34d1d3a72ac96ae8c5cefca15a4e5dbb","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2019-12-16 16:32:36.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b1d1164d103ac2a5bc30d4f783f13b0001af2533","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2019-12-16 17:12:40.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)\n\nI share Sean\u0027s concern.  I think the thing to do here is flag it as something to pursue with the oslo team during ussuri, but go ahead and merge this bugfix now so we can backport it to stable/train, where it\u0027s needed and hopefully will be safe from private members being changed in oslo.config.","accounts_in_message":[],"_revision_number":1},{"id":"b98afe4317411c45ea5295f4c03ed5b14037559c","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2019-12-16 19:01:23.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"a3acf7b709f5313a798cd51767a7f0cc2d35be3b","author":{"_account_id":12016,"name":"DellEMC PowerMAX CI","email":"emc.vmax.ci@emc.com","username":"emc-vmax-ci","tags":["SERVICE_USER"]},"date":"2019-12-17 11:54:06.000000000","message":"Patch Set 1:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- DellEMC_PowerMAX_FC-cl http://publiclogs.emc.com/03/699203/1/check/DellEMC_PowerMAX_FC-cl/02af8ef/DellEMC_PowerMAX_FC-cl/9 : FAILURE in 32m 11s\n- DellEMC_PowerMAX_iSCSI-cl http://publiclogs.emc.com/03/699203/1/check/DellEMC_PowerMAX_iSCSI-cl/6ada5b0/DellEMC_PowerMAX_iSCSI-cl/9 : FAILURE in 1h 17m 35s\n\nLeave a comment with \u0027run-DellEMC PowerMAX CI\u0027 to trigger a recheck. For more information about this CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_PowerMAX_CI","accounts_in_message":[],"_revision_number":1},{"id":"4f51f9cce1cab4438f362d5eb23972631d7d1660","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2019-12-18 18:03:37.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"622ac397966e1269f7c60ee5f360115ff11e700b","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2019-12-18 18:07:08.000000000","message":"Patch Set 2:\n\nI haven\u0027t run the full functional tests, but I have done a couple of manual tests on: LVM, K2, QNAP, 3PAR, Dataontap\n\nI have also confirmed that the code generated by cinderlib\u0027s `cinder-cfg-to-cinderlib-code` tool is still valid for this way of validating configuration.","accounts_in_message":[],"_revision_number":2},{"id":"2ba930a1bd68f96a93968942bf347d0aa7957028","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2019-12-18 18:10:18.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"b33993f5277a5083327243479cd9147b116ccb73","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-18 18:26:06.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3cbe831000ae406d8ab55d940015c7a2 : SUCCESS in 6m 44s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ba740aa669b44704afab9581a1ba4d31 : SUCCESS in 4m 21s\n- cinderlib-tox-py27 https://zuul.opendev.org/t/openstack/build/66cc41579d864e49ac4f06d95beccf56 : FAILURE in 5m 49s\n- cinderlib-tox-py36 https://zuul.opendev.org/t/openstack/build/73051539571a45b3a39bbdca25a33227 : SUCCESS in 5m 22s\n- cinderlib-tox-py37 https://zuul.opendev.org/t/openstack/build/6f14c4ab93194cb99d97b56dfea1130a : SUCCESS in 6m 53s\n- cinderlib-lvm-functional https://zuul.opendev.org/t/openstack/build/c12eb7208acb417686515584df016762 : SUCCESS in 8m 30s\n- cinderlib-ceph-functional https://zuul.opendev.org/t/openstack/build/3128b088afdf4322bbcde65027ceca1c : SUCCESS in 9m 33s","accounts_in_message":[],"_revision_number":3},{"id":"cb3750247e3d50f6c08e2e4ee4da467f973fe2f8","author":{"_account_id":12033,"name":"DellEMC XtremIO CI","email":"emc.xio.ci@emc.com","username":"emc-xio-ci","tags":["SERVICE_USER"]},"date":"2019-12-18 18:29:52.000000000","message":"Patch Set 3:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- DellEMC_XtremIO_FC-cl http://publiclogs.emc.com/03/699203/3/check/DellEMC_XtremIO_FC-cl/4ea0853/DellEMC_XtremIO_FC-cl/17 : FAILURE in 4m 31s\n- DellEMC_XtremIO_iSCSI-cl http://publiclogs.emc.com/03/699203/3/check/DellEMC_XtremIO_iSCSI-cl/6a0111a/DellEMC_XtremIO_iSCSI-cl/29 : FAILURE in 2m 57s\n\nLeave a comment with \u0027run-DellEMC XtremIO CI\u0027 to trigger a recheck, for more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_XtremIO_CI","accounts_in_message":[],"_revision_number":3},{"id":"87784c16d9bd04e8789e3d73301542e98e540ddf","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2019-12-19 10:22:26.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"596cec6dbf4c0a89265b3b218316310445630e58","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-19 10:43:29.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9d9e7f3441984d12b2c7010c9e8d10b5 : SUCCESS in 9m 53s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e76d947ea1aa4cb0bcf9be10a72e2f5f : SUCCESS in 5m 51s\n- cinderlib-tox-py27 https://zuul.opendev.org/t/openstack/build/52445368097f4f8ead2ae59c8d5c98b1 : SUCCESS in 7m 59s\n- cinderlib-tox-py36 https://zuul.opendev.org/t/openstack/build/2a049306a9da4c709c1b325d2e70e17b : SUCCESS in 9m 59s\n- cinderlib-tox-py37 https://zuul.opendev.org/t/openstack/build/bf492f8259c8457daa8da8fd32fef93b : SUCCESS in 7m 37s\n- cinderlib-lvm-functional https://zuul.opendev.org/t/openstack/build/69a2d82a9ec642deb54380e14925f0f3 : SUCCESS in 13m 48s\n- cinderlib-ceph-functional https://zuul.opendev.org/t/openstack/build/551ce4a80d8845b1bf77c0b52ff97db4 : SUCCESS in 14m 13s","accounts_in_message":[],"_revision_number":4},{"id":"c60666b18078fa35688fee1509d5ef89c9fa10e7","author":{"_account_id":12033,"name":"DellEMC XtremIO CI","email":"emc.xio.ci@emc.com","username":"emc-xio-ci","tags":["SERVICE_USER"]},"date":"2019-12-19 11:52:22.000000000","message":"Patch Set 4:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- DellEMC_XtremIO_FC-cl http://publiclogs.emc.com/03/699203/4/check/DellEMC_XtremIO_FC-cl/4b63229/DellEMC_XtremIO_FC-cl/18 : FAILURE in 4m 29s\n- DellEMC_XtremIO_iSCSI-cl http://publiclogs.emc.com/03/699203/4/check/DellEMC_XtremIO_iSCSI-cl/424aa3d/DellEMC_XtremIO_iSCSI-cl/30 : FAILURE in 3m 48s\n\nLeave a comment with \u0027run-DellEMC XtremIO CI\u0027 to trigger a recheck, for more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_XtremIO_CI","accounts_in_message":[],"_revision_number":4},{"id":"25b4e5ac935147f45749c4022746aba1f72e427d","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2019-12-19 12:58:57.000000000","message":"Patch Set 4: Code-Review+2\n\nThis makes a lot of sense.  Using the standard openstack config in the standard way will make cinderlib a lot easier to maintain.","accounts_in_message":[],"_revision_number":4},{"id":"7622fe88bc2ff2811ea63fc59e17a6f2cba44237","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2019-12-19 12:59:58.000000000","message":"Patch Set 4: Review-Priority+2\n\nRaising the priority because it would be good to get this backported to stable/train right away and cut a new release in the train series.","accounts_in_message":[],"_revision_number":4},{"id":"a7a70c716c7fbb1b54935c42ce645a72c01f8888","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2019-12-19 13:01:11.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1\n\nShip it.","accounts_in_message":[],"_revision_number":4},{"id":"ee2f205ba7763591779c35f1fa3ac16e6d102cd7","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-19 13:01:27.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"7f4f9e05c5c781cc4cbbbc9cd056aafd1f399c78","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-19 17:01:23.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/203f4a586ff14794a5aa38785ae3f685 : SUCCESS in 7m 06s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ccde80c378d443b48990543dcd280c63 : SUCCESS in 4m 42s\n- cinderlib-tox-py27 https://zuul.opendev.org/t/openstack/build/231131f0bdfa4acdb53341fbbb102c92 : SUCCESS in 7m 54s\n- cinderlib-tox-py36 https://zuul.opendev.org/t/openstack/build/299f6262e46440168a809fbd5e2a4e9a : SUCCESS in 6m 07s\n- cinderlib-tox-py37 https://zuul.opendev.org/t/openstack/build/8aaef6d849d747a7ad1aafbdae3599fd : SUCCESS in 6m 44s\n- cinderlib-lvm-functional https://zuul.opendev.org/t/openstack/build/dd0d15f871b148cb96ad746ca05d0193 : SUCCESS in 9m 49s\n- cinderlib-ceph-functional https://zuul.opendev.org/t/openstack/build/bfcff6f5835a4a7e823747bb4e996990 : SUCCESS in 10m 35s","accounts_in_message":[],"_revision_number":4},{"id":"88a98f99056a70b7e8653e08142300147b91d2dd","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-19 17:01:23.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":4},{"id":"4e18feb948bdb1b24fcb096d57fdcbfb3214efa7","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-19 17:03:02.000000000","message":"Patch Set 4:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/864c128f600243ac95e27e4c0e70832f : SUCCESS in 1m 18s","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"fbd7a72c1bbfe4696eada41064c476ba3ecd6a8f","revisions":{"a65f840474e6da552593143a2cf1437a280bab5e":{"kind":"REWORK","_number":1,"created":"2019-12-16 12:53:43.000000000","uploader":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"ref":"refs/changes/03/699203/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinderlib","ref":"refs/changes/03/699203/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/03/699203/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/03/699203/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/03/699203/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinderlib refs/changes/03/699203/1"}}},"commit":{"parents":[{"commit":"b3ee3447e05ae89b3372219e5c4c4757f9762031","subject":"Merge \"Add missing release notes\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/b3ee3447e05ae89b3372219e5c4c4757f9762031"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2019-12-16 12:50:46.000000000","tz":60},"committer":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2019-12-16 12:53:27.000000000","tz":60},"subject":"Fix configuration options","message":"Fix configuration options\n\nWhen fixing bug #1854188 (Change-ID:\nI62e992804a3ae6aa0b4aa4f883807783197d4b33) we broke configuration\noptions, because now we cannot pass configuration options from the\nDEFAULT section, and some ListOpt don\u0027t work because cinderlib was\nincorrectly expecting all these options to have bounds\u003dTrue, but some\ndon\u0027t define it and default to False.\n\nThis patch fixes this by supporting configuration options from the\nDEFAULT section and supporting bounds\u003dTrue and bounds\u003dFalse for list and\ndict options.\n\nCloses-Bug: #1856556\nChange-Id: I67fbf8e9d7ee79f3d6617b4d0ae755dae0e1987a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/a65f840474e6da552593143a2cf1437a280bab5e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/a65f840474e6da552593143a2cf1437a280bab5e"}]},"branch":"refs/heads/master"},"ce67a19bd2a6a24a6255323ba3d89b21e75070ec":{"kind":"REWORK","_number":2,"created":"2019-12-18 18:03:37.000000000","uploader":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"ref":"refs/changes/03/699203/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinderlib","ref":"refs/changes/03/699203/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/03/699203/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/03/699203/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/03/699203/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinderlib refs/changes/03/699203/2"}}},"commit":{"parents":[{"commit":"d81fbeb3a9db97c92430fd07872e78d9cd048167","subject":"Merge \"Support passing pool to functional tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/d81fbeb3a9db97c92430fd07872e78d9cd048167"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2019-12-18 16:48:16.000000000","tz":60},"committer":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2019-12-18 18:00:46.000000000","tz":60},"subject":"Fix configuration options","message":"Fix configuration options\n\nWhen fixing bug #1854188 (Change-ID:\nI62e992804a3ae6aa0b4aa4f883807783197d4b33) we broke configuration\noptions, because now we cannot pass configuration options from the\nDEFAULT section, and some ListOpt don\u0027t work because cinderlib was\nincorrectly expecting all these options to have bounds\u003dTrue, but some\ndon\u0027t define it and default to False.\n\nMost of the \"crazy\" code we currently have around oslo config is because\nwe wanted to support drivers that add configuration options on runtime\nand reload the configuration.\n\nThis made sense when cinderlib was not an OpenStack official project,\nbut now that it is it makes more sense to force Cinder drivers to do the\nright thing.\n\nAligned with this, this patch removes all the faking of the cinder.conf\nfile as a StringIO object, and simply sets things in the configuration\nobject that is passed to the drivers, which is the only thing they\nshould be using.\n\nThis will make cinderlib code more robust, even if some drivers will now\nneed to be modified to work with cinderlib.\n\nThe NetApp driver was one of the drivers that would get broken, but\nsince I have access to it and we can make a very small and targeted\nworkaround to avoid breaking it, we do it as well.\n\nCloses-Bug: #1856556\nChange-Id: I67fbf8e9d7ee79f3d6617b4d0ae755dae0e1987a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/ce67a19bd2a6a24a6255323ba3d89b21e75070ec"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/ce67a19bd2a6a24a6255323ba3d89b21e75070ec"}]},"branch":"refs/heads/master"},"a5a566511998e83eb1761a8c3565399d4f36c30a":{"kind":"REWORK","_number":3,"created":"2019-12-18 18:10:18.000000000","uploader":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"ref":"refs/changes/03/699203/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinderlib","ref":"refs/changes/03/699203/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/03/699203/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/03/699203/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/03/699203/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinderlib refs/changes/03/699203/3"}}},"commit":{"parents":[{"commit":"d81fbeb3a9db97c92430fd07872e78d9cd048167","subject":"Merge \"Support passing pool to functional tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/d81fbeb3a9db97c92430fd07872e78d9cd048167"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2019-12-18 16:48:16.000000000","tz":60},"committer":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2019-12-18 18:09:38.000000000","tz":60},"subject":"Fix configuration options","message":"Fix configuration options\n\nWhen fixing bug #1854188 (Change-ID:\nI62e992804a3ae6aa0b4aa4f883807783197d4b33) we broke configuration\noptions, because now we cannot pass configuration options from the\nDEFAULT section, and some ListOpt don\u0027t work because cinderlib was\nincorrectly expecting all these options to have bounds\u003dTrue, but some\ndon\u0027t define it and default to False.\n\nMost of the \"crazy\" code we currently have around oslo config is because\nwe wanted to support drivers that add configuration options on runtime\nand reload the configuration.\n\nThis made sense when cinderlib was not an OpenStack official project,\nbut now that it is it makes more sense to force Cinder drivers to do the\nright thing.\n\nAligned with this, this patch removes all the faking of the cinder.conf\nfile as a StringIO object, and simply sets things in the configuration\nobject that is passed to the drivers, which is the only thing they\nshould be using.\n\nThis will make cinderlib code more robust, even if some drivers will now\nneed to be modified to work with cinderlib.\n\nWe are validating known configuration options and ignoring unknown ones,\nlike Cinder does.\n\nThe NetApp driver was one of the drivers that would get broken, but\nsince I have access to it and we can make a very small and targeted\nworkaround to avoid breaking it, we do it as well.\n\nCloses-Bug: #1856556\nChange-Id: I67fbf8e9d7ee79f3d6617b4d0ae755dae0e1987a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/a5a566511998e83eb1761a8c3565399d4f36c30a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/a5a566511998e83eb1761a8c3565399d4f36c30a"}]},"branch":"refs/heads/master"},"fbd7a72c1bbfe4696eada41064c476ba3ecd6a8f":{"kind":"REWORK","_number":4,"created":"2019-12-19 10:22:26.000000000","uploader":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"ref":"refs/changes/03/699203/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinderlib","ref":"refs/changes/03/699203/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/03/699203/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/03/699203/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/03/699203/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinderlib refs/changes/03/699203/4"}}},"commit":{"parents":[{"commit":"d81fbeb3a9db97c92430fd07872e78d9cd048167","subject":"Merge \"Support passing pool to functional tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/d81fbeb3a9db97c92430fd07872e78d9cd048167"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2019-12-18 16:48:16.000000000","tz":60},"committer":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2019-12-19 10:05:22.000000000","tz":60},"subject":"Fix configuration options","message":"Fix configuration options\n\nWhen fixing bug #1854188 (Change-ID:\nI62e992804a3ae6aa0b4aa4f883807783197d4b33) we broke configuration\noptions, because now we cannot pass configuration options from the\nDEFAULT section, and some ListOpt don\u0027t work because cinderlib was\nincorrectly expecting all these options to have bounds\u003dTrue, but some\ndon\u0027t define it and default to False.\n\nMost of the \"crazy\" code we currently have around oslo config is because\nwe wanted to support drivers that add configuration options on runtime\nand reload the configuration.\n\nThis made sense when cinderlib was not an OpenStack official project,\nbut now that it is it makes more sense to force Cinder drivers to do the\nright thing.\n\nAligned with this, this patch removes all the faking of the cinder.conf\nfile as a StringIO object, and simply sets things in the configuration\nobject that is passed to the drivers, which is the only thing they\nshould be using.\n\nThis will make cinderlib code more robust, even if some drivers will now\nneed to be modified to work with cinderlib.\n\nWe are validating known configuration options and ignoring unknown ones,\nlike Cinder does.\n\nThe NetApp driver was one of the drivers that would get broken, but\nsince I have access to it and we can make a very small and targeted\nworkaround to avoid breaking it, we do it as well.\n\nCloses-Bug: #1856556\nChange-Id: I67fbf8e9d7ee79f3d6617b4d0ae755dae0e1987a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/fbd7a72c1bbfe4696eada41064c476ba3ecd6a8f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/fbd7a72c1bbfe4696eada41064c476ba3ecd6a8f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}