)]}'
{"id":"openstack%2Fcinderlib~699986","triplet_id":"openstack%2Fcinderlib~stable%2Ftrain~I67fbf8e9d7ee79f3d6617b4d0ae755dae0e1987a","project":"openstack/cinderlib","branch":"stable/train","topic":"bug/1854188","hashtags":[],"change_id":"I67fbf8e9d7ee79f3d6617b4d0ae755dae0e1987a","subject":"Fix configuration options","status":"MERGED","created":"2019-12-19 13:31:39.000000000","updated":"2019-12-19 18:48:29.000000000","submitted":"2019-12-19 18:46:46.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"699986-1576781206622-fead5b33","meta_rev_id":"85c7669dd3173a3c7d571762402ad8699fa574d7","_number":699986,"virtual_id_number":699986,"owner":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-12-19 18:46:46.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":2,"date":"2019-12-19 17:09:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":2,"date":"2019-12-19 16:38:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":1,"date":"2019-12-19 17:09:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"approved":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":2,"date":"2019-12-19 16:38:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-12-19 16:38:30.000000000","updated_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"reviewer":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"state":"REVIEWER"},{"updated":"2019-12-19 17:09:57.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2019-12-19 18:46:46.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"de64a008ef2a924d07bb6fd6d862753dc4228124","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2019-12-19 13:31:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2d11a91543f6611407bd61bed86cf9d81783392f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-19 14:04:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/40c213f7b443447fb216f85e51a6f970 : SUCCESS in 7m 12s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0e22ef33632d4c388d79d7b75d7eeb87 : SUCCESS in 5m 10s\n- cinderlib-tox-py27 https://zuul.opendev.org/t/openstack/build/4aed15e6697e4075a204dab19caba72c : SUCCESS in 7m 54s\n- cinderlib-tox-py36 https://zuul.opendev.org/t/openstack/build/51d14af85c724eaeb84efea636cb7a7c : SUCCESS in 8m 56s\n- cinderlib-tox-py37 https://zuul.opendev.org/t/openstack/build/7e14ec580e7b48d2991718ecfef93766 : SUCCESS in 10m 10s\n- cinderlib-lvm-functional https://zuul.opendev.org/t/openstack/build/b4090c29935744dfb28894c4b0ac36f3 : SUCCESS in 10m 20s\n- cinderlib-ceph-functional https://zuul.opendev.org/t/openstack/build/e5b456b147eb489ca5770c6c6abaa693 : SUCCESS in 11m 05s","accounts_in_message":[],"_revision_number":1},{"id":"1143fdf30267c7e39b866cbf46fb0fbee9555b86","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2019-12-19 16:38:30.000000000","message":"Patch Set 1: Code-Review+2 Review-Priority+2\n\nClean backport, and an important bugfix.","accounts_in_message":[],"_revision_number":1},{"id":"5ac4dabb41a8a95a0d638d673706afe8bc88e0b6","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2019-12-19 17:09:57.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nGood to get backported and merged to master.","accounts_in_message":[],"_revision_number":1},{"id":"b42c8459336e84bf01bd6415afbbffa91ede6eea","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-19 17:10:25.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"cf3a7f60ead7029f3dc7748e6d84b71dca7da988","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-19 18:46:46.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"fd5776fb42caca09dae6130f63af2ca8f41f5dec","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-19 18:46:46.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4405a987ba5a4c07960204742f690101 : SUCCESS in 9m 34s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/16a8cd023c464f0090f1c8978f09bbff : SUCCESS in 4m 43s\n- cinderlib-tox-py27 https://zuul.opendev.org/t/openstack/build/5e98884d06414d0088a05af1027e803f : SUCCESS in 7m 05s\n- cinderlib-tox-py36 https://zuul.opendev.org/t/openstack/build/3ee1d610b5284cdfb84dee4973624eae : SUCCESS in 7m 59s\n- cinderlib-tox-py37 https://zuul.opendev.org/t/openstack/build/428cfc7c27144d389032e9cb454bf447 : SUCCESS in 8m 50s\n- cinderlib-lvm-functional https://zuul.opendev.org/t/openstack/build/dea1eea278fd4ca08193d00653f6da14 : SUCCESS in 15m 27s\n- cinderlib-ceph-functional https://zuul.opendev.org/t/openstack/build/c8da04b611414416a446f819b092e795 : SUCCESS in 14m 20s","accounts_in_message":[],"_revision_number":1},{"id":"7d45f4e7d07d6f02264b1d458981a94a6f920c09","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-19 18:48:29.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1ddccea165aa424db7bfc10481b88812 : SUCCESS in 1m 24s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"199ebd4f5a1984573877f582a2655f4171916761","revisions":{"199ebd4f5a1984573877f582a2655f4171916761":{"kind":"REWORK","_number":1,"created":"2019-12-19 13:31:39.000000000","uploader":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"ref":"refs/changes/86/699986/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinderlib","ref":"refs/changes/86/699986/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/86/699986/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/86/699986/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/86/699986/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinderlib refs/changes/86/699986/1"}}},"commit":{"parents":[{"commit":"734376fab5d89d992aa6e0266ed3b828d20ce9d6","subject":"Update TOX/UPPER_CONSTRAINTS_FILE for stable/train","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/734376fab5d89d992aa6e0266ed3b828d20ce9d6"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2019-12-18 16:48:16.000000000","tz":60},"committer":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2019-12-19 13:29:58.000000000","tz":60},"subject":"Fix configuration options","message":"Fix configuration options\n\nWhen fixing bug #1854188 (Change-ID:\nI62e992804a3ae6aa0b4aa4f883807783197d4b33) we broke configuration\noptions, because now we cannot pass configuration options from the\nDEFAULT section, and some ListOpt don\u0027t work because cinderlib was\nincorrectly expecting all these options to have bounds\u003dTrue, but some\ndon\u0027t define it and default to False.\n\nMost of the \"crazy\" code we currently have around oslo config is because\nwe wanted to support drivers that add configuration options on runtime\nand reload the configuration.\n\nThis made sense when cinderlib was not an OpenStack official project,\nbut now that it is it makes more sense to force Cinder drivers to do the\nright thing.\n\nAligned with this, this patch removes all the faking of the cinder.conf\nfile as a StringIO object, and simply sets things in the configuration\nobject that is passed to the drivers, which is the only thing they\nshould be using.\n\nThis will make cinderlib code more robust, even if some drivers will now\nneed to be modified to work with cinderlib.\n\nWe are validating known configuration options and ignoring unknown ones,\nlike Cinder does.\n\nThe NetApp driver was one of the drivers that would get broken, but\nsince I have access to it and we can make a very small and targeted\nworkaround to avoid breaking it, we do it as well.\n\nCloses-Bug: #1856556\nChange-Id: I67fbf8e9d7ee79f3d6617b4d0ae755dae0e1987a\n(cherry picked from commit fbd7a72c1bbfe4696eada41064c476ba3ecd6a8f)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/199ebd4f5a1984573877f582a2655f4171916761"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/199ebd4f5a1984573877f582a2655f4171916761"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[]}