)]}'
{".zuul.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"254662ed25576fe23bcdd0a4f432247d458c584d","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"- job:"},{"line_number":51,"context_line":"    name: cinderlib-lvm-functional"},{"line_number":52,"context_line":"    parent: openstack-tox-functional-with-sudo"},{"line_number":53,"context_line":"    required-projects:"},{"line_number":54,"context_line":"      - openstack/os-brick"},{"line_number":55,"context_line":"      - openstack/cinder"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_972024fa","line":52,"updated":"2020-01-08 16:44:59.000000000","message":"I think these need to be updated now too.","commit_id":"ba55b83f9d1f52f12c6a778ede9e5ddbb276555e"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"fb4241ba2322d1a9dc5f73a2ed3e0c2b42692ca3","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"- job:"},{"line_number":51,"context_line":"    name: cinderlib-lvm-functional"},{"line_number":52,"context_line":"    parent: openstack-tox-functional-with-sudo"},{"line_number":53,"context_line":"    required-projects:"},{"line_number":54,"context_line":"      - openstack/os-brick"},{"line_number":55,"context_line":"      - openstack/cinder"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_37f7f05c","line":52,"in_reply_to":"3fa7e38b_972024fa","updated":"2020-01-08 16:48:30.000000000","message":"Oh, is there a py3 version? Ok.","commit_id":"ba55b83f9d1f52f12c6a778ede9e5ddbb276555e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"92fcad9bcbd9dd95378ca3e00645132869f8e042","unresolved":false,"context_lines":[{"line_number":45,"context_line":"      - openstack/os-brick"},{"line_number":46,"context_line":"      - openstack/cinder"},{"line_number":47,"context_line":"    pre-run: playbooks/setup-lvm.yaml"},{"line_number":48,"context_line":"    nodeset: centos-7"},{"line_number":49,"context_line":"    vars:"},{"line_number":50,"context_line":"      tox_environment:"},{"line_number":51,"context_line":"        CL_FTEST_MEMORY_PERSISTENCE: \"false\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_02bf1460","line":48,"range":{"start_line":48,"start_character":20,"end_line":48,"end_character":21},"updated":"2020-01-08 17:43:54.000000000","message":"Maybe this just needs to change rather than adding py3 to bindep?","commit_id":"2e829ae54a21d5b7d9c0e47fd75ac93d921e28f9"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"27cbdfa5cc646128ffe83feb4fbcba3a790ac121","unresolved":false,"context_lines":[{"line_number":45,"context_line":"      - openstack/os-brick"},{"line_number":46,"context_line":"      - openstack/cinder"},{"line_number":47,"context_line":"    pre-run: playbooks/setup-lvm.yaml"},{"line_number":48,"context_line":"    nodeset: centos-7"},{"line_number":49,"context_line":"    vars:"},{"line_number":50,"context_line":"      tox_environment:"},{"line_number":51,"context_line":"        CL_FTEST_MEMORY_PERSISTENCE: \"false\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_a20de040","line":48,"range":{"start_line":48,"start_character":20,"end_line":48,"end_character":21},"in_reply_to":"3fa7e38b_02bf1460","updated":"2020-01-08 17:53:09.000000000","message":"That was the previous attempt which failed with a weird error about ansible_python_interpreter and python3.6 not found, while running \"Install ceph-common and epel-release\".","commit_id":"2e829ae54a21d5b7d9c0e47fd75ac93d921e28f9"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"31c9f3ba3b89ae6ac2b87196294ef5fc6407caaf","unresolved":false,"context_lines":[{"line_number":45,"context_line":"      - openstack/os-brick"},{"line_number":46,"context_line":"      - openstack/cinder"},{"line_number":47,"context_line":"    pre-run: playbooks/setup-lvm.yaml"},{"line_number":48,"context_line":"    nodeset: centos-7"},{"line_number":49,"context_line":"    vars:"},{"line_number":50,"context_line":"      tox_environment:"},{"line_number":51,"context_line":"        CL_FTEST_MEMORY_PERSISTENCE: \"false\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_bd7ae172","line":48,"range":{"start_line":48,"start_character":20,"end_line":48,"end_character":21},"in_reply_to":"3fa7e38b_a20de040","updated":"2020-01-08 18:11:14.000000000","message":"We should probably focus on figuring that out since centos-8 is technically the only supported Ussuri disto.\n\nhttps://governance.openstack.org/tc/reference/runtimes/ussuri.html","commit_id":"2e829ae54a21d5b7d9c0e47fd75ac93d921e28f9"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"dd7cd96a80b4b66b48912af4cb4dfe485c601c79","unresolved":false,"context_lines":[{"line_number":66,"context_line":"      - openstack/os-brick"},{"line_number":67,"context_line":"      - openstack/cinder"},{"line_number":68,"context_line":"    pre-run: playbooks/setup-ceph.yaml"},{"line_number":69,"context_line":"    nodeset: ubuntu-bionic"},{"line_number":70,"context_line":"    vars:"},{"line_number":71,"context_line":"      tox_environment:"},{"line_number":72,"context_line":"        CL_FTEST_CFG: \"{{ ansible_user_dir }}/{{ zuul.projects[\u0027opendev.org/openstack/cinderlib\u0027].src_dir }}/cinderlib/tests/functional/ceph.yaml\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3fa7e38b_0cf7298e","line":69,"updated":"2020-01-10 13:58:54.000000000","message":"nit: Please add a TODO comment to set it back to centos once it\u0027s possible.","commit_id":"8d81f7cc69af3485ed9f255fc471334850b4d2a7"}],"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ff2f9877b90d49e7ed549c986fa8eceb4f0fe794","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Keep CentOS 7 as the tester node for functional tests for now,"},{"line_number":19,"context_line":"but install python3 (now available). Switching to CentOS 8"},{"line_number":20,"context_line":"would require more changes."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Iea4f4f53df7400248848399494564910d3870f63"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_2e00f6ff","line":21,"updated":"2020-01-08 21:29:02.000000000","message":"Please add Closes-Bug: #1853372","commit_id":"7d959bb5e865c82691fa939938fb8bcc94cf93ac"}],"doc/requirements.txt":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"dd7cd96a80b4b66b48912af4cb4dfe485c601c79","unresolved":false,"context_lines":[{"line_number":1,"context_line":"openstackdocstheme\u003e\u003d1.20.0  # Apache-2.0"},{"line_number":2,"context_line":"reno\u003e\u003d2.5.0 # Apache-2.0"},{"line_number":3,"context_line":"doc8\u003e\u003d0.6.0 # Apache-2.0"},{"line_number":4,"context_line":"sphinx!\u003d1.6.6,!\u003d1.6.7,!\u003d2.1.0,\u003e\u003d1.6.2;python_version\u003e\u003d\u00273.4\u0027  # BSD"},{"line_number":5,"context_line":"os-api-ref\u003e\u003d1.4.0 # Apache-2.0"},{"line_number":6,"context_line":"sphinxcontrib-apidoc\u003e\u003d0.2.0  # BSD"},{"line_number":7,"context_line":"sphinxcontrib-svg2pdfconverter  # BSD"}],"source_content_type":"text/plain","patch_set":11,"id":"3fa7e38b_4cf9a17f","line":4,"range":{"start_line":4,"start_character":37,"end_line":4,"end_character":59},"updated":"2020-01-10 13:58:54.000000000","message":"nit: In other projects we are removing this as well.","commit_id":"8d81f7cc69af3485ed9f255fc471334850b4d2a7"}],"doc/source/validating.rst":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"dd7cd96a80b4b66b48912af4cb4dfe485c601c79","unresolved":false,"context_lines":[{"line_number":297,"context_line":"         - openstack/os-brick"},{"line_number":298,"context_line":"         - openstack/cinder"},{"line_number":299,"context_line":"       pre-run: playbooks/setup-ceph.yaml"},{"line_number":300,"context_line":"       nodeset: centos-8"},{"line_number":301,"context_line":"       vars:"},{"line_number":302,"context_line":"         tox_environment:"},{"line_number":303,"context_line":"           CL_FTEST_CFG: \"cinderlib/tests/functional/ceph.yaml\""}],"source_content_type":"text/x-rst","patch_set":11,"id":"3fa7e38b_8c28f9ed","line":300,"updated":"2020-01-10 13:58:54.000000000","message":"-1: This won\u0027t work, right?","commit_id":"8d81f7cc69af3485ed9f255fc471334850b4d2a7"}],"releasenotes/notes/drop-py2-a56fb12674516c67.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"dd174bd548ceb44edbefdc75bac733768edc26a4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Python 2.7 support has been dropped. The last release of Cinder to support"},{"line_number":5,"context_line":"    py2.7 is OpenStack Train. The minimum version of Python now supported by"},{"line_number":6,"context_line":"    Cinder is Python 3.6."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_2b2c68ff","line":4,"range":{"start_line":4,"start_character":61,"end_line":4,"end_character":67},"updated":"2020-01-08 21:07:37.000000000","message":"Maybe it\u0027s worth saying that Cinder is also dropping py27 support, but I think you want to talk about cinderlib here?  Since dropping py27 support is a breaking change, the next release of cinderlib from master will be 2.0.0.  So maybe say something like cinderlib no longer supports py27 from version 2.0.0 onwards and only the 1.x series supports py27.","commit_id":"7d959bb5e865c82691fa939938fb8bcc94cf93ac"}],"setup.cfg":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"4a13f149edefbc4de17628cae8603baf8759a62e","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    License :: OSI Approved :: Apache Software License"},{"line_number":21,"context_line":"    Operating System :: POSIX :: Linux"},{"line_number":22,"context_line":"    Programming Language :: Python"},{"line_number":23,"context_line":"    Programming Language :: Python :: 2"},{"line_number":24,"context_line":"    Programming Language :: Python :: 2.7"},{"line_number":25,"context_line":"    Programming Language :: Python :: 3"},{"line_number":26,"context_line":"    Programming Language :: Python :: 3.6"},{"line_number":27,"context_line":"    Programming Language :: Python :: 3.7"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"3fa7e38b_d7377cfc","line":24,"range":{"start_line":23,"start_character":2,"end_line":24,"end_character":41},"updated":"2020-01-08 16:54:46.000000000","message":"Should we just do the whole dropping-py2-support as part of this patch. Sorry, I know it\u0027s kind of scope creep, but since we are no longer able to test py2, we should probably remove this metadata and add a release note declaring only py3 is supported.","commit_id":"bc31e261ec48e9a37fdf06798340d9ff9fe35d10"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c7c8f445fd0707f6c56530b9b10a92658419eacb","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    DESCRIPTION.rst"},{"line_number":12,"context_line":"author \u003d OpenStack"},{"line_number":13,"context_line":"author-email \u003d openstack-discuss@lists.openstack.org"},{"line_number":14,"context_line":"home-page \u003d https://docs.openstack.org/cinderlib/latest/"},{"line_number":15,"context_line":"classifier \u003d"},{"line_number":16,"context_line":"    Environment :: OpenStack"},{"line_number":17,"context_line":"    Intended Audience :: Information Technology"}],"source_content_type":"text/x-ttcn-cfg","patch_set":5,"id":"3fa7e38b_299c70bd","line":14,"updated":"2020-01-08 22:55:37.000000000","message":"do you want to add\n\n   python-requires \u003d \u003e\u003d3.6\n\nhere or is it too early for that?","commit_id":"7d959bb5e865c82691fa939938fb8bcc94cf93ac"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"34ffad3d7183ee4b10d6a159af51147811eb446a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    DESCRIPTION.rst"},{"line_number":12,"context_line":"author \u003d OpenStack"},{"line_number":13,"context_line":"author-email \u003d openstack-discuss@lists.openstack.org"},{"line_number":14,"context_line":"home-page \u003d https://docs.openstack.org/cinderlib/latest/"},{"line_number":15,"context_line":"classifier \u003d"},{"line_number":16,"context_line":"    Environment :: OpenStack"},{"line_number":17,"context_line":"    Intended Audience :: Information Technology"}],"source_content_type":"text/x-ttcn-cfg","patch_set":5,"id":"3fa7e38b_af1e195b","line":14,"in_reply_to":"3fa7e38b_299c70bd","updated":"2020-01-09 13:34:27.000000000","message":"I\u0027d wait for cinder to bump it first.","commit_id":"7d959bb5e865c82691fa939938fb8bcc94cf93ac"}],"tox.ini":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"254662ed25576fe23bcdd0a4f432247d458c584d","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  find"},{"line_number":55,"context_line":"  stestr"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"[testenv:functional-py36]"},{"line_number":58,"context_line":"usedevelop\u003dTrue"},{"line_number":59,"context_line":"setenv \u003d"},{"line_number":60,"context_line":"  {[testenv:functional]setenv}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3fa7e38b_d731bc59","line":57,"updated":"2020-01-08 16:44:59.000000000","message":"I wonder if we should just remove this now...","commit_id":"ba55b83f9d1f52f12c6a778ede9e5ddbb276555e"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"fb4241ba2322d1a9dc5f73a2ed3e0c2b42692ca3","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  find"},{"line_number":55,"context_line":"  stestr"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"[testenv:functional-py36]"},{"line_number":58,"context_line":"usedevelop\u003dTrue"},{"line_number":59,"context_line":"setenv \u003d"},{"line_number":60,"context_line":"  {[testenv:functional]setenv}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3fa7e38b_f7edd88d","line":57,"in_reply_to":"3fa7e38b_d731bc59","updated":"2020-01-08 16:48:30.000000000","message":"Uhm, not sure. Don\u0027t we test with python 3.6 still as well? Or maybe the default is 3.6 and we need a job for 3.7?","commit_id":"ba55b83f9d1f52f12c6a778ede9e5ddbb276555e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"db09bad3ff2c023370018e6040372e5151a54fe5","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  find"},{"line_number":55,"context_line":"  stestr"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"[testenv:functional-py36]"},{"line_number":58,"context_line":"usedevelop\u003dTrue"},{"line_number":59,"context_line":"setenv \u003d"},{"line_number":60,"context_line":"  {[testenv:functional]setenv}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3fa7e38b_3753703c","line":57,"in_reply_to":"3fa7e38b_f7edd88d","updated":"2020-01-08 16:53:32.000000000","message":"That\u0027s what I\u0027m thinking. If we just do python3, by default with our current node flavors I think that means function will be exactly the same as functional-py36. So we can either drop this job altogether, or we can have some explicit jobs where we do call out the exact version we want to run. In which case it probably makes sense to add a py37 variant.\n\nI don\u0027t think that has to hold up anything with this patch. We definitely know we don\u0027t want to run py2 testing anymore since that will just fail. We can decide later what kind of coverage we want to have going forward.","commit_id":"ba55b83f9d1f52f12c6a778ede9e5ddbb276555e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"dd174bd548ceb44edbefdc75bac733768edc26a4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 2.0"},{"line_number":3,"context_line":"envlist \u003d py37,pep8"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"}],"source_content_type":"text/x-properties","patch_set":5,"id":"3fa7e38b_6b6ca06a","line":2,"updated":"2020-01-08 21:07:37.000000000","message":"I suggest changing this to 3.1.0 (or higher) and add\n\n  ignore_basepython_conflict \u003d true\n\n(see the current cinder tox.ini).  Otherwise, with basepython set as python3 in the [testenv] at line 8, the basepython overrides the \"inferred\" environments when you run \u0027tox -epy36\u0027 or \u0027tox -epy37\u0027, and the virtualenv for those tests will use whatever the system py3 is instead of honoring one requested by the user.  (Also, you won\u0027t need to declare a basepython at line 62, the correct one will be inferred from the -py27 suffix.)","commit_id":"7d959bb5e865c82691fa939938fb8bcc94cf93ac"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"34ffad3d7183ee4b10d6a159af51147811eb446a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 2.0"},{"line_number":3,"context_line":"envlist \u003d py37,pep8"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"}],"source_content_type":"text/x-properties","patch_set":5,"id":"3fa7e38b_b4374cfd","line":2,"in_reply_to":"3fa7e38b_6b6ca06a","updated":"2020-01-09 13:34:27.000000000","message":"I see, thanks; I haven\u0027t hit this in other projects probably because they explicitly define the additional tox environments (py27, py36, py37, etc).","commit_id":"7d959bb5e865c82691fa939938fb8bcc94cf93ac"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"dd174bd548ceb44edbefdc75bac733768edc26a4","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  find"},{"line_number":55,"context_line":"  stestr"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"[testenv:functional-py37]"},{"line_number":58,"context_line":"usedevelop\u003dTrue"},{"line_number":59,"context_line":"setenv \u003d"},{"line_number":60,"context_line":"  {[testenv:functional]setenv}"}],"source_content_type":"text/x-properties","patch_set":5,"id":"3fa7e38b_0bdbac20","line":57,"updated":"2020-01-08 21:07:37.000000000","message":"Since we support py36 as well in ussuri, I think we should have an explicit functional-py36 testenv instead of relying on the default py3 being py36, which may not be the case for some developers.","commit_id":"7d959bb5e865c82691fa939938fb8bcc94cf93ac"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"34ffad3d7183ee4b10d6a159af51147811eb446a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  find"},{"line_number":55,"context_line":"  stestr"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"[testenv:functional-py37]"},{"line_number":58,"context_line":"usedevelop\u003dTrue"},{"line_number":59,"context_line":"setenv \u003d"},{"line_number":60,"context_line":"  {[testenv:functional]setenv}"}],"source_content_type":"text/x-properties","patch_set":5,"id":"3fa7e38b_f431440b","line":57,"in_reply_to":"3fa7e38b_0bdbac20","updated":"2020-01-09 13:34:27.000000000","message":"Ack. Should I keep the generic \"functional\" as well?","commit_id":"7d959bb5e865c82691fa939938fb8bcc94cf93ac"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"18f3644498329ee118d785f5d62ff1d1c7d575d9","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  find"},{"line_number":55,"context_line":"  stestr"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"[testenv:functional-py37]"},{"line_number":58,"context_line":"usedevelop\u003dTrue"},{"line_number":59,"context_line":"setenv \u003d"},{"line_number":60,"context_line":"  {[testenv:functional]setenv}"}],"source_content_type":"text/x-properties","patch_set":5,"id":"3fa7e38b_4fda0579","line":57,"in_reply_to":"3fa7e38b_0bdbac20","updated":"2020-01-09 13:40:42.000000000","message":"yes, I agree with this.  Since we say that that 3.6 is the minimum, we need to unit test against it, otherwise 3.7 is the minimum since it would be the only py3 tested.","commit_id":"7d959bb5e865c82691fa939938fb8bcc94cf93ac"}]}