)]}'
{"id":"openstack%2Fcinderlib~713965","triplet_id":"openstack%2Fcinderlib~master~I8712045752a7a150a3633451246ed992dee35972","project":"openstack/cinderlib","branch":"master","topic":"bug/1868148","hashtags":[],"change_id":"I8712045752a7a150a3633451246ed992dee35972","subject":"DBMS: Fix volume deletion with MySQL","status":"MERGED","created":"2020-03-19 18:59:08.000000000","updated":"2020-04-17 17:16:51.000000000","submitted":"2020-04-17 17:13:33.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"713965-1587143613745-77dd523e","meta_rev_id":"7b023622d182d30da985cfa10601c887d440bb49","_number":713965,"virtual_id_number":713965,"owner":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"date":"2020-03-24 20:45:33.000000000","_account_id":12033,"name":"DellEMC XtremIO CI","email":"emc.xio.ci@emc.com","username":"emc-xio-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-04-17 17:13:33.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-04-17 13:41:45.000000000","_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},{"value":0,"date":"2020-04-17 13:47:23.000000000","_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":2,"date":"2020-04-03 12:59:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":12033,"name":"DellEMC XtremIO CI","email":"emc.xio.ci@emc.com","username":"emc-xio-ci","tags":["SERVICE_USER"]},{"value":2,"date":"2020-04-17 13:05:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":12033,"name":"DellEMC XtremIO CI","email":"emc.xio.ci@emc.com","username":"emc-xio-ci","tags":["SERVICE_USER"]},{"value":1,"date":"2020-04-17 13:05:01.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":12033,"name":"DellEMC XtremIO CI","email":"emc.xio.ci@emc.com","username":"emc-xio-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":12033,"name":"DellEMC XtremIO CI","email":"emc.xio.ci@emc.com","username":"emc-xio-ci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-03-24 20:45:33.000000000","updated_by":{"_account_id":12033,"name":"DellEMC XtremIO CI","email":"emc.xio.ci@emc.com","username":"emc-xio-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":12033,"name":"DellEMC XtremIO CI","email":"emc.xio.ci@emc.com","username":"emc-xio-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-04-03 12:59:20.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2020-04-17 13:05:01.000000000","updated_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"reviewer":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"state":"REVIEWER"},{"updated":"2020-04-17 13:41:45.000000000","updated_by":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"reviewer":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"state":"REVIEWER"},{"updated":"2020-04-17 17:13:33.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"442b8a76b53ea33c0bd63c6d98625bae51aef379","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2020-03-19 18:59:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f844bd31ec1050ae0433304a8ce5ffd023825f57","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-19 19:14:50.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1c58f870b65340bd831d68ff6aa534e0 : SUCCESS in 8m 58s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/fb5ead33385c49e9a264b33f40538795 : SUCCESS in 6m 55s\n- cinderlib-tox-py36 https://zuul.opendev.org/t/openstack/build/42434e8024fe4b6fb1a9dde2fe09c14e : SUCCESS in 8m 14s\n- cinderlib-tox-py37 https://zuul.opendev.org/t/openstack/build/351a9903ef364c14b5eb47239c02ad4b : SUCCESS in 8m 02s\n- cinderlib-lvm-functional https://zuul.opendev.org/t/openstack/build/d2f43718791743cca68bea767a8020e3 : FAILURE in 7m 31s\n- cinderlib-ceph-functional https://zuul.opendev.org/t/openstack/build/688cafbd1da6487192e1594212fab65b : SUCCESS in 9m 26s","accounts_in_message":[],"_revision_number":1},{"id":"5a506cd314765300f0a243794fe28184a4fd66c4","author":{"_account_id":12033,"name":"DellEMC XtremIO CI","email":"emc.xio.ci@emc.com","username":"emc-xio-ci","tags":["SERVICE_USER"]},"date":"2020-03-20 19:12:22.000000000","message":"Patch Set 1:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- DellEMC_XtremIO_FC-cl http://publiclogs.emc.com/65/713965/1/check/DellEMC_XtremIO_FC-cl/e23b140/DellEMC_XtremIO_FC-cl/40 : FAILURE in 4m 08s\n- DellEMC_XtremIO_iSCSI-cl http://publiclogs.emc.com/65/713965/1/check/DellEMC_XtremIO_iSCSI-cl/7c00124/DellEMC_XtremIO_iSCSI-cl/51 : FAILURE in 1m 51s\n\nLeave a comment with \u0027run-DellEMC XtremIO CI\u0027 to trigger a recheck, for more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_XtremIO_CI","accounts_in_message":[],"_revision_number":1},{"id":"e08c3c27cd2a481341f6f0871e6186db82790bd8","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2020-03-24 12:43:52.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d5c6538c8ab23814fa632be1e85e317a607d07cf","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-24 13:01:32.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/dae8cc04004b4f01a15b4d1fd33ee16c : SUCCESS in 8m 55s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/3324c7ae44fe465fa96873cf8f523177 : SUCCESS in 4m 31s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/646e02bf588640f191582e1ed913546e : SUCCESS in 3m 56s\n- cinderlib-tox-py36 https://zuul.opendev.org/t/openstack/build/318b4e2b81b84a4a9e00a996456c0d0d : SUCCESS in 7m 08s\n- cinderlib-tox-py37 https://zuul.opendev.org/t/openstack/build/51d16574a4e74c44b7b70967b7560419 : SUCCESS in 8m 07s\n- cinderlib-lvm-functional https://zuul.opendev.org/t/openstack/build/87c4d874f0df49789053e3bead6faf74 : SUCCESS in 11m 31s\n- cinderlib-ceph-functional https://zuul.opendev.org/t/openstack/build/43f5ab7ce8b44773882cec54509cdc9f : SUCCESS in 9m 16s","accounts_in_message":[],"_revision_number":2},{"id":"566048c4a823aaea92140b8588f91a77c9a031d8","author":{"_account_id":12033,"name":"DellEMC XtremIO CI","email":"emc.xio.ci@emc.com","username":"emc-xio-ci","tags":["SERVICE_USER"]},"date":"2020-03-24 20:45:33.000000000","message":"Patch Set 2:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- DellEMC_XtremIO_FC-cl http://publiclogs.emc.com/65/713965/2/check/DellEMC_XtremIO_FC-cl/379b85d/DellEMC_XtremIO_FC-cl/48 : FAILURE in 4m 03s\n- DellEMC_XtremIO_iSCSI-cl http://publiclogs.emc.com/65/713965/2/check/DellEMC_XtremIO_iSCSI-cl/36bc58a/DellEMC_XtremIO_iSCSI-cl/58 : FAILURE in 1m 48s\n\nLeave a comment with \u0027run-DellEMC XtremIO CI\u0027 to trigger a recheck, for more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_XtremIO_CI","accounts_in_message":[],"_revision_number":2},{"id":"19f498d979f046e7f891141e33a16dc33559efa9","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-04-03 12:59:20.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"0d1bd249547392365c1a48b62ccd708c16ff0fe7","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2020-04-17 13:05:01.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nWe had the same (or a similar) bug in Cinder.  We added a unit test to prevent it from happening again if the DB is modified, but that relies on sqlalchemy [0], not sure whether you could do something like that in cinderlib, or whether it would be overkill.  Would be good if we had a way to get info about this kind of fix from Cinder -\u003e cinderlib.  We may have to simply rely on reviewers noticing and adding cinderlib to appropriate cinder bugs.  Might be a good idea for you to have a short session at the Victoria PTG about this to raise awareness of the kind of things Cinder reviewers should be looking for.\n\n[0] https://opendev.org/openstack/cinder/src/branch/master/cinder/tests/unit/db/test_orm_relationships.py","accounts_in_message":[],"_revision_number":2},{"id":"7652b6008f06e5e3cd29c4871c4977b115a64733","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-17 13:05:33.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"cb236c26f75e48da3550f93bc7852f179b99a74a","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2020-04-17 13:41:45.000000000","message":"Patch Set 2:\n\nIs there a chance that other tables like[1] might produce the same condition?\nI\u0027m not much aware of the similarities between cinder and cinderlib but might be good idea to list all the foreign key dependent tables.\n\n[1] https://opendev.org/openstack/cinder/src/branch/master/cinder/db/sqlalchemy/api.py#L1676-L1680","accounts_in_message":[],"_revision_number":2},{"id":"00ca9169eab0b2e0c06193e4c8bf9ec89cd5f824","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2020-04-17 13:47:23.000000000","message":"Patch Set 2:\n\nThanks for the reviews.\nWe don\u0027t use any of the other tables in cinderlib, but it is a good idea to add some comments on the dbms.py file to explain that we need to delete any rows that we create when saving a volume.","accounts_in_message":[],"_revision_number":2},{"id":"63d3b3cce2c3e270037f240d2ab1ea524daa81ce","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-17 17:13:33.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/490c58b36ed340c79265991c07837c86 : SUCCESS in 28m 37s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/ec656bcb30424140976faa89220deecf : SUCCESS in 11m 22s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5e15b81d646a49878a66568c00e7a099 : SUCCESS in 8m 08s\n- cinderlib-tox-py36 https://zuul.opendev.org/t/openstack/build/9501fb92b01a4d52b8e0d235c9bfeac3 : SUCCESS in 7m 29s\n- cinderlib-tox-py37 https://zuul.opendev.org/t/openstack/build/26967c1920d74fd48fc27314a71918d3 : SUCCESS in 12m 20s\n- cinderlib-lvm-functional https://zuul.opendev.org/t/openstack/build/fddc27c029a14663a75af35f91598e6b : SUCCESS in 12m 08s\n- cinderlib-ceph-functional https://zuul.opendev.org/t/openstack/build/5710e8014517486aa44ea1fd15bb459c : SUCCESS in 13m 02s","accounts_in_message":[],"_revision_number":2},{"id":"e873f7c4071e0a934ab07ac8deb55fbba4c0f68e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-17 17:13:33.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"24ee40ee46eb51eaf01bb6529537ab106a17263b","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-17 17:16:51.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/48a0be0b4b854a56be41efa7574e839f : SUCCESS in 2m 42s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/5a9de127c25d48fa85d529088805eed0 : SUCCESS in 2m 48s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"cefeef4c7e41bdcc3140cb4ea555187f59e00f7c","revisions":{"1021870680cd61679d803447042aa3a1f1df270a":{"kind":"REWORK","_number":1,"created":"2020-03-19 18:59:08.000000000","uploader":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"ref":"refs/changes/65/713965/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinderlib","ref":"refs/changes/65/713965/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/65/713965/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/65/713965/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/65/713965/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinderlib refs/changes/65/713965/1"}}},"commit":{"parents":[{"commit":"2b335ddc565446526bad7a5ab8be8b4ae9d0a7fa","subject":"Fix test_set_snapshot","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/2b335ddc565446526bad7a5ab8be8b4ae9d0a7fa"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2020-03-19 13:54:55.000000000","tz":60},"committer":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2020-03-19 18:58:50.000000000","tz":60},"subject":"DBMS: Fix volume deletion with MySQL","message":"DBMS: Fix volume deletion with MySQL\n\nWhen using the DBMS plugin with MySQL with default configuration (hard\nDB row deletes) the deletion of a volume fails if the volume has\nmetadata or admin metadata.\n\nThe reason are the foreign key constraints from those 2 tables, because\nwe are not deleting their rows before deleting the volume row.\n\nThis doesn\u0027t fail with SQLite, but we leave rows behind.\n\nWith this patch we will delete all metadata and admin_metadata belonging\nto the volume before we delete the volume row itself.\n\nCloses-Bug: #1868148\nChange-Id: I8712045752a7a150a3633451246ed992dee35972\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/1021870680cd61679d803447042aa3a1f1df270a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/1021870680cd61679d803447042aa3a1f1df270a"}]},"branch":"refs/heads/master"},"cefeef4c7e41bdcc3140cb4ea555187f59e00f7c":{"kind":"REWORK","_number":2,"created":"2020-03-24 12:43:52.000000000","uploader":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"ref":"refs/changes/65/713965/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinderlib","ref":"refs/changes/65/713965/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/65/713965/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/65/713965/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/65/713965/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinderlib refs/changes/65/713965/2"}}},"commit":{"parents":[{"commit":"18f85d8b256e9f2db06a6828d257a7836ad63244","subject":"Merge \"Drop use of unittest2\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/18f85d8b256e9f2db06a6828d257a7836ad63244"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2020-03-19 13:54:55.000000000","tz":60},"committer":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2020-03-24 12:43:22.000000000","tz":60},"subject":"DBMS: Fix volume deletion with MySQL","message":"DBMS: Fix volume deletion with MySQL\n\nWhen using the DBMS plugin with MySQL with default configuration (hard\nDB row deletes) the deletion of a volume fails if the volume has\nmetadata or admin metadata.\n\nThe reason are the foreign key constraints from those 2 tables, because\nwe are not deleting their rows before deleting the volume row.\n\nThis doesn\u0027t fail with SQLite, but we leave rows behind.\n\nWith this patch we will delete all metadata and admin_metadata belonging\nto the volume before we delete the volume row itself.\n\nCloses-Bug: #1868148\nChange-Id: I8712045752a7a150a3633451246ed992dee35972\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/cefeef4c7e41bdcc3140cb4ea555187f59e00f7c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/cefeef4c7e41bdcc3140cb4ea555187f59e00f7c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}