)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"bac484892a16f64380b775591bde9bd99c7a3eb5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"26e712bc_fc39a80a","updated":"2022-08-17 09:53:35.000000000","message":"LGTM, finally this is getting merged!","commit_id":"8a8605c52cd8ea918235e606399112f903a84bf0"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"7ba2db1ab6c8b1d814b3bbf37baaf7ba8a37103f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a2e324b2_a9a097ec","updated":"2022-07-25 16:13:37.000000000","message":"openstack-tox-pep8 passed!","commit_id":"8a8605c52cd8ea918235e606399112f903a84bf0"}],"test-requirements.txt":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f5ff10143a8b9976ffde99a3137e1ca4ed09f12c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"pbr!\u003d2.1.0,\u003e\u003d2.0.0 # Apache-2.0"},{"line_number":6,"context_line":"hacking!\u003d0.13.0,\u003c0.14,\u003e\u003d0.12.0 # Apache-2.0"},{"line_number":7,"context_line":"coverage!\u003d4.4,\u003e\u003d4.0 # Apache-2.0"},{"line_number":8,"context_line":"ddt\u003e\u003d1.0.1 # MIT"},{"line_number":9,"context_line":"oslotest\u003e\u003d3.2.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":2,"id":"1f621f24_7cb829e4","line":6,"range":{"start_line":6,"start_character":7,"end_line":6,"end_character":30},"updated":"2020-11-10 15:39:27.000000000","message":"shouldn\u0027t this be changed to \u003e\u003d3.0.1, since we know that\u0027s what we want?","commit_id":"f0abb256793139c1af1d90963be9030271676fc2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9adc19d06fcc3d03e45089ec8401fba5025ef6ca","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"pbr!\u003d2.1.0,\u003e\u003d2.0.0 # Apache-2.0"},{"line_number":6,"context_line":"hacking!\u003d0.13.0,\u003c0.14,\u003e\u003d0.12.0 # Apache-2.0"},{"line_number":7,"context_line":"coverage!\u003d4.4,\u003e\u003d4.0 # Apache-2.0"},{"line_number":8,"context_line":"ddt\u003e\u003d1.0.1 # MIT"},{"line_number":9,"context_line":"oslotest\u003e\u003d3.2.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":2,"id":"1f621f24_e7e3c103","line":6,"range":{"start_line":6,"start_character":7,"end_line":6,"end_character":30},"in_reply_to":"1f621f24_7cb829e4","updated":"2020-11-16 20:37:44.000000000","message":"If we do bump the hacking in stable branch we may end up fixing some checks which I think not appropriate change for stable as per backport policies. \n\nWe did bump it on master onwards so I think we should not bump hacking here and keep what it was originally .","commit_id":"f0abb256793139c1af1d90963be9030271676fc2"}],"tox.ini":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"284fbe30c4610b164df1bf40edd7e81f7858d608","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# dependencies (include Cinder in required-projects).  This allows us to also"},{"line_number":17,"context_line":"# run local tests against master."},{"line_number":18,"context_line":"deps\u003d -r{toxinidir}/test-requirements.txt"},{"line_number":19,"context_line":"      git+https://opendev.org/openstack/os-brick#egg\u003dos-brick"},{"line_number":20,"context_line":"      git+https://opendev.org/openstack/cinder#egg\u003dcinder"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":2,"id":"ff570b3c_73225ea6","line":19,"updated":"2020-05-28 12:51:34.000000000","message":"Can you please extend the scope of this a bit and remove those git+https requirements? It seems they install os-brick and cinder from master, which is not the expected behavior (unless I misread the code).\n\nGorka, we may need a more stable solution for this. Can you please disable them on master too? I understand the issue with testing, but it makes the maintenance of stable branches more complex.","commit_id":"f0abb256793139c1af1d90963be9030271676fc2"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"095341ca5c0fe3ff5c842ae8316026d4c4adeb8d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# dependencies (include Cinder in required-projects).  This allows us to also"},{"line_number":17,"context_line":"# run local tests against master."},{"line_number":18,"context_line":"deps\u003d -r{toxinidir}/test-requirements.txt"},{"line_number":19,"context_line":"      git+https://opendev.org/openstack/os-brick#egg\u003dos-brick"},{"line_number":20,"context_line":"      git+https://opendev.org/openstack/cinder#egg\u003dcinder"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":2,"id":"fc3b476b_357d4fd3","line":19,"in_reply_to":"1f621f24_87be4dd2","updated":"2021-06-28 12:17:04.000000000","message":"You are right Luigi, we need to fix that, but better not in this patch.\n\nWe are currently in the process of defining the right procedure to make it \"easy\" for stable releases [1], and we have a patch that is in the process of merging [2] doing the pinning of these reference to a specific stable branch.\n\nI can\u0027t see the errors of the functional tests now, so I\u0027ll recheck the patch to see if it\u0027s related to this, if it is, then we\u0027ll fix it here as well, and if it\u0027s not, then I\u0027ll propose a different patch to pin on the stable branch.\n\n[1]: https://review.opendev.org/c/openstack/cinderlib/+/772558\n[2]: https://review.opendev.org/c/openstack/cinderlib/+/785677","commit_id":"f0abb256793139c1af1d90963be9030271676fc2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9adc19d06fcc3d03e45089ec8401fba5025ef6ca","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# dependencies (include Cinder in required-projects).  This allows us to also"},{"line_number":17,"context_line":"# run local tests against master."},{"line_number":18,"context_line":"deps\u003d -r{toxinidir}/test-requirements.txt"},{"line_number":19,"context_line":"      git+https://opendev.org/openstack/os-brick#egg\u003dos-brick"},{"line_number":20,"context_line":"      git+https://opendev.org/openstack/cinder#egg\u003dcinder"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":2,"id":"1f621f24_87be4dd2","line":19,"in_reply_to":"ff570b3c_73225ea6","updated":"2020-11-16 20:37:44.000000000","message":"not sure if we should do that in this change. may be we should do it from master and then backport.","commit_id":"f0abb256793139c1af1d90963be9030271676fc2"}]}