)]}'
{"doc/source/contributor/contributing.rst":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"168634727e68016620da4c74e5cc4e1d4da34949","unresolved":true,"context_lines":[{"line_number":35,"context_line":"for the *previous* cycle.  Thus, cinderlib\u0027s tox.ini requires some manual"},{"line_number":36,"context_line":"maintenance:"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* while both the cinder and cinderlib master branches are the development"},{"line_number":39,"context_line":"  branches for the \u0027n\u0027 release cycle (ussuri, for example), the base testenv"},{"line_number":40,"context_line":"  in tox.ini in master should look like this:"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7708b8bb_c3aa0511","line":38,"range":{"start_line":38,"start_character":2,"end_line":38,"end_character":7},"updated":"2021-01-28 11:33:41.000000000","message":"nit: While","commit_id":"c6eb8a1fae00d7dc13c366fbce053c5c5ac7df1b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ebe9d168f2160bc1b36c92949710db296d5dc1f5","unresolved":false,"context_lines":[{"line_number":35,"context_line":"for the *previous* cycle.  Thus, cinderlib\u0027s tox.ini requires some manual"},{"line_number":36,"context_line":"maintenance:"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* while both the cinder and cinderlib master branches are the development"},{"line_number":39,"context_line":"  branches for the \u0027n\u0027 release cycle (ussuri, for example), the base testenv"},{"line_number":40,"context_line":"  in tox.ini in master should look like this:"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"2af6002d_27d06160","line":38,"range":{"start_line":38,"start_character":2,"end_line":38,"end_character":7},"in_reply_to":"7708b8bb_c3aa0511","updated":"2021-02-17 15:51:19.000000000","message":"Done","commit_id":"c6eb8a1fae00d7dc13c366fbce053c5c5ac7df1b"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"168634727e68016620da4c74e5cc4e1d4da34949","unresolved":true,"context_lines":[{"line_number":50,"context_line":"           git+https://opendev.org/openstack/os-brick#egg\u003dos-brick"},{"line_number":51,"context_line":"           git+https://opendev.org/openstack/cinder#egg\u003dcinder"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"* when the coordinated release for cycle \u0027n\u0027 has occurred, cinderlib\u0027s"},{"line_number":54,"context_line":"  requirements.txt in master must be updated to use only \u0027n\u0027 deliverables (in"},{"line_number":55,"context_line":"  this example, ussuri):"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5dfde7f3_b83df5fa","line":53,"range":{"start_line":53,"start_character":2,"end_line":53,"end_character":6},"updated":"2021-01-28 11:33:41.000000000","message":"nit: When","commit_id":"c6eb8a1fae00d7dc13c366fbce053c5c5ac7df1b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ebe9d168f2160bc1b36c92949710db296d5dc1f5","unresolved":false,"context_lines":[{"line_number":50,"context_line":"           git+https://opendev.org/openstack/os-brick#egg\u003dos-brick"},{"line_number":51,"context_line":"           git+https://opendev.org/openstack/cinder#egg\u003dcinder"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"* when the coordinated release for cycle \u0027n\u0027 has occurred, cinderlib\u0027s"},{"line_number":54,"context_line":"  requirements.txt in master must be updated to use only \u0027n\u0027 deliverables (in"},{"line_number":55,"context_line":"  this example, ussuri):"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ddd10f34_d0806141","line":53,"range":{"start_line":53,"start_character":2,"end_line":53,"end_character":6},"in_reply_to":"5dfde7f3_b83df5fa","updated":"2021-02-17 15:51:19.000000000","message":"Done","commit_id":"c6eb8a1fae00d7dc13c366fbce053c5c5ac7df1b"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"168634727e68016620da4c74e5cc4e1d4da34949","unresolved":true,"context_lines":[{"line_number":70,"context_line":"            -r{toxinidir}/test-requirements.txt"},{"line_number":71,"context_line":"            -r{toxinidir}/requirements.txt"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"* after the \u0027n\u0027 release of cinderlib occurs (and the stable/n branch is cut),"},{"line_number":74,"context_line":"  all of cinder, os-brick, and cinderlib master branches are all n+1 cycle"},{"line_number":75,"context_line":"  development branches, so the base testenv in tox.ini in master must be"},{"line_number":76,"context_line":"  modified to use cinder and os-brick from master for testing, as in the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1688310c_dcaeee9a","line":73,"range":{"start_line":73,"start_character":2,"end_line":73,"end_character":7},"updated":"2021-01-28 11:33:41.000000000","message":"nit: After","commit_id":"c6eb8a1fae00d7dc13c366fbce053c5c5ac7df1b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ebe9d168f2160bc1b36c92949710db296d5dc1f5","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            -r{toxinidir}/test-requirements.txt"},{"line_number":71,"context_line":"            -r{toxinidir}/requirements.txt"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"* after the \u0027n\u0027 release of cinderlib occurs (and the stable/n branch is cut),"},{"line_number":74,"context_line":"  all of cinder, os-brick, and cinderlib master branches are all n+1 cycle"},{"line_number":75,"context_line":"  development branches, so the base testenv in tox.ini in master must be"},{"line_number":76,"context_line":"  modified to use cinder and os-brick from master for testing, as in the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"468e21a3_ebf522ae","line":73,"range":{"start_line":73,"start_character":2,"end_line":73,"end_character":7},"in_reply_to":"1688310c_dcaeee9a","updated":"2021-02-17 15:51:19.000000000","message":"Done","commit_id":"c6eb8a1fae00d7dc13c366fbce053c5c5ac7df1b"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"168634727e68016620da4c74e5cc4e1d4da34949","unresolved":true,"context_lines":[{"line_number":74,"context_line":"  all of cinder, os-brick, and cinderlib master branches are all n+1 cycle"},{"line_number":75,"context_line":"  development branches, so the base testenv in tox.ini in master must be"},{"line_number":76,"context_line":"  modified to use cinder and os-brick from master for testing, as in the"},{"line_number":77,"context_line":"  first code block above."}],"source_content_type":"text/x-rst","patch_set":1,"id":"01f754ba_8d99c4d5","line":77,"updated":"2021-01-28 11:33:41.000000000","message":"nit: Maybe mention that the easiest way to achieve this is to just revert the previously created patch.","commit_id":"c6eb8a1fae00d7dc13c366fbce053c5c5ac7df1b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"bc22ca085c84bc22a8c67d0d109f3e43c1b03de5","unresolved":true,"context_lines":[{"line_number":74,"context_line":"  all of cinder, os-brick, and cinderlib master branches are all n+1 cycle"},{"line_number":75,"context_line":"  development branches, so the base testenv in tox.ini in master must be"},{"line_number":76,"context_line":"  modified to use cinder and os-brick from master for testing, as in the"},{"line_number":77,"context_line":"  first code block above."}],"source_content_type":"text/x-rst","patch_set":1,"id":"87c1ad2e_04af87fb","line":77,"in_reply_to":"01f754ba_8d99c4d5","updated":"2021-01-29 15:24:37.000000000","message":"That\u0027s a great idea, but it makes me wonder if I\u0027m missing a step.  What I mean is, we want to revert the upper bound in requirements.txt, but I think we also need to make sure that requirements.txt has accurate minima for cinder and os-brick (which isn\u0027t the case in master right now).  So maybe we need some more info in this doc about when to modify requirements.txt and lower-constraints.txt so that the cinderlib patch after the \u0027n\u0027 coordinated release only changes tox.ini and puts the upper bound on cinder in requirements.txt.","commit_id":"c6eb8a1fae00d7dc13c366fbce053c5c5ac7df1b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ebe9d168f2160bc1b36c92949710db296d5dc1f5","unresolved":true,"context_lines":[{"line_number":74,"context_line":"  all of cinder, os-brick, and cinderlib master branches are all n+1 cycle"},{"line_number":75,"context_line":"  development branches, so the base testenv in tox.ini in master must be"},{"line_number":76,"context_line":"  modified to use cinder and os-brick from master for testing, as in the"},{"line_number":77,"context_line":"  first code block above."}],"source_content_type":"text/x-rst","patch_set":1,"id":"308cc243_2d76014d","line":77,"in_reply_to":"87c1ad2e_04af87fb","updated":"2021-02-17 15:51:19.000000000","message":"I\u0027m not sure we can do a straight revert here; see what you think of the revised text on PS2.","commit_id":"c6eb8a1fae00d7dc13c366fbce053c5c5ac7df1b"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2855415b2e0018479d8eb614075a1256c6c2ce30","unresolved":true,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"  .. code-block::"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"     deps \u003d -c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/ussuri}"},{"line_number":70,"context_line":"            -r{toxinidir}/test-requirements.txt"},{"line_number":71,"context_line":"            -r{toxinidir}/requirements.txt"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"* After the \u0027n\u0027 release of cinderlib occurs (and the stable/n branch is cut),"},{"line_number":74,"context_line":"  all of cinder, os-brick, and cinderlib master branches are all n+1 cycle"},{"line_number":75,"context_line":"  development branches, so:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"a2672a3a_0fbd53ad","line":72,"range":{"start_line":69,"start_character":0,"end_line":72,"end_character":0},"updated":"2021-06-28 12:08:55.000000000","message":"-1: In the end we have changed this to:\n\n  deps \u003d\n      -r{toxinidir}/test-requirements.txt\n      git+https://opendev.org/openstack/os-brick@stable/wallaby#egg\u003dos-brick\n      git+https://opendev.org/openstack/cinder@stable/wallaby#egg\u003dcinder\n\nAnd only for releasenotes and docs we changed it to:\n  deps \u003d\n    -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/wallaby}","commit_id":"d6481abfb7a247ad4e0f6d890c1dd0c0ccc34824"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"7b59597c35db6b192bac6f954d9b8f199fcd4017","unresolved":true,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"     deps \u003d -r{toxinidir}/test-requirements.txt"},{"line_number":71,"context_line":"            git+https://opendev.org/openstack/os-brick@stable/ussuri#egg\u003dos-brick"},{"line_number":72,"context_line":"            git+https://opendev.org/openstack/cinder@stable/wallaby#egg\u003dcinder"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  The other two places are in the testenvs for ``releasenotes`` and ``docs``."},{"line_number":75,"context_line":"  Both must have the ``deps`` modified so that the default value for the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"e22bcc70_6209e890","line":72,"range":{"start_line":72,"start_character":53,"end_line":72,"end_character":67},"updated":"2021-06-30 10:10:48.000000000","message":"-1: stable/ussuri","commit_id":"03f4004deb6799e013bdd94793d88c7092f56347"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7c91663bca424882966bc11185cdeb124e23b8dd","unresolved":true,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"     deps \u003d -r{toxinidir}/test-requirements.txt"},{"line_number":71,"context_line":"            git+https://opendev.org/openstack/os-brick@stable/ussuri#egg\u003dos-brick"},{"line_number":72,"context_line":"            git+https://opendev.org/openstack/cinder@stable/wallaby#egg\u003dcinder"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  The other two places are in the testenvs for ``releasenotes`` and ``docs``."},{"line_number":75,"context_line":"  Both must have the ``deps`` modified so that the default value for the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"549ea425_91599c5b","line":72,"range":{"start_line":72,"start_character":53,"end_line":72,"end_character":67},"in_reply_to":"e22bcc70_6209e890","updated":"2021-06-30 13:45:09.000000000","message":"good catch, not sure how i missed that","commit_id":"03f4004deb6799e013bdd94793d88c7092f56347"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"7b59597c35db6b192bac6f954d9b8f199fcd4017","unresolved":true,"context_lines":[{"line_number":87,"context_line":"  development branches, so:"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"  * The base testenv in tox.ini in master must be modified to use cinder and"},{"line_number":90,"context_line":"    os-brick from master for testing, as in the first code block above."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"  * The testenvs for ``releasenotes`` and ``docs`` must be reset to use upper"},{"line_number":93,"context_line":"    constraints from the ``master`` branch."}],"source_content_type":"text/x-rst","patch_set":3,"id":"e0501342_94b06e16","line":90,"range":{"start_line":90,"start_character":38,"end_line":90,"end_character":70},"updated":"2021-06-30 10:10:48.000000000","message":"nit: reverting the first code block change above","commit_id":"03f4004deb6799e013bdd94793d88c7092f56347"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7c91663bca424882966bc11185cdeb124e23b8dd","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  development branches, so:"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"  * The base testenv in tox.ini in master must be modified to use cinder and"},{"line_number":90,"context_line":"    os-brick from master for testing, as in the first code block above."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"  * The testenvs for ``releasenotes`` and ``docs`` must be reset to use upper"},{"line_number":93,"context_line":"    constraints from the ``master`` branch."}],"source_content_type":"text/x-rst","patch_set":3,"id":"2ff57039_40d6455c","line":90,"range":{"start_line":90,"start_character":38,"end_line":90,"end_character":70},"in_reply_to":"e0501342_94b06e16","updated":"2021-06-30 13:45:09.000000000","message":"Done","commit_id":"03f4004deb6799e013bdd94793d88c7092f56347"}]}