)]}'
{"requirements.txt":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2cf173e96ba5cfab212b8320879a4b3f86381549","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# restrict cinder to the wallaby series only"},{"line_number":2,"context_line":"cinder\u003e\u003d18.0.0,\u003c19.0.0 # Apache-2.0"},{"line_number":3,"context_line":"# specify brick wallaby (upper bound controlled by openstack upper-constraints)"},{"line_number":4,"context_line":"os-brick\u003e\u003d4.3.1"},{"line_number":5,"context_line":""}],"source_content_type":"text/plain","patch_set":5,"id":"f5858580_0b5b4543","line":2,"range":{"start_line":2,"start_character":15,"end_line":2,"end_character":22},"updated":"2021-06-09 23:20:19.000000000","message":"this might be more significant after cinder xena release but i think it\u0027s safe to add this now also","commit_id":"cd0ae51c93ee773c572dad69cadef3aea5e1ebf3"}],"tox.ini":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"7c39d83bf032a49cd6ff6d2bb2800a893df0ebf1","unresolved":true,"context_lines":[{"line_number":19,"context_line":"# Use wallaby cinder and os-brick"},{"line_number":20,"context_line":"# NOTE: Functional tests may fail if host is missing bindeps from deps projects"},{"line_number":21,"context_line":"deps \u003d -r{toxinidir}/test-requirements.txt"},{"line_number":22,"context_line":"       -r{toxinidir}/requirements.txt"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"commands \u003d"},{"line_number":25,"context_line":"    find . -ignore_readdir_race -type f -name \"*.pyc\" -delete"}],"source_content_type":"text/x-properties","patch_set":1,"id":"d9b7e9ea_d55eeb91","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":37},"updated":"2021-04-15 13:30:40.000000000","message":"?: Is this necessary?  The reason why we specify git as the source is so we can use the latest code from Cinder and os-brick on our local development and not be bound to the latest release.\n\nIn my opinion what we need to do is change this in stable/wallaby to reference the branch we want to use instead of master:\n\ngit+https://opendev.org/openstack/os-brick@stable/wallaby#egg\u003dos-brick\ngit+https://opendev.org/openstack/cinder@stable/wallby#egg\u003dcinder","commit_id":"f16a7c5b101cf3f52fb9650b06f97cf3b3ee3083"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"87749e3eb3e767afff1dd87b96ec08d6fff35eb7","unresolved":true,"context_lines":[{"line_number":19,"context_line":"# Use wallaby cinder and os-brick"},{"line_number":20,"context_line":"# NOTE: Functional tests may fail if host is missing bindeps from deps projects"},{"line_number":21,"context_line":"deps \u003d -r{toxinidir}/test-requirements.txt"},{"line_number":22,"context_line":"       -r{toxinidir}/requirements.txt"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"commands \u003d"},{"line_number":25,"context_line":"    find . -ignore_readdir_race -type f -name \"*.pyc\" -delete"}],"source_content_type":"text/x-properties","patch_set":1,"id":"0ef806a4_4e22641f","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":37},"in_reply_to":"d9b7e9ea_d55eeb91","updated":"2021-04-15 18:07:58.000000000","message":"You\u0027re right, there\u0027s no reason why we can\u0027t use stable/wallaby here.  I\u0027ll change this and also update the docs patch.","commit_id":"f16a7c5b101cf3f52fb9650b06f97cf3b3ee3083"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5dbf11703bfcc74e93c33cbda0eac1748eeef989","unresolved":true,"context_lines":[{"line_number":15,"context_line":"         OS_TEST_TIMEOUT\u003d60"},{"line_number":16,"context_line":"         OS_TEST_PATH\u003d./cinderlib/tests/unit"},{"line_number":17,"context_line":"usedevelop\u003dTrue"},{"line_number":18,"context_line":"install_command \u003d python -m pip install -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/wallaby} {env:PIP_OPTIONS:} {opts} {packages}"},{"line_number":19,"context_line":"# Use cinder and os-brick from the appropriate development branch instead of"},{"line_number":20,"context_line":"# from PyPi.  Defining the egg name we won\u0027t overwrite the package installed"},{"line_number":21,"context_line":"# by Zuul on jobs supporting cross-project dependencies (include Cinder in"}],"source_content_type":"text/x-properties","patch_set":2,"id":"f4327da8_1872abe2","line":18,"range":{"start_line":18,"start_character":40,"end_line":18,"end_character":125},"updated":"2021-04-15 18:28:08.000000000","message":"Am I correct that we should have the upper constraints here?\n\nIf so, I think we can remove lines 89 and 95 (or, if we keep them, update them to wallaby).","commit_id":"2ce5f4eaf7918c90fb22228920b1d42724829c7a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6170f7f6cc6516763c924851396d95b8a173f332","unresolved":true,"context_lines":[{"line_number":15,"context_line":"         OS_TEST_TIMEOUT\u003d60"},{"line_number":16,"context_line":"         OS_TEST_PATH\u003d./cinderlib/tests/unit"},{"line_number":17,"context_line":"usedevelop\u003dTrue"},{"line_number":18,"context_line":"install_command \u003d python -m pip install -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/wallaby} {env:PIP_OPTIONS:} {opts} {packages}"},{"line_number":19,"context_line":"# Use cinder and os-brick from the appropriate development branch instead of"},{"line_number":20,"context_line":"# from PyPi.  Defining the egg name we won\u0027t overwrite the package installed"},{"line_number":21,"context_line":"# by Zuul on jobs supporting cross-project dependencies (include Cinder in"}],"source_content_type":"text/x-properties","patch_set":4,"id":"09068a44_304b4779","line":18,"range":{"start_line":18,"start_character":40,"end_line":18,"end_character":125},"updated":"2021-04-19 23:47:20.000000000","message":"Two questions:\n(1) Am I correct that we want to use upper constraints here?\n(2) If that\u0027s right, I guess we should remove lines 89 and 95.","commit_id":"5cc709942f1c9e0548fdd51d77845649b692fb70"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e4e50f24f80bb66cc97b3d404914e114fea51c10","unresolved":true,"context_lines":[{"line_number":15,"context_line":"         OS_TEST_TIMEOUT\u003d60"},{"line_number":16,"context_line":"         OS_TEST_PATH\u003d./cinderlib/tests/unit"},{"line_number":17,"context_line":"usedevelop\u003dTrue"},{"line_number":18,"context_line":"install_command \u003d python -m pip install -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/wallaby} {env:PIP_OPTIONS:} {opts} {packages}"},{"line_number":19,"context_line":"# Use cinder and os-brick from the appropriate development branch instead of"},{"line_number":20,"context_line":"# from PyPi.  Defining the egg name we won\u0027t overwrite the package installed"},{"line_number":21,"context_line":"# by Zuul on jobs supporting cross-project dependencies (include Cinder in"}],"source_content_type":"text/x-properties","patch_set":4,"id":"eecf8aed_124f94ea","line":18,"range":{"start_line":18,"start_character":40,"end_line":18,"end_character":125},"in_reply_to":"09068a44_304b4779","updated":"2021-04-20 02:12:51.000000000","message":"Actually, we have a different problem here, namely that os-brick is in upper-constraints.txt and when we try to install the wallaby development version of os-brick, it violates the constraint.","commit_id":"5cc709942f1c9e0548fdd51d77845649b692fb70"}]}