)]}'
{"cinderlib/persistence/dbms.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"7045fa22f9c0fff3b7ae6b6b0e546fc0ad91a5aa","unresolved":true,"context_lines":[{"line_number":26,"context_line":"from oslo_db import exception"},{"line_number":27,"context_line":"from oslo_db.sqlalchemy import models as oslo_db_models"},{"line_number":28,"context_line":"from oslo_log import log"},{"line_number":29,"context_line":"import sqlalchemy as sa"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"from cinderlib import objects"},{"line_number":32,"context_line":"from cinderlib.persistence import base as persistence_base"}],"source_content_type":"text/x-python","patch_set":1,"id":"8c4b2faf_019c61a8","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":23},"updated":"2021-06-07 09:18:38.000000000","message":"nit: Doesn\u0027t seem like we are gaining much from using sa instead of sqlalchemy, so we should probably keep the full name.","commit_id":"e1008c79a9d9876aef5e3671779f0926d369a651"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"44d44bdafa342149b3b9d7bee760147ae34d4a48","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from oslo_db import exception"},{"line_number":27,"context_line":"from oslo_db.sqlalchemy import models as oslo_db_models"},{"line_number":28,"context_line":"from oslo_log import log"},{"line_number":29,"context_line":"import sqlalchemy as sa"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"from cinderlib import objects"},{"line_number":32,"context_line":"from cinderlib.persistence import base as persistence_base"}],"source_content_type":"text/x-python","patch_set":1,"id":"4ddc30db_a5b3b8e4","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":23},"in_reply_to":"8c4b2faf_019c61a8","updated":"2021-06-08 11:18:35.000000000","message":"Fair. This is habit from nova, where there can be many times more sqlalchemy imports in a given file 😄 Same it probably true for cinder proper. I can fix if I need to respin","commit_id":"e1008c79a9d9876aef5e3671779f0926d369a651"}]}