)]}'
{"tox.ini":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"8dcda2c6de1a1805d5db669509129d6d46fc4caf","unresolved":true,"context_lines":[{"line_number":12,"context_line":"         OS_STDERR_CAPTURE\u003d1"},{"line_number":13,"context_line":"         OS_TEST_TIMEOUT\u003d60"},{"line_number":14,"context_line":"         OS_TEST_PATH\u003d./cinderlib/tests/unit"},{"line_number":15,"context_line":"\t VIRTUAL_ENV\u003d{envdir}"},{"line_number":16,"context_line":"# this allows tox to infer the base python from the environment name"},{"line_number":17,"context_line":"# and override any basepython configured in this file"},{"line_number":18,"context_line":"usedevelop\u003dTrue"}],"source_content_type":"text/x-properties","patch_set":2,"id":"2a3f5243_9415e425","line":15,"updated":"2021-06-18 14:45:54.000000000","message":"-1: use spaces (no tabs!) to align with previous lines.","commit_id":"1e17b259d482e5b55501ce926f04e5b01028bfe5"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"8dcda2c6de1a1805d5db669509129d6d46fc4caf","unresolved":true,"context_lines":[{"line_number":13,"context_line":"         OS_TEST_TIMEOUT\u003d60"},{"line_number":14,"context_line":"         OS_TEST_PATH\u003d./cinderlib/tests/unit"},{"line_number":15,"context_line":"\t VIRTUAL_ENV\u003d{envdir}"},{"line_number":16,"context_line":"# this allows tox to infer the base python from the environment name"},{"line_number":17,"context_line":"# and override any basepython configured in this file"},{"line_number":18,"context_line":"usedevelop\u003dTrue"},{"line_number":19,"context_line":"install_command \u003d pip install {env:PIP_OPTIONS:} {opts} {packages}"}],"source_content_type":"text/x-properties","patch_set":2,"id":"0c51dd07_3d17e7ff","line":16,"updated":"2021-06-18 14:45:54.000000000","message":"Due to differences in leading white space, it\u0027s no longer clear this comment applies to L15.\n\nSuggest changing \"this allows...\" to something like \"Setting VIRTUAL_ENV allows...\"","commit_id":"1e17b259d482e5b55501ce926f04e5b01028bfe5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d87e6a33bf5a7bff306d46045f33de8f59f05f3b","unresolved":true,"context_lines":[{"line_number":4,"context_line":"envlist \u003d py3,pep8"},{"line_number":5,"context_line":"skipsdist \u003d True"},{"line_number":6,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":7,"context_line":"# this allows tox to infer the base python from the environment name"},{"line_number":8,"context_line":"# and override any basepython configured in this file"},{"line_number":9,"context_line":"ignore_basepython_conflict\u003dtrue"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[testenv]"}],"source_content_type":"text/x-properties","patch_set":5,"id":"2245aac1_fa8f964d","side":"PARENT","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":53},"updated":"2021-06-21 17:55:27.000000000","message":"This comment applies to line 9, you should restore it.","commit_id":"6ffa1c9447f3ecdfd97fcb9d40ce000b1475e570"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ef18a4763599531c182bf521cd673272af5e8003","unresolved":true,"context_lines":[{"line_number":13,"context_line":"         OS_TEST_TIMEOUT\u003d60"},{"line_number":14,"context_line":"         OS_TEST_PATH\u003d./cinderlib/tests/unit"},{"line_number":15,"context_line":"         VIRTUAL_ENV\u003d{envdir}"},{"line_number":16,"context_line":"# Setting VIRTUAL_ENV allows tox to infer the base python from the environment name"},{"line_number":17,"context_line":"# and override any basepython configured in this file"},{"line_number":18,"context_line":"usedevelop\u003dTrue"},{"line_number":19,"context_line":"install_command \u003d pip install {env:PIP_OPTIONS:} {opts} {packages}"},{"line_number":20,"context_line":"# Use cinder from master instead of from PyPi. Defining the egg name we won\u0027t"}],"source_content_type":"text/x-properties","patch_set":5,"id":"f656c3b4_47612df2","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":53},"updated":"2021-06-21 17:54:25.000000000","message":"I don\u0027t think this comment is correct.","commit_id":"6fbc184db4d3f2d23679b75892a20cf81a91d25e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"eaab0130425cfad7c04dd14525ce67d070c63d71","unresolved":true,"context_lines":[{"line_number":12,"context_line":"         OS_TEST_TIMEOUT\u003d60"},{"line_number":13,"context_line":"         OS_TEST_PATH\u003d./cinderlib/tests/unit"},{"line_number":14,"context_line":"         VIRTUAL_ENV\u003d{envdir}"},{"line_number":15,"context_line":"# Setting VIRTUAL_ENV allows tox to infer the base python from the environment name"},{"line_number":16,"context_line":"# and override any basepython configured in this file"},{"line_number":17,"context_line":"usedevelop\u003dTrue"},{"line_number":18,"context_line":"install_command \u003d pip install {env:PIP_OPTIONS:} {opts} {packages}"},{"line_number":19,"context_line":"# Use cinder from master instead of from PyPi. Defining the egg name we won\u0027t"}],"source_content_type":"text/x-properties","patch_set":6,"id":"d4f79998_42914583","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":53},"updated":"2021-06-28 14:02:02.000000000","message":"This comment is not correct.  In its original version, it applied to line 6 (ignore_basepython_conflict) above.","commit_id":"7b2ac6a1b176d0aebb7918152d75642fb07ec0cf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"079c9de6412fc26bc0a9b17cb7931eb01526d926","unresolved":true,"context_lines":[{"line_number":4,"context_line":"envlist \u003d py3,pep8"},{"line_number":5,"context_line":"skipsdist \u003d True"},{"line_number":6,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":7,"context_line":"# this allows tox to infer the base python from the environment name"},{"line_number":8,"context_line":"# and override any basepython configured in this file"},{"line_number":9,"context_line":"ignore_basepython_conflict\u003dtrue"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[testenv]"}],"source_content_type":"text/x-properties","patch_set":7,"id":"72b36904_af0fa7df","side":"PARENT","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":53},"updated":"2021-06-29 20:33:05.000000000","message":"This comment, the entire thing, applies to line 9 [0].  If that\u0027s not clear, I suggest changing it to:\n\n  # setting ignore_basepython_conflict allows tox to infer the base python\n  # from the environment name and override any basepython configured in this file\n\n[0] https://tox.readthedocs.io/en/latest/config.html#conf-ignore_basepython_conflict","commit_id":"6ffa1c9447f3ecdfd97fcb9d40ce000b1475e570"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"079c9de6412fc26bc0a9b17cb7931eb01526d926","unresolved":true,"context_lines":[{"line_number":13,"context_line":"         OS_TEST_TIMEOUT\u003d60"},{"line_number":14,"context_line":"         OS_TEST_PATH\u003d./cinderlib/tests/unit"},{"line_number":15,"context_line":"         VIRTUAL_ENV\u003d{envdir}"},{"line_number":16,"context_line":"# Setting VIRTUAL_ENV allows tox to infer the base python from the environment name"},{"line_number":17,"context_line":"usedevelop\u003dTrue"},{"line_number":18,"context_line":"install_command \u003d pip install {env:PIP_OPTIONS:} {opts} {packages}"},{"line_number":19,"context_line":"# Use cinder from master instead of from PyPi. Defining the egg name we won\u0027t"}],"source_content_type":"text/x-properties","patch_set":7,"id":"b90adaa1_6d558115","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":83},"updated":"2021-06-29 20:33:05.000000000","message":"This isn\u0027t correct.  All this is doing is exporting an environment variable named \u0027VIRTUAL_ENV\u0027 whose value is the environment directory for the current testenv [1].\n\n[1] https://tox.readthedocs.io/en/latest/config.html#conf-envdir","commit_id":"45fa77660cdecc71b691511c5d8d522cea84953b"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8ca975781809e638517a3ca9c51d2af5b9d306c2","unresolved":true,"context_lines":[{"line_number":4,"context_line":"envlist \u003d py3,pep8"},{"line_number":5,"context_line":"skipsdist \u003d True"},{"line_number":6,"context_line":"ignore_basepython_conflict\u003dtrue"},{"line_number":7,"context_line":"# setting ignore_basepython_conflict allows tox to infer the base python"},{"line_number":8,"context_line":"# from the environment name and override any basepython configured in this file"},{"line_number":9,"context_line":"[testenv]"},{"line_number":10,"context_line":"basepython\u003dpython3"},{"line_number":11,"context_line":"setenv \u003d OS_STDOUT_CAPTURE\u003d1"}],"source_content_type":"text/x-properties","patch_set":8,"id":"f468f5c7_6c037b37","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":79},"updated":"2021-06-30 09:43:45.000000000","message":"-1: Comments should go before the code that they are referring to, so this should go before L6.","commit_id":"d5cff72e375cc3c452ca8351f53cbb6b8568e7dd"}]}