)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3ddba121290b33a4127f83313be0c62d8cfef540","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fbd665ae_e42d2ee1","updated":"2022-07-16 14:51:34.000000000","message":"recheck","commit_id":"1df1f7f142b74f713a2e9b774e92be1a9a13dcd5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7d37ba01db2f17d60492e19e905679f507a42f35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2b4bd5de_240bd634","updated":"2022-05-27 14:34:19.000000000","message":"recheck\n\nhttps://review.opendev.org/c/openstack/cinderlib/+/833781 should fix the problem.","commit_id":"1df1f7f142b74f713a2e9b774e92be1a9a13dcd5"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"eb40ce36ad150b3c51c4cb013c896783cf3d8aa3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"addf399c_b6fa254b","updated":"2022-09-23 04:35:55.000000000","message":"In cinderlib/HACKING.rst, there are some rules related to six library.\nThey should be removed.","commit_id":"4fb72684c0e0132f01b25e36d457e8055f452a7e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"bdc14338679aec80e6a91c622e4e1898bbc7f52f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0911d782_c4e9f8f8","in_reply_to":"addf399c_b6fa254b","updated":"2022-10-17 00:46:06.000000000","message":"these are already removed by the parent patch. https://review.opendev.org/c/openstack/cinderlib/+/840567/","commit_id":"4fb72684c0e0132f01b25e36d457e8055f452a7e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ea2034c42c65d6612a5e764189579aa14e08faff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1cf62476_ffecbddb","updated":"2022-12-07 19:18:43.000000000","message":"I think this is mostly OK, but see my comment in the test files.","commit_id":"27c8c4f92f2e986c4ef6bed14e829e24d6d99800"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"d5c208250b897d53de4e8dcc6cbc813c39d7c463","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f02e61b7_eb9edfab","updated":"2022-10-17 16:39:11.000000000","message":"LGTM. Thanks.","commit_id":"27c8c4f92f2e986c4ef6bed14e829e24d6d99800"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3eb5d4b11a4923c295784cfe08aeabc31521d87b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"8b3e3adc_be190ecf","updated":"2022-12-08 22:56:09.000000000","message":"The cinderlib-os-brick-src-tempest-lvm-lio-barbican-yoga failure is most likely due to using tox 4.  Ghanshyam is working on a fix.  Keep an eye on https://review.opendev.org/c/openstack/devstack/+/867059 (though we\u0027ll need it to be backported to stable/yoga to help on this patch).","commit_id":"eb03308ca3dc55dc6b127f4df9251ed63d2f645a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"da720898df46965cbf887d44b3d3412e6b83681f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"d490eb97_b14d6d7b","updated":"2022-12-14 11:48:41.000000000","message":"All I did was rebase this to get it current. I don\u0027t think the previous parent patch is actually a dependency for this one, and as it\u0027s a doc-only patch, it will be easy to merge.","commit_id":"94bd3fffc03d188e3b9d3fc707019edc6ac2459a"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"eb7bb481ce5eedd6036aa0fbd0e99e48b58cba35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"036fd006_6bdcaf45","updated":"2022-12-14 15:28:06.000000000","message":"This is good to get merged.  Thanks!","commit_id":"94bd3fffc03d188e3b9d3fc707019edc6ac2459a"}],"cinderlib/tests/functional/base_tests.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"eb40ce36ad150b3c51c4cb013c896783cf3d8aa3","unresolved":true,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo_config import cfg"},{"line_number":23,"context_line":"from oslo_utils import strutils"},{"line_number":24,"context_line":"import types"},{"line_number":25,"context_line":"import yaml"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"import cinderlib"}],"source_content_type":"text/x-python","patch_set":6,"id":"b3607756_d92dc295","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":12},"updated":"2022-09-23 04:35:55.000000000","message":"The \u0027types\u0027 is in the python standard library.\nhttps://docs.python.org/3/library/types.html\n\nSo this statement should be just after line 19.","commit_id":"4fb72684c0e0132f01b25e36d457e8055f452a7e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"bdc14338679aec80e6a91c622e4e1898bbc7f52f","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo_config import cfg"},{"line_number":23,"context_line":"from oslo_utils import strutils"},{"line_number":24,"context_line":"import types"},{"line_number":25,"context_line":"import yaml"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"import cinderlib"}],"source_content_type":"text/x-python","patch_set":6,"id":"b505c332_c85e64da","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":12},"in_reply_to":"b3607756_d92dc295","updated":"2022-10-17 00:46:06.000000000","message":"Done","commit_id":"4fb72684c0e0132f01b25e36d457e8055f452a7e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ea2034c42c65d6612a5e764189579aa14e08faff","unresolved":true,"context_lines":[{"line_number":96,"context_line":"        def _parse_cli_opts(self, args):"},{"line_number":97,"context_line":"            return original_cli_parser(self, [])"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        cfg.ConfigOpts._parse_cli_opts \u003d types.MethodType("},{"line_number":100,"context_line":"            _parse_cli_opts, cfg.ConfigOpts)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":7,"id":"47038f10_71d3be41","line":99,"updated":"2022-12-07 19:18:43.000000000","message":"See my comment in tests/unit/base.py","commit_id":"27c8c4f92f2e986c4ef6bed14e829e24d6d99800"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b140f37e350d2c58e30c786dbbd3962187a8125f","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        def _parse_cli_opts(self, args):"},{"line_number":97,"context_line":"            return original_cli_parser(self, [])"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        cfg.ConfigOpts._parse_cli_opts \u003d types.MethodType("},{"line_number":100,"context_line":"            _parse_cli_opts, cfg.ConfigOpts)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":7,"id":"01daff63_d82ff082","line":99,"in_reply_to":"47038f10_71d3be41","updated":"2022-12-08 04:27:18.000000000","message":"Done","commit_id":"27c8c4f92f2e986c4ef6bed14e829e24d6d99800"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b140f37e350d2c58e30c786dbbd3962187a8125f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import tempfile"},{"line_number":20,"context_line":"import unittest"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo_config import cfg"},{"line_number":23,"context_line":"from oslo_utils import strutils"},{"line_number":24,"context_line":"import yaml"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"48b192e5_da027f7d","line":22,"in_reply_to":"dc7e9dfc_c5639aa2","updated":"2022-12-08 04:27:18.000000000","message":"\u003e pep8: F401 \u0027oslo_config.cfg\u0027 imported but unused\nDone","commit_id":"dad718c31d089570ab754ea785a89310589b8360"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b140f37e350d2c58e30c786dbbd3962187a8125f","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                            persistence_config\u003d{\u0027storage\u0027: \u0027memory\u0027})"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        # Initialize backends"},{"line_number":111,"context_line":"        cls.backends \u003d [cinderlib.Backend(**cfg) for cfg in"},{"line_number":112,"context_line":"                        config[\u0027backends\u0027]]"},{"line_number":113,"context_line":"        # Lazy load backend\u0027s _volumes variable using the volumes property so"},{"line_number":114,"context_line":"        # new volumes are added to this list on successful creation."}],"source_content_type":"text/x-python","patch_set":8,"id":"4a93c3ae_9ab6fb63","line":111,"in_reply_to":"82aaf461_feb58928","updated":"2022-12-08 04:27:18.000000000","message":"\u003e pep8: F811 redefinition of unused \u0027cfg\u0027 from line 22\n\nDone","commit_id":"dad718c31d089570ab754ea785a89310589b8360"}],"cinderlib/tests/unit/base.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ea2034c42c65d6612a5e764189579aa14e08faff","unresolved":true,"context_lines":[{"line_number":30,"context_line":"    def _parse_cli_opts(self, args):"},{"line_number":31,"context_line":"        return original_cli_parser(self, [])"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    cfg.ConfigOpts._parse_cli_opts \u003d six.create_unbound_method(_parse_cli_opts,"},{"line_number":34,"context_line":"                                                               cfg.ConfigOpts)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"394ac5d2_721c3f75","side":"PARENT","line":33,"range":{"start_line":33,"start_character":37,"end_line":33,"end_character":62},"updated":"2022-12-07 19:18:43.000000000","message":"When running in py3, this wrapper simply returns the function (first argument), so that\u0027s all we need to do here.  Since that would just set _parse_cli_opts to itself, i think we can drop lines 27-34 and remove the call at line 37.","commit_id":"f02e693d25bb1f549efa47263c95e826eafdc62b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b140f37e350d2c58e30c786dbbd3962187a8125f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def _parse_cli_opts(self, args):"},{"line_number":31,"context_line":"        return original_cli_parser(self, [])"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    cfg.ConfigOpts._parse_cli_opts \u003d six.create_unbound_method(_parse_cli_opts,"},{"line_number":34,"context_line":"                                                               cfg.ConfigOpts)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"40630c55_af170fb3","side":"PARENT","line":33,"range":{"start_line":33,"start_character":37,"end_line":33,"end_character":62},"in_reply_to":"394ac5d2_721c3f75","updated":"2022-12-08 04:27:18.000000000","message":"Done","commit_id":"f02e693d25bb1f549efa47263c95e826eafdc62b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b140f37e350d2c58e30c786dbbd3962187a8125f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import unittest"},{"line_number":18,"context_line":"from unittest import mock"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":"import types"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import cinderlib"}],"source_content_type":"text/x-python","patch_set":8,"id":"9654080a_43fa795f","line":20,"in_reply_to":"8e58032b_6f22a18e","updated":"2022-12-08 04:27:18.000000000","message":"\u003e pep8: F401 \u0027oslo_config.cfg\u0027 imported but unused\n\nDone","commit_id":"dad718c31d089570ab754ea785a89310589b8360"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b140f37e350d2c58e30c786dbbd3962187a8125f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from unittest import mock"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":"import types"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import cinderlib"},{"line_number":24,"context_line":"from cinderlib.tests.unit import utils"}],"source_content_type":"text/x-python","patch_set":8,"id":"5c0561ef_3d157539","line":21,"in_reply_to":"187f1951_29688242","updated":"2022-12-08 04:27:18.000000000","message":"\u003e pep8: F401 \u0027types\u0027 imported but unused\n\nDone","commit_id":"dad718c31d089570ab754ea785a89310589b8360"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b140f37e350d2c58e30c786dbbd3962187a8125f","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def setUp(self):"},{"line_number":34,"context_line":"        if not self.PERSISTENCE_CFG:"},{"line_number":35,"context_line":"            cfg \u003d {\u0027storage\u0027: utils.get_mock_persistence()}"},{"line_number":36,"context_line":"            cinderlib.Backend.set_persistence(cfg)"},{"line_number":37,"context_line":"        self.backend_name \u003d \u0027fake_backend\u0027"},{"line_number":38,"context_line":"        self.backend \u003d utils.FakeBackend(volume_backend_name\u003dself.backend_name)"}],"source_content_type":"text/x-python","patch_set":8,"id":"472b5d07_32d3b133","line":35,"in_reply_to":"8bc096e7_4c1b2b10","updated":"2022-12-08 04:27:18.000000000","message":"\u003e pep8: F811 redefinition of unused \u0027cfg\u0027 from line 20\n\nDone","commit_id":"dad718c31d089570ab754ea785a89310589b8360"}]}