)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e855a04bdd965941b5383d61be5f4d29d81aee12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2d55c98e_7cf6c911","updated":"2022-06-25 06:14:31.000000000","message":"LGTM","commit_id":"b2214970033968ec9829e4ba370494193608a967"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1923371fdfc392b6f919649ecd4d1297da3c1cae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bff4fe90_52e8bcc4","updated":"2022-06-24 18:19:11.000000000","message":"LGTM, minor nits that should not block this patch","commit_id":"b2214970033968ec9829e4ba370494193608a967"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0d8d5fda64bf823a90322b760889659b45db69a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d2d9f517_3cd8ed0c","updated":"2022-06-14 15:03:32.000000000","message":"So, how do we know that this is working?  Someone was asking on the ML or in #openstack-requirements the other day why we aren\u0027t using the 4.x.x version of jsonschema.  If you look at the current stable/yoga upper constraints, it restricts jsonschema to 3.2.0 [0].  If you look at one of the job output for cinderlib-tox-py39 [1], you can see that it never even considers a more recent version of jsonschema, whereas if you look at the job output from a patch that doesn\u0027t include this change [2], you can see it download jsonschema-4.6.0 at 2022-06-09 14:02:46.795883 [3].\n\n[0] https://opendev.org/openstack/requirements/src/commit/952b2234a3d9ef94482892948bdb1fb836d2ab36/upper-constraints.txt#L583\n[1] https://e7fb4422092e7ee7d57a-685e6454d5878b87b1fb0dbe32cb950b.ssl.cf5.rackcdn.com/845607/6/check/cinderlib-tox-py39/c4b90f7/job-output.txt\n[2] https://review.opendev.org/c/openstack/cinderlib/+/845272\n[3] https://f281eb0604fd1130bd10-eb80c0e4aee14229f3b21e03b2a44f1c.ssl.cf1.rackcdn.com/845272/1/check/cinderlib-tox-py39/cdb8abd/job-output.txt","commit_id":"b2214970033968ec9829e4ba370494193608a967"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1de990e6eeb15dbc7c32405cb2bb2d5007d0f0f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b685e664_167200f6","updated":"2022-06-25 08:08:02.000000000","message":"Forgot to add my vote :)","commit_id":"e4dd75a3b4d6652df4724a5d81382947f7129305"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3649e72888288f2296976c53821cebe53bbfb51a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0fb9c618_017dddb8","updated":"2022-06-25 07:48:13.000000000","message":"LGTM","commit_id":"e4dd75a3b4d6652df4724a5d81382947f7129305"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9f2bdb5ef76d7ff3e0d6e6c4f65709c623b507ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"08e3beb4_72b2eda2","updated":"2022-06-25 06:25:20.000000000","message":"Rebased. Fixed merge conflict with https://review.opendev.org/c/openstack/cinderlib/+/847170","commit_id":"e4dd75a3b4d6652df4724a5d81382947f7129305"}],"tools/generate_uc.sh":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1923371fdfc392b6f919649ecd4d1297da3c1cae","unresolved":true,"context_lines":[{"line_number":34,"context_line":"    local C_FILE\u003d$(mktemp)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    # if we use OUTFILE here, wget will destroy its content when the GET fails"},{"line_number":37,"context_line":"    wget -q -O $C_FILE $UC_URL"},{"line_number":38,"context_line":"    WGET_EXIT\u003d$?"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    if [[ \"$WGET_EXIT\" \u003d\u003d \"0\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":6,"id":"fd6e7338_2e60fd59","line":37,"range":{"start_line":37,"start_character":4,"end_line":37,"end_character":8},"updated":"2022-06-24 18:19:11.000000000","message":"nit: I think it would be a bit better to use curl, but I\u0027m ok with wget","commit_id":"b2214970033968ec9829e4ba370494193608a967"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1923371fdfc392b6f919649ecd4d1297da3c1cae","unresolved":true,"context_lines":[{"line_number":79,"context_line":"    OUTFILE\u003d\"$OUTNAME\""},{"line_number":80,"context_line":"fi"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"get_constraints_file"},{"line_number":83,"context_line":"RESULT\u003d$?"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"if [[ \"$RESULT\" !\u003d \"0\" ]]; then"},{"line_number":86,"context_line":"    if ${NO_ERROR:-false} ; then"},{"line_number":87,"context_line":"        echo \"[warning] wget error code $RESULT when getting new constraints\""},{"line_number":88,"context_line":"    else"}],"source_content_type":"text/x-sh","patch_set":6,"id":"81954e19_30abe136","line":85,"range":{"start_line":82,"start_character":0,"end_line":85,"end_character":31},"updated":"2022-06-24 18:19:11.000000000","message":"nit: This looks a bit weird to me. I think this should do the job:\n\n  if get_constraints_file; then","commit_id":"b2214970033968ec9829e4ba370494193608a967"}]}
