)]}'
{"id":"openstack%2Fcinderlib~847622","triplet_id":"openstack%2Fcinderlib~stable%2Fxena~I0278b42785d14f92a521e6deff872dcba6505270","project":"openstack/cinderlib","branch":"stable/xena","topic":"fix-privsep","attention_set":{},"removed_from_attention_set":{"10459":{"account":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"last_update":"2022-06-27 10:39:06.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I0278b42785d14f92a521e6deff872dcba6505270","subject":"Fix privsep issues inside virtual env","status":"MERGED","created":"2022-06-24 21:48:01.000000000","updated":"2022-06-27 10:40:41.000000000","submitted":"2022-06-27 10:39:06.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"847622-fix-privsep","meta_rev_id":"cfd3f03cb3470b7870c08f63829b82cd68096af0","_number":847622,"virtual_id_number":847622,"owner":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-06-27 10:39:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2022-06-25 05:37:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},{"value":2,"date":"2022-06-27 09:15:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},{"value":1,"date":"2022-06-27 09:15:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-06-24 21:48:01.000000000","updated_by":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"reviewer":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"state":"CC"},{"updated":"2022-06-24 23:22:30.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-06-25 05:37:35.000000000","updated_by":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"reviewer":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"state":"REVIEWER"},{"updated":"2022-06-27 09:15:37.000000000","updated_by":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"reviewer":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"state":"REVIEWER"}],"messages":[{"id":"c6e7ff92b2fbb6a2b35a14386f4f98371b767a27","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2022-06-24 21:48:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2f09a4125f97dee3b7eeb854967dd50b6125595b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-24 23:22:30.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- test-release-openstack https://zuul.opendev.org/t/openstack/build/6904411ecd5c44f6988ac82ef04d8f6f : SUCCESS in 2m 19s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d650ac4114df4a0e9bc4085f71e0be58 : SUCCESS in 7m 09s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/f328a322de724b2aa7785fe89c657146 : SUCCESS in 3m 54s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7d3468308c0a4e2eab8b5c280e85693a : SUCCESS in 3m 58s\n- cinderlib-tox-py36 https://zuul.opendev.org/t/openstack/build/87b60b47e9174045bb990f3ee1f06d71 : SUCCESS in 7m 04s\n- cinderlib-tox-py37 https://zuul.opendev.org/t/openstack/build/53c7c57308fd4c1b8cf085afc028a38d : SUCCESS in 8m 23s\n- cinderlib-lvm-functional https://zuul.opendev.org/t/openstack/build/30e448b4be3d4dc1ab55c39c92ae0670 : SUCCESS in 8m 59s\n- cinderlib-ceph-functional https://zuul.opendev.org/t/openstack/build/4d231b1981e74d16b1102073fc589bbf : SUCCESS in 9m 50s\n- os-brick-src-tempest-lvm-lio-barbican https://zuul.opendev.org/t/openstack/build/0dc46b91f9b646f281730b2e1c33def7 : SUCCESS in 1h 28m 34s","accounts_in_message":[],"_revision_number":1},{"id":"011068c6a668f2e687ad331514813faaca2973c2","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2022-06-25 05:37:35.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"39efa22ca4722427a4e7fb6fb0094ededecb90e5","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2022-06-27 09:15:37.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"67602bdf6a55f16d183c3061d30a1d07f3e13f69","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-27 09:16:22.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"d126ec9f37e40d8580f6a865d7a93f7fa5e7f7f8","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-27 10:39:06.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- test-release-openstack https://zuul.opendev.org/t/openstack/build/9c0ea77e7c3f42f3b37b2472177ac0c4 : SUCCESS in 2m 13s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8779481559894814b2754ec5af242264 : SUCCESS in 6m 36s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/c13063a3585d4c1f9b244b2b5b9d5252 : SUCCESS in 4m 35s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/718ec931185842778f110ef6efafbcd5 : SUCCESS in 4m 14s\n- cinderlib-tox-py36 https://zuul.opendev.org/t/openstack/build/26578f608afa4fb485536c1b41e89289 : SUCCESS in 7m 01s\n- cinderlib-tox-py37 https://zuul.opendev.org/t/openstack/build/2d1ec0918db64aa2951a99b40795e2d2 : SUCCESS in 8m 02s\n- cinderlib-lvm-functional https://zuul.opendev.org/t/openstack/build/edcad033a10948e1a75e4b26ae76ee5e : SUCCESS in 11m 30s\n- cinderlib-ceph-functional https://zuul.opendev.org/t/openstack/build/29e6a6ad9cb541f2a18656cc1981ac0d : SUCCESS in 9m 32s\n- os-brick-src-tempest-lvm-lio-barbican https://zuul.opendev.org/t/openstack/build/a713ea2b2cb94697aac55c94c5395d80 : SUCCESS in 1h 21m 46s","accounts_in_message":[],"_revision_number":1},{"id":"ff748b9674d56605f4c0d9e562a4afeeb665d671","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-27 10:39:06.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"cfd3f03cb3470b7870c08f63829b82cd68096af0","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-27 10:40:41.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c4a167152c534203808349e061da64b4 : SUCCESS in 52s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/b9b78e951a5f4e19b44c4c7140f45723 : SUCCESS in 1m 13s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"4fc56c815b0e9e4d3706dca14bbe54fbb4866272","revisions":{"4fc56c815b0e9e4d3706dca14bbe54fbb4866272":{"kind":"REWORK","_number":1,"created":"2022-06-24 21:48:01.000000000","uploader":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"ref":"refs/changes/22/847622/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinderlib","ref":"refs/changes/22/847622/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/22/847622/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/22/847622/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/22/847622/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinderlib refs/changes/22/847622/1"}}},"commit":{"parents":[{"commit":"9ae3a1c771ef721d674b35a85dbd6f3095b05680","subject":"Migrate jobs from CentOS 8 to CentOS 8 Stream","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/9ae3a1c771ef721d674b35a85dbd6f3095b05680"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2022-06-22 12:58:55.000000000","tz":120},"committer":{"name":"Luigi Toscano","email":"ltoscano@redhat.com","date":"2022-06-24 21:47:39.000000000","tz":120},"subject":"Fix privsep issues inside virtual env","message":"Fix privsep issues inside virtual env\n\nWhen a virtual environment is created with the \"--system-site-packages\"\noption and privsep is installed on the system privsep will only use the\nsystem packages and completely ignore the ones in the virtual\nenvironment.\n\nThis results in errors such as the ones we see:\n\n- In the Ussuri gate: ModuleNotFoundError: No module named\n  \u0027os_brick.privileged.rootwrap\u0027\n\n- In the Wallaby gate: ModuleNotFoundError: No module named\n  \u0027os_brick.privileged.nvmeof\u0027\n\nThis happens because os-brick and cinder are starting privsep using the\n\"privsep-helper\" mechanism, and privsep was not installed in the virtual\nenv because it was already present system wide, so the \"privsep-helper\"\nthat is executed is the one from \"/usr/local/bin/privsep-helper\".\n\nThis python script \"privsep-helper\" ignores the virtual environment and\nforces usage of the system\u0027s python, for example in a Wallaby\ninstallation this could be \"#!/usr/bin/python3.6\".\n\nSince it ignores the virtual environment it won\u0027t use its packages and\nanything that\u0027s not present on system wide will not be found, and if\nfound it may be executing different code.\n\nThis patch fixes this issue by replacing the helper used to start\nprivsep with our own command.\n\nThis command is the same as the one usually installed in /usr/local/bin\nbut using /usr/bin/env to select the python to use.\n\nThis new script has been included as data in the cinderlib namespace\ninstead of making it install as a system script (like the original\nprivsep command) because we don\u0027t want to polute the system wide\nbinaries directory just for a corner case.\n\nWe also need to preserve user site-packages for the running Python when\ncalling root from the virtual environment, since the packages installed\non the virtual environment with \"--system-site-packages\" would have\ntaken those into consideration during the installation and not the ones\npresent on the root user.\n\nTo help debug issues at the gate all functional tests are now running\nwith debug logs.\n\nChange-Id: I0278b42785d14f92a521e6deff872dcba6505270\nRelated-Bug: #1958159\nCloses-Bug: #1979534\n(cherry picked from commit 4d784d23a91f789918929ca397910f3121fa166e)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/4fc56c815b0e9e4d3706dca14bbe54fbb4866272"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/4fc56c815b0e9e4d3706dca14bbe54fbb4866272"}]},"parents_data":[{"branch_name":"refs/heads/stable/xena","commit_id":"9ae3a1c771ef721d674b35a85dbd6f3095b05680","is_merged_in_target_branch":false,"change_id":"I5867be3e61121891a66f076c922a32bd586dc428","change_number":824418,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/stable/xena"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[]}