)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"20c465956b23d65cdbf9f2c5b9cf50458a1981be","unresolved":true,"context_lines":[{"line_number":14,"context_line":"  the gate (I didn\u0027t see this locally) even when usedevelop\u003dTrue"},{"line_number":15,"context_line":"- unfortunately, without skipsdist\u003dTrue, tox is now grabbing our"},{"line_number":16,"context_line":"  requirements.txt and installing everything in it, which is not"},{"line_number":17,"context_line":"  the behavior we want ... so this patch renames the file to"},{"line_number":18,"context_line":"  _requirements.txt until we figure out a workaround"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This patch also makes tox 4 the default so that we can hopefully"},{"line_number":21,"context_line":"catch problems locally before they block the gate (although that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"94467ffd_434e94d6","line":18,"range":{"start_line":17,"start_character":27,"end_line":18,"end_character":52},"updated":"2022-12-21 18:17:58.000000000","message":"how does this work? We\u0027ve a requirement that is constrained to be only installed if python version is less than 3.10\n\nimportlib_resources\u003e\u003d3.2.1;python_version\u003c\u00273.10\u0027 # Apache-2.0\n\nI think we\u0027ve a check for this in code so it might work but for any constraint, this might cause problems...","commit_id":"3d2862c518b633dcefd884fd55cd4d4c43f8f210"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"082398393ab3b79298dcb2a866ac288fe3493b53","unresolved":true,"context_lines":[{"line_number":14,"context_line":"  the gate (I didn\u0027t see this locally) even when usedevelop\u003dTrue"},{"line_number":15,"context_line":"- unfortunately, without skipsdist\u003dTrue, tox is now grabbing our"},{"line_number":16,"context_line":"  requirements.txt and installing everything in it, which is not"},{"line_number":17,"context_line":"  the behavior we want ... so this patch renames the file to"},{"line_number":18,"context_line":"  _requirements.txt until we figure out a workaround"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This patch also makes tox 4 the default so that we can hopefully"},{"line_number":21,"context_line":"catch problems locally before they block the gate (although that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"a8efd5ac_27220ff1","line":18,"range":{"start_line":17,"start_character":27,"end_line":18,"end_character":52},"in_reply_to":"94467ffd_434e94d6","updated":"2022-12-21 18:44:59.000000000","message":"We\u0027ve never included requirements.txt in deps for any of the testenvs; I think Gorka\u0027s idea was that cinderlib should not use any dependencies other than those of cinder and os-brick.  That said, neither cinder nor os-brick has importlib_resources as a dependency, so I\u0027m not sure where it\u0027s coming from.  \u0027pip freeze\u0027 shows that it\u0027s in 5.8 and 5.9 but not in py3.10:\n\n  [tox-4-ready] wha\u0027ppen? .tox/py38/bin/pip freeze | grep importlib\n  importlib-metadata\u003d\u003d5.0.0\n  importlib-resources\u003d\u003d5.10.1\n  [tox-4-ready] wha\u0027ppen? .tox/py39/bin/pip freeze | grep importlib\n  importlib-metadata\u003d\u003d5.0.0\n  importlib-resources\u003d\u003d5.10.1\n  [tox-4-ready] wha\u0027ppen? .tox/py310/bin/pip freeze | grep importlib\n  importlib-metadata\u003d\u003d5.0.0\n\nGorka had said a few cycles ago that the requirements.txt file is only there for people who install cinderlib from pip.  Maybe he\u0027s rethought that?\n\nIn any case, I don\u0027t have a good answer.  There\u0027s not a lot of cinderlib development going on at the moment, so we can wait to merge this patch until when Gorka\u0027s back after the holidays.","commit_id":"3d2862c518b633dcefd884fd55cd4d4c43f8f210"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2bb256f90e26277202f0260b6e465c14961011ae","unresolved":true,"context_lines":[{"line_number":14,"context_line":"  the gate (I didn\u0027t see this locally) even when usedevelop\u003dTrue"},{"line_number":15,"context_line":"- unfortunately, without skipsdist\u003dTrue, tox is now grabbing our"},{"line_number":16,"context_line":"  requirements.txt and installing everything in it, which is not"},{"line_number":17,"context_line":"  the behavior we want ... so this patch renames the file to"},{"line_number":18,"context_line":"  _requirements.txt until we figure out a workaround"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This patch also makes tox 4 the default so that we can hopefully"},{"line_number":21,"context_line":"catch problems locally before they block the gate (although that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1af11507_2309bb07","line":18,"range":{"start_line":17,"start_character":27,"end_line":18,"end_character":52},"in_reply_to":"a8efd5ac_27220ff1","updated":"2022-12-22 10:42:06.000000000","message":"This looks OK in master but when we pin cinder and os-brick, I\u0027m afraid we might have issues during that time. The only concern i have is if we\u0027re not breaking any deployment case where requirements file is used. Even if we rename the requirements file here we will need to actually fix the issue and rename it later...","commit_id":"3d2862c518b633dcefd884fd55cd4d4c43f8f210"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"69dbb6aab711edcad362264f25bca5cf4d66d006","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"86e99bd4_cdb29557","updated":"2022-12-19 22:31:56.000000000","message":"recheck cannot reproduce locally","commit_id":"01d81324c87b7d919004828521d6d8bfe4eb5a9d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"082398393ab3b79298dcb2a866ac288fe3493b53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"17379364_95249a02","updated":"2022-12-21 18:44:59.000000000","message":"@Rajat: replies inline.","commit_id":"3d2862c518b633dcefd884fd55cd4d4c43f8f210"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2bb256f90e26277202f0260b6e465c14961011ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e1677628_089fd5de","updated":"2022-12-22 10:42:06.000000000","message":"I don\u0027t have major concerns here and honestly i don\u0027t have full context even if this will cause any issue or not. I\u0027m +1 on this, if Brian thinks it\u0027s OK to move forward then i will merge it.","commit_id":"3d2862c518b633dcefd884fd55cd4d4c43f8f210"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"f39922dcdd7c0d1ac972b5f320aa7a1928fd5f75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1a245c28_a4a3120c","updated":"2022-12-21 14:38:05.000000000","message":"LGTM","commit_id":"3d2862c518b633dcefd884fd55cd4d4c43f8f210"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"c96329403b78d1c04617a04562ef5b5562064625","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"20363af3_e2f1c84d","updated":"2022-12-21 14:39:04.000000000","message":"LGTM, welcome tox 4","commit_id":"3d2862c518b633dcefd884fd55cd4d4c43f8f210"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c69c10ab897e754ce1e09111d89e50b73bfdd12b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9e407272_7f3b41e4","updated":"2022-12-22 13:45:52.000000000","message":"Thinking about Rajat\u0027s comments, I realized that I didn\u0027t have the bindep testenv defined properly, so I fixed that now so I don\u0027t forget.\n\nI\u0027m OK with holding this until 2023.  Let\u0027s schedule a video meeting of the cinderlib core team (i.e., the cinder-core team) and invite anyone else interested in cinderlib development to discuss these issues and figure out the best way to move forward.\n\nAlso realized that I need to rebase this directly on master; since the parent patch hasn\u0027t merged yet and tox 4 becomes the default today, the dependency relation has changed.","commit_id":"3a9f4979c87bdb1d24427ee03f99c3fbe563d647"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"77d508ce22f9c869da537156fa63de298f3e0475","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c52981b7_0c428f2f","updated":"2023-01-04 14:56:03.000000000","message":"With tox4, the py311 job is not reading correctly the binary to be used [1]:\n2022-12-22 13:54:24.824301 | ubuntu-jammy | /home/zuul/.local/tox/bin/python3 (/home/zuul/.local/tox/bin/python3) is {\u0027executable\u0027: \u0027/home/zuul/.local/tox/bin/python3\u0027, \u0027implementation\u0027: \u0027CPython\u0027, \u0027version_info\u0027: [3, 10, 6, \u0027final\u0027, 0], \u0027version\u0027: \u00273.10.6 (main, Nov 14 2022, 16:10:14) [GCC 11.3.0]\u0027, \u0027is_64\u0027: True, \u0027sysplatform\u0027: \u0027linux\u0027, \u0027os_sep\u0027: \u0027/\u0027, \u0027extra_version_info\u0027: None}\n\n\nI found the same issue in Neutron CI when trying to test py311\n\n[1]https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_795/866936/6/check/cinderlib-tox-py311/79578c4/job-output.txt","commit_id":"308c5ab78e79775226e8614ab4a09fa5f7ed4f9f"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"b182551685b840aed669351eabf51ba3b03b2cd6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"db84027f_c3e2f0bd","in_reply_to":"9c838d2c_d4d53461","updated":"2023-02-15 18:57:02.000000000","message":"The tox issue seems to be have been fixed, time to restart this effort?","commit_id":"308c5ab78e79775226e8614ab4a09fa5f7ed4f9f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"999dbe1eb45aedf50d8a34b724874f70fe301a70","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9c838d2c_d4d53461","in_reply_to":"c52981b7_0c428f2f","updated":"2023-01-09 18:46:26.000000000","message":"Thanks for the note, Rodolfo.  There was an issue in tox where basepython\u003dpython3 set in [testenv] would cause the system python3 to be used for any of the -pyXX environments instead of the requested python.  I think that\u0027s been fixed, but now there\u0027s an open issue where basepython\u003dpython3 doesn\u0027t work with functional-pyXX environments: https://github.com/tox-dev/tox/issues/2838\n\nI propose to wait for ^^ to be fixed and released, and then do a recheck on this patch (and look to make sure that each job is using the correct python version!).","commit_id":"308c5ab78e79775226e8614ab4a09fa5f7ed4f9f"}],"tox.ini":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"20c465956b23d65cdbf9f2c5b9cf50458a1981be","unresolved":true,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"allowlist_externals \u003d"},{"line_number":84,"context_line":"  {[testenv]allowlist_externals}"},{"line_number":85,"context_line":"  stestr"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"[testenv:functional-py{38,39,310,311}]"},{"line_number":88,"context_line":"install_command \u003d {[testenv:functional]install_command}"}],"source_content_type":"text/x-properties","patch_set":4,"id":"efa78f29_fc27148f","side":"PARENT","line":85,"range":{"start_line":85,"start_character":2,"end_line":85,"end_character":8},"updated":"2022-12-21 18:17:58.000000000","message":"I don\u0027t see stestr in above allowlist_externals sections where we are inheriting from? so I\u0027m not sure where stestr is coming from","commit_id":"642fbea5e409e8aaa91d4c911df34498b8e6fe4d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2bb256f90e26277202f0260b6e465c14961011ae","unresolved":true,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"allowlist_externals \u003d"},{"line_number":84,"context_line":"  {[testenv]allowlist_externals}"},{"line_number":85,"context_line":"  stestr"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"[testenv:functional-py{38,39,310,311}]"},{"line_number":88,"context_line":"install_command \u003d {[testenv:functional]install_command}"}],"source_content_type":"text/x-properties","patch_set":4,"id":"d25d5ab5_c5c41d02","side":"PARENT","line":85,"range":{"start_line":85,"start_character":2,"end_line":85,"end_character":8},"in_reply_to":"c4cc627f_5003d6d8","updated":"2022-12-22 10:42:06.000000000","message":"Ack, I was just confused since we removed it and saw nowhere it is coming from. Maybe it was redundant before as well.","commit_id":"642fbea5e409e8aaa91d4c911df34498b8e6fe4d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"082398393ab3b79298dcb2a866ac288fe3493b53","unresolved":true,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"allowlist_externals \u003d"},{"line_number":84,"context_line":"  {[testenv]allowlist_externals}"},{"line_number":85,"context_line":"  stestr"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"[testenv:functional-py{38,39,310,311}]"},{"line_number":88,"context_line":"install_command \u003d {[testenv:functional]install_command}"}],"source_content_type":"text/x-properties","patch_set":4,"id":"c4cc627f_5003d6d8","side":"PARENT","line":85,"range":{"start_line":85,"start_character":2,"end_line":85,"end_character":8},"in_reply_to":"efa78f29_fc27148f","updated":"2022-12-21 18:44:59.000000000","message":"I think the deal is that if you use something that tox has installed itself in the virtualenv (stestr is in test-requirements.txt), it\u0027s not considered \"external\", so we don\u0027t need to specify it.","commit_id":"642fbea5e409e8aaa91d4c911df34498b8e6fe4d"}]}