)]}'
{"id":"openstack%2Fcinderlib~879035","triplet_id":"openstack%2Fcinderlib~master~Ia243368a9d68aca3a717fb2be1da99bceb271e56","project":"openstack/cinderlib","branch":"master","topic":"fix-ut","attention_set":{},"removed_from_attention_set":{"5314":{"account":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"last_update":"2023-04-21 17:30:27.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ia243368a9d68aca3a717fb2be1da99bceb271e56","subject":"Don\u0027t use deprecated config opt name in unit test","status":"MERGED","created":"2023-03-30 10:44:25.000000000","updated":"2023-04-21 17:31:34.000000000","submitted":"2023-04-21 17:30:27.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"879035-fix-ut","meta_rev_id":"74a3843a06c14af2bf9873de2f43d894350c752c","_number":879035,"virtual_id_number":879035,"owner":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-04-21 17:30:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},{"value":0,"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2023-04-21 14:41:50.000000000","_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},{"value":2,"date":"2023-03-31 05:38:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2023-04-21 14:41:50.000000000","_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},{"value":0,"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},{"value":0,"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-03-30 12:54:59.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-03-31 05:38:29.000000000","updated_by":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"reviewer":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"state":"REVIEWER"},{"updated":"2023-04-21 14:41:50.000000000","updated_by":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"reviewer":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"state":"REVIEWER"}],"messages":[{"id":"52e8abe904ab920e91d7fb3e57c8a26ec4016227","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2023-03-30 10:44:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"067f9c781934262dedd3a7a4638a33e5bdc4952c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-30 12:54:59.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/7883948807704bf8b2ebf80b92d2b650\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6d266a984d814435aa46a8ef622aa0bb : SUCCESS in 7m 12s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d1151dda35a64f59af58912b32ff96fd : SUCCESS in 5m 00s\n- cinderlib-tox-py38 https://zuul.opendev.org/t/openstack/build/6d8d5065385c42dfb1729957dfb38bb4 : SUCCESS in 6m 23s\n- cinderlib-tox-py310 https://zuul.opendev.org/t/openstack/build/94d6626061544357932818421bb19f3d : SUCCESS in 6m 09s\n- cinderlib-tox-py311 https://zuul.opendev.org/t/openstack/build/d86bef8411154ddbb56369af7d8b8c0c : SUCCESS in 6m 47s (non-voting)\n- cinderlib-lvm-functional https://zuul.opendev.org/t/openstack/build/1ebb350fcbdb4f11a3d566f67b3615f3 : SUCCESS in 13m 07s\n- cinderlib-ceph-functional https://zuul.opendev.org/t/openstack/build/b4010eaf429b4b0c97d56143fbbecdf3 : SUCCESS in 8m 49s\n- os-brick-src-tempest-lvm-lio-barbican https://zuul.opendev.org/t/openstack/build/ff096eceb207483493540ee8aa57dd4b : SUCCESS in 2h 02m 55s","accounts_in_message":[],"_revision_number":1},{"id":"2d0c7b1dabda4821af043c607525439496ed2e29","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2023-03-31 05:38:29.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"be75e75e554c76546e25e7ec9a27e889e6a7b4f5","author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"date":"2023-04-21 14:41:50.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d84d56e7c996a54f19784408440dd8c19a293230","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-04-21 14:42:29.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"3e4c707f88353a29e2f3da891921131af86cdc57","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-04-21 17:30:27.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/b1d5c636ae1b42b286f9b83635ba7865\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/82fcd5a955484633898ca8d7e60bd3e3 : SUCCESS in 7m 14s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f52978f8e3fe4ddfb3c16d9e15b69ca8 : SUCCESS in 5m 35s\n- cinderlib-tox-py38 https://zuul.opendev.org/t/openstack/build/b57801b3ac014f12bfc28553a693fd24 : SUCCESS in 5m 51s\n- cinderlib-tox-py310 https://zuul.opendev.org/t/openstack/build/8d7ea085e39341d19cdba4c1a830bcf2 : SUCCESS in 7m 10s\n- cinderlib-lvm-functional https://zuul.opendev.org/t/openstack/build/b45dc1c3f3284f52970c42f0404b6f0a : SUCCESS in 11m 04s\n- cinderlib-ceph-functional https://zuul.opendev.org/t/openstack/build/6154ca9171b7437791f0bdb4b4081813 : SUCCESS in 10m 01s\n- os-brick-src-tempest-lvm-lio-barbican https://zuul.opendev.org/t/openstack/build/2b6f37d1c6c24f82867ba681dbc94cfd : SUCCESS in 1h 53m 46s","accounts_in_message":[],"_revision_number":1},{"id":"41c87b6e75565ea0fcf63d3b8d664e4c77fd4f22","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-04-21 17:30:27.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"74a3843a06c14af2bf9873de2f43d894350c752c","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-04-21 17:31:34.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/2b69257c9a8e427faf46c87b5b485d07\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/04ba95a0d9af44e69146f28361d7b7be : SUCCESS in 41s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d3c48523ccd07a9edd4f2d705ba5d573d52191e1","revisions":{"d3c48523ccd07a9edd4f2d705ba5d573d52191e1":{"kind":"REWORK","_number":1,"created":"2023-03-30 10:44:25.000000000","uploader":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"ref":"refs/changes/35/879035/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinderlib","ref":"refs/changes/35/879035/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/35/879035/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/35/879035/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinderlib refs/changes/35/879035/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinderlib refs/changes/35/879035/1"}}},"commit":{"parents":[{"commit":"9c37686f358e9228446cd85e19db26a56b2f9cbe","subject":"Merge \"Remove unnecessary #egg\u003d URL fragment\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/9c37686f358e9228446cd85e19db26a56b2f9cbe"}]}],"author":{"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","date":"2023-03-30 10:34:56.000000000","tz":-240},"committer":{"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","date":"2023-03-30 10:34:56.000000000","tz":-240},"subject":"Don\u0027t use deprecated config opt name in unit test","message":"Don\u0027t use deprecated config opt name in unit test\n\nWith cinder change Iccfbe62406b6, the \u0027iscsi_secondary_ip_addresses\u0027\nopt was deprecated in favor of \u0027target_secondary_ip_addresses\u0027.  This\nbroke a cinderlib unit test that checked to see if a mocked logger\nwas not called (which it now was, to log a deprecation message).  Use\nthe current option name in the test so that the test continues to\ntest what it was designed to test (i.e., cinderlib config loading,\nnot oslo.config option deprecation).\n\nChange-Id: Ia243368a9d68aca3a717fb2be1da99bceb271e56\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/d3c48523ccd07a9edd4f2d705ba5d573d52191e1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinderlib/commit/d3c48523ccd07a9edd4f2d705ba5d573d52191e1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review priority","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:Review-Priority\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:Review-Priority\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}