)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"c9c93829f811bece84322e96a1473b30da622ec6","unresolved":true,"context_lines":[{"line_number":15,"context_line":"Update get_iscsi_target_details() to paginate through all pages of"},{"line_number":16,"context_line":"iscsi-interface-get-iter, requesting up to 100 records per page and"},{"line_number":17,"context_line":"following next-tag until ONTAP reports no further pages."},{"line_number":18,"context_line":"Assisted-By: Cursor Claude-4.6-Sonnet"},{"line_number":19,"context_line":"AI-modified files:"},{"line_number":20,"context_line":"- cinder/tests/unit/volume/drivers/netapp/dataontap/client/test_client_cmode.py"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"62fd1728_85a1ebce","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":37},"updated":"2026-09-07 10:34:02.000000000","message":"use Co-authored-By tag instead.","commit_id":"595036c1be7189d63d8512d5cec58df09eec0f92"},{"author":{"_account_id":38411,"name":"Hemanth C","display_name":"Hemanth","email":"hemanthc@netapp.com","username":"Hemanthc","status":"Netapp"},"change_message_id":"a0e0bb369814670fc873021c3fc06449a584b1c8","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Update get_iscsi_target_details() to paginate through all pages of"},{"line_number":16,"context_line":"iscsi-interface-get-iter, requesting up to 100 records per page and"},{"line_number":17,"context_line":"following next-tag until ONTAP reports no further pages."},{"line_number":18,"context_line":"Assisted-By: Cursor Claude-4.6-Sonnet"},{"line_number":19,"context_line":"AI-modified files:"},{"line_number":20,"context_line":"- cinder/tests/unit/volume/drivers/netapp/dataontap/client/test_client_cmode.py"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"a8b61f25_e1f19110","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":37},"in_reply_to":"62fd1728_85a1ebce","updated":"2026-09-07 14:22:23.000000000","message":"Updated.","commit_id":"595036c1be7189d63d8512d5cec58df09eec0f92"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"c9c93829f811bece84322e96a1473b30da622ec6","unresolved":true,"context_lines":[{"line_number":16,"context_line":"iscsi-interface-get-iter, requesting up to 100 records per page and"},{"line_number":17,"context_line":"following next-tag until ONTAP reports no further pages."},{"line_number":18,"context_line":"Assisted-By: Cursor Claude-4.6-Sonnet"},{"line_number":19,"context_line":"AI-modified files:"},{"line_number":20,"context_line":"- cinder/tests/unit/volume/drivers/netapp/dataontap/client/test_client_cmode.py"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Ie5fe525040754e6ab3717979d924f15b234f872b"},{"line_number":23,"context_line":"Signed-off-by: hemanthc \u003chemanthc@netapp.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fc1596ba_b7997263","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":79},"updated":"2026-09-07 10:34:02.000000000","message":"remove this line.","commit_id":"595036c1be7189d63d8512d5cec58df09eec0f92"},{"author":{"_account_id":38411,"name":"Hemanth C","display_name":"Hemanth","email":"hemanthc@netapp.com","username":"Hemanthc","status":"Netapp"},"change_message_id":"a0e0bb369814670fc873021c3fc06449a584b1c8","unresolved":false,"context_lines":[{"line_number":16,"context_line":"iscsi-interface-get-iter, requesting up to 100 records per page and"},{"line_number":17,"context_line":"following next-tag until ONTAP reports no further pages."},{"line_number":18,"context_line":"Assisted-By: Cursor Claude-4.6-Sonnet"},{"line_number":19,"context_line":"AI-modified files:"},{"line_number":20,"context_line":"- cinder/tests/unit/volume/drivers/netapp/dataontap/client/test_client_cmode.py"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Ie5fe525040754e6ab3717979d924f15b234f872b"},{"line_number":23,"context_line":"Signed-off-by: hemanthc \u003chemanthc@netapp.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"b7ce8dd2_46fde2f9","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":79},"in_reply_to":"fc1596ba_b7997263","updated":"2026-09-07 14:22:23.000000000","message":"Done","commit_id":"595036c1be7189d63d8512d5cec58df09eec0f92"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"c9c93829f811bece84322e96a1473b30da622ec6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1351712a_22e9128d","updated":"2026-09-07 10:34:02.000000000","message":"Please take a look at the comments.","commit_id":"595036c1be7189d63d8512d5cec58df09eec0f92"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"2654e0f1bcecb039fb9b043bfeb56836aca5627f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"57ea89cb_e72c5310","updated":"2026-09-07 11:59:08.000000000","message":"Please have \"Closes-Bug:\" updated in the commit message. https://bugs.launchpad.net/cinder/+bug/2166372","commit_id":"f066c19b203915fd17fcb5465301de3d17e3e2f2"},{"author":{"_account_id":38411,"name":"Hemanth C","display_name":"Hemanth","email":"hemanthc@netapp.com","username":"Hemanthc","status":"Netapp"},"change_message_id":"45bebee5b52dc81263eefaacf95b7c3c93dc060e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"85b460be_f5c20514","updated":"2026-09-07 14:46:52.000000000","message":"recheck","commit_id":"23be9e0a361cdb21272269144722e2cec1bb5eb8"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"96687493eb57516d4be720a9137d4370d56cc9bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6397affc_885137d3","updated":"2026-09-08 03:18:03.000000000","message":"Run-NetApp CI","commit_id":"a65d60d2252abb7f0f9ec0536e8f357a8157a224"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"23beace53be6a6bbefe4f2ba591e9f6311212521","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4538ecb8_a2030c40","updated":"2026-09-10 13:56:47.000000000","message":"Code and test changes + new test LGTM.  Hemanth, hanks for the detailed writeup in the commit message and bug report.  Good suggestion by Anoop on PS 3 to use send_iter_request, it makes the patch much cleaner.","commit_id":"b51c86d5c61335755b6fde945a75763dc9047ab6"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"e65e04c360606a1029b4f0613db4970f68b6f7f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b68cc470_1ba6db43","updated":"2026-09-09 15:01:05.000000000","message":"LGTM","commit_id":"b51c86d5c61335755b6fde945a75763dc9047ab6"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"730d2c43318b3d147ecdcb7e9ba3dd6f7e2cc992","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"51903b6f_fc697cc8","updated":"2026-09-08 04:52:14.000000000","message":"LGTM\n\n@anthony.galica@hitachivantara.com, @rosmaita.fossdev@gmail.com - Would be great if you could help with the reviews. This is a customer issue and has some urgency tied to it.","commit_id":"b51c86d5c61335755b6fde945a75763dc9047ab6"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"ac21d7acf43349a6723b75aa9266c6a50caaa5b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6d5f0d66_ea2a8260","updated":"2026-09-09 15:12:32.000000000","message":"Looks good to me, thanks for raising the patch Hemanth.","commit_id":"b51c86d5c61335755b6fde945a75763dc9047ab6"}],"cinder/tests/unit/volume/drivers/netapp/dataontap/client/test_client_cmode.py":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"c9c93829f811bece84322e96a1473b30da622ec6","unresolved":true,"context_lines":[{"line_number":412,"context_line":"        target_list \u003d self.client.get_iscsi_target_details()"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"        self.assertEqual([expected_target], target_list)"},{"line_number":415,"context_line":"    "},{"line_number":416,"context_line":"    def test_get_iscsi_target_details_with_multiple_pages(self):"},{"line_number":417,"context_line":"        target_1 \u003d {"},{"line_number":418,"context_line":"            \"address\": \"127.0.0.1\","}],"source_content_type":"text/x-python","patch_set":3,"id":"fd39a25d_6594758f","line":415,"updated":"2026-09-07 10:34:02.000000000","message":"The whitespace may be causing pep8 failure. Please check.","commit_id":"595036c1be7189d63d8512d5cec58df09eec0f92"},{"author":{"_account_id":38411,"name":"Hemanth C","display_name":"Hemanth","email":"hemanthc@netapp.com","username":"Hemanthc","status":"Netapp"},"change_message_id":"a0e0bb369814670fc873021c3fc06449a584b1c8","unresolved":false,"context_lines":[{"line_number":412,"context_line":"        target_list \u003d self.client.get_iscsi_target_details()"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"        self.assertEqual([expected_target], target_list)"},{"line_number":415,"context_line":"    "},{"line_number":416,"context_line":"    def test_get_iscsi_target_details_with_multiple_pages(self):"},{"line_number":417,"context_line":"        target_1 \u003d {"},{"line_number":418,"context_line":"            \"address\": \"127.0.0.1\","}],"source_content_type":"text/x-python","patch_set":3,"id":"f65a1709_4bceef36","line":415,"in_reply_to":"fd39a25d_6594758f","updated":"2026-09-07 14:22:23.000000000","message":"Done.","commit_id":"595036c1be7189d63d8512d5cec58df09eec0f92"}],"cinder/volume/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"c9c93829f811bece84322e96a1473b30da622ec6","unresolved":true,"context_lines":[{"line_number":346,"context_line":"        iscsi_if_iter \u003d netapp_api.NaElement(\u0027iscsi-interface-get-iter\u0027)"},{"line_number":347,"context_line":"        iscsi_if_iter.add_new_child(\u0027max-records\u0027, \u0027100\u0027)"},{"line_number":348,"context_line":"        while True:"},{"line_number":349,"context_line":"            result \u003d self.connection.invoke_successfully(iscsi_if_iter, True)"},{"line_number":350,"context_line":"            num_records \u003d result.get_child_content(\u0027num-records\u0027)"},{"line_number":351,"context_line":"            if num_records and int(num_records) \u003e\u003d 1:"},{"line_number":352,"context_line":"                attr_list \u003d result.get_child_by_name(\u0027attributes-list\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"2067d8e5_e1700010","line":349,"updated":"2026-09-07 10:34:02.000000000","message":"I think its better to use send_iter_request instead of the while loop:\n\n```suggestion\n            result \u003d self.send_iter_request(\u0027iscsi-interface-get-iter\u0027)\n```","commit_id":"595036c1be7189d63d8512d5cec58df09eec0f92"},{"author":{"_account_id":38411,"name":"Hemanth C","display_name":"Hemanth","email":"hemanthc@netapp.com","username":"Hemanthc","status":"Netapp"},"change_message_id":"a0e0bb369814670fc873021c3fc06449a584b1c8","unresolved":false,"context_lines":[{"line_number":346,"context_line":"        iscsi_if_iter \u003d netapp_api.NaElement(\u0027iscsi-interface-get-iter\u0027)"},{"line_number":347,"context_line":"        iscsi_if_iter.add_new_child(\u0027max-records\u0027, \u0027100\u0027)"},{"line_number":348,"context_line":"        while True:"},{"line_number":349,"context_line":"            result \u003d self.connection.invoke_successfully(iscsi_if_iter, True)"},{"line_number":350,"context_line":"            num_records \u003d result.get_child_content(\u0027num-records\u0027)"},{"line_number":351,"context_line":"            if num_records and int(num_records) \u003e\u003d 1:"},{"line_number":352,"context_line":"                attr_list \u003d result.get_child_by_name(\u0027attributes-list\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"987ba89c_ac13bc38","line":349,"in_reply_to":"2067d8e5_e1700010","updated":"2026-09-07 14:22:23.000000000","message":"Changed accordingly.","commit_id":"595036c1be7189d63d8512d5cec58df09eec0f92"}]}