)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"577f4e0dd3104fb7cf1518c765a9b900f9bab7a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"92c20c35_04e99cb8","updated":"2026-10-27 03:55:16.000000000","message":"Hi @rajatdhasmana@gmail.com,\n\nI have made the suggested changes.  Thank you for your review!","commit_id":"b51ae8fd92faca3be7b9e241f0c4d5756b9b980c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f102421985e823000beb7eeb1f55aed6d502fee2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"8147b5c9_f53eabbd","updated":"2026-10-27 14:37:47.000000000","message":"Some comments on the release note after you get the other stuff fixed.","commit_id":"b51ae8fd92faca3be7b9e241f0c4d5756b9b980c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a5a3ed15995d63134c2af7e465b8a3f55ddc3644","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"bf838a13_9fafda45","updated":"2026-10-27 13:49:44.000000000","message":"unit test failure is cinder.tests.unit.volume.drivers.hitachi.test_hitachi_hbsd_rest_iscsi.HBSDRESTISCSIDriverTest.test_to_spc_name","commit_id":"b51ae8fd92faca3be7b9e241f0c4d5756b9b980c"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"e68da4f47f7d293a63eb24a4d898fcf5b38ae88a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"f1e78f78_d45d1526","updated":"2026-10-27 23:08:35.000000000","message":"Thanks for the review, Brian.  I have updated the release notes and (hopefully) the docs and UT should pass now.","commit_id":"c7c1ad250d5f67179f23e4f12bb0402c42b2029d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"25939e13ed82b05b9165d82904a77b9c84260026","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3dc475da_f71e98bb","updated":"2026-10-28 19:56:21.000000000","message":"few corrections in the releasenote, also the zuul and hitachi CI are failing","commit_id":"353109ebcde9196337c127d702f6480c4e3b21b2"}],"cinder/volume/drivers/hitachi/hbsd_common.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"aac6e6dfe55559330e842ade0c3049819237986e","unresolved":true,"context_lines":[{"line_number":152,"context_line":"        default\u003dFalse,"},{"line_number":153,"context_line":"        help\u003d\u0027Set True to announce auto unmap/discard support.\u0027),"},{"line_number":154,"context_line":"    cfg.StrOpt("},{"line_number":155,"context_line":"        \u0027hitachi_group_search_pattern\u0027,"},{"line_number":156,"context_line":"        default\u003d\"\","},{"line_number":157,"context_line":"        help\u003d\u0027The regex pattern to use when searching for host groups, iSCSI \u0027"},{"line_number":158,"context_line":"             \u0027targets, or NVMe subsystems. Groups that do not match this \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a4e638b_7f31dabd","line":155,"range":{"start_line":155,"start_character":9,"end_line":155,"end_character":37},"updated":"2026-10-26 20:42:58.000000000","message":"also provide few examples of what end users/operators can set as search patterns","commit_id":"7a1891e4ddaf99b27570fe07c8a24455ff506ea1"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"577f4e0dd3104fb7cf1518c765a9b900f9bab7a8","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        default\u003dFalse,"},{"line_number":153,"context_line":"        help\u003d\u0027Set True to announce auto unmap/discard support.\u0027),"},{"line_number":154,"context_line":"    cfg.StrOpt("},{"line_number":155,"context_line":"        \u0027hitachi_group_search_pattern\u0027,"},{"line_number":156,"context_line":"        default\u003d\"\","},{"line_number":157,"context_line":"        help\u003d\u0027The regex pattern to use when searching for host groups, iSCSI \u0027"},{"line_number":158,"context_line":"             \u0027targets, or NVMe subsystems. Groups that do not match this \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"bcbf4cf6_5729c1c6","line":155,"range":{"start_line":155,"start_character":9,"end_line":155,"end_character":37},"in_reply_to":"5a4e638b_7f31dabd","updated":"2026-10-27 03:55:16.000000000","message":"Acknowledged","commit_id":"7a1891e4ddaf99b27570fe07c8a24455ff506ea1"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7f4ce9a09c5b08ee4c38b896a96202bb86a8d308","unresolved":true,"context_lines":[{"line_number":161,"context_line":"    cfg.BoolOpt("},{"line_number":162,"context_line":"        \u0027hitachi_use_group_search_optimization\u0027,"},{"line_number":163,"context_line":"        default\u003dFalse,"},{"line_number":164,"context_line":"        help\u003d\u0027Set True to enable group search optimization when\u0027"},{"line_number":165,"context_line":"             \u0027HBA searches are required.\u0027),"},{"line_number":166,"context_line":"]"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"a0d09936_148a82ee","line":164,"range":{"start_line":164,"start_character":63,"end_line":164,"end_character":64},"updated":"2026-10-26 20:40:18.000000000","message":"nit: add space here","commit_id":"7a1891e4ddaf99b27570fe07c8a24455ff506ea1"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"577f4e0dd3104fb7cf1518c765a9b900f9bab7a8","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    cfg.BoolOpt("},{"line_number":162,"context_line":"        \u0027hitachi_use_group_search_optimization\u0027,"},{"line_number":163,"context_line":"        default\u003dFalse,"},{"line_number":164,"context_line":"        help\u003d\u0027Set True to enable group search optimization when\u0027"},{"line_number":165,"context_line":"             \u0027HBA searches are required.\u0027),"},{"line_number":166,"context_line":"]"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ebfaf036_19783b99","line":164,"range":{"start_line":164,"start_character":63,"end_line":164,"end_character":64},"in_reply_to":"a0d09936_148a82ee","updated":"2026-10-27 03:55:16.000000000","message":"Acknowledged","commit_id":"7a1891e4ddaf99b27570fe07c8a24455ff506ea1"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7f4ce9a09c5b08ee4c38b896a96202bb86a8d308","unresolved":true,"context_lines":[{"line_number":162,"context_line":"        \u0027hitachi_use_group_search_optimization\u0027,"},{"line_number":163,"context_line":"        default\u003dFalse,"},{"line_number":164,"context_line":"        help\u003d\u0027Set True to enable group search optimization when\u0027"},{"line_number":165,"context_line":"             \u0027HBA searches are required.\u0027),"},{"line_number":166,"context_line":"]"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"COMMON_PORT_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":9,"id":"b09feb6c_dc619b3f","line":165,"range":{"start_line":165,"start_character":14,"end_line":165,"end_character":17},"updated":"2026-10-26 20:40:18.000000000","message":"we mention HBA here which seems FC specific but the search pattern mentions about iSCSI, NVMe (could be NVMe-tcp) so should we make this help text more generic?","commit_id":"7a1891e4ddaf99b27570fe07c8a24455ff506ea1"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"577f4e0dd3104fb7cf1518c765a9b900f9bab7a8","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        \u0027hitachi_use_group_search_optimization\u0027,"},{"line_number":163,"context_line":"        default\u003dFalse,"},{"line_number":164,"context_line":"        help\u003d\u0027Set True to enable group search optimization when\u0027"},{"line_number":165,"context_line":"             \u0027HBA searches are required.\u0027),"},{"line_number":166,"context_line":"]"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"COMMON_PORT_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":9,"id":"2885e227_b70cb8d8","line":165,"range":{"start_line":165,"start_character":14,"end_line":165,"end_character":17},"in_reply_to":"b09feb6c_dc619b3f","updated":"2026-10-27 03:55:16.000000000","message":"Yeah, it should say \"host group\" (shared name for iSCSI and FC).  NVMe doesn\u0027t apply here.","commit_id":"7a1891e4ddaf99b27570fe07c8a24455ff506ea1"}],"cinder/volume/drivers/hitachi/hbsd_rest_iscsi.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7f4ce9a09c5b08ee4c38b896a96202bb86a8d308","unresolved":true,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        # The SPC naming scheme is to convert the IQN to a hash"},{"line_number":206,"context_line":"        # and truncate the first 4 characters...."},{"line_number":207,"context_line":"        hash \u003d hashlib.md5(iqn.encode()).hexdigest()"},{"line_number":208,"context_line":"        return hash[4:]"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    def find_targets_from_storage(self, targets, connector, target_ports):"}],"source_content_type":"text/x-python","patch_set":9,"id":"5320b56e_e3d90a35","line":207,"range":{"start_line":207,"start_character":15,"end_line":207,"end_character":52},"updated":"2026-10-26 20:40:18.000000000","message":"this should include usedforsecurity\u003dFalse when calling md5","commit_id":"7a1891e4ddaf99b27570fe07c8a24455ff506ea1"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"577f4e0dd3104fb7cf1518c765a9b900f9bab7a8","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        # The SPC naming scheme is to convert the IQN to a hash"},{"line_number":206,"context_line":"        # and truncate the first 4 characters...."},{"line_number":207,"context_line":"        hash \u003d hashlib.md5(iqn.encode()).hexdigest()"},{"line_number":208,"context_line":"        return hash[4:]"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    def find_targets_from_storage(self, targets, connector, target_ports):"}],"source_content_type":"text/x-python","patch_set":9,"id":"80488a89_e8b613b0","line":207,"range":{"start_line":207,"start_character":15,"end_line":207,"end_character":52},"in_reply_to":"5320b56e_e3d90a35","updated":"2026-10-27 03:55:16.000000000","message":"Acknowledged","commit_id":"7a1891e4ddaf99b27570fe07c8a24455ff506ea1"}],"releasenotes/notes/hitachi-group-filter-and-sort-8de9e84788244619.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f102421985e823000beb7eeb1f55aed6d502fee2","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Hitachi driver: The ``hitachi_group_search_pattern`` option was added"},{"line_number":5,"context_line":"    to allow for a regex pattern for filtering out host groups during a"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"893bea61_d674e1eb","line":2,"updated":"2026-10-27 14:37:47.000000000","message":"After you get the other stuff working, please reformat this along the lines of\n\n```\n- |\n  Hitachi driver `bug #123456 \u003claunchpad link\u003e`_: Added options to (some cogent description here):\n  \n  - ``option1`` text\n  - ``option2`` text\n- |\n  HPE/XP driver bug #1234 (same thing)\n  \n  - ``option1`` text\n  - ``option2`` text\n- |\n  NEC/V driver bug ...\n  \n```\n\nYou don\u0027t need to use the bulleted sublists, you can use a description list (or whatever it\u0027s called in RST), Primary thing is to get it along the lines of https://docs.openstack.org/cinder/latest/contributor/releasenotes.html#drivers","commit_id":"b51ae8fd92faca3be7b9e241f0c4d5756b9b980c"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"87a8a072ceaa27e6832e1dc12305329c792b9c1d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Hitachi driver: The ``hitachi_group_search_pattern`` option was added"},{"line_number":5,"context_line":"    to allow for a regex pattern for filtering out host groups during a"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"e80d8d30_9edd8ab8","line":2,"in_reply_to":"868cc1b6_0d93e6ea","updated":"2026-10-27 23:08:47.000000000","message":"Marked as resolved.","commit_id":"b51ae8fd92faca3be7b9e241f0c4d5756b9b980c"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"e68da4f47f7d293a63eb24a4d898fcf5b38ae88a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Hitachi driver: The ``hitachi_group_search_pattern`` option was added"},{"line_number":5,"context_line":"    to allow for a regex pattern for filtering out host groups during a"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"868cc1b6_0d93e6ea","line":2,"in_reply_to":"893bea61_d674e1eb","updated":"2026-10-27 23:08:35.000000000","message":"Got it. These things should pass now, and I have updated the release notes.","commit_id":"b51ae8fd92faca3be7b9e241f0c4d5756b9b980c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"25939e13ed82b05b9165d82904a77b9c84260026","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    down long-running searches on ports that cause timeouts and"},{"line_number":6,"context_line":"    excessive delays during attachments and startup:"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    - ``hitachi_group_search_pattern`` option was added to allow for"},{"line_number":9,"context_line":"    a regex pattern for filtering out host groups. This option"},{"line_number":10,"context_line":"    defaults to an empty string (disabled)."},{"line_number":11,"context_line":"    - ``hitachi_use_group_search_optimization`` option was added to"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"b1240432_938de9f6","line":8,"range":{"start_line":8,"start_character":46,"end_line":8,"end_character":49},"updated":"2026-10-28 19:56:21.000000000","message":"nit: is\nThe operator will read this at time of Indri release so should be present tense","commit_id":"353109ebcde9196337c127d702f6480c4e3b21b2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"25939e13ed82b05b9165d82904a77b9c84260026","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    - ``hitachi_group_search_pattern`` option was added to allow for"},{"line_number":9,"context_line":"    a regex pattern for filtering out host groups. This option"},{"line_number":10,"context_line":"    defaults to an empty string (disabled)."},{"line_number":11,"context_line":"    - ``hitachi_use_group_search_optimization`` option was added to"},{"line_number":12,"context_line":"    was added to optimize host group searches for groups created by"},{"line_number":13,"context_line":"    other Hitachi software. This option defaults to ``False``."},{"line_number":14,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3ae42301_f7aa688b","line":11,"range":{"start_line":11,"start_character":55,"end_line":11,"end_character":58},"updated":"2026-10-28 19:56:21.000000000","message":"is","commit_id":"353109ebcde9196337c127d702f6480c4e3b21b2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"25939e13ed82b05b9165d82904a77b9c84260026","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    a regex pattern for filtering out host groups. This option"},{"line_number":10,"context_line":"    defaults to an empty string (disabled)."},{"line_number":11,"context_line":"    - ``hitachi_use_group_search_optimization`` option was added to"},{"line_number":12,"context_line":"    was added to optimize host group searches for groups created by"},{"line_number":13,"context_line":"    other Hitachi software. This option defaults to ``False``."},{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    HPE/XP driver `bug #2170300 \u003chttps://bugs.launchpad.net/cinder/+bug/2170300\u003e\u0027_: Added options to help narrow"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"86ad47f5_661b164f","line":12,"range":{"start_line":12,"start_character":4,"end_line":12,"end_character":16},"updated":"2026-10-28 19:56:21.000000000","message":"repeated twice","commit_id":"353109ebcde9196337c127d702f6480c4e3b21b2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"25939e13ed82b05b9165d82904a77b9c84260026","unresolved":true,"context_lines":[{"line_number":16,"context_line":"    down long-running searches on ports that cause timeouts and"},{"line_number":17,"context_line":"    excessive delays during attachments and startup:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    - ``hpexp_group_search_pattern`` option was added to allow for"},{"line_number":20,"context_line":"    a regex pattern for filtering out host groups. This option"},{"line_number":21,"context_line":"    defaults to an empty string (disabled)."},{"line_number":22,"context_line":"    - ``hpexp_use_group_search_optimization`` option was added to"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"2b3d66d6_ac620e89","line":19,"range":{"start_line":19,"start_character":44,"end_line":19,"end_character":47},"updated":"2026-10-28 19:56:21.000000000","message":"same","commit_id":"353109ebcde9196337c127d702f6480c4e3b21b2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"25939e13ed82b05b9165d82904a77b9c84260026","unresolved":true,"context_lines":[{"line_number":20,"context_line":"    a regex pattern for filtering out host groups. This option"},{"line_number":21,"context_line":"    defaults to an empty string (disabled)."},{"line_number":22,"context_line":"    - ``hpexp_use_group_search_optimization`` option was added to"},{"line_number":23,"context_line":"    was added to optimize host group searches for groups created by"},{"line_number":24,"context_line":"    other related software. This option defaults to ``False``."},{"line_number":25,"context_line":"  - |"},{"line_number":26,"context_line":"    NEC/V driver `bug #2170300 \u003chttps://bugs.launchpad.net/cinder/+bug/2170300\u003e\u0027_: Added options to help narrow"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"603046e4_ce7370ec","line":23,"range":{"start_line":23,"start_character":4,"end_line":23,"end_character":16},"updated":"2026-10-28 19:56:21.000000000","message":"same","commit_id":"353109ebcde9196337c127d702f6480c4e3b21b2"}]}
