)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"604e9ea18f9c2b962048272dc18ab72fca1e899d","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This, along with thin-provisioning accounting, will"},{"line_number":16,"context_line":"give a path to move toward thin LVM as the default."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Partial-Bug: #1472803"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Idfc1cd749bfd7aec659ab8e80629cc506cd9797a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba3cc151_c2a0bef6","line":17,"updated":"2015-07-09 02:36:13.000000000","message":"Need DocImpact here please.","commit_id":"2edd982230d6bedcd8a3811a789409579df2a2c3"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"8a674b162b02c4015d576d3788c0b97659a050c3","unresolved":false,"context_lines":[{"line_number":16,"context_line":"give a path to move toward thin LVM as the default."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Partial-Bug: #1472803"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Idfc1cd749bfd7aec659ab8e80629cc506cd9797a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba3cc151_a8032a41","line":19,"updated":"2015-07-09 03:27:27.000000000","message":"DocImpact","commit_id":"2edd982230d6bedcd8a3811a789409579df2a2c3"}],"cinder/tests/unit/test_volume.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"8a674b162b02c4015d576d3788c0b97659a050c3","unresolved":false,"context_lines":[{"line_number":5974,"context_line":""},{"line_number":5975,"context_line":"        lvm_driver.check_for_setup_error()"},{"line_number":5976,"context_line":""},{"line_number":5977,"context_line":"        self.assertEqual(lvm_driver.configuration.lvm_type, \u0027thin\u0027)"},{"line_number":5978,"context_line":""},{"line_number":5979,"context_line":"    @mock.patch.object(cinder.volume.utils, \u0027get_all_volume_groups\u0027,"},{"line_number":5980,"context_line":"                       return_value\u003d[{\u0027name\u0027: \u0027cinder-volumes\u0027}])"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_e2faa242","line":5977,"updated":"2015-07-09 03:27:27.000000000","message":"assert order should be expected, actual","commit_id":"2edd982230d6bedcd8a3811a789409579df2a2c3"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c3e40a8c2092ab1d3af5d4348540e017a0f27d31","unresolved":false,"context_lines":[{"line_number":5974,"context_line":""},{"line_number":5975,"context_line":"        lvm_driver.check_for_setup_error()"},{"line_number":5976,"context_line":""},{"line_number":5977,"context_line":"        self.assertEqual(lvm_driver.configuration.lvm_type, \u0027thin\u0027)"},{"line_number":5978,"context_line":""},{"line_number":5979,"context_line":"    @mock.patch.object(cinder.volume.utils, \u0027get_all_volume_groups\u0027,"},{"line_number":5980,"context_line":"                       return_value\u003d[{\u0027name\u0027: \u0027cinder-volumes\u0027}])"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_6ab72f3a","line":5977,"in_reply_to":"ba3cc151_e2faa242","updated":"2015-07-09 15:11:30.000000000","message":"Done","commit_id":"2edd982230d6bedcd8a3811a789409579df2a2c3"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"8a674b162b02c4015d576d3788c0b97659a050c3","unresolved":false,"context_lines":[{"line_number":5983,"context_line":"                return_value\u003dFalse)"},{"line_number":5984,"context_line":"    def test_lvm_type_auto_no_thin_support(self, *_unused_mocks):"},{"line_number":5985,"context_line":"        configuration \u003d conf.Configuration(fake_opt, \u0027fake_group\u0027)"},{"line_number":5986,"context_line":"        self.configuration.lvm_type \u003d \u0027auto\u0027"},{"line_number":5987,"context_line":""},{"line_number":5988,"context_line":"        lvm_driver \u003d lvm.LVMVolumeDriver(configuration\u003dconfiguration)"},{"line_number":5989,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_bd791b95","line":5986,"updated":"2015-07-09 03:27:27.000000000","message":"I think this should be configuration.lvm_type instead of self.configurataion.lvm_type, which leaves the configuration.lvm_type in the driver set to \u0027default\u0027 instead of \u0027auto\u0027 and yields a false positive here.","commit_id":"2edd982230d6bedcd8a3811a789409579df2a2c3"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c3e40a8c2092ab1d3af5d4348540e017a0f27d31","unresolved":false,"context_lines":[{"line_number":5983,"context_line":"                return_value\u003dFalse)"},{"line_number":5984,"context_line":"    def test_lvm_type_auto_no_thin_support(self, *_unused_mocks):"},{"line_number":5985,"context_line":"        configuration \u003d conf.Configuration(fake_opt, \u0027fake_group\u0027)"},{"line_number":5986,"context_line":"        self.configuration.lvm_type \u003d \u0027auto\u0027"},{"line_number":5987,"context_line":""},{"line_number":5988,"context_line":"        lvm_driver \u003d lvm.LVMVolumeDriver(configuration\u003dconfiguration)"},{"line_number":5989,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_aadf7767","line":5986,"in_reply_to":"ba3cc151_bd791b95","updated":"2015-07-09 15:11:30.000000000","message":"Done","commit_id":"2edd982230d6bedcd8a3811a789409579df2a2c3"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"8a674b162b02c4015d576d3788c0b97659a050c3","unresolved":false,"context_lines":[{"line_number":5989,"context_line":""},{"line_number":5990,"context_line":"        lvm_driver.check_for_setup_error()"},{"line_number":5991,"context_line":""},{"line_number":5992,"context_line":"        self.assertEqual(lvm_driver.configuration.lvm_type, \u0027default\u0027)"},{"line_number":5993,"context_line":""},{"line_number":5994,"context_line":"    @mock.patch.object(cinder.volume.utils, \u0027get_all_volume_groups\u0027,"},{"line_number":5995,"context_line":"                       return_value\u003d[{\u0027name\u0027: \u0027cinder-volumes\u0027}])"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_629d3209","line":5992,"updated":"2015-07-09 03:27:27.000000000","message":"assert order should be expected, actual","commit_id":"2edd982230d6bedcd8a3811a789409579df2a2c3"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"8a674b162b02c4015d576d3788c0b97659a050c3","unresolved":false,"context_lines":[{"line_number":5999,"context_line":"                return_value\u003dFalse)"},{"line_number":6000,"context_line":"    def test_lvm_type_auto_no_thin_pool(self, *_unused_mocks):"},{"line_number":6001,"context_line":"        configuration \u003d conf.Configuration(fake_opt, \u0027fake_group\u0027)"},{"line_number":6002,"context_line":"        self.configuration.lvm_type \u003d \u0027auto\u0027"},{"line_number":6003,"context_line":""},{"line_number":6004,"context_line":"        lvm_driver \u003d lvm.LVMVolumeDriver(configuration\u003dconfiguration)"},{"line_number":6005,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_9d9d37be","line":6002,"updated":"2015-07-09 03:27:27.000000000","message":"Again, I think this should be configuration.lvm_type \u003d \u0027auto\u0027 instead of self.configuration.lvm_type \u003d \u0027auto\u0027","commit_id":"2edd982230d6bedcd8a3811a789409579df2a2c3"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c3e40a8c2092ab1d3af5d4348540e017a0f27d31","unresolved":false,"context_lines":[{"line_number":5999,"context_line":"                return_value\u003dFalse)"},{"line_number":6000,"context_line":"    def test_lvm_type_auto_no_thin_pool(self, *_unused_mocks):"},{"line_number":6001,"context_line":"        configuration \u003d conf.Configuration(fake_opt, \u0027fake_group\u0027)"},{"line_number":6002,"context_line":"        self.configuration.lvm_type \u003d \u0027auto\u0027"},{"line_number":6003,"context_line":""},{"line_number":6004,"context_line":"        lvm_driver \u003d lvm.LVMVolumeDriver(configuration\u003dconfiguration)"},{"line_number":6005,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_2ad2875c","line":6002,"in_reply_to":"ba3cc151_9d9d37be","updated":"2015-07-09 15:11:30.000000000","message":"Done","commit_id":"2edd982230d6bedcd8a3811a789409579df2a2c3"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"8a674b162b02c4015d576d3788c0b97659a050c3","unresolved":false,"context_lines":[{"line_number":6005,"context_line":""},{"line_number":6006,"context_line":"        lvm_driver.check_for_setup_error()"},{"line_number":6007,"context_line":""},{"line_number":6008,"context_line":"        self.assertEqual(lvm_driver.configuration.lvm_type, \u0027default\u0027)"},{"line_number":6009,"context_line":""},{"line_number":6010,"context_line":""},{"line_number":6011,"context_line":"class ISCSITestCase(DriverTestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_82a07643","line":6008,"updated":"2015-07-09 03:27:27.000000000","message":"assert order should be expected, actual","commit_id":"2edd982230d6bedcd8a3811a789409579df2a2c3"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c3e40a8c2092ab1d3af5d4348540e017a0f27d31","unresolved":false,"context_lines":[{"line_number":6005,"context_line":""},{"line_number":6006,"context_line":"        lvm_driver.check_for_setup_error()"},{"line_number":6007,"context_line":""},{"line_number":6008,"context_line":"        self.assertEqual(lvm_driver.configuration.lvm_type, \u0027default\u0027)"},{"line_number":6009,"context_line":""},{"line_number":6010,"context_line":""},{"line_number":6011,"context_line":"class ISCSITestCase(DriverTestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_0acb03a5","line":6008,"in_reply_to":"ba3cc151_82a07643","updated":"2015-07-09 15:11:30.000000000","message":"Done","commit_id":"2edd982230d6bedcd8a3811a789409579df2a2c3"}],"cinder/volume/drivers/lvm.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"ab25c27bbd1ea3c695a1c365d767b260e70e0288","unresolved":false,"context_lines":[{"line_number":280,"context_line":""},{"line_number":281,"context_line":"        pool_name \u003d \"%s-pool\" % self.configuration.volume_group"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        if self.configuration.lvm_type \u003d\u003d \u0027auto\u0027:"},{"line_number":284,"context_line":"            # Default to thin provisioning if it is supported and"},{"line_number":285,"context_line":"            # the volume group is empty, or contains a thin pool"},{"line_number":286,"context_line":"            # for us to use."}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_73d85154","line":283,"updated":"2015-07-12 15:53:33.000000000","message":"I\u0027m kinda mixed on introducing a new flag here.  Especially since we need to change again if/when we change the default.  Would it be \"safe\" to just implement this for default and then offer a \"linear\" option explicitly?\n\nFor example, when we make thin our preferred, we just offer the conf options: \"default, linear\"\n\ndefault will do exactly what you have here, and linear will give the ability to explicitly use linear provisioned LVM if desired.\n\n\nThoughts?","commit_id":"836b364ba79b7d08e0626c120c6e4e5e6cb9d9b2"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"28db21fde340313b8ab5aa9c0610bb681663aa64","unresolved":false,"context_lines":[{"line_number":280,"context_line":""},{"line_number":281,"context_line":"        pool_name \u003d \"%s-pool\" % self.configuration.volume_group"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        if self.configuration.lvm_type \u003d\u003d \u0027auto\u0027:"},{"line_number":284,"context_line":"            # Default to thin provisioning if it is supported and"},{"line_number":285,"context_line":"            # the volume group is empty, or contains a thin pool"},{"line_number":286,"context_line":"            # for us to use."}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_c33b61d0","line":283,"in_reply_to":"9a41bdd9_60784b90","updated":"2015-07-13 14:32:17.000000000","message":"Since I somewhat forgot the reasoning myself... the reason I haven\u0027t defaulted this yet to thin is because then the default is an over provisioning ratio of 2.0, which doesn\u0027t have the same space and safety guarantees as thick.  (That is, it will run out of space and fail when users use it.)\n\nI think moving to thin as default also requires us to default that ratio to 1.0.","commit_id":"836b364ba79b7d08e0626c120c6e4e5e6cb9d9b2"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"807016b8bc6ee3f494965dc2ce37a8b8667447bf","unresolved":false,"context_lines":[{"line_number":280,"context_line":""},{"line_number":281,"context_line":"        pool_name \u003d \"%s-pool\" % self.configuration.volume_group"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        if self.configuration.lvm_type \u003d\u003d \u0027auto\u0027:"},{"line_number":284,"context_line":"            # Default to thin provisioning if it is supported and"},{"line_number":285,"context_line":"            # the volume group is empty, or contains a thin pool"},{"line_number":286,"context_line":"            # for us to use."}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_60784b90","line":283,"in_reply_to":"9a41bdd9_73d85154","updated":"2015-07-13 14:15:32.000000000","message":"We certainly need to keep the option \u0027thin\u0027 for people who\u0027re using it. We also need to keep the behaviour on upgraded systems the same, i.e. existing thick systems need to keep working correctly.","commit_id":"836b364ba79b7d08e0626c120c6e4e5e6cb9d9b2"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"c188d440c88a0985a77a2f962604b633b6cb4d43","unresolved":false,"context_lines":[{"line_number":297,"context_line":"                    LOG.info(_LI(\u0027Enabling LVM thin provisioning by default \u0027"},{"line_number":298,"context_line":"                                 \u0027because no LVs exist.\u0027))"},{"line_number":299,"context_line":"                    self.configuration.lvm_type \u003d \u0027thin\u0027"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        if self.configuration.lvm_type \u003d\u003d \u0027thin\u0027:"},{"line_number":302,"context_line":"            # Specific checks for using Thin provisioned LV\u0027s"},{"line_number":303,"context_line":"            if not volutils.supports_thin_provisioning():"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a41bdd9_ef61b6d4","line":300,"updated":"2015-07-17 13:49:55.000000000","message":"Don\u0027t you need to set it to \"think\" if above two cases failed?","commit_id":"68044b19a357fb958fbfa77513b88b05a82c7590"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"217f7671fe332eef9e679811900625c8ed352be3","unresolved":false,"context_lines":[{"line_number":297,"context_line":"                    LOG.info(_LI(\u0027Enabling LVM thin provisioning by default \u0027"},{"line_number":298,"context_line":"                                 \u0027because no LVs exist.\u0027))"},{"line_number":299,"context_line":"                    self.configuration.lvm_type \u003d \u0027thin\u0027"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        if self.configuration.lvm_type \u003d\u003d \u0027thin\u0027:"},{"line_number":302,"context_line":"            # Specific checks for using Thin provisioned LV\u0027s"},{"line_number":303,"context_line":"            if not volutils.supports_thin_provisioning():"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a41bdd9_808799d6","line":300,"in_reply_to":"9a41bdd9_ef61b6d4","updated":"2015-07-17 14:58:21.000000000","message":"No, it should be set to \u0027default\u0027 as it is doing in line 289, because that\u0027s the default value (see line 53).","commit_id":"68044b19a357fb958fbfa77513b88b05a82c7590"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"88e02c1a9b0dc1e6995eee92d554d2c1fe32d592","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    cfg.StrOpt(\u0027lvm_type\u0027,"},{"line_number":53,"context_line":"               default\u003d\u0027default\u0027,"},{"line_number":54,"context_line":"               choices\u003d[\u0027default\u0027, \u0027thin\u0027, \u0027auto\u0027],"},{"line_number":55,"context_line":"               help\u003d\u0027Type of LVM volumes to deploy; (default, thin, or auto).\u0027"},{"line_number":56,"context_line":"                    \u0027Auto defaults to thin if thin is supported.\u0027),"},{"line_number":57,"context_line":"    cfg.StrOpt(\u0027lvm_conf_file\u0027,"},{"line_number":58,"context_line":"               default\u003d\u0027/etc/cinder/lvm.conf\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_ae81b5c4","line":55,"updated":"2015-07-23 16:00:07.000000000","message":"Need space so string doesn\u0027t run together.","commit_id":"da863368500def4554c815ea86181a480d3e1b83"}]}