)]}'
{"cinder/volume/drivers/emc/emc_vnx_cli.py":[{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"a6ac32a1af99d860531c680e480faf9b43abe250","unresolved":false,"context_lines":[{"line_number":44,"context_line":"               help\u003d\u0027ISCSI pool name\u0027),"},{"line_number":45,"context_line":"    cfg.IntOpt(\u0027default_timeout\u0027,"},{"line_number":46,"context_line":"               default\u003d20,"},{"line_number":47,"context_line":"               help\u003d\u0027Default time out for CLI operations in minutes\u0027),"},{"line_number":48,"context_line":"    cfg.IntOpt(\u0027max_luns_per_storage_group\u0027,"},{"line_number":49,"context_line":"               default\u003d256,"},{"line_number":50,"context_line":"               help\u003d\u0027Default max number of LUNs in a storage group\u0027), ]"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_bbd8da7f","line":47,"updated":"2014-07-22 07:14:13.000000000","message":"s/time out/timeout/","commit_id":"3b1919dd723ff531293ab533f47a3725582b2764"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"ab57af3b32552b73972b74b9e7b42783e51cce3e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"loc_opts \u003d ["},{"line_number":39,"context_line":"    cfg.StrOpt(\u0027naviseccli_path\u0027,"},{"line_number":40,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":41,"context_line":"               help\u003d\u0027Naviseccli path\u0027),"},{"line_number":42,"context_line":"    cfg.StrOpt(\u0027storage_vnx_pool_name\u0027,"},{"line_number":43,"context_line":"               default\u003dNone,"},{"line_number":44,"context_line":"               help\u003d\u0027ISCSI pool name\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_b4bc39dd","line":41,"updated":"2014-07-22 20:22:56.000000000","message":"As you added a dot at the end of the help string, please add it in all help strings.","commit_id":"7d64b55ab40c490982e12bde766564fbfe35e90b"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"59cb0982f811367a0f74927dc19c7a6260d6c2ad","unresolved":false,"context_lines":[{"line_number":38,"context_line":"loc_opts \u003d ["},{"line_number":39,"context_line":"    cfg.StrOpt(\u0027naviseccli_path\u0027,"},{"line_number":40,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":41,"context_line":"               help\u003d\u0027Naviseccli path\u0027),"},{"line_number":42,"context_line":"    cfg.StrOpt(\u0027storage_vnx_pool_name\u0027,"},{"line_number":43,"context_line":"               default\u003dNone,"},{"line_number":44,"context_line":"               help\u003d\u0027ISCSI pool name\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_c6ebb5da","line":41,"in_reply_to":"baada198_b4bc39dd","updated":"2014-07-23 05:23:23.000000000","message":"This would be needed in far more places all over cinder and should be a separate patch. I added the dots only for longer strings that are sentence-like.","commit_id":"7d64b55ab40c490982e12bde766564fbfe35e90b"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"252ed59c95885b871a194e56c02412111011de78","unresolved":false,"context_lines":[{"line_number":38,"context_line":"loc_opts \u003d ["},{"line_number":39,"context_line":"    cfg.StrOpt(\u0027naviseccli_path\u0027,"},{"line_number":40,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":41,"context_line":"               help\u003d\u0027Naviseccli path\u0027),"},{"line_number":42,"context_line":"    cfg.StrOpt(\u0027storage_vnx_pool_name\u0027,"},{"line_number":43,"context_line":"               default\u003dNone,"},{"line_number":44,"context_line":"               help\u003d\u0027ISCSI pool name\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_91e72346","line":41,"in_reply_to":"baada198_c6ebb5da","updated":"2014-07-23 11:27:23.000000000","message":"Ok. A separate patch for the dots is better!","commit_id":"7d64b55ab40c490982e12bde766564fbfe35e90b"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"ab57af3b32552b73972b74b9e7b42783e51cce3e","unresolved":false,"context_lines":[{"line_number":41,"context_line":"               help\u003d\u0027Naviseccli path\u0027),"},{"line_number":42,"context_line":"    cfg.StrOpt(\u0027storage_vnx_pool_name\u0027,"},{"line_number":43,"context_line":"               default\u003dNone,"},{"line_number":44,"context_line":"               help\u003d\u0027ISCSI pool name\u0027),"},{"line_number":45,"context_line":"    cfg.IntOpt(\u0027default_timeout\u0027,"},{"line_number":46,"context_line":"               default\u003d20,"},{"line_number":47,"context_line":"               help\u003d\u0027Default timeout for CLI operations in minutes.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_f4b6b1f8","line":44,"updated":"2014-07-22 20:22:56.000000000","message":"As you added a dot at the end of the help string, please add it in all help strings.","commit_id":"7d64b55ab40c490982e12bde766564fbfe35e90b"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"dfd757a1ed8c5bbc4a0cde95a40981df5a71f5d2","unresolved":false,"context_lines":[{"line_number":44,"context_line":"               help\u003d\u0027ISCSI pool name\u0027),"},{"line_number":45,"context_line":"    cfg.IntOpt(\u0027default_timeout\u0027,"},{"line_number":46,"context_line":"               default\u003d20,"},{"line_number":47,"context_line":"               help\u003d\u0027Default timeout for CLI operations in minutes.\u0027),"},{"line_number":48,"context_line":"    cfg.IntOpt(\u0027max_luns_per_storage_group\u0027,"},{"line_number":49,"context_line":"               default\u003d256,"},{"line_number":50,"context_line":"               help\u003d\u0027Default max number of LUNs in a storage group.\u0027), ]"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_d0dea769","line":47,"updated":"2014-08-01 13:25:20.000000000","message":"I don\u0027t see a reason to add periods to these options.","commit_id":"84f8f1e47e30b7beee793129da21618c92cf8d24"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"dfd757a1ed8c5bbc4a0cde95a40981df5a71f5d2","unresolved":false,"context_lines":[{"line_number":47,"context_line":"               help\u003d\u0027Default timeout for CLI operations in minutes.\u0027),"},{"line_number":48,"context_line":"    cfg.IntOpt(\u0027max_luns_per_storage_group\u0027,"},{"line_number":49,"context_line":"               default\u003d256,"},{"line_number":50,"context_line":"               help\u003d\u0027Default max number of LUNs in a storage group.\u0027), ]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"CONF.register_opts(loc_opts)"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_30c52390","line":50,"updated":"2014-08-01 13:25:20.000000000","message":"^","commit_id":"84f8f1e47e30b7beee793129da21618c92cf8d24"}],"cinder/volume/drivers/hds/iscsi.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"dfd757a1ed8c5bbc4a0cde95a40981df5a71f5d2","unresolved":false,"context_lines":[{"line_number":38,"context_line":"iSCSI_OPTS \u003d ["},{"line_number":39,"context_line":"    cfg.StrOpt(\u0027hds_hnas_iscsi_config_file\u0027,"},{"line_number":40,"context_line":"               default\u003d\u0027/opt/hds/hnas/cinder_iscsi_conf.xml\u0027,"},{"line_number":41,"context_line":"               help\u003d\u0027Configuration file for HDS iSCSI cinder plugin.\u0027)]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"CONF \u003d cfg.CONF"},{"line_number":44,"context_line":"CONF.register_opts(iSCSI_OPTS)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_90bfcffb","line":41,"updated":"2014-08-01 13:25:20.000000000","message":"Ditto","commit_id":"84f8f1e47e30b7beee793129da21618c92cf8d24"}],"cinder/volume/drivers/hds/nfs.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"dfd757a1ed8c5bbc4a0cde95a40981df5a71f5d2","unresolved":false,"context_lines":[{"line_number":41,"context_line":"NFS_OPTS \u003d ["},{"line_number":42,"context_line":"    cfg.StrOpt(\u0027hds_hnas_nfs_config_file\u0027,"},{"line_number":43,"context_line":"               default\u003d\u0027/opt/hds/hnas/cinder_nfs_conf.xml\u0027,"},{"line_number":44,"context_line":"               help\u003d\u0027Configuration file for HDS NFS cinder plugin.\u0027), ]"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"CONF \u003d cfg.CONF"},{"line_number":47,"context_line":"CONF.register_opts(NFS_OPTS)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_d0b5c719","line":44,"updated":"2014-08-01 13:25:20.000000000","message":"Ditto","commit_id":"84f8f1e47e30b7beee793129da21618c92cf8d24"}],"etc/cinder/cinder.conf.sample":[{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"a6ac32a1af99d860531c680e480faf9b43abe250","unresolved":false,"context_lines":[{"line_number":1093,"context_line":"# ISCSI pool name (string value)"},{"line_number":1094,"context_line":"#storage_vnx_pool_name\u003d\u003cNone\u003e"},{"line_number":1095,"context_line":""},{"line_number":1096,"context_line":"# Default time out for CLI operations in minutes (integer"},{"line_number":1097,"context_line":"# value)"},{"line_number":1098,"context_line":"#default_timeout\u003d20"},{"line_number":1099,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baada198_fbb5f218","line":1096,"updated":"2014-07-22 07:14:13.000000000","message":"s/time out/timeout/","commit_id":"3b1919dd723ff531293ab533f47a3725582b2764"}]}
