)]}'
{"cinder/api/openstack/volume/volumes.py":[{"author":{"_account_id":1107,"name":"Josh Durgin","email":"jdurgin@redhat.com","username":"jdurgin"},"change_message_id":"87ebbc3bdc3586d70c82c0492f99fb7efa3f0a65","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        volume \u003d body[\u0027volume\u0027]"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        def as_int(s):"},{"line_number":246,"context_line":"            try:"},{"line_number":247,"context_line":"                return int(s)"},{"line_number":248,"context_line":"            except ValueError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fs%2BU%3D","line":245,"updated":"2012-08-17 15:55:04.000000000","message":"this was moved to the rpc api layer in f5ebb33f9a0ebc3b8f6d0e0d97e3d4b673106907, probably should keep it there","commit_id":"2d7e17652f79a48956fe4853950530ab39057ec3"},{"author":{"_account_id":1107,"name":"Josh Durgin","email":"jdurgin@redhat.com","username":"jdurgin"},"change_message_id":"87ebbc3bdc3586d70c82c0492f99fb7efa3f0a65","unresolved":false,"context_lines":[{"line_number":268,"context_line":"            kwargs[\u0027snapshot\u0027] \u003d None"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        size \u003d volume.get(\u0027size\u0027)"},{"line_number":271,"context_line":"        if size \u003d\u003d None and kwargs[\u0027snapshot\u0027] !\u003d None:"},{"line_number":272,"context_line":"            size \u003d as_int(kwargs[\u0027snapshot\u0027][\u0027volume_size\u0027])"},{"line_number":273,"context_line":"        else:"},{"line_number":274,"context_line":"            size \u003d as_int(size)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fs%2BY%3D","line":271,"updated":"2012-08-17 15:55:04.000000000","message":"usually comparisons with None should use \u0027is\u0027 and \u0027is not\u0027 instead of \u003d\u003d and !\u003d","commit_id":"2d7e17652f79a48956fe4853950530ab39057ec3"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"651aad0756f400bfe572d8612cdc90ef49dcefbc","unresolved":false,"context_lines":[{"line_number":268,"context_line":"            kwargs[\u0027snapshot\u0027] \u003d None"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        size \u003d volume.get(\u0027size\u0027)"},{"line_number":271,"context_line":"        if size \u003d\u003d None and kwargs[\u0027snapshot\u0027] !\u003d None:"},{"line_number":272,"context_line":"            size \u003d as_int(kwargs[\u0027snapshot\u0027][\u0027volume_size\u0027])"},{"line_number":273,"context_line":"        else:"},{"line_number":274,"context_line":"            size \u003d as_int(size)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fs78%3D","line":271,"in_reply_to":"AAAALH%2F%2Fs%2BY%3D","updated":"2012-08-17 16:25:39.000000000","message":"Will fix.","commit_id":"2d7e17652f79a48956fe4853950530ab39057ec3"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"b4ce7d07e068494843bfa3e0c85186776eb2f5db","unresolved":false,"context_lines":[{"line_number":262,"context_line":"            kwargs[\u0027snapshot\u0027] \u003d None"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        size \u003d volume.get(\u0027size\u0027)"},{"line_number":265,"context_line":"        if size \u003d\u003d None and kwargs[\u0027snapshot\u0027] !\u003d None:"},{"line_number":266,"context_line":"            size \u003d kwargs[\u0027snapshot\u0027][\u0027volume_size\u0027]"},{"line_number":267,"context_line":"        else:"},{"line_number":268,"context_line":"            size \u003d size"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FmVc%3D","line":265,"updated":"2012-08-28 16:45:25.000000000","message":"Looks like to comparison change wasn\u0027t done, per Durgin\u0027s suggestion?","commit_id":"7e073e8fcd795841b54cab58bb3ebaa2347fdd5e"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"7e1b1ba754b2e8416199011ae44bb75d24aab047","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        else:"},{"line_number":262,"context_line":"            kwargs[\u0027snapshot\u0027] \u003d None"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        size \u003d volume.get(\u0027size\u0027)"},{"line_number":265,"context_line":"        if size is None and kwargs[\u0027snapshot\u0027] is not None:"},{"line_number":266,"context_line":"            size \u003d kwargs[\u0027snapshot\u0027][\u0027volume_size\u0027]"},{"line_number":267,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FjjM%3D","line":264,"updated":"2012-08-31 14:30:23.000000000","message":"volume.get(\u0027size\u0027, None)","commit_id":"6d70d1401ee319844441e82a170350597302c7e9"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"25fb8c7e485e19390a2f74dad51ab7b75ee17259","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        else:"},{"line_number":262,"context_line":"            kwargs[\u0027snapshot\u0027] \u003d None"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        size \u003d volume.get(\u0027size\u0027)"},{"line_number":265,"context_line":"        if size is None and kwargs[\u0027snapshot\u0027] is not None:"},{"line_number":266,"context_line":"            size \u003d kwargs[\u0027snapshot\u0027][\u0027volume_size\u0027]"},{"line_number":267,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FjiQ%3D","line":264,"in_reply_to":"AAAALH%2F%2FjjM%3D","updated":"2012-08-31 14:47:29.000000000","message":"Done","commit_id":"6d70d1401ee319844441e82a170350597302c7e9"},{"author":{"_account_id":1107,"name":"Josh Durgin","email":"jdurgin@redhat.com","username":"jdurgin"},"change_message_id":"090febe80d5350698a7ff51728befe5776671d2e","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        size \u003d volume.get(\u0027size\u0027)"},{"line_number":265,"context_line":"        if size is None and kwargs[\u0027snapshot\u0027] is not None:"},{"line_number":266,"context_line":"            size \u003d kwargs[\u0027snapshot\u0027][\u0027volume_size\u0027]"},{"line_number":267,"context_line":"        else:"},{"line_number":268,"context_line":"            size \u003d size"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        LOG.audit(_(\"Create volume of %s GB\"), size, context\u003dcontext)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FkSE%3D","line":267,"updated":"2012-08-30 18:02:40.000000000","message":"don\u0027t need the else clause anymore","commit_id":"6d70d1401ee319844441e82a170350597302c7e9"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"25fb8c7e485e19390a2f74dad51ab7b75ee17259","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        size \u003d volume.get(\u0027size\u0027)"},{"line_number":265,"context_line":"        if size is None and kwargs[\u0027snapshot\u0027] is not None:"},{"line_number":266,"context_line":"            size \u003d kwargs[\u0027snapshot\u0027][\u0027volume_size\u0027]"},{"line_number":267,"context_line":"        else:"},{"line_number":268,"context_line":"            size \u003d size"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        LOG.audit(_(\"Create volume of %s GB\"), size, context\u003dcontext)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FjiU%3D","line":267,"in_reply_to":"AAAALH%2F%2FkSE%3D","updated":"2012-08-31 14:47:29.000000000","message":"Done","commit_id":"6d70d1401ee319844441e82a170350597302c7e9"}]}