)]}'
{"cinder/tests/volume/drivers/netapp/client/test_seven_mode.py":[{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"29d7febe6fc1f723cbf19f67e61ed28c7415881c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        self.connection \u003d mock.MagicMock()"},{"line_number":31,"context_line":"        self.fake_volume \u003d str(uuid.uuid4())"},{"line_number":32,"context_line":"        self.client \u003d seven_mode.Client(self.connection, [self.fake_volume])"},{"line_number":33,"context_line":"        self.fake_lun \u003d str(uuid.uuid4())"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def tearDown(self):"},{"line_number":36,"context_line":"        super(NetApp7modeClientTestCase, self).tearDown()"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_e722b4b7","line":33,"updated":"2014-11-18 11:12:16.000000000","message":"would you mind using six module to be more py3 compatible?","commit_id":"ba65606c905ae1dbbc340ef6ffdd7e517439cea8"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"89ec1737ca4fbef6509428c968d032d3b936863e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        self.connection \u003d mock.MagicMock()"},{"line_number":31,"context_line":"        self.fake_volume \u003d str(uuid.uuid4())"},{"line_number":32,"context_line":"        self.client \u003d seven_mode.Client(self.connection, [self.fake_volume])"},{"line_number":33,"context_line":"        self.fake_lun \u003d str(uuid.uuid4())"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def tearDown(self):"},{"line_number":36,"context_line":"        super(NetApp7modeClientTestCase, self).tearDown()"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_fa7214ac","line":33,"in_reply_to":"5a890539_e722b4b7","updated":"2014-11-20 17:39:12.000000000","message":"Done.  I eliminated str() across the NetApp Cinder codebase.","commit_id":"ba65606c905ae1dbbc340ef6ffdd7e517439cea8"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"29d7febe6fc1f723cbf19f67e61ed28c7415881c","unresolved":false,"context_lines":[{"line_number":477,"context_line":"                          expected_src_path,"},{"line_number":478,"context_line":"                          expected_dest_path)"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"        __, _args, __ \u003d self.connection.invoke_successfully.mock_calls[0]"},{"line_number":481,"context_line":"        actual_request \u003d _args[0]"},{"line_number":482,"context_line":"        actual_src_path \u003d actual_request \\"},{"line_number":483,"context_line":"            .get_child_by_name(\u0027source-path\u0027).get_content()"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_8a081529","line":480,"updated":"2014-11-18 11:12:16.000000000","message":"I would prefer if we don\u0027t use double underscores, but single underscore, or maybe even _useless :)","commit_id":"ba65606c905ae1dbbc340ef6ffdd7e517439cea8"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"89ec1737ca4fbef6509428c968d032d3b936863e","unresolved":false,"context_lines":[{"line_number":477,"context_line":"                          expected_src_path,"},{"line_number":478,"context_line":"                          expected_dest_path)"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"        __, _args, __ \u003d self.connection.invoke_successfully.mock_calls[0]"},{"line_number":481,"context_line":"        actual_request \u003d _args[0]"},{"line_number":482,"context_line":"        actual_src_path \u003d actual_request \\"},{"line_number":483,"context_line":"            .get_child_by_name(\u0027source-path\u0027).get_content()"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_d36c630b","line":480,"in_reply_to":"5a890539_8a081529","updated":"2014-11-20 17:39:12.000000000","message":"Single underscore is already used by i18n.  The double underscore is an OpenStack convention:\n\nhttp://lists.openstack.org/pipermail/openstack-dev/2014-October/048474.html","commit_id":"ba65606c905ae1dbbc340ef6ffdd7e517439cea8"}],"cinder/tests/volume/drivers/netapp/test_iscsi.py":[{"author":{"_account_id":9533,"name":"Eiichi Aikawa","email":"aikawa@mxk.nes.nec.co.jp","username":"EiichiAikawa"},"change_message_id":"74228551928094191cd36c42f615eaf8768c132b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) - 2014, Alex Meade.  All rights reserved."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_9f1a837b","line":1,"updated":"2014-10-23 09:20:58.000000000","message":"Is change allowed?","commit_id":"79560835bec528ac9af8cd2f15bca956e3cd0f9d"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"2194619e3a26217ab7f7b00d35e43bbca0d2c5ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) - 2014, Alex Meade.  All rights reserved."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_08081627","line":1,"in_reply_to":"9aa7fdbe_9f1a837b","updated":"2014-10-23 13:35:39.000000000","message":"Yes, thanks.  NetApp has asked us to remove their copyrights and attribute the individual contributors.","commit_id":"79560835bec528ac9af8cd2f15bca956e3cd0f9d"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"29d7febe6fc1f723cbf19f67e61ed28c7415881c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) - 2014, Alex Meade.  All rights reserved."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_8a565504","line":1,"updated":"2014-11-18 11:12:16.000000000","message":"I would prefer if the previous copyright header is kept as well along with your name..","commit_id":"ba65606c905ae1dbbc340ef6ffdd7e517439cea8"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"89ec1737ca4fbef6509428c968d032d3b936863e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) - 2014, Alex Meade.  All rights reserved."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_1a952088","line":1,"in_reply_to":"5a890539_8a565504","updated":"2014-11-20 17:39:12.000000000","message":"NetApp legal has asked us to remove all of NetApp\u0027s copyright notices.  We plan to submit a later patch to remove the remaining ones.","commit_id":"ba65606c905ae1dbbc340ef6ffdd7e517439cea8"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"e33011096be274ee6d7931e0d3cb323b3bc844ad","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        try:"},{"line_number":151,"context_line":"            self.driver.initialize_connection(fake_volume, fake_connector)"},{"line_number":152,"context_line":"        except exception.VolumeBackendAPIException as exc:"},{"line_number":153,"context_line":"            if expected not in str(exc):"},{"line_number":154,"context_line":"                self.fail(_(\u0027Expected exception message is missing\u0027))"},{"line_number":155,"context_line":"        else:"},{"line_number":156,"context_line":"            self.fail(_(\u0027VolumeBackendAPIException not raised\u0027))"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_c56bd51d","line":153,"updated":"2014-11-18 23:04:06.000000000","message":"Please use six.text_type instead of str().","commit_id":"ba65606c905ae1dbbc340ef6ffdd7e517439cea8"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"89ec1737ca4fbef6509428c968d032d3b936863e","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        try:"},{"line_number":151,"context_line":"            self.driver.initialize_connection(fake_volume, fake_connector)"},{"line_number":152,"context_line":"        except exception.VolumeBackendAPIException as exc:"},{"line_number":153,"context_line":"            if expected not in str(exc):"},{"line_number":154,"context_line":"                self.fail(_(\u0027Expected exception message is missing\u0027))"},{"line_number":155,"context_line":"        else:"},{"line_number":156,"context_line":"            self.fail(_(\u0027VolumeBackendAPIException not raised\u0027))"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_5a8fa875","line":153,"in_reply_to":"5a890539_c56bd51d","updated":"2014-11-20 17:39:12.000000000","message":"Done.  I eliminated str() across the NetApp Cinder codebase.","commit_id":"ba65606c905ae1dbbc340ef6ffdd7e517439cea8"}],"cinder/volume/drivers/netapp/client/base.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"e33011096be274ee6d7931e0d3cb323b3bc844ad","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            message \u003d e.message"},{"line_number":90,"context_line":"            msg \u003d _LW(\u0027Error mapping lun. Code :%(code)s, Message:%(message)s\u0027)"},{"line_number":91,"context_line":"            msg_fmt \u003d {\u0027code\u0027: code, \u0027message\u0027: message}"},{"line_number":92,"context_line":"            LOG.warn(msg % msg_fmt)"},{"line_number":93,"context_line":"            raise"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def unmap_lun(self, path, igroup_name):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_05da3d17","line":92,"updated":"2014-11-18 23:04:06.000000000","message":"Please use LOG.warning.","commit_id":"ba65606c905ae1dbbc340ef6ffdd7e517439cea8"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"89ec1737ca4fbef6509428c968d032d3b936863e","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            message \u003d e.message"},{"line_number":90,"context_line":"            msg \u003d _LW(\u0027Error mapping lun. Code :%(code)s, Message:%(message)s\u0027)"},{"line_number":91,"context_line":"            msg_fmt \u003d {\u0027code\u0027: code, \u0027message\u0027: message}"},{"line_number":92,"context_line":"            LOG.warn(msg % msg_fmt)"},{"line_number":93,"context_line":"            raise"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def unmap_lun(self, path, igroup_name):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_9d4caa78","line":92,"in_reply_to":"5a890539_05da3d17","updated":"2014-11-20 17:39:12.000000000","message":"Done.  I fixed this across the NetApp Cinder codebase.","commit_id":"ba65606c905ae1dbbc340ef6ffdd7e517439cea8"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"e33011096be274ee6d7931e0d3cb323b3bc844ad","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                      \" Message:%(message)s\")"},{"line_number":105,"context_line":"            msg_fmt \u003d {\u0027code\u0027: e.code, \u0027message\u0027: e.message}"},{"line_number":106,"context_line":"            exc_info \u003d sys.exc_info()"},{"line_number":107,"context_line":"            LOG.warn(msg % msg_fmt)"},{"line_number":108,"context_line":"            # if the lun is already unmapped"},{"line_number":109,"context_line":"            if e.code \u003d\u003d \u002713115\u0027 or e.code \u003d\u003d \u00279016\u0027:"},{"line_number":110,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_65086192","line":107,"updated":"2014-11-18 23:04:06.000000000","message":"warning","commit_id":"ba65606c905ae1dbbc340ef6ffdd7e517439cea8"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"89ec1737ca4fbef6509428c968d032d3b936863e","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                      \" Message:%(message)s\")"},{"line_number":105,"context_line":"            msg_fmt \u003d {\u0027code\u0027: e.code, \u0027message\u0027: e.message}"},{"line_number":106,"context_line":"            exc_info \u003d sys.exc_info()"},{"line_number":107,"context_line":"            LOG.warn(msg % msg_fmt)"},{"line_number":108,"context_line":"            # if the lun is already unmapped"},{"line_number":109,"context_line":"            if e.code \u003d\u003d \u002713115\u0027 or e.code \u003d\u003d \u00279016\u0027:"},{"line_number":110,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_1d67daeb","line":107,"in_reply_to":"5a890539_65086192","updated":"2014-11-20 17:39:12.000000000","message":"Done.  I fixed this across the NetApp Cinder codebase.","commit_id":"ba65606c905ae1dbbc340ef6ffdd7e517439cea8"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"e33011096be274ee6d7931e0d3cb323b3bc844ad","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    def do_direct_resize(self, path, new_size_bytes, force\u003dTrue):"},{"line_number":132,"context_line":"        \"\"\"Resize the lun.\"\"\""},{"line_number":133,"context_line":"        seg \u003d path.split(\"/\")"},{"line_number":134,"context_line":"        LOG.info(_(\"Resizing lun %s directly to new size.\"), seg[-1])"},{"line_number":135,"context_line":"        lun_resize \u003d netapp_api.NaElement.create_node_with_children("},{"line_number":136,"context_line":"            \u0027lun-resize\u0027,"},{"line_number":137,"context_line":"            **{\u0027path\u0027: path,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_85346d4b","line":134,"updated":"2014-11-18 23:04:06.000000000","message":"_LI","commit_id":"ba65606c905ae1dbbc340ef6ffdd7e517439cea8"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"89ec1737ca4fbef6509428c968d032d3b936863e","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    def do_direct_resize(self, path, new_size_bytes, force\u003dTrue):"},{"line_number":132,"context_line":"        \"\"\"Resize the lun.\"\"\""},{"line_number":133,"context_line":"        seg \u003d path.split(\"/\")"},{"line_number":134,"context_line":"        LOG.info(_(\"Resizing lun %s directly to new size.\"), seg[-1])"},{"line_number":135,"context_line":"        lun_resize \u003d netapp_api.NaElement.create_node_with_children("},{"line_number":136,"context_line":"            \u0027lun-resize\u0027,"},{"line_number":137,"context_line":"            **{\u0027path\u0027: path,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_5de6c245","line":134,"in_reply_to":"5a890539_85346d4b","updated":"2014-11-20 17:39:12.000000000","message":"Done","commit_id":"ba65606c905ae1dbbc340ef6ffdd7e517439cea8"}],"cinder/volume/drivers/netapp/client/cmode.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"e33011096be274ee6d7931e0d3cb323b3bc844ad","unresolved":false,"context_lines":[{"line_number":282,"context_line":"        msg_fmt \u003d {\u0027vserver\u0027: vserver, \u0027junction\u0027: junction}"},{"line_number":283,"context_line":"        raise exception.NotFound(_(\"\"\"No volume on cluster with vserver"},{"line_number":284,"context_line":"                                   %(vserver)s and junction path %(junction)s"},{"line_number":285,"context_line":"                                   \"\"\") % msg_fmt)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def clone_file(self, flex_vol, src_path, dest_path, vserver,"},{"line_number":288,"context_line":"                   dest_exists\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_65930150","line":285,"updated":"2014-11-18 23:04:06.000000000","message":"Any reason why this message uses \"\"\" which is usually for docstring?","commit_id":"ba65606c905ae1dbbc340ef6ffdd7e517439cea8"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"89ec1737ca4fbef6509428c968d032d3b936863e","unresolved":false,"context_lines":[{"line_number":282,"context_line":"        msg_fmt \u003d {\u0027vserver\u0027: vserver, \u0027junction\u0027: junction}"},{"line_number":283,"context_line":"        raise exception.NotFound(_(\"\"\"No volume on cluster with vserver"},{"line_number":284,"context_line":"                                   %(vserver)s and junction path %(junction)s"},{"line_number":285,"context_line":"                                   \"\"\") % msg_fmt)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def clone_file(self, flex_vol, src_path, dest_path, vserver,"},{"line_number":288,"context_line":"                   dest_exists\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_10d0a1f6","line":285,"in_reply_to":"5a890539_65930150","updated":"2014-11-20 17:39:12.000000000","message":"No idea!  Fixed.","commit_id":"ba65606c905ae1dbbc340ef6ffdd7e517439cea8"}],"cinder/volume/drivers/netapp/client/seven_mode.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"e33011096be274ee6d7931e0d3cb323b3bc844ad","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                    if luns:"},{"line_number":74,"context_line":"                        lun_list.extend(luns)"},{"line_number":75,"context_line":"                except netapp_api.NaApiError:"},{"line_number":76,"context_line":"                    LOG.warn(_LW(\"Error finding luns for volume %s.\""},{"line_number":77,"context_line":"                                 \" Verify volume exists.\") % (vol))"},{"line_number":78,"context_line":"        else:"},{"line_number":79,"context_line":"            luns \u003d self._get_vol_luns(None)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_2551f9d8","line":76,"updated":"2014-11-18 23:04:06.000000000","message":"Can you change \"warn\" to \"warning\" as \"warn\" is deprecated?","commit_id":"ba65606c905ae1dbbc340ef6ffdd7e517439cea8"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"89ec1737ca4fbef6509428c968d032d3b936863e","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                    if luns:"},{"line_number":74,"context_line":"                        lun_list.extend(luns)"},{"line_number":75,"context_line":"                except netapp_api.NaApiError:"},{"line_number":76,"context_line":"                    LOG.warn(_LW(\"Error finding luns for volume %s.\""},{"line_number":77,"context_line":"                                 \" Verify volume exists.\") % (vol))"},{"line_number":78,"context_line":"        else:"},{"line_number":79,"context_line":"            luns \u003d self._get_vol_luns(None)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_f0ecf591","line":76,"in_reply_to":"5a890539_2551f9d8","updated":"2014-11-20 17:39:12.000000000","message":"Done.  I fixed this across the NetApp Cinder codebase.","commit_id":"ba65606c905ae1dbbc340ef6ffdd7e517439cea8"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"29d7febe6fc1f723cbf19f67e61ed28c7415881c","unresolved":false,"context_lines":[{"line_number":313,"context_line":"            try:"},{"line_number":314,"context_line":"                self.connection.invoke_successfully(clone_clear)"},{"line_number":315,"context_line":"                break"},{"line_number":316,"context_line":"            except Exception:"},{"line_number":317,"context_line":"                # Filer might be rebooting"},{"line_number":318,"context_line":"                time.sleep(5)"},{"line_number":319,"context_line":"            retry \u003d retry - 1"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_6a3da98e","line":316,"updated":"2014-11-18 11:12:16.000000000","message":"Can a specific exception be put here?","commit_id":"ba65606c905ae1dbbc340ef6ffdd7e517439cea8"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"89ec1737ca4fbef6509428c968d032d3b936863e","unresolved":false,"context_lines":[{"line_number":313,"context_line":"            try:"},{"line_number":314,"context_line":"                self.connection.invoke_successfully(clone_clear)"},{"line_number":315,"context_line":"                break"},{"line_number":316,"context_line":"            except Exception:"},{"line_number":317,"context_line":"                # Filer might be rebooting"},{"line_number":318,"context_line":"                time.sleep(5)"},{"line_number":319,"context_line":"            retry \u003d retry - 1"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_ff13de0a","line":316,"in_reply_to":"5a890539_6a3da98e","updated":"2014-11-20 17:39:12.000000000","message":"Done.","commit_id":"ba65606c905ae1dbbc340ef6ffdd7e517439cea8"}]}