)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"407896dd937eae34eb2274ce4e4449c51154eac0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Juan Zuluaga \u003cjuan.c.zuluaga@oracle.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-09-24 19:03:02 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ZFSSA iSCSI vol create fails with in extra specs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"volume_backend_name was using the class name."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da9df570_8af07a92","line":7,"updated":"2014-09-25 14:13:22.000000000","message":"Do you mean \u0027with name in\u0027 here?","commit_id":"0618fd763d4b34e2073f461d30282dc6b23be867"},{"author":{"_account_id":11509,"name":"Juan Zuluaga","email":"juan.c.zuluaga@oracle.com","username":"juzuluag"},"change_message_id":"42da0b9ee41d8a647d81b423824de657221c83a5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Juan Zuluaga \u003cjuan.c.zuluaga@oracle.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-09-24 19:03:02 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ZFSSA iSCSI vol create fails with in extra specs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"volume_backend_name was using the class name."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da9df570_40df5369","line":7,"in_reply_to":"da9df570_8af07a92","updated":"2014-09-25 14:56:14.000000000","message":"Changed the title.","commit_id":"0618fd763d4b34e2073f461d30282dc6b23be867"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"407896dd937eae34eb2274ce4e4449c51154eac0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ZFSSA iSCSI vol create fails with in extra specs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"volume_backend_name was using the class name."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I1bc501dd4c5689d96c7beb720b64112df1770232"},{"line_number":12,"context_line":"Closes-Bug: 1373621"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da9df570_4a4132a8","line":9,"updated":"2014-09-25 14:13:22.000000000","message":"Could you provide some additional details here please?  It looks like a pretty simple change but I thik it requires explanation as to why it was needed.\n\nThanks!","commit_id":"0618fd763d4b34e2073f461d30282dc6b23be867"},{"author":{"_account_id":11509,"name":"Juan Zuluaga","email":"juan.c.zuluaga@oracle.com","username":"juzuluag"},"change_message_id":"42da0b9ee41d8a647d81b423824de657221c83a5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ZFSSA iSCSI vol create fails with in extra specs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"volume_backend_name was using the class name."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I1bc501dd4c5689d96c7beb720b64112df1770232"},{"line_number":12,"context_line":"Closes-Bug: 1373621"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da9df570_c0d2635b","line":9,"in_reply_to":"da9df570_4a4132a8","updated":"2014-09-25 14:56:14.000000000","message":"I did add more explanation as you requested.\nThx.","commit_id":"0618fd763d4b34e2073f461d30282dc6b23be867"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"0658315b6c75aa80265ef75fc433d30ccbd2ea57","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Juan Zuluaga \u003cjuan.c.zuluaga@oracle.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-09-25 12:02:45 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ZFSSA iSCSI vol create fails with vol type option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Vol create with volume-type option is not working since"},{"line_number":10,"context_line":"volume_backend_name contains the class name as"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baa201ad_0c04137a","line":7,"updated":"2014-09-30 02:35:08.000000000","message":"Volume type definition can vary, e.g. it doesn\u0027t have to have \u0027volume_backend_name\u0027 in extra specs.  So I think the commit here isn\u0027t clear enough.  I\u0027d rather have it changed to \u0027Fix ZFSSA driver to honor volume_backend_name configuration option, like I mentioned in bug report.","commit_id":"78ad426fbcbcd4042f07490c97986dc73b21aa30"},{"author":{"_account_id":11509,"name":"Juan Zuluaga","email":"juan.c.zuluaga@oracle.com","username":"juzuluag"},"change_message_id":"a7df0a8ceba96324bc42293f01af67fd83b26677","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Juan Zuluaga \u003cjuan.c.zuluaga@oracle.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-09-25 12:02:45 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ZFSSA iSCSI vol create fails with vol type option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Vol create with volume-type option is not working since"},{"line_number":10,"context_line":"volume_backend_name contains the class name as"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baa201ad_2c5b8c55","line":7,"in_reply_to":"baa201ad_0c04137a","updated":"2014-09-30 13:19:53.000000000","message":"I\u0027m not sure whether \u0027volume_backend_name\u0027 is the property to be used or not for this purpose. I followed what openstack multi-backend documentation uses: http://docs.openstack.org/admin-guide-cloud/content/multi_backend.html.\nSo I think it\u0027s an important property that follow certain usage already.","commit_id":"78ad426fbcbcd4042f07490c97986dc73b21aa30"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"0658315b6c75aa80265ef75fc433d30ccbd2ea57","unresolved":false,"context_lines":[{"line_number":15,"context_line":"The fix is to look whether volume_backend_name is part of the"},{"line_number":16,"context_line":"configuration or falls into the class name in case there is"},{"line_number":17,"context_line":"no backend name."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I1bc501dd4c5689d96c7beb720b64112df1770232"},{"line_number":20,"context_line":"Closes-Bug: 1373621"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baa201ad_2cf8f77b","line":18,"updated":"2014-09-30 02:35:08.000000000","message":"Need a DocImpact.","commit_id":"78ad426fbcbcd4042f07490c97986dc73b21aa30"},{"author":{"_account_id":11509,"name":"Juan Zuluaga","email":"juan.c.zuluaga@oracle.com","username":"juzuluag"},"change_message_id":"a7df0a8ceba96324bc42293f01af67fd83b26677","unresolved":false,"context_lines":[{"line_number":15,"context_line":"The fix is to look whether volume_backend_name is part of the"},{"line_number":16,"context_line":"configuration or falls into the class name in case there is"},{"line_number":17,"context_line":"no backend name."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I1bc501dd4c5689d96c7beb720b64112df1770232"},{"line_number":20,"context_line":"Closes-Bug: 1373621"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baa201ad_6c2cb4ac","line":18,"in_reply_to":"baa201ad_2cf8f77b","updated":"2014-09-30 13:19:53.000000000","message":"Done","commit_id":"78ad426fbcbcd4042f07490c97986dc73b21aa30"}],"cinder/volume/drivers/zfssa/zfssaiscsi.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"b456d681af264a82c94736ffb9aa59106af1d2c8","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    \"\"\"ZFSSA Cinder volume driver\"\"\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    VERSION \u003d \u00271.0.0\u0027"},{"line_number":79,"context_line":"    protocol \u003d \u0027iscsi\u0027"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":82,"context_line":"        super(ZFSSAISCSIDriver, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_c0918348","line":79,"updated":"2014-09-25 15:04:13.000000000","message":"I think this may be inadvertent?  If not we should pretend it is and put it back to iSCSI.  :)","commit_id":"7eb1fac7a481d4710be1f6f271c77d6811a65f8d"},{"author":{"_account_id":11509,"name":"Juan Zuluaga","email":"juan.c.zuluaga@oracle.com","username":"juzuluag"},"change_message_id":"57f9f52a811b2cc4c5575e98418c5ffd77477f28","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    \"\"\"ZFSSA Cinder volume driver\"\"\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    VERSION \u003d \u00271.0.0\u0027"},{"line_number":79,"context_line":"    protocol \u003d \u0027iscsi\u0027"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":82,"context_line":"        super(ZFSSAISCSIDriver, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_fece282d","line":79,"in_reply_to":"da9df570_c0918348","updated":"2014-09-25 16:03:59.000000000","message":"Done","commit_id":"7eb1fac7a481d4710be1f6f271c77d6811a65f8d"}]}
