)]}'
{"cinder/tests/test_hplefthand.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"393f8e54d6b29021ee8473955b87126b24eab26f","unresolved":false,"context_lines":[{"line_number":979,"context_line":"            mock.call.removeServerAccess(1, 0)]"},{"line_number":980,"context_line":""},{"line_number":981,"context_line":"        # validate call chain"},{"line_number":982,"context_line":"        mock_client.assert_has_calls(expected)"},{"line_number":983,"context_line":""},{"line_number":984,"context_line":"        mock_client.getVolumeByName.side_effect \u003d hpexceptions.HTTPNotFound()"},{"line_number":985,"context_line":"        # ensure the raised exception is a cinder exception"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_3f64ccb1","line":982,"updated":"2015-01-08 16:49:34.000000000","message":"This could still call deleteServer next and you wouldn\u0027t catch it here.  Would be good to test for deleteServer not called.","commit_id":"bfd68080b43400df4a40b9fb57bb46c1f4f34b59"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"f66681ec8cbbd5a2815bf92f424b02689e0b9bc3","unresolved":false,"context_lines":[{"line_number":979,"context_line":"            mock.call.removeServerAccess(1, 0)]"},{"line_number":980,"context_line":""},{"line_number":981,"context_line":"        # validate call chain"},{"line_number":982,"context_line":"        mock_client.assert_has_calls(expected)"},{"line_number":983,"context_line":""},{"line_number":984,"context_line":"        mock_client.getVolumeByName.side_effect \u003d hpexceptions.HTTPNotFound()"},{"line_number":985,"context_line":"        # ensure the raised exception is a cinder exception"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_33431c40","line":982,"in_reply_to":"3a961159_3f64ccb1","updated":"2015-01-08 23:50:24.000000000","message":"Done","commit_id":"bfd68080b43400df4a40b9fb57bb46c1f4f34b59"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"16f9911c50fd6101cc990b6669305845f5233550","unresolved":false,"context_lines":[{"line_number":986,"context_line":""},{"line_number":987,"context_line":"        # validate call chain"},{"line_number":988,"context_line":"        mock_client.assert_has_calls(expected)"},{"line_number":989,"context_line":"        assert not mock_client.deleteServer.called"},{"line_number":990,"context_line":""},{"line_number":991,"context_line":"        mock_client.getVolumeByName.side_effect \u003d hpexceptions.HTTPNotFound()"},{"line_number":992,"context_line":"        # ensure the raised exception is a cinder exception"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_9eca179e","line":989,"updated":"2015-01-09 00:07:45.000000000","message":"self.assertFalse(...","commit_id":"d0e2ae8bdaf212e9d84fad192ee57f4fcbc3799d"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"13de7e4469865813b5b0577bcf9d3a845d7f170f","unresolved":false,"context_lines":[{"line_number":986,"context_line":""},{"line_number":987,"context_line":"        # validate call chain"},{"line_number":988,"context_line":"        mock_client.assert_has_calls(expected)"},{"line_number":989,"context_line":"        assert not mock_client.deleteServer.called"},{"line_number":990,"context_line":""},{"line_number":991,"context_line":"        mock_client.getVolumeByName.side_effect \u003d hpexceptions.HTTPNotFound()"},{"line_number":992,"context_line":"        # ensure the raised exception is a cinder exception"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_5ee18fce","line":989,"in_reply_to":"3a961159_9eca179e","updated":"2015-01-09 00:20:44.000000000","message":"Done","commit_id":"d0e2ae8bdaf212e9d84fad192ee57f4fcbc3799d"}],"cinder/volume/drivers/san/hp/hp_lefthand_rest_proxy.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"393f8e54d6b29021ee8473955b87126b24eab26f","unresolved":false,"context_lines":[{"line_number":310,"context_line":"            for entry in volume_list:"},{"line_number":311,"context_line":"                if entry[\u0027id\u0027] !\u003d volume_info[\u0027id\u0027]:"},{"line_number":312,"context_line":"                    removeServer \u003d False"},{"line_number":313,"context_line":"                    break"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"            self.client.removeServerAccess("},{"line_number":316,"context_line":"                volume_info[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_9fda2049","line":313,"updated":"2015-01-08 16:49:34.000000000","message":"You might make this nicer with for/else, but this is fine the way it is.","commit_id":"bfd68080b43400df4a40b9fb57bb46c1f4f34b59"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"f66681ec8cbbd5a2815bf92f424b02689e0b9bc3","unresolved":false,"context_lines":[{"line_number":310,"context_line":"            for entry in volume_list:"},{"line_number":311,"context_line":"                if entry[\u0027id\u0027] !\u003d volume_info[\u0027id\u0027]:"},{"line_number":312,"context_line":"                    removeServer \u003d False"},{"line_number":313,"context_line":"                    break"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"            self.client.removeServerAccess("},{"line_number":316,"context_line":"                volume_info[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_936bf0b7","line":313,"in_reply_to":"3a961159_9fda2049","updated":"2015-01-08 23:50:24.000000000","message":"I am going to keep it the same structure for now.","commit_id":"bfd68080b43400df4a40b9fb57bb46c1f4f34b59"}]}
