)]}'
{"cinder/volume/driver.py":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"239c67d5d057f07676962c8da23492acbd61fe68","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        # TODO(yamahata): zeroing out the whole snapshot triggers COW."},{"line_number":213,"context_line":"        # it\u0027s quite slow."},{"line_number":214,"context_line":"        #self._delete_volume(snapshot, snapshot[\u0027volume_size\u0027])"},{"line_number":215,"context_line":"        self._try_execute(\u0027lvremove\u0027, \u0027-f\u0027, \"%s/%s\" %"},{"line_number":216,"context_line":"                          (FLAGS.volume_group,"},{"line_number":217,"context_line":"                           self._escape_snapshot(snapshot[\u0027name\u0027])),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Few0%3D","line":214,"updated":"2012-09-07 11:08:15.000000000","message":"Don\u0027t leave commented-out code without an explaination of why please, it\u0027s a nightmare when you try to figure out why in six month time. \"# See note above about BUG 1023755\" is enough","commit_id":"d21c7a5109d1ab305f6eb7ce08d8f4f1203ca1fb"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"59240558a7c278a8ec807e8d19f753e5af98cb12","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        # TODO(yamahata): zeroing out the whole snapshot triggers COW."},{"line_number":213,"context_line":"        # it\u0027s quite slow."},{"line_number":214,"context_line":"        #self._delete_volume(snapshot, snapshot[\u0027volume_size\u0027])"},{"line_number":215,"context_line":"        self._try_execute(\u0027lvremove\u0027, \u0027-f\u0027, \"%s/%s\" %"},{"line_number":216,"context_line":"                          (FLAGS.volume_group,"},{"line_number":217,"context_line":"                           self._escape_snapshot(snapshot[\u0027name\u0027])),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Femk%3D","line":214,"in_reply_to":"AAAALH%2F%2Few0%3D","updated":"2012-09-07 14:33:15.000000000","message":"Done","commit_id":"d21c7a5109d1ab305f6eb7ce08d8f4f1203ca1fb"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"5da2a1c179e5179c813a6d28cfae9859734a7856","unresolved":false,"context_lines":[{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        # TODO(yamahata): zeroing out the whole snapshot triggers COW."},{"line_number":215,"context_line":"        # it\u0027s quite slow."},{"line_number":216,"context_line":"        self._delete_volume(snapshot, snapshot[\u0027volume_size\u0027])"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def local_path(self, volume):"},{"line_number":219,"context_line":"        # NOTE(vish): stops deprecation warning"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2Fdyg%3D","side":"PARENT","line":216,"updated":"2012-09-08 17:45:35.000000000","message":"remove size","commit_id":"43bc69336b10e357c4b8a8d802bfaf9e4a29157a"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"5da2a1c179e5179c813a6d28cfae9859734a7856","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def _delete_volume(self, volume, size_in_g):"},{"line_number":147,"context_line":"        \"\"\"Deletes a logical volume.\"\"\""},{"line_number":148,"context_line":"        # We zero out on create, so no need to do it here"},{"line_number":149,"context_line":"        self._try_execute(\u0027lvremove\u0027, \u0027-f\u0027, \"%s/%s\" %"},{"line_number":150,"context_line":"                          (FLAGS.volume_group,"},{"line_number":151,"context_line":"                           self._escape_snapshot(volume[\u0027name\u0027])),"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2Fdyo%3D","line":148,"updated":"2012-09-08 17:45:35.000000000","message":"this method doesn\u0027t need size_in_g anymore","commit_id":"2260580e7710edb6b24a001fface0bc851717283"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"5da2a1c179e5179c813a6d28cfae9859734a7856","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            if (out[0] \u003d\u003d \u0027o\u0027) or (out[0] \u003d\u003d \u0027O\u0027):"},{"line_number":203,"context_line":"                raise exception.VolumeIsBusy(volume_name\u003dvolume[\u0027name\u0027])"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        self._delete_volume(volume, volume[\u0027size\u0027])"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def create_snapshot(self, snapshot):"},{"line_number":208,"context_line":"        \"\"\"Creates a snapshot.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2Fdyk%3D","line":205,"updated":"2012-09-08 17:45:35.000000000","message":"remove size","commit_id":"2260580e7710edb6b24a001fface0bc851717283"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"5da2a1c179e5179c813a6d28cfae9859734a7856","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        # it\u0027s quite slow."},{"line_number":223,"context_line":"        self._try_execute(\u0027lvremove\u0027, \u0027-f\u0027, \"%s/%s\" %"},{"line_number":224,"context_line":"                          (FLAGS.volume_group,"},{"line_number":225,"context_line":"                           self._escape_snapshot(snapshot[\u0027name\u0027])),"},{"line_number":226,"context_line":"                          run_as_root\u003dTrue)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    def local_path(self, volume):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2Fdys%3D","line":225,"updated":"2012-09-08 17:45:35.000000000","message":"looks like you can revert this part of the change","commit_id":"2260580e7710edb6b24a001fface0bc851717283"}]}
