)]}'
{"id":"openstack%2Fcinder~12867","triplet_id":"openstack%2Fcinder~master~I04127972981522c1ed81903893396c4f9665bcd3","project":"openstack/cinder","branch":"master","topic":"bug/1048565","hashtags":[],"change_id":"I04127972981522c1ed81903893396c4f9665bcd3","subject":"Improve entity validation in volumes APIs","status":"MERGED","created":"2012-09-12 11:55:42.000000000","updated":"2012-09-14 03:41:14.000000000","submitted":"2012-09-14 03:41:14.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"98ec13250c5f781e5fd76075e543390d1e1855af","_number":12867,"virtual_id_number":12867,"owner":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":2,"date":"2012-09-14 03:41:14.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"all":[{"value":0,"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":2,"date":"2012-09-13 20:01:26.000000000","_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"all":[{"value":0,"date":"2012-09-13 15:13:42.000000000","_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":1,"date":"2012-09-14 03:23:44.000000000","_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-09-14 03:23:44.000000000","updated_by":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"reviewer":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"state":"REVIEWER"},{"updated":"2012-09-14 03:41:14.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"6fb2de69e0837d01b383f722c13560306bc71f26","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2012-09-12 11:57:47.000000000","message":"Patch Set 1: Work In Progress\n\nThe is_valid_body() helper needs to go into Nova first","accounts_in_message":[],"_revision_number":1},{"id":"f1216eefb970b30241f27a04e4cf53f74366a7cd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-12 12:17:56.000000000","message":"Patch Set 1: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/12867/1/check/gate-cinder-merge/859 : SUCCESS\n- http://logs.openstack.org/12867/1/check/gate-cinder-docs/773 : SUCCESS\n- http://logs.openstack.org/12867/1/check/gate-cinder-pep8/812 : SUCCESS\n- http://logs.openstack.org/12867/1/check/gate-cinder-python26/801 : SUCCESS\n- http://logs.openstack.org/12867/1/check/gate-cinder-python27/813 : SUCCESS\n- http://logs.openstack.org/12867/1/check/gate-tempest-devstack-vm/11309 : SUCCESS\n- http://logs.openstack.org/12867/1/check/gate-tempest-devstack-vm-cinder/1290 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"e397773bcce3f76e9e7d7e8f5f2669fbcd7dfbaa","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2012-09-13 15:13:42.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"abce3eab0444df87093a08b3344dfbfd5318a9cc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-13 15:38:33.000000000","message":"Patch Set 2: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/12867/2/check/gate-cinder-merge/877 : SUCCESS\n- http://logs.openstack.org/12867/2/check/gate-cinder-docs/791 : SUCCESS\n- http://logs.openstack.org/12867/2/check/gate-cinder-pep8/830 : SUCCESS\n- http://logs.openstack.org/12867/2/check/gate-cinder-python26/818 : SUCCESS\n- http://logs.openstack.org/12867/2/check/gate-cinder-python27/831 : SUCCESS\n- http://logs.openstack.org/12867/2/check/gate-tempest-devstack-vm/11511 : SUCCESS\n- http://logs.openstack.org/12867/2/check/gate-tempest-devstack-vm-cinder/1492 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"048bd5a921ec39174ea7d583c515efc6d0c45f15","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2012-09-13 20:01:26.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"4ff7285d501a92bbe067b1be2a4132e24fa1f97c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-14 03:23:44.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"685fa44ca68d8f5d94f7ec8ca03a658a38bd04bb","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2012-09-14 03:23:44.000000000","message":"Patch Set 2: Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"1d2d1e3a399eb15f35ce8a279f43af3901fe77b3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-14 03:41:14.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2},{"id":"1998c19fc6815b4cc26de6c76e9e317a862711f3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-14 03:41:14.000000000","message":"Patch Set 2: Verified\n\nBuild successful\n\n- http://logs.openstack.org/12867/2/gate/gate-cinder-merge/883 : SUCCESS\n- http://logs.openstack.org/12867/2/gate/gate-cinder-docs/797 : SUCCESS\n- http://logs.openstack.org/12867/2/gate/gate-cinder-pep8/836 : SUCCESS\n- http://logs.openstack.org/12867/2/gate/gate-cinder-python26/824 : SUCCESS\n- http://logs.openstack.org/12867/2/gate/gate-cinder-python27/837 : SUCCESS\n- http://logs.openstack.org/12867/2/gate/gate-tempest-devstack-vm/11593 : SUCCESS\n- http://logs.openstack.org/12867/2/gate/gate-tempest-devstack-vm-cinder/1573 : SUCCESS\n","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"dcecb586a0578688656d5420c40c26e5a8caa942","revisions":{"e40241c9f33b58174732c7c6d06a7ccf471dab91":{"kind":"REWORK","_number":1,"created":"2012-09-12 11:55:42.000000000","uploader":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"ref":"refs/changes/67/12867/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder","ref":"refs/changes/67/12867/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder refs/changes/67/12867/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder refs/changes/67/12867/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder refs/changes/67/12867/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder refs/changes/67/12867/1"}}},"commit":{"parents":[{"commit":"97f9c93950861593519a5934600a28a77f155b5d","subject":"Add entity body validation helper","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/97f9c93950861593519a5934600a28a77f155b5d"}]}],"author":{"name":"Mark McLoughlin","email":"markmc@redhat.com","date":"2012-09-12 11:51:40.000000000","tz":60},"committer":{"name":"Mark McLoughlin","email":"markmc@redhat.com","date":"2012-09-12 11:51:40.000000000","tz":60},"subject":"Improve entity validation in volumes APIs","message":"Improve entity validation in volumes APIs\n\nFixes bug #1048565\n\nUse the new Controller.is_valid_body() helper to validate the entity\nbody in various volumes related POST/PUT handlers and return 422\nas appropriate.\n\nChange-Id: I04127972981522c1ed81903893396c4f9665bcd3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/e40241c9f33b58174732c7c6d06a7ccf471dab91"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/e40241c9f33b58174732c7c6d06a7ccf471dab91"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"97f9c93950861593519a5934600a28a77f155b5d","is_merged_in_target_branch":false,"change_id":"If8114cc76d68567005c85c803f29e30e034db89a","change_number":12866,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"},"dcecb586a0578688656d5420c40c26e5a8caa942":{"kind":"NO_CHANGE","_number":2,"created":"2012-09-13 15:13:42.000000000","uploader":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"ref":"refs/changes/67/12867/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder","ref":"refs/changes/67/12867/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder refs/changes/67/12867/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder refs/changes/67/12867/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder refs/changes/67/12867/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder refs/changes/67/12867/2"}}},"commit":{"parents":[{"commit":"3dcb3fdba791639ab3fe7ab20b3398babcd27512","subject":"Add entity body validation helper","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/3dcb3fdba791639ab3fe7ab20b3398babcd27512"}]}],"author":{"name":"Mark McLoughlin","email":"markmc@redhat.com","date":"2012-09-12 11:51:40.000000000","tz":60},"committer":{"name":"Mark McLoughlin","email":"markmc@redhat.com","date":"2012-09-13 15:11:36.000000000","tz":60},"subject":"Improve entity validation in volumes APIs","message":"Improve entity validation in volumes APIs\n\nFixes bug #1048565\n\nUse the new Controller.is_valid_body() helper to validate the entity\nbody in various volumes related POST/PUT handlers and return 422\nas appropriate.\n\nChange-Id: I04127972981522c1ed81903893396c4f9665bcd3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/dcecb586a0578688656d5420c40c26e5a8caa942"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/dcecb586a0578688656d5420c40c26e5a8caa942"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"3dcb3fdba791639ab3fe7ab20b3398babcd27512","is_merged_in_target_branch":true,"change_id":"If8114cc76d68567005c85c803f29e30e034db89a","change_number":12866,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}