)]}'
{"id":"openstack%2Fcinder~12910","triplet_id":"openstack%2Fcinder~master~I9b9a2400a172d52987d76f3132793cb042fd201c","project":"openstack/cinder","branch":"master","topic":"bug/1050086","hashtags":[],"change_id":"I9b9a2400a172d52987d76f3132793cb042fd201c","subject":"Use tmpdir and avoid leaving test files behind","status":"MERGED","created":"2012-09-12 23:01:01.000000000","updated":"2012-09-13 00:16:08.000000000","submitted":"2012-09-13 00:16:08.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"101b29b7909a9a7d6325a6af92851a274906e0e7","_number":12910,"virtual_id_number":12910,"owner":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":2,"date":"2012-09-13 00:16:08.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":693,"name":"Christopher MacGown","email":"chris@pistoncloud.com","username":"0x44"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"recommended":{"_account_id":693,"name":"Christopher MacGown","email":"chris@pistoncloud.com","username":"0x44"},"all":[{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2012-09-12 23:38:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":693,"name":"Christopher MacGown","email":"chris@pistoncloud.com","username":"0x44"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":2,"date":"2012-09-12 23:43:29.000000000","_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":693,"name":"Christopher MacGown","email":"chris@pistoncloud.com","username":"0x44"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":1,"date":"2012-09-12 23:43:29.000000000","_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":693,"name":"Christopher MacGown","email":"chris@pistoncloud.com","username":"0x44"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":693,"name":"Christopher MacGown","email":"chris@pistoncloud.com","username":"0x44"},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-09-12 23:35:26.000000000","updated_by":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"reviewer":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"state":"REVIEWER"},{"updated":"2012-09-12 23:38:06.000000000","updated_by":{"_account_id":693,"name":"Christopher MacGown","email":"chris@pistoncloud.com","username":"0x44"},"reviewer":{"_account_id":693,"name":"Christopher MacGown","email":"chris@pistoncloud.com","username":"0x44"},"state":"REVIEWER"},{"updated":"2012-09-12 23:43:29.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2012-09-13 00:16:08.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"5654155201fd9f96fa866f5ef7a2eddc93f50be9","author":{"_account_id":693,"name":"Christopher MacGown","email":"chris@pistoncloud.com","username":"0x44"},"date":"2012-09-12 23:03:17.000000000","message":"Patch Set 1:\n\nIs there code elsewhere that cleans up after tempdirs? Unlike tempfile.NamedTemporaryFile or tempfile.TemporaryFile the caller is responsible for cleaning up the directory made with tempfile.mkdtemp","accounts_in_message":[],"_revision_number":1},{"id":"96b43886e3b07de1bcb9bae9d1f05e3b2ca5204e","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2012-09-12 23:09:47.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nUh oh... nice catch","accounts_in_message":[],"_revision_number":1},{"id":"dec89f14362d232a53b4fbae0fa43b27dcf036d9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-12 23:25:56.000000000","message":"Patch Set 1: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/12910/1/check/gate-cinder-merge/865 : SUCCESS\n- http://logs.openstack.org/12910/1/check/gate-cinder-docs/779 : SUCCESS\n- http://logs.openstack.org/12910/1/check/gate-cinder-pep8/818 : SUCCESS\n- http://logs.openstack.org/12910/1/check/gate-cinder-python26/806 : SUCCESS\n- http://logs.openstack.org/12910/1/check/gate-cinder-python27/819 : SUCCESS\n- http://logs.openstack.org/12910/1/check/gate-tempest-devstack-vm/11417 : SUCCESS\n- http://logs.openstack.org/12910/1/check/gate-tempest-devstack-vm-cinder/1397 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"ba34baf560bc9174585b777125b1483adede8a04","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2012-09-12 23:32:14.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"e9991c6851563eee31c6ad1dc2e51891b2443c94","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2012-09-12 23:35:26.000000000","message":"Patch Set 2:\n\nJohn, why is the file created and not deleted by the iSCSI driver itself?  When I started looking at this problem it looked like a naming related problem.\n\nin the iSCSI driver, it tries creating a file called \u0027blaa\u0027 and then tries to delete \u0027volume-blaa\u0027?","accounts_in_message":[],"_revision_number":2},{"id":"4d74b3352f67b28f9fe3a0739eb7a8a871a9f7a1","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2012-09-12 23:35:52.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"f961d1cc9bdf3580795de844e1ac51677197b29e","author":{"_account_id":693,"name":"Christopher MacGown","email":"chris@pistoncloud.com","username":"0x44"},"date":"2012-09-12 23:38:06.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":3},{"id":"3420ae51eba5fdd3cb1989c92c30156b8bc81c68","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-12 23:43:29.000000000","message":"Patch Set 3:\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"3ee8a41444b9f02ab5c51795425d3d1185a5815c","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2012-09-12 23:43:29.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\nGOOD BYE tests/blaa !!!","accounts_in_message":[],"_revision_number":3},{"id":"de13074c9c5ec7bba7170d44c58c9a773388d362","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-13 00:06:18.000000000","message":"Patch Set 3: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/12910/3/check/gate-cinder-merge/867 : SUCCESS\n- http://logs.openstack.org/12910/3/check/gate-cinder-docs/781 : SUCCESS\n- http://logs.openstack.org/12910/3/check/gate-cinder-pep8/820 : SUCCESS\n- http://logs.openstack.org/12910/3/check/gate-cinder-python26/808 : SUCCESS\n- http://logs.openstack.org/12910/3/check/gate-cinder-python27/821 : SUCCESS\n- http://logs.openstack.org/12910/3/check/gate-tempest-devstack-vm/11425 : SUCCESS\n- http://logs.openstack.org/12910/3/check/gate-tempest-devstack-vm-cinder/1405 : SUCCESS\n","accounts_in_message":[],"_revision_number":3},{"id":"2dec5287614728cd6dcebcbefbf1e08ea2483b4c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-13 00:16:08.000000000","message":"Patch Set 3: Verified\n\nBuild successful\n\n- http://logs.openstack.org/12910/3/gate/gate-cinder-merge/870 : SUCCESS\n- http://logs.openstack.org/12910/3/gate/gate-cinder-docs/784 : SUCCESS\n- http://logs.openstack.org/12910/3/gate/gate-cinder-pep8/823 : SUCCESS\n- http://logs.openstack.org/12910/3/gate/gate-cinder-python26/811 : SUCCESS\n- http://logs.openstack.org/12910/3/gate/gate-cinder-python27/824 : SUCCESS\n- http://logs.openstack.org/12910/3/gate/gate-tempest-devstack-vm/11430 : SUCCESS\n- http://logs.openstack.org/12910/3/gate/gate-tempest-devstack-vm-cinder/1410 : SUCCESS\n","accounts_in_message":[],"_revision_number":3},{"id":"bde95d2651c512cd72e58d8ee656cbbea37be35e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-13 00:16:08.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"96f72f2cfd0afa6e60399dadd30bb83b0ab8ee0e","revisions":{"f6b520881b9db3d527a55ecbc7cdc2dc71f6a002":{"kind":"REWORK","_number":1,"created":"2012-09-12 23:01:01.000000000","uploader":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"ref":"refs/changes/10/12910/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder","ref":"refs/changes/10/12910/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder refs/changes/10/12910/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder refs/changes/10/12910/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder refs/changes/10/12910/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder refs/changes/10/12910/1"}}},"commit":{"parents":[{"commit":"b4e63d4269c658d412d0e635e396993ea0a2dc86","subject":"Merge \"Fixes bug 1049446.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/b4e63d4269c658d412d0e635e396993ea0a2dc86"}]}],"author":{"name":"John Griffith","email":"john.griffith@solidfire.com","date":"2012-09-12 22:52:02.000000000","tz":-360},"committer":{"name":"John Griffith","email":"john.griffith@solidfire.com","date":"2012-09-12 23:01:00.000000000","tz":-360},"subject":"Use tmpdir and avoid leaving test files behind","message":"Use tmpdir and avoid leaving test files behind\n\n We were just creating a file for testing iscsi persist files and\n weren\u0027t cleaning up after the test.\n\n Change this to use a tmpdir and make sure we leave no tracks.\n\n Fixes bug #1050086\n\nChange-Id: I9b9a2400a172d52987d76f3132793cb042fd201c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/f6b520881b9db3d527a55ecbc7cdc2dc71f6a002"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/f6b520881b9db3d527a55ecbc7cdc2dc71f6a002"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"b4e63d4269c658d412d0e635e396993ea0a2dc86","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"97bd198394ec68e01d1474ef16cd487371f222dc":{"kind":"REWORK","_number":2,"created":"2012-09-12 23:32:14.000000000","uploader":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"ref":"refs/changes/10/12910/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder","ref":"refs/changes/10/12910/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder refs/changes/10/12910/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder refs/changes/10/12910/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder refs/changes/10/12910/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder refs/changes/10/12910/2"}}},"commit":{"parents":[{"commit":"81061b1b251a568697836a91d6e5dff08872cf3a","subject":"Merge \"Add volume quota in volume/api.py and olume/manager.py\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/81061b1b251a568697836a91d6e5dff08872cf3a"}]}],"author":{"name":"John Griffith","email":"john.griffith@solidfire.com","date":"2012-09-12 22:52:02.000000000","tz":-360},"committer":{"name":"John Griffith","email":"john.griffith@solidfire.com","date":"2012-09-12 23:32:12.000000000","tz":-360},"subject":"Use tmpdir and avoid leaving test files behind","message":"Use tmpdir and avoid leaving test files behind\n\n We were just creating a file for testing iscsi persist files and\n weren\u0027t cleaning up after the test.\n\n Change this to use a tmpdir and make sure we leave no tracks.\n\n Fixes bug #1050086\n\nChange-Id: I9b9a2400a172d52987d76f3132793cb042fd201c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/97bd198394ec68e01d1474ef16cd487371f222dc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/97bd198394ec68e01d1474ef16cd487371f222dc"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"81061b1b251a568697836a91d6e5dff08872cf3a","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"96f72f2cfd0afa6e60399dadd30bb83b0ab8ee0e":{"kind":"REWORK","_number":3,"created":"2012-09-12 23:35:52.000000000","uploader":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"ref":"refs/changes/10/12910/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder","ref":"refs/changes/10/12910/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder refs/changes/10/12910/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder refs/changes/10/12910/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder refs/changes/10/12910/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder refs/changes/10/12910/3"}}},"commit":{"parents":[{"commit":"81061b1b251a568697836a91d6e5dff08872cf3a","subject":"Merge \"Add volume quota in volume/api.py and olume/manager.py\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/81061b1b251a568697836a91d6e5dff08872cf3a"}]}],"author":{"name":"John Griffith","email":"john.griffith@solidfire.com","date":"2012-09-12 22:52:02.000000000","tz":-360},"committer":{"name":"John Griffith","email":"john.griffith@solidfire.com","date":"2012-09-12 23:35:44.000000000","tz":-360},"subject":"Use tmpdir and avoid leaving test files behind","message":"Use tmpdir and avoid leaving test files behind\n\n We were just creating a file for testing iscsi persist files and\n weren\u0027t cleaning up after the test.\n\n Change this to use a tmpdir and make sure we leave no tracks.\n\n Fixes bug #1050086\n\nChange-Id: I9b9a2400a172d52987d76f3132793cb042fd201c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/96f72f2cfd0afa6e60399dadd30bb83b0ab8ee0e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/96f72f2cfd0afa6e60399dadd30bb83b0ab8ee0e"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"81061b1b251a568697836a91d6e5dff08872cf3a","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}