)]}'
{"cinder/tests/test_context.py":[{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"95237c1032ab16419557dcc7893b0c643d5b4636","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        ctxt \u003d context.RequestContext(\u0027111\u0027,"},{"line_number":62,"context_line":"                                      \u0027222\u0027,)"},{"line_number":63,"context_line":"        ctxt \u003d ctxt.elevated()"},{"line_number":64,"context_line":"        mock_copy_deepcopy.assertCalled()"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def test_service_catalog_nova_and_swift(self):"},{"line_number":67,"context_line":"        service_catalog \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_06b4b533","line":64,"updated":"2014-11-20 20:09:40.000000000","message":"I don\u0027t think an instance of Mock has a method assertCalled which would be one reason why this test always passes.\nAn alternative would be:\nmock_copy_deepcopy.assert_called_once_with(ctxt)\nself.assertEqual(ctxt_elevated, mock_copy_deepcopy.return_value)","commit_id":"b4b0dbd9caa62317c62c39209fb21da98a14f921"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ba2917f042d8e6095730b0efc50b1cc5359d9b82","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        ctxt \u003d context.RequestContext(\u0027111\u0027,"},{"line_number":62,"context_line":"                                      \u0027222\u0027,)"},{"line_number":63,"context_line":"        ctxt \u003d ctxt.elevated()"},{"line_number":64,"context_line":"        mock_copy_deepcopy.assertCalled()"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def test_service_catalog_nova_and_swift(self):"},{"line_number":67,"context_line":"        service_catalog \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_6b6d4204","line":64,"updated":"2014-11-20 19:41:32.000000000","message":"This test does not verify leak of admin role to original context.\n\nAlso, if you revert back fix and try run this test it will success.\n\nSee same test for manila project: https://review.openstack.org/#/c/136102/1/manila/tests/test_context.py","commit_id":"b4b0dbd9caa62317c62c39209fb21da98a14f921"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"188c71cc6c389c0556cf28c29b01be3c9376c5c4","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        ctxt \u003d context.RequestContext(\u0027111\u0027,"},{"line_number":62,"context_line":"                                      \u0027222\u0027,)"},{"line_number":63,"context_line":"        ctxt \u003d ctxt.elevated()"},{"line_number":64,"context_line":"        mock_copy_deepcopy.assertCalled()"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def test_service_catalog_nova_and_swift(self):"},{"line_number":67,"context_line":"        service_catalog \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_723a92ce","line":64,"in_reply_to":"5a890539_6b6d4204","updated":"2014-11-20 22:11:11.000000000","message":"Valeriy,\n\nThank you for the information and pointer!\n\nI have created a similar test case.","commit_id":"b4b0dbd9caa62317c62c39209fb21da98a14f921"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"9cf9028b4f9151f92619be298eea6bbe9c36e8f5","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        admin_context \u003d user_context.elevated()"},{"line_number":64,"context_line":"        self.assertFalse(user_context.is_admin)"},{"line_number":65,"context_line":"        self.assertTrue(admin_context.is_admin)"},{"line_number":66,"context_line":"        self.assertFalse(\u0027admin\u0027 in user_context.roles)"},{"line_number":67,"context_line":"        self.assertTrue(\u0027admin\u0027 in admin_context.roles)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def test_service_catalog_nova_and_swift(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_72f8d27c","line":66,"updated":"2014-11-20 22:36:03.000000000","message":"This can also be written as:\nself.assertNotIn(\u0027admin\u0027, user_context.roles)","commit_id":"5ea8fc9b40e3f22d203fe5ff51ec55b812a05ef7"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"c5fdf1984f22ed63a493624c4c967a5e8a71d1bd","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        admin_context \u003d user_context.elevated()"},{"line_number":64,"context_line":"        self.assertFalse(user_context.is_admin)"},{"line_number":65,"context_line":"        self.assertTrue(admin_context.is_admin)"},{"line_number":66,"context_line":"        self.assertFalse(\u0027admin\u0027 in user_context.roles)"},{"line_number":67,"context_line":"        self.assertTrue(\u0027admin\u0027 in admin_context.roles)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def test_service_catalog_nova_and_swift(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_6371e2df","line":66,"in_reply_to":"5a890539_72f8d27c","updated":"2014-11-21 00:13:40.000000000","message":"I am going to leave these as is to be consistent with the test case in manila.","commit_id":"5ea8fc9b40e3f22d203fe5ff51ec55b812a05ef7"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"9cf9028b4f9151f92619be298eea6bbe9c36e8f5","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.assertFalse(user_context.is_admin)"},{"line_number":65,"context_line":"        self.assertTrue(admin_context.is_admin)"},{"line_number":66,"context_line":"        self.assertFalse(\u0027admin\u0027 in user_context.roles)"},{"line_number":67,"context_line":"        self.assertTrue(\u0027admin\u0027 in admin_context.roles)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def test_service_catalog_nova_and_swift(self):"},{"line_number":70,"context_line":"        service_catalog \u003d ["}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_32364a53","line":67,"updated":"2014-11-20 22:36:03.000000000","message":"This can also be written as:\nself.assertIn(\u0027admin\u0027, admin_context.roles)","commit_id":"5ea8fc9b40e3f22d203fe5ff51ec55b812a05ef7"}]}