)]}'
{"cinder/brick/local_dev/lvm.py":[{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"070d990047851a9d320c9a1d6b2f6799ed131bc1","unresolved":false,"context_lines":[{"line_number":265,"context_line":"                    ctx.reraise \u003d False"},{"line_number":266,"context_line":"                    msg \u003d _LI(\"\u0027Not found\u0027 when querying LVM info. \""},{"line_number":267,"context_line":"                              \"(vg_name\u003d%(vg)s, lv_name\u003d%(lv)s\")"},{"line_number":268,"context_line":"                    LOG.info(msg % {\u0027vg\u0027: vg_name, \u0027lv\u0027: lv_name})"},{"line_number":269,"context_line":"                    out \u003d \"\""},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        total_time \u003d time.time() - lvs_start"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_25cfb02a","line":268,"updated":"2014-11-23 09:51:05.000000000","message":"Use \u0027,\u0027 instead of \u0027%\u0027\nhttp://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages","commit_id":"38415643ac2db49fa90ffe499762be9483344fcb"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"31f0419785dd660f740b54be3a58ad59cc154d88","unresolved":false,"context_lines":[{"line_number":265,"context_line":"                    ctx.reraise \u003d False"},{"line_number":266,"context_line":"                    msg \u003d _LI(\"\u0027Not found\u0027 when querying LVM info. \""},{"line_number":267,"context_line":"                              \"(vg_name\u003d%(vg)s, lv_name\u003d%(lv)s\")"},{"line_number":268,"context_line":"                    LOG.info(msg % {\u0027vg\u0027: vg_name, \u0027lv\u0027: lv_name})"},{"line_number":269,"context_line":"                    out \u003d \"\""},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        total_time \u003d time.time() - lvs_start"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_2304d048","line":268,"in_reply_to":"5a890539_25cfb02a","updated":"2014-11-25 13:58:31.000000000","message":"Done","commit_id":"38415643ac2db49fa90ffe499762be9483344fcb"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"f30c2bd522734ada82d08b59496ba6a155dec7aa","unresolved":false,"context_lines":[{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        total_time \u003d time.time() - lvs_start"},{"line_number":272,"context_line":"        if total_time \u003e 60:"},{"line_number":273,"context_line":"            LOG.warning(_LW(\u0027Took %s seconds to get logical volumes.\u0027),"},{"line_number":274,"context_line":"                        total_time)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"        lv_list \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_f771dd0c","line":273,"updated":"2014-11-23 17:16:46.000000000","message":"one volume? \"Took %s seconds to get logical volume info.\"","commit_id":"38415643ac2db49fa90ffe499762be9483344fcb"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"31f0419785dd660f740b54be3a58ad59cc154d88","unresolved":false,"context_lines":[{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        total_time \u003d time.time() - lvs_start"},{"line_number":272,"context_line":"        if total_time \u003e 60:"},{"line_number":273,"context_line":"            LOG.warning(_LW(\u0027Took %s seconds to get logical volumes.\u0027),"},{"line_number":274,"context_line":"                        total_time)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"        lv_list \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_a6844e5e","line":273,"in_reply_to":"5a890539_f771dd0c","updated":"2014-11-25 13:58:31.000000000","message":"Done","commit_id":"38415643ac2db49fa90ffe499762be9483344fcb"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"d3e7809817ee2e97a99c4036bcd9e4b5e44a5e9c","unresolved":false,"context_lines":[{"line_number":274,"context_line":"                        total_time)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"        lv_list \u003d []"},{"line_number":277,"context_line":"        if out is not None:"},{"line_number":278,"context_line":"            volumes \u003d out.split()"},{"line_number":279,"context_line":"            for vg, name, size in itertools.izip(*[iter(volumes)] * 3):"},{"line_number":280,"context_line":"                lv_list.append({\"vg\": vg, \"name\": name, \"size\": size})"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_dab7abd6","line":277,"updated":"2014-11-23 04:05:38.000000000","message":"If exception is caught and \"not found\" in error, out \u003d \"\" and it will enter this if block.  Is this what you wanted?  Maybe change to \"if out\" so it won\u0027t enter the if block?","commit_id":"38415643ac2db49fa90ffe499762be9483344fcb"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"31f0419785dd660f740b54be3a58ad59cc154d88","unresolved":false,"context_lines":[{"line_number":274,"context_line":"                        total_time)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"        lv_list \u003d []"},{"line_number":277,"context_line":"        if out is not None:"},{"line_number":278,"context_line":"            volumes \u003d out.split()"},{"line_number":279,"context_line":"            for vg, name, size in itertools.izip(*[iter(volumes)] * 3):"},{"line_number":280,"context_line":"                lv_list.append({\"vg\": vg, \"name\": name, \"size\": size})"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_c336ac02","line":277,"in_reply_to":"5a890539_3767e54e","updated":"2014-11-25 13:58:31.000000000","message":"We want to return an empty lv_list when the not found case occurs.","commit_id":"38415643ac2db49fa90ffe499762be9483344fcb"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"070d990047851a9d320c9a1d6b2f6799ed131bc1","unresolved":false,"context_lines":[{"line_number":274,"context_line":"                        total_time)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"        lv_list \u003d []"},{"line_number":277,"context_line":"        if out is not None:"},{"line_number":278,"context_line":"            volumes \u003d out.split()"},{"line_number":279,"context_line":"            for vg, name, size in itertools.izip(*[iter(volumes)] * 3):"},{"line_number":280,"context_line":"                lv_list.append({\"vg\": vg, \"name\": name, \"size\": size})"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_e532080f","line":277,"in_reply_to":"5a890539_dab7abd6","updated":"2014-11-23 09:51:05.000000000","message":"I don\u0027t think it makes any difference, well except for executing a couple of extra lines of code. If out \u003d\u003d \u0027\u0027 then volumes \u003d\u003d [] which means nothing gets appended to lv_list.\n\nMaybe out should be set to None instead?","commit_id":"38415643ac2db49fa90ffe499762be9483344fcb"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"31f0419785dd660f740b54be3a58ad59cc154d88","unresolved":false,"context_lines":[{"line_number":274,"context_line":"                        total_time)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"        lv_list \u003d []"},{"line_number":277,"context_line":"        if out is not None:"},{"line_number":278,"context_line":"            volumes \u003d out.split()"},{"line_number":279,"context_line":"            for vg, name, size in itertools.izip(*[iter(volumes)] * 3):"},{"line_number":280,"context_line":"                lv_list.append({\"vg\": vg, \"name\": name, \"size\": size})"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_23605000","line":277,"in_reply_to":"5a890539_e532080f","updated":"2014-11-25 13:58:31.000000000","message":"Done","commit_id":"38415643ac2db49fa90ffe499762be9483344fcb"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"f30c2bd522734ada82d08b59496ba6a155dec7aa","unresolved":false,"context_lines":[{"line_number":274,"context_line":"                        total_time)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"        lv_list \u003d []"},{"line_number":277,"context_line":"        if out is not None:"},{"line_number":278,"context_line":"            volumes \u003d out.split()"},{"line_number":279,"context_line":"            for vg, name, size in itertools.izip(*[iter(volumes)] * 3):"},{"line_number":280,"context_line":"                lv_list.append({\"vg\": vg, \"name\": name, \"size\": size})"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_3767e54e","line":277,"in_reply_to":"5a890539_e532080f","updated":"2014-11-23 17:16:46.000000000","message":"so we can return empty lv_list  [] while exception caught?","commit_id":"38415643ac2db49fa90ffe499762be9483344fcb"}],"cinder/tests/brick/test_brick_lvm.py":[{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"070d990047851a9d320c9a1d6b2f6799ed131bc1","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        self.assertEqual(self.vg.get_volume(\u0027fake-unknown\u0027), None)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def test_get_lv_info_notfound(self):"},{"line_number":163,"context_line":"        self.assertEqual("},{"line_number":164,"context_line":"            self.vg.get_lv_info("},{"line_number":165,"context_line":"                \u0027sudo\u0027, vg_name\u003d\u0027fake-vg\u0027, lv_name\u003d\u0027lv-nothere\u0027),"},{"line_number":166,"context_line":"            []"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_c017ba43","line":163,"updated":"2014-11-23 09:51:05.000000000","message":"I believe the correct order is self.assertEqual(expected, observed) - although the codebase isn\u0027t exactly consistent on this.","commit_id":"38415643ac2db49fa90ffe499762be9483344fcb"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"f30c2bd522734ada82d08b59496ba6a155dec7aa","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        self.assertEqual(self.vg.get_volume(\u0027fake-unknown\u0027), None)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def test_get_lv_info_notfound(self):"},{"line_number":163,"context_line":"        self.assertEqual("},{"line_number":164,"context_line":"            self.vg.get_lv_info("},{"line_number":165,"context_line":"                \u0027sudo\u0027, vg_name\u003d\u0027fake-vg\u0027, lv_name\u003d\u0027lv-nothere\u0027),"},{"line_number":166,"context_line":"            []"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_d774e1ff","line":163,"in_reply_to":"5a890539_c017ba43","updated":"2014-11-23 17:16:46.000000000","message":"agree with git-harry +1","commit_id":"38415643ac2db49fa90ffe499762be9483344fcb"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"31f0419785dd660f740b54be3a58ad59cc154d88","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        self.assertEqual(self.vg.get_volume(\u0027fake-unknown\u0027), None)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def test_get_lv_info_notfound(self):"},{"line_number":163,"context_line":"        self.assertEqual("},{"line_number":164,"context_line":"            self.vg.get_lv_info("},{"line_number":165,"context_line":"                \u0027sudo\u0027, vg_name\u003d\u0027fake-vg\u0027, lv_name\u003d\u0027lv-nothere\u0027),"},{"line_number":166,"context_line":"            []"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_c365cc45","line":163,"in_reply_to":"5a890539_d774e1ff","updated":"2014-11-25 13:58:31.000000000","message":"I can\u0027t find any rule that actually says this is the case.  Python just calls them \"first\" and \"second\".  Would rather not make this one inconsistent with all of the other tests in this file.\n\nhttps://docs.python.org/2/library/unittest.html#unittest.TestCase.assertEqual\n\nhttps://docs.python.org/3/library/unittest.html#unittest.TestCase.assertEqual","commit_id":"38415643ac2db49fa90ffe499762be9483344fcb"}]}