)]}'
{"cinder/tests/test_vmware_datastore.py":[{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"bd3edde451687123b693c42c8192ebc27258d652","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import mock"},{"line_number":21,"context_line":"from oslo.vmware import exceptions"},{"line_number":22,"context_line":"from oslo_utils import units"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from cinder import test"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa81d914_9c19c08a","line":21,"updated":"2015-01-29 21:42:34.000000000","message":"Should this be \"oslo_vmware\"?","commit_id":"bfe238cc97f4d3fada498b7623a2bf573df5da94"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"829f89a0904a0af0bcd56baa55bd2dae05f2ca08","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import mock"},{"line_number":21,"context_line":"from oslo.vmware import exceptions"},{"line_number":22,"context_line":"from oslo_utils import units"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from cinder import test"}],"source_content_type":"text/x-python","patch_set":15,"id":"da86d52c_0e619dd2","line":21,"in_reply_to":"da86d52c_173d40c4","updated":"2015-02-06 10:12:39.000000000","message":"Done","commit_id":"bfe238cc97f4d3fada498b7623a2bf573df5da94"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"0c94e4ed78bd3a84673ba27fe75bed1ee72681ae","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import mock"},{"line_number":21,"context_line":"from oslo.vmware import exceptions"},{"line_number":22,"context_line":"from oslo_utils import units"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from cinder import test"}],"source_content_type":"text/x-python","patch_set":15,"id":"da86d52c_173d40c4","line":21,"in_reply_to":"fa81d914_9c19c08a","updated":"2015-02-06 01:46:37.000000000","message":"Yes, it looks like that library has changed its namespace as well.","commit_id":"bfe238cc97f4d3fada498b7623a2bf573df5da94"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"0c94e4ed78bd3a84673ba27fe75bed1ee72681ae","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        self._vops \u003d mock.Mock()"},{"line_number":36,"context_line":"        self._ds_sel \u003d ds_sel.DatastoreSelector(self._vops, self._session)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @mock.patch(\u0027oslo.vmware.pbm.get_profile_id_by_name\u0027)"},{"line_number":39,"context_line":"    def test_get_profile_id(self, get_profile_id_by_name):"},{"line_number":40,"context_line":"        profile_id \u003d mock.sentinel.profile_id"},{"line_number":41,"context_line":"        get_profile_id_by_name.return_value \u003d profile_id"}],"source_content_type":"text/x-python","patch_set":15,"id":"da86d52c_17446048","line":38,"updated":"2015-02-06 01:46:37.000000000","message":"oslo_vmware ... looks like you have that may places.  Won\u0027t comment on all of them.","commit_id":"bfe238cc97f4d3fada498b7623a2bf573df5da94"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"829f89a0904a0af0bcd56baa55bd2dae05f2ca08","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        self._vops \u003d mock.Mock()"},{"line_number":36,"context_line":"        self._ds_sel \u003d ds_sel.DatastoreSelector(self._vops, self._session)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @mock.patch(\u0027oslo.vmware.pbm.get_profile_id_by_name\u0027)"},{"line_number":39,"context_line":"    def test_get_profile_id(self, get_profile_id_by_name):"},{"line_number":40,"context_line":"        profile_id \u003d mock.sentinel.profile_id"},{"line_number":41,"context_line":"        get_profile_id_by_name.return_value \u003d profile_id"}],"source_content_type":"text/x-python","patch_set":15,"id":"da86d52c_4e9e35ba","line":38,"in_reply_to":"da86d52c_17446048","updated":"2015-02-06 10:12:39.000000000","message":"Done","commit_id":"bfe238cc97f4d3fada498b7623a2bf573df5da94"}],"cinder/tests/test_vmware_vmdk.py":[{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"bd3edde451687123b693c42c8192ebc27258d652","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import mock"},{"line_number":23,"context_line":"import mox"},{"line_number":24,"context_line":"from oslo.vmware import api"},{"line_number":25,"context_line":"from oslo.vmware import exceptions"},{"line_number":26,"context_line":"from oslo.vmware import image_transfer"},{"line_number":27,"context_line":"from oslo_utils import units"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa81d914_dc133864","line":24,"updated":"2015-01-29 21:42:34.000000000","message":"Ditto - \"oslo_vmware\"","commit_id":"bfe238cc97f4d3fada498b7623a2bf573df5da94"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"829f89a0904a0af0bcd56baa55bd2dae05f2ca08","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import mock"},{"line_number":23,"context_line":"import mox"},{"line_number":24,"context_line":"from oslo.vmware import api"},{"line_number":25,"context_line":"from oslo.vmware import exceptions"},{"line_number":26,"context_line":"from oslo.vmware import image_transfer"},{"line_number":27,"context_line":"from oslo_utils import units"}],"source_content_type":"text/x-python","patch_set":15,"id":"da86d52c_8e7bcd79","line":24,"in_reply_to":"fa81d914_dc133864","updated":"2015-02-06 10:12:39.000000000","message":"Done","commit_id":"bfe238cc97f4d3fada498b7623a2bf573df5da94"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"0c94e4ed78bd3a84673ba27fe75bed1ee72681ae","unresolved":false,"context_lines":[{"line_number":1872,"context_line":"        self.assertEqual(session_obj, self._driver.volumeops._session)"},{"line_number":1873,"context_line":"        self.assertEqual(session_obj, self._driver.ds_sel._session)"},{"line_number":1874,"context_line":""},{"line_number":1875,"context_line":"    @mock.patch(\u0027oslo.vmware.pbm.get_pbm_wsdl_location\u0027)"},{"line_number":1876,"context_line":"    @mock.patch(\u0027cinder.volume.drivers.vmware.vmdk.VMwareVcVmdkDriver.\u0027"},{"line_number":1877,"context_line":"                \u0027_get_vc_version\u0027)"},{"line_number":1878,"context_line":"    def test_do_setup_with_invalid_pbm_wsdl(self, get_vc_version,"}],"source_content_type":"text/x-python","patch_set":15,"id":"da86d52c_576178d1","line":1875,"updated":"2015-02-06 01:46:37.000000000","message":"oslo_vmware","commit_id":"bfe238cc97f4d3fada498b7623a2bf573df5da94"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"829f89a0904a0af0bcd56baa55bd2dae05f2ca08","unresolved":false,"context_lines":[{"line_number":1872,"context_line":"        self.assertEqual(session_obj, self._driver.volumeops._session)"},{"line_number":1873,"context_line":"        self.assertEqual(session_obj, self._driver.ds_sel._session)"},{"line_number":1874,"context_line":""},{"line_number":1875,"context_line":"    @mock.patch(\u0027oslo.vmware.pbm.get_pbm_wsdl_location\u0027)"},{"line_number":1876,"context_line":"    @mock.patch(\u0027cinder.volume.drivers.vmware.vmdk.VMwareVcVmdkDriver.\u0027"},{"line_number":1877,"context_line":"                \u0027_get_vc_version\u0027)"},{"line_number":1878,"context_line":"    def test_do_setup_with_invalid_pbm_wsdl(self, get_vc_version,"}],"source_content_type":"text/x-python","patch_set":15,"id":"da86d52c_0e8fdd75","line":1875,"in_reply_to":"da86d52c_576178d1","updated":"2015-02-06 10:12:39.000000000","message":"Done","commit_id":"bfe238cc97f4d3fada498b7623a2bf573df5da94"}],"cinder/tests/test_vmware_volumeops.py":[{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"bd3edde451687123b693c42c8192ebc27258d652","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import mock"},{"line_number":21,"context_line":"from oslo.vmware import exceptions"},{"line_number":22,"context_line":"from oslo.vmware import vim_util"},{"line_number":23,"context_line":"from oslo_utils import units"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"fa81d914_7c024c0c","line":21,"updated":"2015-01-29 21:42:34.000000000","message":"Ditto - \"oslo_vmware\"","commit_id":"bfe238cc97f4d3fada498b7623a2bf573df5da94"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"829f89a0904a0af0bcd56baa55bd2dae05f2ca08","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import mock"},{"line_number":21,"context_line":"from oslo.vmware import exceptions"},{"line_number":22,"context_line":"from oslo.vmware import vim_util"},{"line_number":23,"context_line":"from oslo_utils import units"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"da86d52c_cedf8567","line":21,"in_reply_to":"fa81d914_7c024c0c","updated":"2015-02-06 10:12:39.000000000","message":"Done","commit_id":"bfe238cc97f4d3fada498b7623a2bf573df5da94"}],"cinder/volume/drivers/vmware/datastore.py":[{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"bd3edde451687123b693c42c8192ebc27258d652","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Classes and utility methods for datastore selection."},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo.vmware import exceptions"},{"line_number":21,"context_line":"from oslo.vmware import pbm"},{"line_number":22,"context_line":"from oslo_utils import excutils"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"fa81d914_f70d7538","line":20,"updated":"2015-01-29 21:42:34.000000000","message":"Ditto - \"oslo_vmware\"","commit_id":"bfe238cc97f4d3fada498b7623a2bf573df5da94"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"829f89a0904a0af0bcd56baa55bd2dae05f2ca08","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Classes and utility methods for datastore selection."},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo.vmware import exceptions"},{"line_number":21,"context_line":"from oslo.vmware import pbm"},{"line_number":22,"context_line":"from oslo_utils import excutils"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"da86d52c_2ee1012a","line":20,"in_reply_to":"fa81d914_f70d7538","updated":"2015-02-06 10:12:39.000000000","message":"Done","commit_id":"bfe238cc97f4d3fada498b7623a2bf573df5da94"}],"cinder/volume/drivers/vmware/exceptions.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"573d6e6f8cb6a4983faa4bf932d02736d6e3e5cc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014 VMware, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a930d6b_0a39f340","line":1,"updated":"2015-01-23 21:55:59.000000000","message":"2015","commit_id":"8d5cd8625d29390fe661aeed1aa9ab32d8df2b28"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"dc84d2db8751bd2a94d6d98e5471d444cfdca3cd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014 VMware, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a930d6b_eec2a8e7","line":1,"in_reply_to":"1a930d6b_0a39f340","updated":"2015-01-27 12:15:37.000000000","message":"Done\n\nNot sure about this because this code was first uploaded in 2014.","commit_id":"8d5cd8625d29390fe661aeed1aa9ab32d8df2b28"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"bd3edde451687123b693c42c8192ebc27258d652","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Exception definitions."},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo.vmware import exceptions"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from cinder.i18n import _"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"fa81d914_173be9d1","line":20,"updated":"2015-01-29 21:42:34.000000000","message":"Ditto - \"oslo_vmware\"","commit_id":"bfe238cc97f4d3fada498b7623a2bf573df5da94"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"829f89a0904a0af0bcd56baa55bd2dae05f2ca08","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Exception definitions."},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo.vmware import exceptions"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from cinder.i18n import _"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"da86d52c_aecc11bc","line":20,"in_reply_to":"fa81d914_173be9d1","updated":"2015-02-06 10:12:39.000000000","message":"Done","commit_id":"bfe238cc97f4d3fada498b7623a2bf573df5da94"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"bd3edde451687123b693c42c8192ebc27258d652","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo.vmware import exceptions"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from cinder.i18n import _"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class InvalidAdapterTypeException(exceptions.VMwareDriverException):"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa81d914_d72151a0","line":22,"updated":"2015-01-29 21:42:34.000000000","message":"Should this be using oslo_i18n?","commit_id":"bfe238cc97f4d3fada498b7623a2bf573df5da94"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"0c94e4ed78bd3a84673ba27fe75bed1ee72681ae","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo.vmware import exceptions"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from cinder.i18n import _"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class InvalidAdapterTypeException(exceptions.VMwareDriverException):"}],"source_content_type":"text/x-python","patch_set":15,"id":"da86d52c_b788f471","line":22,"in_reply_to":"fa81d914_d72151a0","updated":"2015-02-06 01:46:37.000000000","message":"This is correct.","commit_id":"bfe238cc97f4d3fada498b7623a2bf573df5da94"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"17bd0e79c28fe8ec6b8619a31ec7d183c20ef6f6","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo.vmware import exceptions"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from cinder.i18n import _"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class InvalidAdapterTypeException(exceptions.VMwareDriverException):"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa81d914_23becfb4","line":22,"in_reply_to":"fa81d914_d72151a0","updated":"2015-01-30 16:57:48.000000000","message":"We are still using cinder.i18n in rest of cinder.","commit_id":"bfe238cc97f4d3fada498b7623a2bf573df5da94"}],"cinder/volume/drivers/vmware/vmdk.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"e2bb64c2b6d77c3eca6c2e32e11fcc8113b0eed8","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from oslo.config import cfg"},{"line_number":31,"context_line":"from oslo.utils import excutils"},{"line_number":32,"context_line":"from oslo.utils import units"},{"line_number":33,"context_line":"from oslo.vmware import api"},{"line_number":34,"context_line":"from oslo.vmware import exceptions"},{"line_number":35,"context_line":"from oslo.vmware import image_transfer"},{"line_number":36,"context_line":"from oslo.vmware import pbm"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_a68a85b9","line":33,"updated":"2015-01-16 16:00:39.000000000","message":"Please, use oslo_vmware over the all code","commit_id":"16f0b2bebc0404bf0c554738bbfcd4371571f341"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"8be42e0f337a10bfe58fd79b36adcc0fb8618142","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from oslo.config import cfg"},{"line_number":31,"context_line":"from oslo.utils import excutils"},{"line_number":32,"context_line":"from oslo.utils import units"},{"line_number":33,"context_line":"from oslo.vmware import api"},{"line_number":34,"context_line":"from oslo.vmware import exceptions"},{"line_number":35,"context_line":"from oslo.vmware import image_transfer"},{"line_number":36,"context_line":"from oslo.vmware import pbm"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a930d6b_8ad6c3ef","line":33,"in_reply_to":"3a961159_8ab54334","updated":"2015-01-23 21:46:37.000000000","message":"I new oslo.vmware is not released, i won\u0027t block this patch. we\u0027ll be able to change it once new oslo.vmware will be released","commit_id":"16f0b2bebc0404bf0c554738bbfcd4371571f341"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"e4474a471333bb24185aa7a300c151fab24b23e9","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from oslo.config import cfg"},{"line_number":31,"context_line":"from oslo.utils import excutils"},{"line_number":32,"context_line":"from oslo.utils import units"},{"line_number":33,"context_line":"from oslo.vmware import api"},{"line_number":34,"context_line":"from oslo.vmware import exceptions"},{"line_number":35,"context_line":"from oslo.vmware import image_transfer"},{"line_number":36,"context_line":"from oslo.vmware import pbm"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_8ab54334","line":33,"in_reply_to":"3a961159_a68a85b9","updated":"2015-01-20 10:11:11.000000000","message":"Hi Ivan,\nAs mentioned by Gary, we will have to wait for a new version of oslo.vmware. We can do the namespace change once it is available. I don\u0027t want to hold this patch for long as there are many dependencies.\n\nThanks.","commit_id":"16f0b2bebc0404bf0c554738bbfcd4371571f341"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0961914e8c55eb40d879af86e19754ecd3aeea40","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from oslo.config import cfg"},{"line_number":31,"context_line":"from oslo.utils import excutils"},{"line_number":32,"context_line":"from oslo.utils import units"},{"line_number":33,"context_line":"from oslo.vmware import api"},{"line_number":34,"context_line":"from oslo.vmware import exceptions"},{"line_number":35,"context_line":"from oslo.vmware import image_transfer"},{"line_number":36,"context_line":"from oslo.vmware import pbm"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_2414b43f","line":33,"in_reply_to":"3a961159_a68a85b9","updated":"2015-01-18 12:47:50.000000000","message":"we are unable to do this at the moment. the reason for this is that the patch has only landed in oslo and there is no version that has been tagged with the format oslo_vmware.\n\nthere are two options:\n1. update as you have suggested - this may take a while as it will be blocked by things out of our control\n2. continue with this patch and the refactor when the oslo_vmware support has landed\n\nI am in favor of #2","commit_id":"16f0b2bebc0404bf0c554738bbfcd4371571f341"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"573d6e6f8cb6a4983faa4bf932d02736d6e3e5cc","unresolved":false,"context_lines":[{"line_number":588,"context_line":"                except exceptions.VimException as excep:"},{"line_number":589,"context_line":"                    LOG.warn(_LW(\"Unable to find suitable datastore for volume\""},{"line_number":590,"context_line":"                                 \" of size: %(vol)s GB under host: %(host)s. \""},{"line_number":591,"context_line":"                                 \"More details: %(excep)s\") %"},{"line_number":592,"context_line":"                             {\u0027vol\u0027: volume[\u0027size\u0027],"},{"line_number":593,"context_line":"                              \u0027host\u0027: host, \u0027excep\u0027: excep})"},{"line_number":594,"context_line":"            if selected_host:"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a930d6b_6a1ef7bc","line":591,"updated":"2015-01-23 21:55:59.000000000","message":"Once you\u0027re here, please, change % \u003d\u003e ,","commit_id":"8d5cd8625d29390fe661aeed1aa9ab32d8df2b28"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"dc84d2db8751bd2a94d6d98e5471d444cfdca3cd","unresolved":false,"context_lines":[{"line_number":588,"context_line":"                except exceptions.VimException as excep:"},{"line_number":589,"context_line":"                    LOG.warn(_LW(\"Unable to find suitable datastore for volume\""},{"line_number":590,"context_line":"                                 \" of size: %(vol)s GB under host: %(host)s. \""},{"line_number":591,"context_line":"                                 \"More details: %(excep)s\") %"},{"line_number":592,"context_line":"                             {\u0027vol\u0027: volume[\u0027size\u0027],"},{"line_number":593,"context_line":"                              \u0027host\u0027: host, \u0027excep\u0027: excep})"},{"line_number":594,"context_line":"            if selected_host:"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a930d6b_6e75d8c9","line":591,"in_reply_to":"1a930d6b_6a1ef7bc","updated":"2015-01-27 12:15:37.000000000","message":"There are many places where we need to make this change. See https://review.openstack.org/#/c/150388/","commit_id":"8d5cd8625d29390fe661aeed1aa9ab32d8df2b28"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"573d6e6f8cb6a4983faa4bf932d02736d6e3e5cc","unresolved":false,"context_lines":[{"line_number":1224,"context_line":"                              excep)"},{"line_number":1225,"context_line":"                backing \u003d self.volumeops.get_backing(volume[\u0027name\u0027])"},{"line_number":1226,"context_line":"                if backing:"},{"line_number":1227,"context_line":"                    LOG.exception(_LE(\"Deleting the backing: %s\") % backing)"},{"line_number":1228,"context_line":"                    # delete the backing"},{"line_number":1229,"context_line":"                    self.volumeops.delete_backing(backing)"},{"line_number":1230,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"1a930d6b_8a72430f","line":1227,"updated":"2015-01-23 21:55:59.000000000","message":"% \u003d\u003e ,","commit_id":"8d5cd8625d29390fe661aeed1aa9ab32d8df2b28"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"573d6e6f8cb6a4983faa4bf932d02736d6e3e5cc","unresolved":false,"context_lines":[{"line_number":1228,"context_line":"                    # delete the backing"},{"line_number":1229,"context_line":"                    self.volumeops.delete_backing(backing)"},{"line_number":1230,"context_line":""},{"line_number":1231,"context_line":"        LOG.info(_LI(\"Done copying image: %(id)s to volume: %(vol)s.\") %"},{"line_number":1232,"context_line":"                 {\u0027id\u0027: image_id, \u0027vol\u0027: volume[\u0027name\u0027]})"},{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"    def _extend_vmdk_virtual_disk(self, name, new_size_in_gb):"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a930d6b_ea58278c","line":1231,"updated":"2015-01-23 21:55:59.000000000","message":"% \u003d\u003e ,","commit_id":"8d5cd8625d29390fe661aeed1aa9ab32d8df2b28"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"573d6e6f8cb6a4983faa4bf932d02736d6e3e5cc","unresolved":false,"context_lines":[{"line_number":1881,"context_line":"        else:"},{"line_number":1882,"context_line":"            version_str \u003d vim_util.get_vc_version(self.session)"},{"line_number":1883,"context_line":"            LOG.info(_LI(\"Fetched VC server version: %s\"), version_str)"},{"line_number":1884,"context_line":"        # convert version_str to LooseVersion and return"},{"line_number":1885,"context_line":"        version \u003d None"},{"line_number":1886,"context_line":"        try:"},{"line_number":1887,"context_line":"            version \u003d str(dist_version.LooseVersion(version_str))"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a930d6b_0aa3b34f","line":1884,"updated":"2015-01-23 21:55:59.000000000","message":"c \u003d\u003e C","commit_id":"8d5cd8625d29390fe661aeed1aa9ab32d8df2b28"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"dc84d2db8751bd2a94d6d98e5471d444cfdca3cd","unresolved":false,"context_lines":[{"line_number":1881,"context_line":"        else:"},{"line_number":1882,"context_line":"            version_str \u003d vim_util.get_vc_version(self.session)"},{"line_number":1883,"context_line":"            LOG.info(_LI(\"Fetched VC server version: %s\"), version_str)"},{"line_number":1884,"context_line":"        # convert version_str to LooseVersion and return"},{"line_number":1885,"context_line":"        version \u003d None"},{"line_number":1886,"context_line":"        try:"},{"line_number":1887,"context_line":"            version \u003d str(dist_version.LooseVersion(version_str))"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a930d6b_ee50e833","line":1884,"in_reply_to":"1a930d6b_0aa3b34f","updated":"2015-01-27 12:15:37.000000000","message":"Done","commit_id":"8d5cd8625d29390fe661aeed1aa9ab32d8df2b28"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"573d6e6f8cb6a4983faa4bf932d02736d6e3e5cc","unresolved":false,"context_lines":[{"line_number":1884,"context_line":"        # convert version_str to LooseVersion and return"},{"line_number":1885,"context_line":"        version \u003d None"},{"line_number":1886,"context_line":"        try:"},{"line_number":1887,"context_line":"            version \u003d str(dist_version.LooseVersion(version_str))"},{"line_number":1888,"context_line":"        except Exception:"},{"line_number":1889,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1890,"context_line":"                LOG.exception(_LE(\"Version string \u0027%s\u0027 is not parseable\"),"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a930d6b_eacf4727","line":1887,"updated":"2015-01-23 21:55:59.000000000","message":"Please, use six.text_type","commit_id":"8d5cd8625d29390fe661aeed1aa9ab32d8df2b28"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"dc84d2db8751bd2a94d6d98e5471d444cfdca3cd","unresolved":false,"context_lines":[{"line_number":1884,"context_line":"        # convert version_str to LooseVersion and return"},{"line_number":1885,"context_line":"        version \u003d None"},{"line_number":1886,"context_line":"        try:"},{"line_number":1887,"context_line":"            version \u003d str(dist_version.LooseVersion(version_str))"},{"line_number":1888,"context_line":"        except Exception:"},{"line_number":1889,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1890,"context_line":"                LOG.exception(_LE(\"Version string \u0027%s\u0027 is not parseable\"),"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a930d6b_71c21986","line":1887,"in_reply_to":"1a930d6b_eacf4727","updated":"2015-01-27 12:15:37.000000000","message":"We just need to get the version string in LooseVersion which is returned by LooseVersion.__str__. But we can move this down to line 1902 to avoid unnecessary conversions, since the comparison (\u003e\u003d) in line 1901 will convert its __cmp__ argument to LooseVersion if it\u0027s a string.","commit_id":"8d5cd8625d29390fe661aeed1aa9ab32d8df2b28"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"bd3edde451687123b693c42c8192ebc27258d652","unresolved":false,"context_lines":[{"line_number":28,"context_line":"import tempfile"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from oslo.vmware import api"},{"line_number":31,"context_line":"from oslo.vmware import exceptions"},{"line_number":32,"context_line":"from oslo.vmware import image_transfer"},{"line_number":33,"context_line":"from oslo.vmware import pbm"},{"line_number":34,"context_line":"from oslo.vmware import vim_util"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa81d914_7730a5e8","line":31,"updated":"2015-01-29 21:42:34.000000000","message":"Ditto - \"oslo_vmware\"","commit_id":"bfe238cc97f4d3fada498b7623a2bf573df5da94"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"829f89a0904a0af0bcd56baa55bd2dae05f2ca08","unresolved":false,"context_lines":[{"line_number":28,"context_line":"import tempfile"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from oslo.vmware import api"},{"line_number":31,"context_line":"from oslo.vmware import exceptions"},{"line_number":32,"context_line":"from oslo.vmware import image_transfer"},{"line_number":33,"context_line":"from oslo.vmware import pbm"},{"line_number":34,"context_line":"from oslo.vmware import vim_util"}],"source_content_type":"text/x-python","patch_set":15,"id":"da86d52c_6e3db98e","line":31,"in_reply_to":"fa81d914_7730a5e8","updated":"2015-02-06 10:12:39.000000000","message":"Done","commit_id":"bfe238cc97f4d3fada498b7623a2bf573df5da94"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f20bf952b41afd320eebfef200c37204c6e23bb3","unresolved":false,"context_lines":[{"line_number":588,"context_line":"                except exceptions.VimException as excep:"},{"line_number":589,"context_line":"                    LOG.warn(_LW(\"Unable to find suitable datastore for volume\""},{"line_number":590,"context_line":"                                 \" of size: %(vol)s GB under host: %(host)s. \""},{"line_number":591,"context_line":"                                 \"More details: %(excep)s\") %"},{"line_number":592,"context_line":"                             {\u0027vol\u0027: volume[\u0027size\u0027],"},{"line_number":593,"context_line":"                              \u0027host\u0027: host, \u0027excep\u0027: excep})"},{"line_number":594,"context_line":"            if selected_host:"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a930d6b_51e0bd28","line":591,"updated":"2015-01-27 11:58:04.000000000","message":"Missed Ivan\u0027s request from last patchset. Please change the % to , .","commit_id":"bfe238cc97f4d3fada498b7623a2bf573df5da94"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"3684d9bda3489032b9a56928b41070d6b2f719ec","unresolved":false,"context_lines":[{"line_number":588,"context_line":"                except exceptions.VimException as excep:"},{"line_number":589,"context_line":"                    LOG.warn(_LW(\"Unable to find suitable datastore for volume\""},{"line_number":590,"context_line":"                                 \" of size: %(vol)s GB under host: %(host)s. \""},{"line_number":591,"context_line":"                                 \"More details: %(excep)s\") %"},{"line_number":592,"context_line":"                             {\u0027vol\u0027: volume[\u0027size\u0027],"},{"line_number":593,"context_line":"                              \u0027host\u0027: host, \u0027excep\u0027: excep})"},{"line_number":594,"context_line":"            if selected_host:"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a930d6b_e47ac986","line":591,"in_reply_to":"1a930d6b_51e0bd28","updated":"2015-01-27 12:25:24.000000000","message":"I wasn\u0027t expecting a quick review :)\n\nhttps://review.openstack.org/#/c/150388","commit_id":"bfe238cc97f4d3fada498b7623a2bf573df5da94"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f20bf952b41afd320eebfef200c37204c6e23bb3","unresolved":false,"context_lines":[{"line_number":1224,"context_line":"                              excep)"},{"line_number":1225,"context_line":"                backing \u003d self.volumeops.get_backing(volume[\u0027name\u0027])"},{"line_number":1226,"context_line":"                if backing:"},{"line_number":1227,"context_line":"                    LOG.exception(_LE(\"Deleting the backing: %s\") % backing)"},{"line_number":1228,"context_line":"                    # delete the backing"},{"line_number":1229,"context_line":"                    self.volumeops.delete_backing(backing)"},{"line_number":1230,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"1a930d6b_11cab5a0","line":1227,"updated":"2015-01-27 11:58:04.000000000","message":"Another miss.","commit_id":"bfe238cc97f4d3fada498b7623a2bf573df5da94"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f20bf952b41afd320eebfef200c37204c6e23bb3","unresolved":false,"context_lines":[{"line_number":1228,"context_line":"                    # delete the backing"},{"line_number":1229,"context_line":"                    self.volumeops.delete_backing(backing)"},{"line_number":1230,"context_line":""},{"line_number":1231,"context_line":"        LOG.info(_LI(\"Done copying image: %(id)s to volume: %(vol)s.\") %"},{"line_number":1232,"context_line":"                 {\u0027id\u0027: image_id, \u0027vol\u0027: volume[\u0027name\u0027]})"},{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"    def _extend_vmdk_virtual_disk(self, name, new_size_in_gb):"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a930d6b_51c7dd95","line":1231,"updated":"2015-01-27 11:58:04.000000000","message":"Another.","commit_id":"bfe238cc97f4d3fada498b7623a2bf573df5da94"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f20bf952b41afd320eebfef200c37204c6e23bb3","unresolved":false,"context_lines":[{"line_number":1899,"context_line":"        # Enable pbm only if VC version is greater than 5.5"},{"line_number":1900,"context_line":"        vc_version \u003d self._get_vc_version()"},{"line_number":1901,"context_line":"        if vc_version and vc_version \u003e\u003d self.PBM_ENABLED_VC_VERSION:"},{"line_number":1902,"context_line":"            self.pbm_wsdl \u003d pbm.get_pbm_wsdl_location(str(vc_version))"},{"line_number":1903,"context_line":"            if not self.pbm_wsdl:"},{"line_number":1904,"context_line":"                LOG.error(_LE(\"Not able to configure PBM for VC server: %s\"),"},{"line_number":1905,"context_line":"                          vc_version)"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a930d6b_f10b69d3","line":1902,"updated":"2015-01-27 11:58:04.000000000","message":"I believe you should be using six.text_type here.","commit_id":"bfe238cc97f4d3fada498b7623a2bf573df5da94"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"0c94e4ed78bd3a84673ba27fe75bed1ee72681ae","unresolved":false,"context_lines":[{"line_number":1899,"context_line":"        # Enable pbm only if VC version is greater than 5.5"},{"line_number":1900,"context_line":"        vc_version \u003d self._get_vc_version()"},{"line_number":1901,"context_line":"        if vc_version and vc_version \u003e\u003d self.PBM_ENABLED_VC_VERSION:"},{"line_number":1902,"context_line":"            self.pbm_wsdl \u003d pbm.get_pbm_wsdl_location(str(vc_version))"},{"line_number":1903,"context_line":"            if not self.pbm_wsdl:"},{"line_number":1904,"context_line":"                LOG.error(_LE(\"Not able to configure PBM for VC server: %s\"),"},{"line_number":1905,"context_line":"                          vc_version)"}],"source_content_type":"text/x-python","patch_set":15,"id":"da86d52c_b7d6344d","line":1902,"in_reply_to":"1a930d6b_a4eb61da","updated":"2015-02-06 01:46:37.000000000","message":"six.text_type should be used instead of using str().","commit_id":"bfe238cc97f4d3fada498b7623a2bf573df5da94"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"3684d9bda3489032b9a56928b41070d6b2f719ec","unresolved":false,"context_lines":[{"line_number":1899,"context_line":"        # Enable pbm only if VC version is greater than 5.5"},{"line_number":1900,"context_line":"        vc_version \u003d self._get_vc_version()"},{"line_number":1901,"context_line":"        if vc_version and vc_version \u003e\u003d self.PBM_ENABLED_VC_VERSION:"},{"line_number":1902,"context_line":"            self.pbm_wsdl \u003d pbm.get_pbm_wsdl_location(str(vc_version))"},{"line_number":1903,"context_line":"            if not self.pbm_wsdl:"},{"line_number":1904,"context_line":"                LOG.error(_LE(\"Not able to configure PBM for VC server: %s\"),"},{"line_number":1905,"context_line":"                          vc_version)"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a930d6b_a4eb61da","line":1902,"in_reply_to":"1a930d6b_f10b69d3","updated":"2015-01-27 12:25:24.000000000","message":"In line 1882, we get the vCenter version string (e.g. 5.5.0). Are you saying that we should call dist_version.LooseVersion(six.text_type(version_str)) in line 1887. Once we convert the the version string to a LooseVersion object in line 1887, will it matter whether we call LooseVersion.__str__()  or six.text_type(LooseVersion) here?","commit_id":"bfe238cc97f4d3fada498b7623a2bf573df5da94"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"829f89a0904a0af0bcd56baa55bd2dae05f2ca08","unresolved":false,"context_lines":[{"line_number":1899,"context_line":"        # Enable pbm only if VC version is greater than 5.5"},{"line_number":1900,"context_line":"        vc_version \u003d self._get_vc_version()"},{"line_number":1901,"context_line":"        if vc_version and vc_version \u003e\u003d self.PBM_ENABLED_VC_VERSION:"},{"line_number":1902,"context_line":"            self.pbm_wsdl \u003d pbm.get_pbm_wsdl_location(str(vc_version))"},{"line_number":1903,"context_line":"            if not self.pbm_wsdl:"},{"line_number":1904,"context_line":"                LOG.error(_LE(\"Not able to configure PBM for VC server: %s\"),"},{"line_number":1905,"context_line":"                          vc_version)"}],"source_content_type":"text/x-python","patch_set":15,"id":"da86d52c_2e4f4135","line":1902,"in_reply_to":"da86d52c_b7d6344d","updated":"2015-02-06 10:12:39.000000000","message":"Done","commit_id":"bfe238cc97f4d3fada498b7623a2bf573df5da94"}],"cinder/volume/drivers/vmware/volumeops.py":[{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"bd3edde451687123b693c42c8192ebc27258d652","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import urllib"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo.vmware import exceptions"},{"line_number":23,"context_line":"from oslo.vmware import vim_util"},{"line_number":24,"context_line":"from oslo_utils import units"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"fa81d914_b7513d10","line":22,"updated":"2015-01-29 21:42:34.000000000","message":"Ditto - \"oslo_vmware\"","commit_id":"bfe238cc97f4d3fada498b7623a2bf573df5da94"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"829f89a0904a0af0bcd56baa55bd2dae05f2ca08","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import urllib"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo.vmware import exceptions"},{"line_number":23,"context_line":"from oslo.vmware import vim_util"},{"line_number":24,"context_line":"from oslo_utils import units"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"da86d52c_ae5a51ef","line":22,"in_reply_to":"fa81d914_b7513d10","updated":"2015-02-06 10:12:39.000000000","message":"Done","commit_id":"bfe238cc97f4d3fada498b7623a2bf573df5da94"}],"requirements.txt":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"48985b7ae32a43e012a94016f1e83a35c24a0807","unresolved":false,"context_lines":[{"line_number":43,"context_line":"oslo.i18n\u003e\u003d1.0.0  # Apache-2.0"},{"line_number":44,"context_line":"oslo.vmware\u003e\u003d0.8.0                      # Apache-2.0"},{"line_number":45,"context_line":"xattr\u003e\u003d0.4"},{"line_number":46,"context_line":""}],"source_content_type":"text/plain","patch_set":6,"id":"3a961159_8ede140f","line":46,"updated":"2015-01-13 07:03:05.000000000","message":"do you need this change?","commit_id":"eeddf18bd8e6d15a07f32da601de161ceacb2da7"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"1189e10f1f61573ad6f3005f32958946b2550b1d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"oslo.i18n\u003e\u003d1.0.0  # Apache-2.0"},{"line_number":44,"context_line":"oslo.vmware\u003e\u003d0.8.0                      # Apache-2.0"},{"line_number":45,"context_line":"xattr\u003e\u003d0.4"},{"line_number":46,"context_line":""}],"source_content_type":"text/plain","patch_set":6,"id":"3a961159_e4adf733","line":46,"in_reply_to":"3a961159_8ede140f","updated":"2015-01-13 08:32:28.000000000","message":"Done","commit_id":"eeddf18bd8e6d15a07f32da601de161ceacb2da7"}]}