)]}'
{"cinder/scheduler/manager.py":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"9ae6688af6de2370752875584ec28d467c30d968","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                      filter_properties\u003dNone):"},{"line_number":77,"context_line":"        try:"},{"line_number":78,"context_line":"            self.driver.schedule_create_volume(context, request_spec,"},{"line_number":79,"context_line":"                                               filter_properties)"},{"line_number":80,"context_line":"        except exception.NoValidHost as ex:"},{"line_number":81,"context_line":"            volume_state \u003d {\u0027volume_state\u0027: {\u0027status\u0027: \u0027error\u0027}}"},{"line_number":82,"context_line":"            self._set_volume_state_and_notify(\u0027create_volume\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2F7LU%3D","line":79,"updated":"2012-10-26 19:44:44.000000000","message":"What happens if request_spec and filter_properties are not specified and you get the old arguments instead?  Can you update this to make it work in that case?","commit_id":"7eec8e108a23312ef132325a7723c031ef546806"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"96317d2bff09e5972ed98a427278d07ec8aa4224","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                      filter_properties\u003dNone):"},{"line_number":77,"context_line":"        try:"},{"line_number":78,"context_line":"            self.driver.schedule_create_volume(context, request_spec,"},{"line_number":79,"context_line":"                                               filter_properties)"},{"line_number":80,"context_line":"        except exception.NoValidHost as ex:"},{"line_number":81,"context_line":"            volume_state \u003d {\u0027volume_state\u0027: {\u0027status\u0027: \u0027error\u0027}}"},{"line_number":82,"context_line":"            self._set_volume_state_and_notify(\u0027create_volume\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2F63U%3D","line":79,"in_reply_to":"AAAALn%2F%2F7LU%3D","updated":"2012-10-30 00:45:30.000000000","message":"Done","commit_id":"7eec8e108a23312ef132325a7723c031ef546806"}],"cinder/scheduler/rpcapi.py":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"087165b664b28b99a2b3b8318dc6b0a05d71ff94","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        super(SchedulerAPI, self).__init__(topic\u003dFLAGS.scheduler_topic,"},{"line_number":41,"context_line":"                default_version\u003dself.RPC_API_VERSION)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def create_volume(self, ctxt, request_spec, filter_properties):"},{"line_number":44,"context_line":"        return self.cast(ctxt, self.make_msg(\u0027create_volume\u0027,"},{"line_number":45,"context_line":"                         request_spec\u003drequest_spec,"},{"line_number":46,"context_line":"                         filter_properties\u003dfilter_properties))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FJ3c%3D","line":43,"updated":"2012-10-10 19:03:02.000000000","message":"This is a non backwards compatible change to the rpc API, which should not happen within the 1.X API version.","commit_id":"9b886af419afeae4f8de6f015c9c69735112d21c"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"3b56a2795c26d7dcb5f27fe6db6e69a2b02edd47","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        super(SchedulerAPI, self).__init__(topic\u003dFLAGS.scheduler_topic,"},{"line_number":41,"context_line":"                default_version\u003dself.RPC_API_VERSION)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def create_volume(self, ctxt, request_spec, filter_properties):"},{"line_number":44,"context_line":"        return self.cast(ctxt, self.make_msg(\u0027create_volume\u0027,"},{"line_number":45,"context_line":"                         request_spec\u003drequest_spec,"},{"line_number":46,"context_line":"                         filter_properties\u003dfilter_properties))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FJds%3D","line":43,"in_reply_to":"AAAALH%2F%2FJ3c%3D","updated":"2012-10-11 08:21:22.000000000","message":"What if I made this change at the first place (merge this change to \"Add \u0027create_volume\u0027 to scheduler RPC API\")?","commit_id":"9b886af419afeae4f8de6f015c9c69735112d21c"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"5437af9d16ce0375514f981d4fb0142fb088448b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        super(SchedulerAPI, self).__init__(topic\u003dFLAGS.scheduler_topic,"},{"line_number":41,"context_line":"                default_version\u003dself.RPC_API_VERSION)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def create_volume(self, ctxt, request_spec, filter_properties):"},{"line_number":44,"context_line":"        return self.cast(ctxt, self.make_msg(\u0027create_volume\u0027,"},{"line_number":45,"context_line":"                         request_spec\u003drequest_spec,"},{"line_number":46,"context_line":"                         filter_properties\u003dfilter_properties))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FJZ8%3D","line":43,"in_reply_to":"AAAALH%2F%2FJds%3D","updated":"2012-10-11 13:28:07.000000000","message":"The 1.X API should really be only what is already in the code.  If a message were to come in from before create_volume() was versioned, it is going to be treated as requesting the 1.0 API, so it\u0027s going to break.\n\nYou can make this change, but just go ahead and bump the API to 2.0 if it\u0027s not going to be backwards compatible.  Then I\u0027ll be ok with it.  \n\nFWIW, unless you do something to maintain some backwards compatibility temporarily, it will break rolling upgrades for anyone following trunk, similar to a change with a db migration, but I think that\u0027s ok.  I just wanted to note the implications of making a change like this.","commit_id":"9b886af419afeae4f8de6f015c9c69735112d21c"}]}