)]}'
{"cinder/volume/drivers/san/san.py":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"eae357c27bdc6afef130ddf3b9e86ef71cf60d22","unresolved":false,"context_lines":[{"line_number":74,"context_line":"]"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"replica_san_opts \u003d ["},{"line_number":77,"context_line":"    cfg.StrOpt(\u0027replica_san_ip\u0027,"},{"line_number":78,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":79,"context_line":"               help\u003d\u0027IP address of replica SAN controller\u0027),"},{"line_number":80,"context_line":"    cfg.StrOpt(\u0027replica_san_login\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_09648c20","line":77,"updated":"2015-01-06 12:53:01.000000000","message":"Not sure these should be in the base SAN class, since most will not be providing replication, and this will lead to an example cinder.conf that is not at all clear when a driver does not support replication.\n\nThere is already plenty of confusion on this front, so I\u0027m very reluctant to make it worse. Can we do this in a subclass instead?","commit_id":"ec04cb7026981479107edf42b7eb4e359cdac347"},{"author":{"_account_id":8587,"name":"Li Min Liu","email":"liulm@certusnet.com.cn","username":"LarryLiu"},"change_message_id":"54a26d34b4e636a50b36c93f5fdbc5865277a3e5","unresolved":false,"context_lines":[{"line_number":74,"context_line":"]"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"replica_san_opts \u003d ["},{"line_number":77,"context_line":"    cfg.StrOpt(\u0027replica_san_ip\u0027,"},{"line_number":78,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":79,"context_line":"               help\u003d\u0027IP address of replica SAN controller\u0027),"},{"line_number":80,"context_line":"    cfg.StrOpt(\u0027replica_san_login\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_183affcc","line":77,"in_reply_to":"3a961159_09648c20","updated":"2015-01-07 01:44:06.000000000","message":"Hi, Duncan:\nThanks for your point.\n\nWhen implement replication feature for Storwize driver , see https://review.openstack.org/#/c/144080/. Avishay thinks these options are generic and should not be defined in the driver.\n\nI agree with Avishay\u0027s opinion and move these here.\n\nSure there is a plenty of confusion on this if other driver not implement replication, but I think other driver may implement in the future.\n\nAny more comments will be welcomed. Thanks again.","commit_id":"ec04cb7026981479107edf42b7eb4e359cdac347"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"3573c0d9bda6c1edacb0d066f3685a70f5243186","unresolved":false,"context_lines":[{"line_number":74,"context_line":"]"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"replica_san_opts \u003d ["},{"line_number":77,"context_line":"    cfg.StrOpt(\u0027replica_san_ip\u0027,"},{"line_number":78,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":79,"context_line":"               help\u003d\u0027IP address of replica SAN controller\u0027),"},{"line_number":80,"context_line":"    cfg.StrOpt(\u0027replica_san_login\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_dd4bf784","line":77,"in_reply_to":"3a961159_183affcc","updated":"2015-01-07 16:00:34.000000000","message":"I\u0027d agree with Avishay that they should be somewhere common, I just don\u0027t think that should be here - a subclass of this called ReplicatingSan or similar that can be further subclassed by storwize and others makes perfect sense.","commit_id":"ec04cb7026981479107edf42b7eb4e359cdac347"},{"author":{"_account_id":11079,"name":"TaoBai","email":"baitao5@huawei.com","username":"TaoBai"},"change_message_id":"83c550110206217df0af4807d9b3aab7d1905904","unresolved":false,"context_lines":[{"line_number":74,"context_line":"]"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"replica_san_opts \u003d ["},{"line_number":77,"context_line":"    cfg.StrOpt(\u0027replica_san_ip\u0027,"},{"line_number":78,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":79,"context_line":"               help\u003d\u0027IP address of replica SAN controller\u0027),"},{"line_number":80,"context_line":"    cfg.StrOpt(\u0027replica_san_login\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_c364f8b4","line":77,"in_reply_to":"3a961159_dd4bf784","updated":"2015-01-07 16:45:11.000000000","message":"Hi Duncan\n\nThanks for your clarification","commit_id":"ec04cb7026981479107edf42b7eb4e359cdac347"}]}