)]}'
{"cinder/tests/api/middleware/test_faults.py":[{"author":{"_account_id":6601,"name":"James Carey","email":"jecarey@yerac.com","username":"jecarey"},"change_message_id":"3491f5f776ee40475aa0d4053eeb53abd504865e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def setUp(self):"},{"line_number":33,"context_line":"        super(TestFaults, self).setUp()"},{"line_number":34,"context_line":"        cinder_i18n.enable_lazy()"},{"line_number":35,"context_line":"        self.addCleanup(cinder_i18n.enable_lazy())"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def _prepare_xml(self, xml_string):"},{"line_number":38,"context_line":"        \"\"\"Remove characters from string which hinder XML equality testing.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_7b3784fe","line":35,"updated":"2015-01-06 23:11:10.000000000","message":"This isn\u0027t the same behavior.   The original code enables lazy (True) for the test and then restores the value ... which based on the code in test.py was probably False.  So this could cause test cases run after this one to run with lazy enabled.  It would probably be safer to use enable_lazy(False) in the cleanup for now.   \n\nOr just remove setting it to true, skip anything that fails and then we can add using the fixture Doug just added to oslo.i18n for toggling it when we fix up the skips.","commit_id":"61bc2e6483da0ec3516d82c09286c643807bd63d"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"21a916d1a0c1a62ffd8701471044fe3131da678d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        xml_string \u003d xml_string.replace(\"\\t\", \"\")"},{"line_number":42,"context_line":"        return xml_string"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @test.testtools.skip(\"SKIP until bug #1408099 is fixed\")"},{"line_number":45,"context_line":"    def test_400_fault_json(self):"},{"line_number":46,"context_line":"        \"\"\"Test fault serialized to JSON via file-extension and/or header.\"\"\""},{"line_number":47,"context_line":"        requests \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_717fa3df","line":44,"updated":"2015-01-06 23:18:05.000000000","message":"I am surprised that all of these test cases are broken by removing lazy enablement.","commit_id":"61bc2e6483da0ec3516d82c09286c643807bd63d"}],"cinder/tests/test_wsgi.py":[{"author":{"_account_id":6601,"name":"James Carey","email":"jecarey@yerac.com","username":"jecarey"},"change_message_id":"3491f5f776ee40475aa0d4053eeb53abd504865e","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    def setUp(self):"},{"line_number":258,"context_line":"        super(ExceptionTest, self).setUp()"},{"line_number":259,"context_line":"        i18n.enable_lazy()"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    def _wsgi_app(self, inner_app):"},{"line_number":262,"context_line":"        # NOTE(luisg): In order to test localization, we need to"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_11165f49","line":259,"updated":"2015-01-06 23:11:10.000000000","message":"This turns it on for all subsequent test classes, which isn\u0027t what I think we want and not what it did before.","commit_id":"61bc2e6483da0ec3516d82c09286c643807bd63d"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"10c79f82bb478a2e0c84621390b450b332156931","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    def setUp(self):"},{"line_number":258,"context_line":"        super(ExceptionTest, self).setUp()"},{"line_number":259,"context_line":"        i18n.enable_lazy()"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    def _wsgi_app(self, inner_app):"},{"line_number":262,"context_line":"        # NOTE(luisg): In order to test localization, we need to"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_ec181c78","line":259,"in_reply_to":"3a961159_11165f49","updated":"2015-01-06 23:34:02.000000000","message":"well, it\u0027s the same method/code... the call in oslo.i18n takes a bool and defaults True, I just exposed it in cinder.i18n wrapper?\n\nThe back_use_lazy that has zero documentation or explanation of what it\u0027s doing is another story.","commit_id":"61bc2e6483da0ec3516d82c09286c643807bd63d"},{"author":{"_account_id":6601,"name":"James Carey","email":"jecarey@yerac.com","username":"jecarey"},"change_message_id":"3491f5f776ee40475aa0d4053eeb53abd504865e","unresolved":false,"context_lines":[{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    @mock.patch(\u0027cinder.i18n.translate\u0027)"},{"line_number":338,"context_line":"    def test_cinder_exception_with_localized_explanation(self, mock_t9n):"},{"line_number":339,"context_line":"        i18n.enable_lazy(False)"},{"line_number":340,"context_line":"        msg \u003d \u0027My Not Found\u0027"},{"line_number":341,"context_line":"        msg_translation \u003d \u0027Mi No Encontrado\u0027"},{"line_number":342,"context_line":"        message \u003d _(msg)  # noqa"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_b112eb55","line":339,"updated":"2015-01-06 23:11:10.000000000","message":"Why does this suddenly need to be turned off?  It should have been running with it on before.\n\nIf this is left here and this is the last test run on the class, then it will turn it off globally, if not, it will be left on.   So if we add/change things so this moves to or off the end, we could get different behavior in the tests after this.  (if we add cleanup to turn it off in the class then this isn\u0027t an issue).","commit_id":"61bc2e6483da0ec3516d82c09286c643807bd63d"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"10c79f82bb478a2e0c84621390b450b332156931","unresolved":false,"context_lines":[{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    @mock.patch(\u0027cinder.i18n.translate\u0027)"},{"line_number":338,"context_line":"    def test_cinder_exception_with_localized_explanation(self, mock_t9n):"},{"line_number":339,"context_line":"        i18n.enable_lazy(False)"},{"line_number":340,"context_line":"        msg \u003d \u0027My Not Found\u0027"},{"line_number":341,"context_line":"        msg_translation \u003d \u0027Mi No Encontrado\u0027"},{"line_number":342,"context_line":"        message \u003d _(msg)  # noqa"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_0cb72822","line":339,"in_reply_to":"3a961159_b112eb55","updated":"2015-01-06 23:34:02.000000000","message":"it\u0027s irrelevant, it was part of me testing things, I\u0027ll remove it.","commit_id":"61bc2e6483da0ec3516d82c09286c643807bd63d"}]}