)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"a7baf0f43d4c907c711b55182614c7072b2f58b6","unresolved":false,"context_lines":[{"line_number":22,"context_line":"mentioned above to eliminate the unnecessary and"},{"line_number":23,"context_line":"duplicate info in their arguments."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Fixes-Bug: #1408171"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Change-Id: Ibfd1feefd72c43ef316b267e9d6645f2e67e2558"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a961159_ef41d2a6","line":25,"updated":"2015-01-07 20:51:06.000000000","message":"Bug link needs to be fixed please.","commit_id":"9e1eb316e4e75ae7d41516b1108e10d60dee6aea"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"c42eb114dd58c4c50fb3a7850641adb6168d3699","unresolved":false,"context_lines":[{"line_number":22,"context_line":"mentioned above to eliminate the unnecessary and"},{"line_number":23,"context_line":"duplicate info in their arguments."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Fixes-Bug: #1408171"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Change-Id: Ibfd1feefd72c43ef316b267e9d6645f2e67e2558"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a961159_8fdccee5","line":25,"updated":"2015-01-07 20:57:16.000000000","message":"Closes-Bug","commit_id":"2c9ff853473258e6017b72e21452b0a2c140864b"}],"cinder/volume/drivers/block_device.py":[{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"eba27c932400966931006c3f43e27c27fd00677d","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        # TODO(jdg): Maybe at some point make the target even"},{"line_number":196,"context_line":"        # more independent by moving the target related conf"},{"line_number":197,"context_line":"        # options out of the driver and into the target, but"},{"line_number":198,"context_line":"        # for now pass in the drivers config"},{"line_number":199,"context_line":"        model_update \u003d \\"},{"line_number":200,"context_line":"            self.target_driver.ensure_export("},{"line_number":201,"context_line":"                context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_14947135","line":198,"updated":"2015-01-07 20:28:20.000000000","message":"This comment should be fixed because config is not passed here.","commit_id":"9e1eb316e4e75ae7d41516b1108e10d60dee6aea"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"eba27c932400966931006c3f43e27c27fd00677d","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        # FIXME(jdg): Redundant, we use config to form this"},{"line_number":209,"context_line":"        # so we can pass it in to target driver, but we"},{"line_number":210,"context_line":"        # also send in config now too"},{"line_number":211,"context_line":"        volume_path \u003d \"/dev/%s/%s\" % (self.configuration.volume_group,"},{"line_number":212,"context_line":"                                      volume[\u0027name\u0027])"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_3497ad3b","line":210,"updated":"2015-01-07 20:28:20.000000000","message":"ditto","commit_id":"9e1eb316e4e75ae7d41516b1108e10d60dee6aea"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"eba27c932400966931006c3f43e27c27fd00677d","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        # TODO(jdg): Maybe at some point make the target even"},{"line_number":215,"context_line":"        # more independent by moving the target related conf"},{"line_number":216,"context_line":"        # options out of the driver and into the target, but"},{"line_number":217,"context_line":"        # for now pass in the drivers config"},{"line_number":218,"context_line":"        export_info \u003d self.target_driver.create_export(context,"},{"line_number":219,"context_line":"                                                       volume,"},{"line_number":220,"context_line":"                                                       volume_path)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_549a7962","line":217,"updated":"2015-01-07 20:28:20.000000000","message":"ditto","commit_id":"9e1eb316e4e75ae7d41516b1108e10d60dee6aea"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"c42eb114dd58c4c50fb3a7850641adb6168d3699","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        return model_update"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def create_export(self, context, volume):"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        volume_path \u003d \"/dev/%s/%s\" % (self.configuration.volume_group,"},{"line_number":205,"context_line":"                                      volume[\u0027name\u0027])"},{"line_number":206,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_8f03ee40","line":203,"updated":"2015-01-07 20:57:16.000000000","message":"Is this blank line it really needed or it\u0027s a \u0027typo\u0027?","commit_id":"2c9ff853473258e6017b72e21452b0a2c140864b"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"bda7a580b9410d1e0e680a9b58a54ab9767c9e53","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        return model_update"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def create_export(self, context, volume):"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        volume_path \u003d \"/dev/%s/%s\" % (self.configuration.volume_group,"},{"line_number":205,"context_line":"                                      volume[\u0027name\u0027])"},{"line_number":206,"context_line":"        export_info \u003d self.target_driver.create_export(context,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_b309d385","line":203,"updated":"2015-01-08 19:07:03.000000000","message":"I don\u0027t want to be nerdy, but I will be happy it this line will be removed","commit_id":"c5bb1290291cf2c64faf18c85a3f3708cec06e51"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"bd140c4a9a0b3ca99338e36cb5a6b0e1d1399c72","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        return model_update"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def create_export(self, context, volume):"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        volume_path \u003d \"/dev/%s/%s\" % (self.configuration.volume_group,"},{"line_number":205,"context_line":"                                      volume[\u0027name\u0027])"},{"line_number":206,"context_line":"        export_info \u003d self.target_driver.create_export(context,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_7123d957","line":203,"in_reply_to":"3a961159_b309d385","updated":"2015-01-09 04:38:01.000000000","message":"Done","commit_id":"c5bb1290291cf2c64faf18c85a3f3708cec06e51"}],"cinder/volume/drivers/lvm.py":[{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"eba27c932400966931006c3f43e27c27fd00677d","unresolved":false,"context_lines":[{"line_number":548,"context_line":"        # TODO(jdg): Maybe at some point make the target even"},{"line_number":549,"context_line":"        # more independent by moving the target related conf"},{"line_number":550,"context_line":"        # options out of the driver and into the target, but"},{"line_number":551,"context_line":"        # for now pass in the drivers config"},{"line_number":552,"context_line":"        model_update \u003d \\"},{"line_number":553,"context_line":"            self.target_driver.ensure_export(context, volume, volume_path)"},{"line_number":554,"context_line":"        return model_update"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_94f5c1cc","line":551,"updated":"2015-01-07 20:28:20.000000000","message":"This comment should be fixed because config is not passed here.","commit_id":"9e1eb316e4e75ae7d41516b1108e10d60dee6aea"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"eba27c932400966931006c3f43e27c27fd00677d","unresolved":false,"context_lines":[{"line_number":559,"context_line":""},{"line_number":560,"context_line":"        # FIXME(jdg): Redundant, we use config to form this"},{"line_number":561,"context_line":"        # so we can pass it in to target driver, but we"},{"line_number":562,"context_line":"        # also send in config now too"},{"line_number":563,"context_line":"        volume_path \u003d \"/dev/%s/%s\" % (vg, volume[\u0027name\u0027])"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"        # TODO(jdg): Maybe at some point make the target even"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_d4c0294c","line":562,"updated":"2015-01-07 20:28:20.000000000","message":"ditto","commit_id":"9e1eb316e4e75ae7d41516b1108e10d60dee6aea"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"eba27c932400966931006c3f43e27c27fd00677d","unresolved":false,"context_lines":[{"line_number":565,"context_line":"        # TODO(jdg): Maybe at some point make the target even"},{"line_number":566,"context_line":"        # more independent by moving the target related conf"},{"line_number":567,"context_line":"        # options out of the driver and into the target, but"},{"line_number":568,"context_line":"        # for now pass in the drivers config"},{"line_number":569,"context_line":"        export_info \u003d self.target_driver.create_export("},{"line_number":570,"context_line":"            context,"},{"line_number":571,"context_line":"            volume,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_54ac399f","line":568,"updated":"2015-01-07 20:28:20.000000000","message":"ditto","commit_id":"9e1eb316e4e75ae7d41516b1108e10d60dee6aea"}],"cinder/volume/drivers/srb.py":[{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"9997c48f4b31676ee138abfb9c3fb014b32291f8","unresolved":false,"context_lines":[{"line_number":829,"context_line":"        device_path \u003d self._mapper_path(volume)"},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"        model_update \u003d self.target_driver.ensure_export("},{"line_number":832,"context_line":"            context, volume,"},{"line_number":833,"context_line":"            iscsi_name,"},{"line_number":834,"context_line":"            device_path)"},{"line_number":835,"context_line":"        if model_update:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_b113815a","line":832,"updated":"2015-01-09 04:19:29.000000000","message":"sig is context, volume and path. I think iscsi_name needs to be removed from here.","commit_id":"c5bb1290291cf2c64faf18c85a3f3708cec06e51"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"bd140c4a9a0b3ca99338e36cb5a6b0e1d1399c72","unresolved":false,"context_lines":[{"line_number":829,"context_line":"        device_path \u003d self._mapper_path(volume)"},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"        model_update \u003d self.target_driver.ensure_export("},{"line_number":832,"context_line":"            context, volume,"},{"line_number":833,"context_line":"            iscsi_name,"},{"line_number":834,"context_line":"            device_path)"},{"line_number":835,"context_line":"        if model_update:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_b1f9c1c9","line":832,"in_reply_to":"3a961159_b113815a","updated":"2015-01-09 04:38:01.000000000","message":"Done","commit_id":"c5bb1290291cf2c64faf18c85a3f3708cec06e51"}],"cinder/volume/targets/iser.py":[{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"96f0008d916aca4ad4f570f4d83d93e3b6949376","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                                \u003ctarget %s\u003e"},{"line_number":33,"context_line":"                                    driver iser"},{"line_number":34,"context_line":"                                    backing-store %s"},{"line_number":35,"context_line":"                                    write_cache %s"},{"line_number":36,"context_line":"                                    %s"},{"line_number":37,"context_line":"                                \u003c/target\u003e"},{"line_number":38,"context_line":"                                 \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_94bb0c0e","line":35,"updated":"2015-01-07 14:04:05.000000000","message":"write_cache is 4th argument not 3rd argument. The order is name, path, chap_str and write_cache","commit_id":"bc54db483a748d78575d6e4b5ece801b84968f33"}],"cinder/volume/targets/tgt.py":[{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"a83d42dda186d35c23c0ed08cfdd88d9d02f2a0f","unresolved":false,"context_lines":[{"line_number":285,"context_line":"                                               chap_password)"},{"line_number":286,"context_line":"        # NOTE(jdg): For TgtAdm case iscsi_name is the ONLY param we need"},{"line_number":287,"context_line":"        # should clean this all up at some point in the future"},{"line_number":288,"context_line":"        iscsi_write_cache \u003d config.get(\u0027iscsi_write_cache\u0027, \u0027on\u0027)"},{"line_number":289,"context_line":"        tid \u003d self.create_iscsi_target(iscsi_name,"},{"line_number":290,"context_line":"                                       iscsi_target,"},{"line_number":291,"context_line":"                                       0,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_61f50e50","line":288,"updated":"2015-01-07 06:51:24.000000000","message":"I think we can get the value from self.configuration.iscsi_write_cache directly instead of using config argument.\nSo, the config argument is unnecessary argument here IMHO.","commit_id":"bc54db483a748d78575d6e4b5ece801b84968f33"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"fc4f921d454a1d3ee1474a9a4219d127b58f8938","unresolved":false,"context_lines":[{"line_number":285,"context_line":"                                               chap_password)"},{"line_number":286,"context_line":"        # NOTE(jdg): For TgtAdm case iscsi_name is the ONLY param we need"},{"line_number":287,"context_line":"        # should clean this all up at some point in the future"},{"line_number":288,"context_line":"        iscsi_write_cache \u003d config.get(\u0027iscsi_write_cache\u0027, \u0027on\u0027)"},{"line_number":289,"context_line":"        tid \u003d self.create_iscsi_target(iscsi_name,"},{"line_number":290,"context_line":"                                       iscsi_target,"},{"line_number":291,"context_line":"                                       0,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_dc45c46f","line":288,"in_reply_to":"3a961159_61f50e50","updated":"2015-01-07 10:23:00.000000000","message":"Is this true of the other times above where config is passed in? Because it would be much neater (and more consistent with the rest of the cinder \u0026 openstack code) if we could get rid of passing config around","commit_id":"bc54db483a748d78575d6e4b5ece801b84968f33"}]}