)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9e9eff3b14b0bc759f89b30cc627d57c3bd4df6f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"and plans later."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Partial-Bug: #1408099"},{"line_number":31,"context_line":"(cherry picked from commit 894f20d9cf57b36ccf9a675c6b2b070d56c9b297)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Conflicts:"},{"line_number":34,"context_line":"\tcinder/test.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3a961159_d656df2a","line":31,"updated":"2015-01-13 15:48:37.000000000","message":"At this point we should remove this.","commit_id":"c37391e50a67932990722b0a523b47c7a0173c59"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9e9eff3b14b0bc759f89b30cc627d57c3bd4df6f","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Conflicts:"},{"line_number":34,"context_line":"\tcinder/test.py"},{"line_number":35,"context_line":"\tcinder/tests/api/middleware/test_faults.py"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Change-Id: I2ae3d9b98c107cebaf386adbdcdb3cfafee070be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3a961159_5632ef0f","line":35,"updated":"2015-01-13 15:48:37.000000000","message":"Remove this as well.","commit_id":"c37391e50a67932990722b0a523b47c7a0173c59"}],"cinder/test.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"ac99443d00dc15d126bdd0f515bbfe6e971376f0","unresolved":false,"context_lines":[{"line_number":39,"context_line":"from cinder.common import config  # noqa Need to register global_opts"},{"line_number":40,"context_line":"from cinder.db import migration"},{"line_number":41,"context_line":"from cinder.db.sqlalchemy import api as sqla_api"},{"line_number":42,"context_line":"from cinder import i18n"},{"line_number":43,"context_line":"from cinder.openstack.common import log as oslo_logging"},{"line_number":44,"context_line":"from cinder.openstack.common import strutils"},{"line_number":45,"context_line":"from cinder.openstack.common import timeutils"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_2c7da11c","line":42,"updated":"2015-01-08 00:31:36.000000000","message":"Don\u0027t know that we should port this in to here, see note below.","commit_id":"75f851bf2cd6b66761fef51ee48aa9c0d1999479"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"8883898423bcee03b5d378839877613a669e5c67","unresolved":false,"context_lines":[{"line_number":39,"context_line":"from cinder.common import config  # noqa Need to register global_opts"},{"line_number":40,"context_line":"from cinder.db import migration"},{"line_number":41,"context_line":"from cinder.db.sqlalchemy import api as sqla_api"},{"line_number":42,"context_line":"from cinder import i18n"},{"line_number":43,"context_line":"from cinder.openstack.common import log as oslo_logging"},{"line_number":44,"context_line":"from cinder.openstack.common import strutils"},{"line_number":45,"context_line":"from cinder.openstack.common import timeutils"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_806f3427","line":42,"in_reply_to":"3a961159_2c7da11c","updated":"2015-01-08 04:17:53.000000000","message":"It appears that we actually do need this with the new i18n library.  If I remove this and the i18n.enable_lazy(False) I get errors complaining that they can\u0027t find the cinder.mo files.  I am wondering if not calling enable_lazy is causing issues because the domain is not set up properly.  Then there are issues when it tries to verify exceptions that are returned?\n\nAnyway, given that this works I think this is the better way to go than expanding changes into test cases.","commit_id":"75f851bf2cd6b66761fef51ee48aa9c0d1999479"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"98b11a5f48288a86864760cf258245f07ea3a3ef","unresolved":false,"context_lines":[{"line_number":39,"context_line":"from cinder.common import config  # noqa Need to register global_opts"},{"line_number":40,"context_line":"from cinder.db import migration"},{"line_number":41,"context_line":"from cinder.db.sqlalchemy import api as sqla_api"},{"line_number":42,"context_line":"from cinder import i18n"},{"line_number":43,"context_line":"from cinder.openstack.common import log as oslo_logging"},{"line_number":44,"context_line":"from cinder.openstack.common import strutils"},{"line_number":45,"context_line":"from cinder.openstack.common import timeutils"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_688655dd","line":42,"in_reply_to":"3a961159_45426269","updated":"2015-01-12 16:33:31.000000000","message":"Sorry, wrong link:  Here is what I meant to point to:  https://review.openstack.org/146545","commit_id":"75f851bf2cd6b66761fef51ee48aa9c0d1999479"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"4063d90f9b26c755e3f1592a84ce23b2caa7f256","unresolved":false,"context_lines":[{"line_number":39,"context_line":"from cinder.common import config  # noqa Need to register global_opts"},{"line_number":40,"context_line":"from cinder.db import migration"},{"line_number":41,"context_line":"from cinder.db.sqlalchemy import api as sqla_api"},{"line_number":42,"context_line":"from cinder import i18n"},{"line_number":43,"context_line":"from cinder.openstack.common import log as oslo_logging"},{"line_number":44,"context_line":"from cinder.openstack.common import strutils"},{"line_number":45,"context_line":"from cinder.openstack.common import timeutils"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_73e4afe0","line":42,"in_reply_to":"3a961159_5b235657","updated":"2015-01-09 18:26:32.000000000","message":"Ihar, I am at a bit of a loss here.  I have tried to recreate your results but have not had any lucks.  I have tried on RHEL and ubuntu using both run_tests.sh and tox and get the same error.  When you tried to recreate did you download this patch and then remove the above import and the two lines below?","commit_id":"75f851bf2cd6b66761fef51ee48aa9c0d1999479"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"db2015bbb6ef2d44874f7ba27356652807f7546f","unresolved":false,"context_lines":[{"line_number":39,"context_line":"from cinder.common import config  # noqa Need to register global_opts"},{"line_number":40,"context_line":"from cinder.db import migration"},{"line_number":41,"context_line":"from cinder.db.sqlalchemy import api as sqla_api"},{"line_number":42,"context_line":"from cinder import i18n"},{"line_number":43,"context_line":"from cinder.openstack.common import log as oslo_logging"},{"line_number":44,"context_line":"from cinder.openstack.common import strutils"},{"line_number":45,"context_line":"from cinder.openstack.common import timeutils"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_130df5e8","line":42,"in_reply_to":"3a961159_688655dd","updated":"2015-01-12 22:20:56.000000000","message":"I have spent the day investigating this and working it with James Carey and here is what we have discovered.  Importing i18n and setting enable_lazy(False) was not originally in Juno.  The problem with not including this in this patch is that it then becomes possible for enable_lazy() to be accidentally set if a library that a test case is calling sets it up.  This is why the Samba test cases are failing.  Lazy is getting enabled somewhere and then the test cases fail when it tries to go through the translation code as the translations are not in the venv.\n\nAs part of our cleanup during later Kilo we need to cleanup the use of enable_lazy to use the new fixture that will come with oslo.i18n 1.3.0.  In the mean time, however, I think we need to get this change in to make stable/juno compatible with oslo.i18n 1.2.0 .  \n\nOn a related note, my attempts to pin the oslo.i18n version have been unsuccessful as the global requirements would also need to be changed.  I am going with the assumption that an attempt to update the global requirements on stable/juno would be met with more resistance than this patch.","commit_id":"75f851bf2cd6b66761fef51ee48aa9c0d1999479"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a8e88aa52719c2b207425c0d2cd372d6c6ee2593","unresolved":false,"context_lines":[{"line_number":39,"context_line":"from cinder.common import config  # noqa Need to register global_opts"},{"line_number":40,"context_line":"from cinder.db import migration"},{"line_number":41,"context_line":"from cinder.db.sqlalchemy import api as sqla_api"},{"line_number":42,"context_line":"from cinder import i18n"},{"line_number":43,"context_line":"from cinder.openstack.common import log as oslo_logging"},{"line_number":44,"context_line":"from cinder.openstack.common import strutils"},{"line_number":45,"context_line":"from cinder.openstack.common import timeutils"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_f9414764","line":42,"in_reply_to":"3a961159_73e4afe0","updated":"2015-01-12 10:09:43.000000000","message":"Yes, that\u0027s what I did. I run Fedora 21.\n\nCan you check whether you actually have locale files generated at /home/vagrant/backport_lazyFix/.venv/share/locale/en_US.ISO8859-1/LC_MESSAGES/cinder.mo? I don\u0027t have share/locale directory in my tox environment. Where do you get it from?","commit_id":"75f851bf2cd6b66761fef51ee48aa9c0d1999479"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0ab591052a1b6014801ecacbd84370399932c006","unresolved":false,"context_lines":[{"line_number":39,"context_line":"from cinder.common import config  # noqa Need to register global_opts"},{"line_number":40,"context_line":"from cinder.db import migration"},{"line_number":41,"context_line":"from cinder.db.sqlalchemy import api as sqla_api"},{"line_number":42,"context_line":"from cinder import i18n"},{"line_number":43,"context_line":"from cinder.openstack.common import log as oslo_logging"},{"line_number":44,"context_line":"from cinder.openstack.common import strutils"},{"line_number":45,"context_line":"from cinder.openstack.common import timeutils"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_b8b0d2dc","line":42,"in_reply_to":"3a961159_806f3427","updated":"2015-01-08 18:30:13.000000000","message":"That would be great to see the failures you see.","commit_id":"75f851bf2cd6b66761fef51ee48aa9c0d1999479"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"2b8820a7794e3d858dcbed4d4dddd350b3eeb6a2","unresolved":false,"context_lines":[{"line_number":39,"context_line":"from cinder.common import config  # noqa Need to register global_opts"},{"line_number":40,"context_line":"from cinder.db import migration"},{"line_number":41,"context_line":"from cinder.db.sqlalchemy import api as sqla_api"},{"line_number":42,"context_line":"from cinder import i18n"},{"line_number":43,"context_line":"from cinder.openstack.common import log as oslo_logging"},{"line_number":44,"context_line":"from cinder.openstack.common import strutils"},{"line_number":45,"context_line":"from cinder.openstack.common import timeutils"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_45426269","line":42,"in_reply_to":"3a961159_85a7f44f","updated":"2015-01-12 16:16:32.000000000","message":"I have put https://review.openstack.org/#/c/145642/ out there for review.  Discussed this in the weekly oslo meeting and they felt this was a sensible approach if it didn\u0027t break grenade.  So, will drop this patch if 145642 passes the check.","commit_id":"75f851bf2cd6b66761fef51ee48aa9c0d1999479"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"1bc51eef8714fad368483463769f537fb57310ca","unresolved":false,"context_lines":[{"line_number":39,"context_line":"from cinder.common import config  # noqa Need to register global_opts"},{"line_number":40,"context_line":"from cinder.db import migration"},{"line_number":41,"context_line":"from cinder.db.sqlalchemy import api as sqla_api"},{"line_number":42,"context_line":"from cinder import i18n"},{"line_number":43,"context_line":"from cinder.openstack.common import log as oslo_logging"},{"line_number":44,"context_line":"from cinder.openstack.common import strutils"},{"line_number":45,"context_line":"from cinder.openstack.common import timeutils"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_45f18200","line":42,"in_reply_to":"3a961159_85a7f44f","updated":"2015-01-12 15:59:08.000000000","message":"Ihar, thanks for the update.  Glad to know I am not the only one seeing this then.  In discussion with Jim Carey, he suggested that the problem is the fact that oslo.i18n was not capped for stable/juno.  His recommendation was to handle this issue that way.  I am verifying that we can avoid this issue by capping oslo.i18n at 1.1.0.  If that works I will abandon this patch.","commit_id":"75f851bf2cd6b66761fef51ee48aa9c0d1999479"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"dea847af8994499063a3b1cf11de86fc3c819b79","unresolved":false,"context_lines":[{"line_number":39,"context_line":"from cinder.common import config  # noqa Need to register global_opts"},{"line_number":40,"context_line":"from cinder.db import migration"},{"line_number":41,"context_line":"from cinder.db.sqlalchemy import api as sqla_api"},{"line_number":42,"context_line":"from cinder import i18n"},{"line_number":43,"context_line":"from cinder.openstack.common import log as oslo_logging"},{"line_number":44,"context_line":"from cinder.openstack.common import strutils"},{"line_number":45,"context_line":"from cinder.openstack.common import timeutils"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_5b235657","line":42,"in_reply_to":"3a961159_8993ca4d","updated":"2015-01-09 11:30:15.000000000","message":"I\u0027ve checked the test locally, and it does not fail for me. Also, the output shows that you have locale files generated in your venv, which is not the case at least when you run it via tox. Have you tried to clean up your venv?","commit_id":"75f851bf2cd6b66761fef51ee48aa9c0d1999479"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"ea338a26e3626a2e2d2ed27b13ad3d8831d46e65","unresolved":false,"context_lines":[{"line_number":39,"context_line":"from cinder.common import config  # noqa Need to register global_opts"},{"line_number":40,"context_line":"from cinder.db import migration"},{"line_number":41,"context_line":"from cinder.db.sqlalchemy import api as sqla_api"},{"line_number":42,"context_line":"from cinder import i18n"},{"line_number":43,"context_line":"from cinder.openstack.common import log as oslo_logging"},{"line_number":44,"context_line":"from cinder.openstack.common import strutils"},{"line_number":45,"context_line":"from cinder.openstack.common import timeutils"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_8993ca4d","line":42,"in_reply_to":"3a961159_b8b0d2dc","updated":"2015-01-08 20:10:48.000000000","message":"Ihar:  This is the failure I am seeing:\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nFAIL: cinder.tests.windows.test_smbfs.WindowsSmbFsTestCase.test_create_existing_volume\n----------------------------------------------------------------------\nTraceback (most recent call last):\n_StringException: Traceback (most recent call last):\n  File \"/home/vagrant/backport_lazyFix/cinder/tests/windows/test_smbfs.py\", line 97, in test_create_existing_volume\n    self._test_create_volume(True)\n  File \"/home/vagrant/backport_lazyFix/cinder/tests/windows/test_smbfs.py\", line 86, in _test_create_volume\n    self._FAKE_VOLUME)\n  File \"/home/vagrant/backport_lazyFix/.venv/local/lib/python2.7/site-packages/testtools/testcase.py\", line 420, in assertRaises\n    self.assertThat(our_callable, matcher)\n  File \"/home/vagrant/backport_lazyFix/.venv/local/lib/python2.7/site-packages/testtools/testcase.py\", line 431, in assertThat\n    mismatch_error \u003d self._matchHelper(matchee, matcher, message, verbose)\n  File \"/home/vagrant/backport_lazyFix/.venv/local/lib/python2.7/site-packages/testtools/testcase.py\", line 481, in _matchHelper\n    mismatch \u003d matcher.match(matchee)\n  File \"/home/vagrant/backport_lazyFix/.venv/local/lib/python2.7/site-packages/testtools/matchers/_exception.py\", line 108, in match\n    mismatch \u003d self.exception_matcher.match(exc_info)\n  File \"/home/vagrant/backport_lazyFix/.venv/local/lib/python2.7/site-packages/testtools/matchers/_higherorder.py\", line 62, in match\n    mismatch \u003d matcher.match(matchee)\n  File \"/home/vagrant/backport_lazyFix/.venv/local/lib/python2.7/site-packages/testtools/testcase.py\", line 412, in match\n    reraise(*matchee)\n  File \"/home/vagrant/backport_lazyFix/.venv/local/lib/python2.7/site-packages/testtools/matchers/_exception.py\", line 101, in match\n    result \u003d matchee()\n  File \"/home/vagrant/backport_lazyFix/.venv/local/lib/python2.7/site-packages/testtools/testcase.py\", line 965, in __call__\n    return self._callable_object(*self._args, **self._kwargs)\n  File \"/home/vagrant/backport_lazyFix/cinder/volume/drivers/windows/smbfs.py\", line 76, in _do_create_volume\n    err_msg \u003d _(\u0027File already exists at: %s\u0027) % volume_path\n  File \"/home/vagrant/backport_lazyFix/.venv/local/lib/python2.7/site-packages/oslo_i18n/_factory.py\", line 80, in f\n    return _message.Message(msg, domain\u003ddomain)\n  File \"/home/vagrant/backport_lazyFix/.venv/local/lib/python2.7/site-packages/oslo_i18n/_message.py\", line 51, in __new__\n    msgtext \u003d Message._translate_msgid(msgid, domain)\n  File \"/home/vagrant/backport_lazyFix/.venv/local/lib/python2.7/site-packages/oslo_i18n/_message.py\", line 101, in _translate_msgid\n    fallback\u003dTrue)\n  File \"/usr/lib/python2.7/gettext.py\", line 492, in translation\n    with open(mofile, \u0027rb\u0027) as fp:\nIOError: [Errno 2] No such file or directory: \u0027/home/vagrant/backport_lazyFix/.venv/share/locale/en_US.ISO8859-1/LC_MESSAGES/cinder.mo\u0027\nTraceback (most recent call last):\n_StringException: Empty attachments:\n  stderr\n  stdout","commit_id":"75f851bf2cd6b66761fef51ee48aa9c0d1999479"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"635761af65ee63aef7251be9cbcef5d7a9e976e3","unresolved":false,"context_lines":[{"line_number":39,"context_line":"from cinder.common import config  # noqa Need to register global_opts"},{"line_number":40,"context_line":"from cinder.db import migration"},{"line_number":41,"context_line":"from cinder.db.sqlalchemy import api as sqla_api"},{"line_number":42,"context_line":"from cinder import i18n"},{"line_number":43,"context_line":"from cinder.openstack.common import log as oslo_logging"},{"line_number":44,"context_line":"from cinder.openstack.common import strutils"},{"line_number":45,"context_line":"from cinder.openstack.common import timeutils"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_85a7f44f","line":42,"in_reply_to":"3a961159_f9414764","updated":"2015-01-12 12:07:47.000000000","message":"Sorry, the reason why I haven\u0027t seen the test failure was because I executed one test only. If I run the whole suite, it fails for me. I\u0027ll remove -1 for now and will look into it.","commit_id":"75f851bf2cd6b66761fef51ee48aa9c0d1999479"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"ac99443d00dc15d126bdd0f515bbfe6e971376f0","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        super(TestCase, self).setUp()"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        # Unit tests do not need to use lazy gettext"},{"line_number":117,"context_line":"        i18n.enable_lazy(False)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        test_timeout \u003d os.environ.get(\u0027OS_TEST_TIMEOUT\u0027, 0)"},{"line_number":120,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_ec7f1915","line":117,"updated":"2015-01-08 00:31:36.000000000","message":"So this didn\u0027t exist, so not sure we need it.  I realize however it\u0027s probably an artifact of the cherry pick, just not sure it should be there since Juno didn\u0027t have the bad \"_lazy\" import and call to begin with.","commit_id":"75f851bf2cd6b66761fef51ee48aa9c0d1999479"}],"cinder/tests/api/middleware/test_faults.py":[{"author":{"_account_id":6601,"name":"James Carey","email":"jecarey@yerac.com","username":"jecarey"},"change_message_id":"84c0667226ad8f6865cdf83cb579363655071d9e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def setUp(self):"},{"line_number":33,"context_line":"        super(TestFaults, self).setUp()"},{"line_number":34,"context_line":"        cinder_i18n.enable_lazy()"},{"line_number":35,"context_line":"        self.addCleanup(cinder_i18n.enable_lazy())"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def _prepare_xml(self, xml_string):"},{"line_number":38,"context_line":"        \"\"\"Remove characters from string which hinder XML equality testing.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_f1986cce","line":35,"updated":"2015-01-12 17:24:13.000000000","message":"Cleanup should probably not be turning it on.   I think with the desired default being off ... it should call enable_lazy(False).","commit_id":"75f851bf2cd6b66761fef51ee48aa9c0d1999479"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"db2015bbb6ef2d44874f7ba27356652807f7546f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def setUp(self):"},{"line_number":33,"context_line":"        super(TestFaults, self).setUp()"},{"line_number":34,"context_line":"        cinder_i18n.enable_lazy()"},{"line_number":35,"context_line":"        self.addCleanup(cinder_i18n.enable_lazy())"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def _prepare_xml(self, xml_string):"},{"line_number":38,"context_line":"        \"\"\"Remove characters from string which hinder XML equality testing.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_f3eb0910","line":35,"in_reply_to":"3a961159_f1986cce","updated":"2015-01-12 22:20:56.000000000","message":"Agreed.  We will need to investigate fixing this in master.","commit_id":"75f851bf2cd6b66761fef51ee48aa9c0d1999479"}],"cinder/tests/test_wsgi.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9e9eff3b14b0bc759f89b30cc627d57c3bd4df6f","unresolved":false,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def setUp(self):"},{"line_number":221,"context_line":"        super(ExceptionTest, self).setUp()"},{"line_number":222,"context_line":"        i18n.enable_lazy()"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def _wsgi_app(self, inner_app):"},{"line_number":225,"context_line":"        # NOTE(luisg): In order to test localization, we need to"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_167a27ba","line":222,"updated":"2015-01-13 15:48:37.000000000","message":"John, as we discussed last night, I think this patch is acceptable if we use the fixture for enabling/disabling lazy translation like is being done here:  https://review.openstack.org/#/c/146763/","commit_id":"c37391e50a67932990722b0a523b47c7a0173c59"}]}